)]}'
{"deployment/ceph-ansible/ceph-grafana.yaml":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"6d5e2d26cb50e6a9d1f5e869221e230ddbd61e6d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"          grafana_plugins: {get_param: GrafanaPlugins}"},{"line_number":96,"context_line":"          grafana_port: 3100"},{"line_number":97,"context_line":"          prometheus_container_image: {get_param: PrometheusContainerImage}"},{"line_number":98,"context_line":"          prometheus_port: 9090"},{"line_number":99,"context_line":"          alertmanager_container_image: {get_param: AlertManagerContainerImage}"},{"line_number":100,"context_line":"          alertmanager_port: 9093"},{"line_number":101,"context_line":"          node_exporter_container_image: {get_param: NodeExporterContainerImage}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_c8fb36bb","line":98,"range":{"start_line":98,"start_character":10,"end_line":98,"end_character":31},"updated":"2019-10-01 06:05:23.000000000","message":"Basically I created this review because in this commit [1] the prometheus  default port is changed (9090 \u003d\u003e 9092).\nFor tripleo this means if we continue to rely on ceph-ansible defaults (that could change for several reasons), we can result in breaking our firewall rules (l164).\n\n\n[1] https://github.com/ceph/ceph-ansible/pull/4484/files","commit_id":"f40965d4bfe0ab911f3fca03199f1f8659891c67"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e9ee8ff2348fdd69869801c5d28a0c14bda36c41","unresolved":false,"context_lines":[{"line_number":95,"context_line":"          grafana_plugins: {get_param: GrafanaPlugins}"},{"line_number":96,"context_line":"          grafana_port: 3100"},{"line_number":97,"context_line":"          prometheus_container_image: {get_param: PrometheusContainerImage}"},{"line_number":98,"context_line":"          prometheus_port: 9090"},{"line_number":99,"context_line":"          alertmanager_container_image: {get_param: AlertManagerContainerImage}"},{"line_number":100,"context_line":"          alertmanager_port: 9093"},{"line_number":101,"context_line":"          node_exporter_container_image: {get_param: NodeExporterContainerImage}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_6df32d75","line":98,"range":{"start_line":98,"start_character":10,"end_line":98,"end_character":31},"in_reply_to":"3fa7e38b_3ea00042","updated":"2019-10-01 13:00:38.000000000","message":"maybe keep prometheus_port only here then?","commit_id":"f40965d4bfe0ab911f3fca03199f1f8659891c67"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"5918e56e21bf28214c1b5cf07ef2db9236a89a0e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"          grafana_plugins: {get_param: GrafanaPlugins}"},{"line_number":96,"context_line":"          grafana_port: 3100"},{"line_number":97,"context_line":"          prometheus_container_image: {get_param: PrometheusContainerImage}"},{"line_number":98,"context_line":"          prometheus_port: 9090"},{"line_number":99,"context_line":"          alertmanager_container_image: {get_param: AlertManagerContainerImage}"},{"line_number":100,"context_line":"          alertmanager_port: 9093"},{"line_number":101,"context_line":"          node_exporter_container_image: {get_param: NodeExporterContainerImage}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_c7c1c3e6","line":98,"range":{"start_line":98,"start_character":10,"end_line":98,"end_character":31},"in_reply_to":"3fa7e38b_6df32d75","updated":"2019-10-02 20:38:38.000000000","message":"sure, I think we can avoid alertmanager here","commit_id":"f40965d4bfe0ab911f3fca03199f1f8659891c67"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"7b5542179336b7bafdda897a8db09380b38a1ae1","unresolved":false,"context_lines":[{"line_number":95,"context_line":"          grafana_plugins: {get_param: GrafanaPlugins}"},{"line_number":96,"context_line":"          grafana_port: 3100"},{"line_number":97,"context_line":"          prometheus_container_image: {get_param: PrometheusContainerImage}"},{"line_number":98,"context_line":"          prometheus_port: 9090"},{"line_number":99,"context_line":"          alertmanager_container_image: {get_param: AlertManagerContainerImage}"},{"line_number":100,"context_line":"          alertmanager_port: 9093"},{"line_number":101,"context_line":"          node_exporter_container_image: {get_param: NodeExporterContainerImage}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_3ea00042","line":98,"range":{"start_line":98,"start_character":10,"end_line":98,"end_character":31},"in_reply_to":"3fa7e38b_c8fb36bb","updated":"2019-10-01 09:24:41.000000000","message":"understood but this looks more like something to address in ceph-ansible which should either deal with a port change or not enforce it ... using 9092 seems a better default though\n\nluckily we did not release any code deploying the dashboard yet (and we don\u0027t want to conflict with cockpit either) so I\u0027d still not add these settings","commit_id":"f40965d4bfe0ab911f3fca03199f1f8659891c67"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e9ee8ff2348fdd69869801c5d28a0c14bda36c41","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            - {}"},{"line_number":162,"context_line":"          - tripleo::ceph_grafana::firewall_rules:"},{"line_number":163,"context_line":"              \u0027123 ceph_dashboard\u0027:"},{"line_number":164,"context_line":"                dport: [3100,9090,9093,9094,9100]"},{"line_number":165,"context_line":"          - {}"},{"line_number":166,"context_line":"      metadata_settings:"},{"line_number":167,"context_line":"        if:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_edd5ddb8","line":164,"updated":"2019-10-01 13:00:38.000000000","message":"we need to replace 9090 with 9092 I think\n\ndo we need to add 9283 on the ceph-mgr nodes? [1]\n\n1. https://github.com/prometheus/prometheus/wiki/Default-port-allocations","commit_id":"f40965d4bfe0ab911f3fca03199f1f8659891c67"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"5918e56e21bf28214c1b5cf07ef2db9236a89a0e","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            - {}"},{"line_number":162,"context_line":"          - tripleo::ceph_grafana::firewall_rules:"},{"line_number":163,"context_line":"              \u0027123 ceph_dashboard\u0027:"},{"line_number":164,"context_line":"                dport: [3100,9090,9093,9094,9100]"},{"line_number":165,"context_line":"          - {}"},{"line_number":166,"context_line":"      metadata_settings:"},{"line_number":167,"context_line":"        if:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_a2fd9509","line":164,"in_reply_to":"3fa7e38b_edd5ddb8","updated":"2019-10-02 20:38:38.000000000","message":"yeah, you\u0027re right, we need to add 9283 (I think it\u0027s used by ceph-mgr service [1]).\n\n[1] https://646c55c2d6610d187ca3-b6ff674ac41b2664de016d688de11652.ssl.cf1.rackcdn.com/682015/21/check/tripleo-ci-centos-7-scenario001-standalone/ca035db/logs/undercloud/var/log/extra/netstat.txt.gz","commit_id":"f40965d4bfe0ab911f3fca03199f1f8659891c67"}]}