)]}'
{"deployment/cinder/cinder-volume-pacemaker-puppet.yaml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"f7cd78a9a6f29f247e061ebf754fb56b39fcf75e","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                - cinder_volume_image_current !\u003d \u0027\u0027"},{"line_number":276,"context_line":"                - cinder_volume_image_current !\u003d cinder_volume_image_latest"},{"line_number":277,"context_line":"            - name: Check openstack-cinder-volume cluster resource status"},{"line_number":278,"context_line":"              pacemaker_resource:"},{"line_number":279,"context_line":"                resource: openstack-cinder-volume"},{"line_number":280,"context_line":"                state: show"},{"line_number":281,"context_line":"                check_mode: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_d23aaacb","line":278,"updated":"2019-10-07 14:16:15.000000000","message":"I think this blew up when testing on 14-\u003e15 which is why i went to `resource config`. I don\u0027t recall what exactly was the problem now, i think either some incompatibility with newer pacemaker, or the module was crashing the Ansible run when pacemaker cluster wasn\u0027t present. This will need to be checked before we go back to the pacemaker_resource module.\n\nSo for now i\u0027d perhaps keep the `pcs resource config` way to be safe, ditto in other files.","commit_id":"41fa59a24d09a9c5e422d8b6b7b3c51b5f15fdf0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ee114522a06cacbcf51f4ac883488c1039afbad8","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                - cinder_volume_image_current !\u003d \u0027\u0027"},{"line_number":276,"context_line":"                - cinder_volume_image_current !\u003d cinder_volume_image_latest"},{"line_number":277,"context_line":"            - name: Check openstack-cinder-volume cluster resource status"},{"line_number":278,"context_line":"              pacemaker_resource:"},{"line_number":279,"context_line":"                resource: openstack-cinder-volume"},{"line_number":280,"context_line":"                state: show"},{"line_number":281,"context_line":"                check_mode: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_ab69a6be","line":278,"in_reply_to":"3fa7e38b_4a9593e3","updated":"2019-10-08 12:59:20.000000000","message":"OK, will do. Thanks!","commit_id":"41fa59a24d09a9c5e422d8b6b7b3c51b5f15fdf0"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"e79f2725871a9d1dadfbbe344a6a9d35b4598c97","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                - cinder_volume_image_current !\u003d \u0027\u0027"},{"line_number":276,"context_line":"                - cinder_volume_image_current !\u003d cinder_volume_image_latest"},{"line_number":277,"context_line":"            - name: Check openstack-cinder-volume cluster resource status"},{"line_number":278,"context_line":"              pacemaker_resource:"},{"line_number":279,"context_line":"                resource: openstack-cinder-volume"},{"line_number":280,"context_line":"                state: show"},{"line_number":281,"context_line":"                check_mode: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_4a9593e3","line":278,"in_reply_to":"3fa7e38b_beab3473","updated":"2019-10-08 07:46:20.000000000","message":"I can\u0027t answer with certainty as i\u0027m not sure of the root cause. But if it was that cluster is completely deleted (not just stopped), then that would only be the case on an upgrade of operating system. FWIW i only hit the issue with pacemaker_resource when testing with OS upgrade, i don\u0027t recall anyone hitting this problem in other updates/upgrades.\n\nSo probably the ideal solution is to fix the pacemaker_resource module. I.e. it can fail (we have \"failed_when: false\" below) but it should not crash. However, if we want to backport this patch to stable/stein, perhaps it would best be kept as-is for now (using `shell` instead) and do the fixes in separate patches.","commit_id":"41fa59a24d09a9c5e422d8b6b7b3c51b5f15fdf0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a35380b78cce80c27e6d79afc06233f5acda3f6e","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                - cinder_volume_image_current !\u003d \u0027\u0027"},{"line_number":276,"context_line":"                - cinder_volume_image_current !\u003d cinder_volume_image_latest"},{"line_number":277,"context_line":"            - name: Check openstack-cinder-volume cluster resource status"},{"line_number":278,"context_line":"              pacemaker_resource:"},{"line_number":279,"context_line":"                resource: openstack-cinder-volume"},{"line_number":280,"context_line":"                state: show"},{"line_number":281,"context_line":"                check_mode: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_beab3473","line":278,"in_reply_to":"3fa7e38b_d23aaacb","updated":"2019-10-07 16:58:07.000000000","message":"Is this specific to upgrade tasks, or does the comment apply to too upgrade types? If so, there are tons of places this\u0027ll need to change.","commit_id":"41fa59a24d09a9c5e422d8b6b7b3c51b5f15fdf0"}]}