)]}'
{"common/container-puppet.py":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"653cf75819de7626845b6445063448b2d0f048de","unresolved":false,"context_lines":[{"line_number":483,"context_line":"            infile_data[k][\u0027environment\u0027] \u003d env"},{"line_number":484,"context_line":"            log.debug(\"Updating config hash for %s, config_volume\u003d%s hash\u003d%s\" % (k, config_volume, config_hash))"},{"line_number":485,"context_line":"            # When python 27 support is removed, we will be able to use z \u003d {**x, **y} to merge the dicts."},{"line_number":486,"context_line":"            infile_data[k][\u0027environment\u0027].update({\u0027TRIPLEO_CONFIG_HASH\u0027: config_hash})"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"    outfile \u003d os.path.join(os.path.dirname(infile), \"hashed-\" + os.path.basename(infile))"},{"line_number":489,"context_line":"    with open(outfile, \u0027w\u0027) as out_f:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_91527e34","line":486,"updated":"2019-10-14 15:24:36.000000000","message":"not working yet:\n\n2019-10-14 13:49:58 |     \"Traceback (most recent call last):\", \n2019-10-14 13:49:58 |     \"  File \\\"/var/lib/container-puppet/container-puppet.py\\\", line 486, in \u003cmodule\u003e\", \n2019-10-14 13:49:58 |     \"    infile_data[k][\u0027environment\u0027].update({\u0027TRIPLEO_CONFIG_HASH\u0027: config_hash})\", \n2019-10-14 13:49:58 |     \"AttributeError: \u0027unicode\u0027 object has no attribute \u0027update\u0027\"\n2019-10-14 13:49:58 |    ]","commit_id":"cafc63d37501a020b6f8c0f7640a58e34a68c0ba"}],"deployment/cinder/cinder-common-container-puppet.yaml":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a74f387b583dfa175061c7b9a708b84aff68daa6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    default: []"},{"line_number":37,"context_line":"    description: list of optional volumes to be mounted"},{"line_number":38,"context_line":"    type: comma_delimited_list"},{"line_number":39,"context_line":"  CinderVolumeOptEnvVars:"},{"line_number":40,"context_line":"    default: []"},{"line_number":41,"context_line":"    description: list of optional environment variables"},{"line_number":42,"context_line":"    type: comma_delimited_list"},{"line_number":43,"context_line":"  CinderEnableIscsiBackend:"},{"line_number":44,"context_line":"    default: true"},{"line_number":45,"context_line":"    description: Whether to enable or not the Iscsi backend for Cinder"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_dca255fc","line":42,"range":{"start_line":39,"start_character":0,"end_line":42,"end_character":30},"updated":"2019-10-14 06:43:53.000000000","message":"need this also changed to dict","commit_id":"4ecbfcf3536bf3fe65f26433ba88a9db46690d15"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"653cf75819de7626845b6445063448b2d0f048de","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    default: []"},{"line_number":37,"context_line":"    description: list of optional volumes to be mounted"},{"line_number":38,"context_line":"    type: comma_delimited_list"},{"line_number":39,"context_line":"  CinderVolumeOptEnvVars:"},{"line_number":40,"context_line":"    default: []"},{"line_number":41,"context_line":"    description: list of optional environment variables"},{"line_number":42,"context_line":"    type: comma_delimited_list"},{"line_number":43,"context_line":"  CinderEnableIscsiBackend:"},{"line_number":44,"context_line":"    default: true"},{"line_number":45,"context_line":"    description: Whether to enable or not the Iscsi backend for Cinder"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_50cc0434","line":42,"range":{"start_line":39,"start_character":0,"end_line":42,"end_character":30},"in_reply_to":"3fa7e38b_dca255fc","updated":"2019-10-14 15:24:36.000000000","message":"Done","commit_id":"4ecbfcf3536bf3fe65f26433ba88a9db46690d15"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a74f387b583dfa175061c7b9a708b84aff68daa6","unresolved":false,"context_lines":[{"line_number":178,"context_line":"  cinder_volume_environment:"},{"line_number":179,"context_line":"    description: Docker environment for the cinder-volume container (HA or non-HA)"},{"line_number":180,"context_line":"    value:"},{"line_number":181,"context_line":"      list_concat:"},{"line_number":182,"context_line":"      map_merge:"},{"line_number":183,"context_line":"        - {get_param: CinderVolumeOptEnvVars}"},{"line_number":184,"context_line":"        - KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_3c528914","line":181,"range":{"start_line":181,"start_character":0,"end_line":181,"end_character":18},"updated":"2019-10-14 06:43:53.000000000","message":"this extra","commit_id":"4ecbfcf3536bf3fe65f26433ba88a9db46690d15"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"653cf75819de7626845b6445063448b2d0f048de","unresolved":false,"context_lines":[{"line_number":178,"context_line":"  cinder_volume_environment:"},{"line_number":179,"context_line":"    description: Docker environment for the cinder-volume container (HA or non-HA)"},{"line_number":180,"context_line":"    value:"},{"line_number":181,"context_line":"      list_concat:"},{"line_number":182,"context_line":"      map_merge:"},{"line_number":183,"context_line":"        - {get_param: CinderVolumeOptEnvVars}"},{"line_number":184,"context_line":"        - KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_30c94825","line":181,"range":{"start_line":181,"start_character":0,"end_line":181,"end_character":18},"in_reply_to":"3fa7e38b_3c528914","updated":"2019-10-14 15:24:36.000000000","message":"Done","commit_id":"4ecbfcf3536bf3fe65f26433ba88a9db46690d15"}],"deployment/database/mysql-container-puppet.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"dda8dc8be9599d4a567152792ded3ba570f84ef1","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                  template:"},{"line_number":310,"context_line":"                    \"{{ mysql_json.cli }} run --rm -u root --net\u003dhost ENV VOLUMES \\\"IMAGE\\\" /bin/bash -ecx \\\"SCRIPT\\\"\""},{"line_number":311,"context_line":"                  params:"},{"line_number":312,"context_line":"                    ENV: \u0027-e \"KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS\"\u0027"},{"line_number":313,"context_line":"                    IMAGE: \"{{ mysql_json.image }}\""},{"line_number":314,"context_line":"                    VOLUMES: \"-v {{ mysql_clean_up_volumes | join(\u0027 -v \u0027) }}\""},{"line_number":315,"context_line":"                    SCRIPT: \"{{ mysql_clean_up_script }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_72f31a0a","line":312,"updated":"2019-10-16 14:58:27.000000000","message":"does this need to be updated too?","commit_id":"81258ae551f84237fe9028edd2ac7d3fba28e14b"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"d84fd1ba25b19715d1cd6bba8f3d87ad1e2b16d2","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                  template:"},{"line_number":310,"context_line":"                    \"{{ mysql_json.cli }} run --rm -u root --net\u003dhost ENV VOLUMES \\\"IMAGE\\\" /bin/bash -ecx \\\"SCRIPT\\\"\""},{"line_number":311,"context_line":"                  params:"},{"line_number":312,"context_line":"                    ENV: \u0027-e \"KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS\"\u0027"},{"line_number":313,"context_line":"                    IMAGE: \"{{ mysql_json.image }}\""},{"line_number":314,"context_line":"                    VOLUMES: \"-v {{ mysql_clean_up_volumes | join(\u0027 -v \u0027) }}\""},{"line_number":315,"context_line":"                    SCRIPT: \"{{ mysql_clean_up_script }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_32e36207","line":312,"in_reply_to":"3fa7e38b_72f31a0a","updated":"2019-10-16 15:03:58.000000000","message":"No because it\u0027s shell syntax, not THT.\n\nSame for deployment/database/mysql-pacemaker-puppet.yaml:585","commit_id":"81258ae551f84237fe9028edd2ac7d3fba28e14b"}],"deployment/logging/stdout/keystone.yaml":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a74f387b583dfa175061c7b9a708b84aff68daa6","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  environment:"},{"line_number":55,"context_line":"    description: Extra environment variables needed for the service to log to stdout."},{"line_number":56,"context_line":"    value:"},{"line_number":57,"context_line":"      EXTRA_KEYSTONE_MANAGE_ARGS\u003d--log-dir\u003d --log-file\u003d"},{"line_number":58,"context_line":"  volumes:"},{"line_number":59,"context_line":"    description: The volumes needed to log to stdout or a sidecar container."},{"line_number":60,"context_line":"    value:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_bc94398c","line":57,"range":{"start_line":57,"start_character":32,"end_line":57,"end_character":33},"updated":"2019-10-14 06:43:53.000000000","message":"?","commit_id":"4ecbfcf3536bf3fe65f26433ba88a9db46690d15"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"653cf75819de7626845b6445063448b2d0f048de","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  environment:"},{"line_number":55,"context_line":"    description: Extra environment variables needed for the service to log to stdout."},{"line_number":56,"context_line":"    value:"},{"line_number":57,"context_line":"      EXTRA_KEYSTONE_MANAGE_ARGS\u003d--log-dir\u003d --log-file\u003d"},{"line_number":58,"context_line":"  volumes:"},{"line_number":59,"context_line":"    description: The volumes needed to log to stdout or a sidecar container."},{"line_number":60,"context_line":"    value:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_70e260a2","line":57,"range":{"start_line":57,"start_character":32,"end_line":57,"end_character":33},"in_reply_to":"3fa7e38b_bc94398c","updated":"2019-10-14 15:24:36.000000000","message":"Done","commit_id":"4ecbfcf3536bf3fe65f26433ba88a9db46690d15"}]}