)]}'
{"puppet/services/tripleo-packages.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0206b11369805636b530e08bea128d243555cfbc","unresolved":false,"context_lines":[{"line_number":136,"context_line":"          when: step|int \u003d\u003d 3"},{"line_number":137,"context_line":"          yum: name\u003d* state\u003dlatest exclude\u003dceph*,librados*,librbd*,libcephfs*,librgw*,python-rados*,python-rbd*,python-cephfs*,python-rgw*,rbd-mirror"},{"line_number":138,"context_line":"      update_tasks:"},{"line_number":139,"context_line":"        # With the layered product packaging, the key package is rhosp-openvswitch. It depends on"},{"line_number":140,"context_line":"        # a openvswitch package that includes the version as part of the name (e.g openvswitch2.10)."},{"line_number":141,"context_line":"        # This requires some additional special handling:"},{"line_number":142,"context_line":"        #   - During an upgrade the package name for openvswitch may change so"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_dd3884a0","line":139,"updated":"2019-10-23 07:53:46.000000000","message":"afaics and per the commit message this should be a copy/pasta of https://opendev.org/openstack/tripleo-heat-templates/src/commit/5ffad3a3f07d8f93e6930edb3ad3f7bd5345f23f/deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml#L216 (except you skipped the last task for setting flag to skip - i guess as this is minor update only so we don\u0027t have to worry about the upgrade case here)","commit_id":"bdea2c17f50c2947d9746e55ca6bb91f6659745c"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"bb814c8168b4a70b2d797f589a417d5d1aee2944","unresolved":false,"context_lines":[{"line_number":136,"context_line":"          when: step|int \u003d\u003d 3"},{"line_number":137,"context_line":"          yum: name\u003d* state\u003dlatest exclude\u003dceph*,librados*,librbd*,libcephfs*,librgw*,python-rados*,python-rbd*,python-cephfs*,python-rgw*,rbd-mirror"},{"line_number":138,"context_line":"      update_tasks:"},{"line_number":139,"context_line":"        # With the layered product packaging, the key package is rhosp-openvswitch. It depends on"},{"line_number":140,"context_line":"        # a openvswitch package that includes the version as part of the name (e.g openvswitch2.10)."},{"line_number":141,"context_line":"        # This requires some additional special handling:"},{"line_number":142,"context_line":"        #   - During an upgrade the package name for openvswitch may change so"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_85205cf9","line":139,"in_reply_to":"3fa7e38b_dd3884a0","updated":"2019-10-24 12:03:02.000000000","message":"Yes. The flag run_ovs_update is skipped for minor update.\n\nThis flag \"run_ovs_update\" is required to update the openvswitch package, when there is a specific issue on ovs rpm (without the package name change to openvswitch2.11). IIRC, this specific issue on the ovs rpm was present in ovs2.5.0-14 and lesser versions. The issue is that, when openvswitch package is updated to a new version, it restarts the ovs service (ovs2.5.0-14 to ovs2.6 will restart the ovs service).\n\nIt has been fixed in the later versions and also in ovs2.6 and ovs2.9 version. So in the later versions, if the openvswitch pacakge is updated (for example, ovs2.6 to ovs2.9), the ovs service will NOT be restarted. \n\nThe flag \"run_ovs_update\" is required for this specific issue for ovs2.5.0-14 or lesser versions. For queens, we are always on ovs2.9, so we will never hit this issue. The flag is not required, and I removed it.","commit_id":"bdea2c17f50c2947d9746e55ca6bb91f6659745c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0206b11369805636b530e08bea128d243555cfbc","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            - name: install/upgrade OpenvSwitch LP package"},{"line_number":220,"context_line":"              package:"},{"line_number":221,"context_line":"                name: rhosp-openvswitch"},{"line_number":222,"context_line":"                state: latest"},{"line_number":223,"context_line":"        - name: Check for existing yum.pid"},{"line_number":224,"context_line":"          stat:  path\u003d/var/run/yum.pid"},{"line_number":225,"context_line":"          register: yum_pid_file"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_1d4e1c38","line":222,"updated":"2019-10-23 07:53:46.000000000","message":"sanity check... and we don\u0027t need the cases of checking if this is not \u0027layered package\u0027 ... i.e. it will never be something less than 2.11 here? thinking about that bit https://opendev.org/openstack/tripleo-heat-templates/src/commit/5ffad3a3f07d8f93e6930edb3ad3f7bd5345f23f/deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml#L276","commit_id":"bdea2c17f50c2947d9746e55ca6bb91f6659745c"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"bb814c8168b4a70b2d797f589a417d5d1aee2944","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            - name: install/upgrade OpenvSwitch LP package"},{"line_number":220,"context_line":"              package:"},{"line_number":221,"context_line":"                name: rhosp-openvswitch"},{"line_number":222,"context_line":"                state: latest"},{"line_number":223,"context_line":"        - name: Check for existing yum.pid"},{"line_number":224,"context_line":"          stat:  path\u003d/var/run/yum.pid"},{"line_number":225,"context_line":"          register: yum_pid_file"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_6564404a","line":222,"in_reply_to":"3fa7e38b_1d4e1c38","updated":"2019-10-24 12:03:02.000000000","message":"If it is layered product, it will be handled with earlier block. If it is NOT layered product (ovs2.9.0-x to ovs2.9.0-y), then \"Update all packages\" step below, will handle the openvswitch package update too and the ovs service will not be restarted (as ovs rpm will not trigger the scripts during update).","commit_id":"bdea2c17f50c2947d9746e55ca6bb91f6659745c"}]}