)]}'
{"network/network.j2":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c588952b0a8c3c3456e50eb32daaf5f5020b4237","unresolved":false,"context_lines":[{"line_number":144,"context_line":"resources:"},{"line_number":145,"context_line":"  {{network.name}}Network:"},{"line_number":146,"context_line":"    type: OS::Neutron::Net"},{"line_number":147,"context_line":"    condition: manage_networks"},{"line_number":148,"context_line":"{%- if network.external_resource_network_id|default(\u0027\u0027) %}"},{"line_number":149,"context_line":"    external_id: {{ network.external_resource_network_id }}"},{"line_number":150,"context_line":"{%- endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_e7f95f4e","line":147,"updated":"2019-11-07 14:06:11.000000000","message":"in a case we doing a T-\u003eU upgrade, and changing this do becomem unmanaged, what would be the impact on Heat resources?\nshall we also update the policy for Heat to not touch already existing resources? Like in https://review.opendev.org/#/c/684142/ ?","commit_id":"251aeef8b641ff05cbdac04040a7a4994b98442e"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"d16a4ab2b52c907be6f1a863f10f8d83f369f1bd","unresolved":false,"context_lines":[{"line_number":144,"context_line":"resources:"},{"line_number":145,"context_line":"  {{network.name}}Network:"},{"line_number":146,"context_line":"    type: OS::Neutron::Net"},{"line_number":147,"context_line":"    condition: manage_networks"},{"line_number":148,"context_line":"{%- if network.external_resource_network_id|default(\u0027\u0027) %}"},{"line_number":149,"context_line":"    external_id: {{ network.external_resource_network_id }}"},{"line_number":150,"context_line":"{%- endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_6210fd5a","line":147,"in_reply_to":"3fa7e38b_e7f95f4e","updated":"2019-11-07 15:38:09.000000000","message":"it would be the equivalent of forgetting to include network-isolation.yaml.\n\nwe could add a validation. however, i don\u0027t think we need to get into the habit of adding heat policy. that would be counter-productive to how the Heat environments are supposed to work and limit the flexibility of the framework.\n\nan alternative to this patch, would be some variation on network-isolation.yaml, that maps the networks to None, but still enables the isolated port mappings. However, we also need to get the cidrs from the isolated networks and not fall back to the ctlplane cidr, so this parameter seemed like the easiest approach.","commit_id":"251aeef8b641ff05cbdac04040a7a4994b98442e"}]}