)]}'
{"deployment/database/mysql-pacemaker-puppet.yaml":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"85d56299f4c14b5a53607632804d53fffe4c994c","unresolved":false,"context_lines":[{"line_number":233,"context_line":"              list_concat:"},{"line_number":234,"context_line":"                - {get_attr: [ContainersCommon, volumes]}"},{"line_number":235,"context_line":"                -"},{"line_number":236,"context_line":"                - /var/lib/kolla/config_files/mysql.json:/var/lib/kolla/config_files/config.json:rw,z"},{"line_number":237,"context_line":"                  - /var/lib/config-data/puppet-generated/mysql/:/var/lib/kolla/config_files/src:ro,z"},{"line_number":238,"context_line":"                  - /var/lib/mysql:/var/lib/mysql:rw,z"},{"line_number":239,"context_line":"            environment:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_36524b6a","line":236,"updated":"2019-11-07 09:28:26.000000000","message":"Indentation. Upgrade prepare fails for this.","commit_id":"96784cc48e69838affb4f53fd9ad6a4112ec511c"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"4051be04e02730235a935b026bc9ba2ed1de8015","unresolved":false,"context_lines":[{"line_number":233,"context_line":"              list_concat:"},{"line_number":234,"context_line":"                - {get_attr: [ContainersCommon, volumes]}"},{"line_number":235,"context_line":"                -"},{"line_number":236,"context_line":"                - /var/lib/kolla/config_files/mysql.json:/var/lib/kolla/config_files/config.json:rw,z"},{"line_number":237,"context_line":"                  - /var/lib/config-data/puppet-generated/mysql/:/var/lib/kolla/config_files/src:ro,z"},{"line_number":238,"context_line":"                  - /var/lib/mysql:/var/lib/mysql:rw,z"},{"line_number":239,"context_line":"            environment:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_d14e616d","line":236,"in_reply_to":"3fa7e38b_36524b6a","updated":"2019-11-07 09:56:06.000000000","message":"Done","commit_id":"96784cc48e69838affb4f53fd9ad6a4112ec511c"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"0c73853c4ce8decf3f9b5c52b8976a4c41228873","unresolved":false,"context_lines":[{"line_number":584,"context_line":"              shell:"},{"line_number":585,"context_line":"                str_replace:"},{"line_number":586,"context_line":"                  template:"},{"line_number":587,"context_line":"                    \u0027CONTAINER_CLI run --rm --log-driver\u003dk8s-file --log-opt path\u003d/var/log/containers/stdout/db-upgrade.log \\"},{"line_number":588,"context_line":"                    -u root --net\u003dhost UPGRADE_ENV UPGRADE_VOLUMES \"UPGRADE_IMAGE\" /bin/bash -ecx \"UPGRADE_SCRIPT\"\u0027"},{"line_number":589,"context_line":"                  params:"},{"line_number":590,"context_line":"                    UPGRADE_ENV: \u0027-e \"KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS\"\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_f1503dd8","line":587,"range":{"start_line":587,"start_character":57,"end_line":587,"end_character":65},"updated":"2019-11-07 10:12:43.000000000","message":"Are you sure this is is supported and/or useful?\n\n- https://github.com/containers/libpod/pull/1773/files#diff-038101eb3a1e9e8f078066da44d8a18eR336\n- https://github.com/containers/libpod/commit/93135565914c17eae64b81855e72526fe6c80e66\n\nIf I correctly understand it they:\n- doesn\u0027t support `log-driver`, it\u0027s only for script compatibility (docker [1] to podman, podman to docker)\n- the default seems to be `k8s-logging`\n\n[1] https://docs.docker.com/config/containers/logging/configure/\n\nThoughts?","commit_id":"aee85fea35f72c332fdeb69992c4db154a20cca8"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"b9a15678d67b97506bfea9e144d26402f7b988b7","unresolved":false,"context_lines":[{"line_number":584,"context_line":"              shell:"},{"line_number":585,"context_line":"                str_replace:"},{"line_number":586,"context_line":"                  template:"},{"line_number":587,"context_line":"                    \u0027CONTAINER_CLI run --rm --log-driver\u003dk8s-file --log-opt path\u003d/var/log/containers/stdout/db-upgrade.log \\"},{"line_number":588,"context_line":"                    -u root --net\u003dhost UPGRADE_ENV UPGRADE_VOLUMES \"UPGRADE_IMAGE\" /bin/bash -ecx \"UPGRADE_SCRIPT\"\u0027"},{"line_number":589,"context_line":"                  params:"},{"line_number":590,"context_line":"                    UPGRADE_ENV: \u0027-e \"KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS\"\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_a71047ad","line":587,"range":{"start_line":587,"start_character":57,"end_line":587,"end_character":65},"in_reply_to":"3fa7e38b_67800ff9","updated":"2019-11-07 13:52:58.000000000","message":"Then LGTM :)\n\nThanks for your explanations","commit_id":"aee85fea35f72c332fdeb69992c4db154a20cca8"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"12e38d4af083992b71cef93a4180ea290ed89d11","unresolved":false,"context_lines":[{"line_number":584,"context_line":"              shell:"},{"line_number":585,"context_line":"                str_replace:"},{"line_number":586,"context_line":"                  template:"},{"line_number":587,"context_line":"                    \u0027CONTAINER_CLI run --rm --log-driver\u003dk8s-file --log-opt path\u003d/var/log/containers/stdout/db-upgrade.log \\"},{"line_number":588,"context_line":"                    -u root --net\u003dhost UPGRADE_ENV UPGRADE_VOLUMES \"UPGRADE_IMAGE\" /bin/bash -ecx \"UPGRADE_SCRIPT\"\u0027"},{"line_number":589,"context_line":"                  params:"},{"line_number":590,"context_line":"                    UPGRADE_ENV: \u0027-e \"KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS\"\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_ec8dc67c","line":587,"range":{"start_line":587,"start_character":57,"end_line":587,"end_character":65},"in_reply_to":"3fa7e38b_6c6c76d0","updated":"2019-11-07 11:35:16.000000000","message":"Log directory should point to /var/log/containers/stdouts/ instead if stdout/","commit_id":"aee85fea35f72c332fdeb69992c4db154a20cca8"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"cbd1e5e5a17143544e22e87165f6a11ae763f3bc","unresolved":false,"context_lines":[{"line_number":584,"context_line":"              shell:"},{"line_number":585,"context_line":"                str_replace:"},{"line_number":586,"context_line":"                  template:"},{"line_number":587,"context_line":"                    \u0027CONTAINER_CLI run --rm --log-driver\u003dk8s-file --log-opt path\u003d/var/log/containers/stdout/db-upgrade.log \\"},{"line_number":588,"context_line":"                    -u root --net\u003dhost UPGRADE_ENV UPGRADE_VOLUMES \"UPGRADE_IMAGE\" /bin/bash -ecx \"UPGRADE_SCRIPT\"\u0027"},{"line_number":589,"context_line":"                  params:"},{"line_number":590,"context_line":"                    UPGRADE_ENV: \u0027-e \"KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS\"\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_c729c389","line":587,"range":{"start_line":587,"start_character":57,"end_line":587,"end_character":65},"in_reply_to":"3fa7e38b_6c6c76d0","updated":"2019-11-07 13:06:23.000000000","message":"Thanks for your explanations.\n\nMy main concern was about the `log-driver` option itself and not about the format passed in through this option (`k8s-file`).\n\nBeen explicit here even if this option exist only for compatibility can mislead us in the futur.\n\nI mean we need to don\u0027t forget that point and avoid to expect for something that possibly we risk to don\u0027t get (`k8s-file` driver).\n\nBut if you are sure that this option now works as expected (not only for compatibility between CLIs), then I ok with that.","commit_id":"aee85fea35f72c332fdeb69992c4db154a20cca8"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"1d2f9cd1cd7980aa86ec5d8a56fc9071bc3089d4","unresolved":false,"context_lines":[{"line_number":584,"context_line":"              shell:"},{"line_number":585,"context_line":"                str_replace:"},{"line_number":586,"context_line":"                  template:"},{"line_number":587,"context_line":"                    \u0027CONTAINER_CLI run --rm --log-driver\u003dk8s-file --log-opt path\u003d/var/log/containers/stdout/db-upgrade.log \\"},{"line_number":588,"context_line":"                    -u root --net\u003dhost UPGRADE_ENV UPGRADE_VOLUMES \"UPGRADE_IMAGE\" /bin/bash -ecx \"UPGRADE_SCRIPT\"\u0027"},{"line_number":589,"context_line":"                  params:"},{"line_number":590,"context_line":"                    UPGRADE_ENV: \u0027-e \"KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS\"\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_67800ff9","line":587,"range":{"start_line":587,"start_character":57,"end_line":587,"end_character":65},"in_reply_to":"3fa7e38b_c729c389","updated":"2019-11-07 13:40:51.000000000","message":"basically the issue with all that driver was the drop of \"json-file\" for 1.4.1-1.4.2, but it was re-added as an alias to k8s-file in 1.4.3 :). Sooo yep, I\u0027m pretty sure it\u0027s working - and afaik Container Team doesn\u0027t intend to drop that format.","commit_id":"aee85fea35f72c332fdeb69992c4db154a20cca8"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"314be7e81fccfe03795ea85f222d386a52fa0126","unresolved":false,"context_lines":[{"line_number":584,"context_line":"              shell:"},{"line_number":585,"context_line":"                str_replace:"},{"line_number":586,"context_line":"                  template:"},{"line_number":587,"context_line":"                    \u0027CONTAINER_CLI run --rm --log-driver\u003dk8s-file --log-opt path\u003d/var/log/containers/stdout/db-upgrade.log \\"},{"line_number":588,"context_line":"                    -u root --net\u003dhost UPGRADE_ENV UPGRADE_VOLUMES \"UPGRADE_IMAGE\" /bin/bash -ecx \"UPGRADE_SCRIPT\"\u0027"},{"line_number":589,"context_line":"                  params:"},{"line_number":590,"context_line":"                    UPGRADE_ENV: \u0027-e \"KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS\"\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_6c6c76d0","line":587,"range":{"start_line":587,"start_character":57,"end_line":587,"end_character":65},"in_reply_to":"3fa7e38b_f1503dd8","updated":"2019-11-07 11:29:34.000000000","message":"well, yes, it\u0027s supported - already in use in paunch + container-puppet.py.\nUseful: yes, for debugging purpose, since you\u0027ll get a proper, dedicated log file for that precise task.\n\nAs for docker - we\u0027re moving away from that tool, which doesn\u0027t even support the k8s-file format, and doesn\u0027t have the --log-opt \"path\" anyway.\n\nI\u0027d rather stay consistent with the other tools we have (paunch, container-puppet.py) with the syntax and options. We can try to drop the \"--log-driver\" option to see if it still works later. Being explicit doesn\u0027t hurt ;).\n\nDoes it answer your concerns?","commit_id":"aee85fea35f72c332fdeb69992c4db154a20cca8"}]}