)]}'
{"puppet/services/docker.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"91f6f8f376ff8df3aab4876f22634eab2d6b2bc0","unresolved":false,"context_lines":[{"line_number":169,"context_line":"              docker ps --format \"{{.ID}} {{.Names}}\" | grep -v ceph- |\\"},{"line_number":170,"context_line":"              grep -v neutron-.*qdhcp | grep -v neutron-.*qrouter | grep -v neutron-radvd |\\"},{"line_number":171,"context_line":"              awk \u0027{print $1}\u0027"},{"line_number":172,"context_line":"              {% endraw %}"},{"line_number":173,"context_line":"            # If we ship a config change which requires docker restart, change the when condition:"},{"line_number":174,"context_line":"            # when: puppet_docker_is_outofsync or docker_rpm_needs_update"},{"line_number":175,"context_line":"            when: docker_rpm_needs_update"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_64e1d19b","line":172,"updated":"2019-11-11 09:50:58.000000000","message":"I think something\u0027s missing here.\nLike \"| xargs --no-run-if-empty ...\"","commit_id":"cf34228dfbbdb142849127e89a75e0da2f14fd01"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"b59189643b1bf47feca41197a7bc76bc898a8fa1","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            # We need to make sure connectivity stays by keeping alive ceph and the side containers"},{"line_number":167,"context_line":"            shell: |"},{"line_number":168,"context_line":"              {% raw %}"},{"line_number":169,"context_line":"              docker ps --format \"{{.ID}} {{.Names}}\" | grep -v ceph- |\\"},{"line_number":170,"context_line":"              grep -v neutron-.*qdhcp | grep -v neutron-.*qrouter | grep -v neutron-radvd |\\"},{"line_number":171,"context_line":"              awk \u0027{print $1}\u0027 | xarg --no-run-if-empty docker stop"},{"line_number":172,"context_line":"              {% endraw %}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_3a2d30fd","line":169,"range":{"start_line":169,"start_character":56,"end_line":169,"end_character":68},"updated":"2019-11-11 13:43:43.000000000","message":"Yes, thank you for excluding ceph from the \"docker stop\". Note how the ceph containers are managed by systemd below with Restart\u003dalways. If you docker stop then systemd will just start a new one.\n\n[root@overcloud-cephstorage-2 ~]# vi /etc/systemd/system/ceph-osd\\@.service\n# Please do not change this file directly since it is managed by Ansible and will be overwritten\n[Unit]\nDescription\u003dCeph OSD\nAfter\u003ddocker.service\n\n[Service]\nEnvironmentFile\u003d-/etc/environment\nExecStartPre\u003d-/usr/bin/docker stop ceph-osd-overcloud-cephstorage-2-dev%i\nExecStartPre\u003d-/usr/bin/docker rm -f ceph-osd-overcloud-cephstorage-2-dev%i\nExecStart\u003d/usr/share/ceph-osd-run.sh %i\nExecStop\u003d-/usr/bin/docker stop ceph-osd-overcloud-cephstorage-2-dev%i\nRestart\u003dalways   # \u003c---------------------------------------------------------- HERE!  \nRestartSec\u003d10s\nTimeoutStartSec\u003d120\nTimeoutStopSec\u003d15\n\n[Install]\nWantedBy\u003dmulti-user.target\n[root@overcloud-cephstorage-2 ~]#","commit_id":"6fac64b3254ec87cdb4dc28c4b7729a402347adf"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"a304175bbe50f2c6fa9fb57126c38b5908979123","unresolved":false,"context_lines":[{"line_number":168,"context_line":"              {% raw %}"},{"line_number":169,"context_line":"              docker ps --format \"{{.ID}} {{.Names}}\" | grep -v ceph- |\\"},{"line_number":170,"context_line":"              grep -v neutron-.*qdhcp | grep -v neutron-.*qrouter | grep -v neutron-radvd |\\"},{"line_number":171,"context_line":"              awk \u0027{print $1}\u0027 | xarg --no-run-if-empty docker stop"},{"line_number":172,"context_line":"              {% endraw %}"},{"line_number":173,"context_line":"            # If we ship a config change which requires docker restart, change the when condition:"},{"line_number":174,"context_line":"            # when: puppet_docker_is_outofsync or docker_rpm_needs_update"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_daa73cbc","line":171,"range":{"start_line":171,"start_character":33,"end_line":171,"end_character":37},"updated":"2019-11-11 13:22:02.000000000","message":"missing \"s\"? (s/xarg/xargs)","commit_id":"6fac64b3254ec87cdb4dc28c4b7729a402347adf"}]}