)]}'
{"deployment/nova/nova-libvirt-container-puppet.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"f46f2f57b58ffd32f2e92da2e0a3e9d7871b4aa2","unresolved":false,"context_lines":[{"line_number":646,"context_line":"            privileged: true"},{"line_number":647,"context_line":"            restart: always"},{"line_number":648,"context_line":"            healthcheck:"},{"line_number":649,"context_line":"              test: /openstack/healthcheck"},{"line_number":650,"context_line":"            volumes:"},{"line_number":651,"context_line":"              list_concat:"},{"line_number":652,"context_line":"                - {get_attr: [ContainersCommon, volumes]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_a0348aad","line":649,"range":{"start_line":649,"start_character":0,"end_line":649,"end_character":42},"updated":"2019-11-12 09:17:33.000000000","message":"As mentioned in [1], I think we\u0027d need to pass the binary to\ncheck as libvirt/virtlogd use the same image and we have to \nuse a combined healthcheck script.\n\n[1] https://review.opendev.org/#/c/693674/1","commit_id":"a65197848baf590c7cdbe141c6adeaa03ce9557d"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"f46f2f57b58ffd32f2e92da2e0a3e9d7871b4aa2","unresolved":false,"context_lines":[{"line_number":683,"context_line":"            depends_on:"},{"line_number":684,"context_line":"              - tripleo_nova_virtlogd"},{"line_number":685,"context_line":"            healthcheck:"},{"line_number":686,"context_line":"              test: /openstack/healthcheck"},{"line_number":687,"context_line":"            volumes:"},{"line_number":688,"context_line":"              list_concat:"},{"line_number":689,"context_line":"                - {get_attr: [ContainersCommon, volumes]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_603e928c","line":686,"range":{"start_line":686,"start_character":1,"end_line":686,"end_character":42},"updated":"2019-11-12 09:17:33.000000000","message":"also here","commit_id":"a65197848baf590c7cdbe141c6adeaa03ce9557d"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"7f0834eca366e44f7bca7208701a3221352c84a1","unresolved":false,"context_lines":[{"line_number":646,"context_line":"            privileged: true"},{"line_number":647,"context_line":"            restart: always"},{"line_number":648,"context_line":"            healthcheck:"},{"line_number":649,"context_line":"              test: \u0027/usr/share/openstack-tripleo-common/healthcheck/nova-libvirt virtlogd\u0027"},{"line_number":650,"context_line":"            volumes:"},{"line_number":651,"context_line":"              list_concat:"},{"line_number":652,"context_line":"                - {get_attr: [ContainersCommon, volumes]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_11ebfda3","line":649,"range":{"start_line":649,"start_character":1,"end_line":649,"end_character":91},"updated":"2019-11-20 17:09:57.000000000","message":"this runs inside the container, so it should be /openstack/healthcheck virtlogd, no?","commit_id":"06b5d8d8ab5286f8871cf03f54a8891f18cfaa11"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"7f0834eca366e44f7bca7208701a3221352c84a1","unresolved":false,"context_lines":[{"line_number":683,"context_line":"            depends_on:"},{"line_number":684,"context_line":"              - tripleo_nova_virtlogd"},{"line_number":685,"context_line":"            healthcheck:"},{"line_number":686,"context_line":"              test: \u0027/usr/share/openstack-tripleo-common/healthcheck/nova-libvirt libvirtd\u0027"},{"line_number":687,"context_line":"            volumes:"},{"line_number":688,"context_line":"              list_concat:"},{"line_number":689,"context_line":"                - {get_attr: [ContainersCommon, volumes]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_d12ec5f8","line":686,"range":{"start_line":686,"start_character":20,"end_line":686,"end_character":91},"updated":"2019-11-20 17:09:57.000000000","message":"same as above?","commit_id":"06b5d8d8ab5286f8871cf03f54a8891f18cfaa11"}]}