)]}'
{"deployment/ovn/ovn-dbs-container-puppet.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6752aacc7aa8230a4d8da6d07afdb73c2e50f55d","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                  - /var/lib/openvswitch/ovn:/var/lib/openvswitch:shared,z"},{"line_number":170,"context_line":"                  - /var/lib/openvswitch/ovn:/run/openvswitch:shared,z"},{"line_number":171,"context_line":"                  - /var/log/containers/openvswitch:/var/log/openvswitch:z"},{"line_number":172,"context_line":"            command: bash -c $* -- eval if [ ! -z $(ovsdb-tool db-name) ]; then exec ovsdb-tool create \"/var/lib/openvswitch/ovnsb.db\" \"/usr/share/openvswitch/ovn-sb.ovsschema\"; fi"},{"line_number":173,"context_line":"        step_4:"},{"line_number":174,"context_line":"          ovn_north_db_server:"},{"line_number":175,"context_line":"            start_order: 0"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_0abaf109","line":172,"updated":"2019-11-20 08:09:46.000000000","message":"this is kinda scary command statement - not sure where to start.\n\nso how does \"ovsdb-tool db-name\"  work then I don\u0027t see it anywhere else in tht. does that db-name magically resolve to the name of your database? (ovnsb.db?) or its something else","commit_id":"64f893faa3dc8c8d24df26d7e4ed0ec58b82a875"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"eab0d5c1387bee26e125447d6bf4d93126126061","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                  - /var/lib/openvswitch/ovn:/var/lib/openvswitch:shared,z"},{"line_number":170,"context_line":"                  - /var/lib/openvswitch/ovn:/run/openvswitch:shared,z"},{"line_number":171,"context_line":"                  - /var/log/containers/openvswitch:/var/log/openvswitch:z"},{"line_number":172,"context_line":"            command: bash -c $* -- eval if [ ! -z $(ovsdb-tool db-name) ]; then exec ovsdb-tool create \"/var/lib/openvswitch/ovnsb.db\" \"/usr/share/openvswitch/ovn-sb.ovsschema\"; fi"},{"line_number":173,"context_line":"        step_4:"},{"line_number":174,"context_line":"          ovn_north_db_server:"},{"line_number":175,"context_line":"            start_order: 0"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_8dd7db22","line":172,"in_reply_to":"3fa7e38b_0abaf109","updated":"2019-11-20 09:37:16.000000000","message":"Well I\u0027m testing it atm, it\u0027s working for upgrade and normal deployment.\nThis should return the db name if the db exist, if not, then we create the db.\nThe recent commit that introduce this creation totally ignore the case where the db already exist.\nI don\u0027t want to claim a revert of this commit for now, so I\u0027m want to find something that take in consideration the upgrade case.","commit_id":"64f893faa3dc8c8d24df26d7e4ed0ec58b82a875"}]}