)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f2c5aff2afe06db3c8e03fc35f6983d2506d8073","unresolved":false,"context_lines":[{"line_number":10,"context_line":"management network. This is because the service principal is not"},{"line_number":11,"context_line":"created due to VIP being set to false in network_data.yaml"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Resolves: rhbz#1777605"},{"line_number":14,"context_line":"Change-Id: I43fd5f67c1a0be6eaa1752575349e64329cada4a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_40f16fdd","line":13,"updated":"2020-01-09 19:14:24.000000000","message":"should be a launchpad reference for upstream patches.","commit_id":"3766564edb9e3a6e3fe49054f1f9efdf0e67ee93"}],"deployment/apache/apache-baremetal-puppet.j2.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"4f4c4d6b3d28f36448bacc271cd456a93b709570","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # since we don\u0027t generate certificates for those."},{"line_number":64,"context_line":"        - ctlplane"},{"line_number":65,"context_line":"{%- for network in networks if network.enabled|default(true) %}"},{"line_number":66,"context_line":"  {%- if network.vip !\u003d false %}"},{"line_number":67,"context_line":"        - {{network.name_lower}}"},{"line_number":68,"context_line":"  {%- endif %}"},{"line_number":69,"context_line":"{%- endfor %}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df33271e_5db2c195","line":66,"range":{"start_line":66,"start_character":9,"end_line":66,"end_character":30},"updated":"2020-03-27 20:12:38.000000000","message":"We want to make sure we have a default here.\n\n {%- if network.vip|default(false) %}","commit_id":"76f093bad658b4e4ebd0cd431cc1a39839614443"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"646935c2ba17dfbc182d0e23b59d4f05da1c0956","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # since we don\u0027t generate certificates for those."},{"line_number":64,"context_line":"        - ctlplane"},{"line_number":65,"context_line":"{%- for network in networks if network.enabled|default(true) %}"},{"line_number":66,"context_line":"  {%- if network.vip !\u003d false %}"},{"line_number":67,"context_line":"        - {{network.name_lower}}"},{"line_number":68,"context_line":"  {%- endif %}"},{"line_number":69,"context_line":"{%- endfor %}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df33271e_8e61df3c","line":66,"range":{"start_line":66,"start_character":9,"end_line":66,"end_character":30},"in_reply_to":"df33271e_5d0e413b","updated":"2020-04-07 12:01:07.000000000","message":"Done","commit_id":"76f093bad658b4e4ebd0cd431cc1a39839614443"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"4864acbf8f9e5de914aa8d014508be06bc16310b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # since we don\u0027t generate certificates for those."},{"line_number":64,"context_line":"        - ctlplane"},{"line_number":65,"context_line":"{%- for network in networks if network.enabled|default(true) %}"},{"line_number":66,"context_line":"  {%- if network.vip !\u003d false %}"},{"line_number":67,"context_line":"        - {{network.name_lower}}"},{"line_number":68,"context_line":"  {%- endif %}"},{"line_number":69,"context_line":"{%- endfor %}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df33271e_9849f7d1","line":66,"range":{"start_line":66,"start_character":9,"end_line":66,"end_character":30},"in_reply_to":"df33271e_5d0e413b","updated":"2020-03-27 20:47:37.000000000","message":"This is\u0027nt ansible. It\u0027s python-\u003ejinj2 - see: tripleo_common/utils/template.py#L135\n\nIs it ansible specificly that won\u0027t evaluate bare variables? Or is it actually a jinja2? (If this is something in jinja2 we have many many places to update in THT.)","commit_id":"76f093bad658b4e4ebd0cd431cc1a39839614443"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9be623e8aaa78ae3442e185722482aca7ec6b7b4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # since we don\u0027t generate certificates for those."},{"line_number":64,"context_line":"        - ctlplane"},{"line_number":65,"context_line":"{%- for network in networks if network.enabled|default(true) %}"},{"line_number":66,"context_line":"  {%- if network.vip !\u003d false %}"},{"line_number":67,"context_line":"        - {{network.name_lower}}"},{"line_number":68,"context_line":"  {%- endif %}"},{"line_number":69,"context_line":"{%- endfor %}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df33271e_5d0e413b","line":66,"range":{"start_line":66,"start_character":9,"end_line":66,"end_character":30},"in_reply_to":"df33271e_5db2c195","updated":"2020-03-27 20:15:24.000000000","message":"In future versions of ansible the evaluation of bare variables will be removed.\n\n    {% if network.vip | default(false) | bool %}","commit_id":"76f093bad658b4e4ebd0cd431cc1a39839614443"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"8d97d23733ffc74356a862cbc81aa4aeac149aea","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # since we don\u0027t generate certificates for those."},{"line_number":64,"context_line":"        - ctlplane"},{"line_number":65,"context_line":"{%- for network in networks if network.enabled|default(true) %}"},{"line_number":66,"context_line":"  {%- if network.vip !\u003d false %}"},{"line_number":67,"context_line":"        - {{network.name_lower}}"},{"line_number":68,"context_line":"  {%- endif %}"},{"line_number":69,"context_line":"{%- endfor %}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df33271e_97727348","line":66,"range":{"start_line":66,"start_character":9,"end_line":66,"end_character":30},"in_reply_to":"df33271e_8e61df3c","updated":"2020-04-08 12:32:38.000000000","message":"looks like there is no bool filter\n\njinja2.exceptions.TemplateAssertionError: no filter named \u0027bool\u0027","commit_id":"76f093bad658b4e4ebd0cd431cc1a39839614443"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"cec6d32f4256d93215a8f37ee9663e60b2b51e1f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # since we don\u0027t generate certificates for those."},{"line_number":64,"context_line":"        - ctlplane"},{"line_number":65,"context_line":"{%- for network in networks if network.enabled|default(true) %}"},{"line_number":66,"context_line":"  {%- if network.vip !\u003d false %}"},{"line_number":67,"context_line":"        - {{network.name_lower}}"},{"line_number":68,"context_line":"  {%- endif %}"},{"line_number":69,"context_line":"{%- endfor %}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df33271e_bf4da9c5","line":66,"range":{"start_line":66,"start_character":9,"end_line":66,"end_character":30},"in_reply_to":"df33271e_9849f7d1","updated":"2020-03-30 13:07:57.000000000","message":"I know ansible is deprecating it which leverages the same jinja2, but I\u0027m not sure if Jinja2 is the reason Ansible is deprecating this functionality. That said, even if this still works in Jinja2 after the Ansible deprecation I would still rewrite the statement so that its not comparing bare variables.","commit_id":"76f093bad658b4e4ebd0cd431cc1a39839614443"}]}