)]}'
{"network/scripts/run-os-net-config.sh":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a93b651bb587606542090654bc1faa7585ae032d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        network_config_hook"},{"line_number":81,"context_line":"    fi"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    sed -i \"s/: \\\"bridge_name/: \\\"${bridge_name:-\u0027\u0027}/\" /etc/os-net-config/config.json"},{"line_number":84,"context_line":"    sed -i \"s/interface_name/${interface_name:-\u0027\u0027}/\" /etc/os-net-config/config.json"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    set +e"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_7d24f060","line":83,"range":{"start_line":83,"start_character":15,"end_line":83,"end_character":18},"updated":"2019-12-02 18:59:32.000000000","message":"The nic config\u0027s are user input, do we want to enforce quotes and a single space, i.e tab not supported?\n\nWould this be better:\n  sed -i \"s/:\\s*\\\"?bridge_name\\\"?/: \\\"${bridge_name:-\u0027\u0027}\\\"/\"\n\nA colon + any number of whitepace + optional quote + bridge_name + optional quote?","commit_id":"858cc6c54f690058ce28b0832870df875a7923e9"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"4170232e592918b5041034c30a38188c8516c4b6","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        network_config_hook"},{"line_number":81,"context_line":"    fi"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    sed -i \"s/: \\\"bridge_name/: \\\"${bridge_name:-\u0027\u0027}/\" /etc/os-net-config/config.json"},{"line_number":84,"context_line":"    sed -i \"s/interface_name/${interface_name:-\u0027\u0027}/\" /etc/os-net-config/config.json"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    set +e"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_5d757432","line":83,"range":{"start_line":83,"start_character":15,"end_line":83,"end_character":18},"in_reply_to":"3fa7e38b_7d24f060","updated":"2019-12-02 19:08:10.000000000","message":"err, on second tought I\u0027m wrong. This file is dumped from tha yaml the user input\u0027s. This should be fine with the current patchset.","commit_id":"858cc6c54f690058ce28b0832870df875a7923e9"}]}