)]}'
{"common/deploy-steps.j2":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ab0c6c1164c63758fc6405af65f32f83b4e27cf5","unresolved":false,"context_lines":[{"line_number":1518,"context_line":"                - facts"},{"line_number":1519,"context_line":"            - hosts: DEPLOY_TARGET_HOST"},{"line_number":1520,"context_line":"              name: Scaling"},{"line_number":1521,"context_line":"              gather_facts: {{ \u0027\"{{\u0027 }} gather_facts | default(false) {{ \u0027}}\"\u0027 }}"},{"line_number":1522,"context_line":"              any_errors_fatal: yes"},{"line_number":1523,"context_line":"              become: false"},{"line_number":1524,"context_line":"              vars:"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_6b590027","line":1521,"updated":"2019-12-11 18:39:24.000000000","message":"I think the issue was here because this was default false. it should just be default true?","commit_id":"393696bc6027e1a16e5907b023dc2315f80b5910"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"851dd45bc19df52fa530dae119f5c9d2d287116c","unresolved":false,"context_lines":[{"line_number":1518,"context_line":"                - facts"},{"line_number":1519,"context_line":"            - hosts: DEPLOY_TARGET_HOST"},{"line_number":1520,"context_line":"              name: Scaling"},{"line_number":1521,"context_line":"              gather_facts: {{ \u0027\"{{\u0027 }} gather_facts | default(false) {{ \u0027}}\"\u0027 }}"},{"line_number":1522,"context_line":"              any_errors_fatal: yes"},{"line_number":1523,"context_line":"              become: false"},{"line_number":1524,"context_line":"              vars:"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_2bd46846","line":1521,"in_reply_to":"3fa7e38b_6b590027","updated":"2019-12-11 18:42:34.000000000","message":"Done","commit_id":"393696bc6027e1a16e5907b023dc2315f80b5910"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ab0c6c1164c63758fc6405af65f32f83b4e27cf5","unresolved":false,"context_lines":[{"line_number":1537,"context_line":"                # If a task is allowed to fail, it needs to be configured at"},{"line_number":1538,"context_line":"                # the task definition level but not here."},{"line_number":1539,"context_line":"                - name: Force fact gathering"},{"line_number":1540,"context_line":"                  setup: {}"},{"line_number":1541,"context_line":"                - include_tasks: scale_steps_tasks.yaml"},{"line_number":1542,"context_line":"                  with_sequence: start\u003d1 end\u003d{{scale_steps_max}}"},{"line_number":1543,"context_line":"                  loop_control:"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_ab6378dc","line":1540,"updated":"2019-12-11 18:39:24.000000000","message":"I wonder how painful this will be for perf because fact gathering on computes is problematic when they have lots of network interfaces (it\u0027s just not as bad as facter 2 was, but it\u0027s still awful)","commit_id":"393696bc6027e1a16e5907b023dc2315f80b5910"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"851dd45bc19df52fa530dae119f5c9d2d287116c","unresolved":false,"context_lines":[{"line_number":1537,"context_line":"                # If a task is allowed to fail, it needs to be configured at"},{"line_number":1538,"context_line":"                # the task definition level but not here."},{"line_number":1539,"context_line":"                - name: Force fact gathering"},{"line_number":1540,"context_line":"                  setup: {}"},{"line_number":1541,"context_line":"                - include_tasks: scale_steps_tasks.yaml"},{"line_number":1542,"context_line":"                  with_sequence: start\u003d1 end\u003d{{scale_steps_max}}"},{"line_number":1543,"context_line":"                  loop_control:"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_ab91389c","line":1540,"in_reply_to":"3fa7e38b_ab6378dc","updated":"2019-12-11 18:42:34.000000000","message":"Done","commit_id":"393696bc6027e1a16e5907b023dc2315f80b5910"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"704ca3a0254fa7c5f9e26072bd04e69a331b2665","unresolved":false,"context_lines":[{"line_number":1518,"context_line":"                - facts"},{"line_number":1519,"context_line":"            - hosts: DEPLOY_TARGET_HOST"},{"line_number":1520,"context_line":"              name: Scaling"},{"line_number":1521,"context_line":"              gather_facts: true"},{"line_number":1522,"context_line":"              any_errors_fatal: yes"},{"line_number":1523,"context_line":"              become: false"},{"line_number":1524,"context_line":"              vars:"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_ab1b7819","line":1521,"updated":"2019-12-11 18:49:36.000000000","message":"I would add a comment on this one so someone doesn\u0027t think this was accidental and update it to use gather_facts","commit_id":"c7aefd6ec87fad698bdb09c34491c94080980f8a"}]}