)]}'
{"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"6abe24836f3d620a0231cc043373a5a2c260a172","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        - block:"},{"line_number":417,"context_line":"            - name: set is_bootstrap_node fact"},{"line_number":418,"context_line":"              set_fact: is_bootstrap_node\u003d{{tripleo_packages_short_bootstrap_node_name|lower \u003d\u003d ansible_hostname|lower}}"},{"line_number":419,"context_line":"            - name: Register repo type FastForwardRepoTypeand args"},{"line_number":420,"context_line":"              set_fact:"},{"line_number":421,"context_line":"                fast_forward_repo_type: {get_param: FastForwardRepoType}"},{"line_number":422,"context_line":"                fast_forward_repo_args: {get_param: FastForwardRepoArgs}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_1cd73b53","line":419,"range":{"start_line":419,"start_character":54,"end_line":419,"end_character":61},"updated":"2019-12-16 12:45:14.000000000","message":"typo","commit_id":"8a2cb22f2f580610bce0a667b7a1e59f42dff74f"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"42860b76c04b9f32f1abe5f05c2fae5bbc691979","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            - step|int \u003d\u003d 3"},{"line_number":361,"context_line":"            - os_net_config_need_upgrade.stdout"},{"line_number":362,"context_line":"            - os_net_config_has_config.rc \u003d\u003d 0"},{"line_number":363,"context_line":"        # Exclude ansible until https://github.com/ansible/ansible/issues/56636"},{"line_number":364,"context_line":"        # is available"},{"line_number":365,"context_line":"        - name: Set boolean skip_yum_update"},{"line_number":366,"context_line":"          set_fact:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_e2ff0664","line":363,"updated":"2019-12-17 14:23:33.000000000","message":"You should add the task over this line, as this command belonged to the \"Update all packages\" task.","commit_id":"b7ec7230b87cb34ced152246664a96d4444da338"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"42860b76c04b9f32f1abe5f05c2fae5bbc691979","unresolved":false,"context_lines":[{"line_number":366,"context_line":"          set_fact:"},{"line_number":367,"context_line":"            skip_yum_update: {get_param: SkipYumUpdate}"},{"line_number":368,"context_line":"        - name: Update all packages"},{"line_number":369,"context_line":"          when: step|int \u003d\u003d 3 and skip_yum_update|bool"},{"line_number":370,"context_line":"          yum:"},{"line_number":371,"context_line":"            name: \u0027*\u0027"},{"line_number":372,"context_line":"            state: latest"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_0226e223","line":369,"updated":"2019-12-17 14:23:33.000000000","message":"Use the list sintax when having more than one condition please:\nwhen:\n  - step|int \u003d\u003d 3\n  - skip_yum_update|bool","commit_id":"b7ec7230b87cb34ced152246664a96d4444da338"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"a88f16e968a38386391c00d7cb06a8e22a1d2038","unresolved":false,"context_lines":[{"line_number":83,"context_line":"      major-upgrade-composable-steps.yaml and major-upgrade-converge.yaml"},{"line_number":84,"context_line":"      environment files."},{"line_number":85,"context_line":"    default: \u0027\u0027"},{"line_number":86,"context_line":"  SkipYumUpdate:"},{"line_number":87,"context_line":"    default: \u0027false\u0027"},{"line_number":88,"context_line":"    description: Set to true to skip the update all packages"},{"line_number":89,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_29f9344d","line":86,"range":{"start_line":86,"start_character":2,"end_line":86,"end_character":15},"updated":"2019-12-24 06:08:59.000000000","message":"SkipPackageUpdate would be a better name.","commit_id":"486ded537a748e55331523a0f855baa330c36003"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"370999bb6efaf112fcf3a84bc93567df2ab6a4fd","unresolved":false,"context_lines":[{"line_number":83,"context_line":"      major-upgrade-composable-steps.yaml and major-upgrade-converge.yaml"},{"line_number":84,"context_line":"      environment files."},{"line_number":85,"context_line":"    default: \u0027\u0027"},{"line_number":86,"context_line":"  SkipYumUpdate:"},{"line_number":87,"context_line":"    default: \u0027false\u0027"},{"line_number":88,"context_line":"    description: Set to true to skip the update all packages"},{"line_number":89,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_715cdf4b","line":86,"range":{"start_line":86,"start_character":2,"end_line":86,"end_character":15},"in_reply_to":"3fa7e38b_29f9344d","updated":"2019-12-30 09:08:19.000000000","message":"Why you think it\u0027s a better name? We use yum here, so for me it\u0027s a right name.","commit_id":"486ded537a748e55331523a0f855baa330c36003"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8bbea8bf732a714d7f868df9eb27a858fb078423","unresolved":false,"context_lines":[{"line_number":83,"context_line":"      major-upgrade-composable-steps.yaml and major-upgrade-converge.yaml"},{"line_number":84,"context_line":"      environment files."},{"line_number":85,"context_line":"    default: \u0027\u0027"},{"line_number":86,"context_line":"  SkipYumUpdate:"},{"line_number":87,"context_line":"    default: \u0027false\u0027"},{"line_number":88,"context_line":"    description: Set to true to skip the update all packages"},{"line_number":89,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_14c0f9df","line":86,"range":{"start_line":86,"start_character":2,"end_line":86,"end_character":15},"in_reply_to":"3fa7e38b_715cdf4b","updated":"2019-12-30 12:52:12.000000000","message":"in RHEL8 it\u0027s actually DNF, I would rather prefer using Package vs Yum indeed.","commit_id":"486ded537a748e55331523a0f855baa330c36003"}]}