)]}'
{"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bf2dd2a330b9c3e2c0fa6ae1d71c96aae8138512","unresolved":false,"context_lines":[{"line_number":222,"context_line":"          register: ovs_pkg_out"},{"line_number":223,"context_line":"          shell:"},{"line_number":224,"context_line":"            rpm -qa | awk -F- \u0027/^(openvswitch[0-9]+\\.[0-9]+-|openvswitch-2)/{print $1}\u0027"},{"line_number":225,"context_line":"        - name: Don\u0027t update if not present"},{"line_number":226,"context_line":"          set_fact:"},{"line_number":227,"context_line":"            run_ovs_update: \"{{ (ovs_pkg_out.stdout | length) \u003e 0 }}\""},{"line_number":228,"context_line":"        - name: Block for gathering information for upgrading OpenvSwitch layered product packaging"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_386263da","line":225,"range":{"start_line":225,"start_character":19,"end_line":225,"end_character":43},"updated":"2020-01-10 07:56:00.000000000","message":"can you revise that a bit... would look odd in logs (don\u0027t update what if what is not present?) \"Set fact to skip ovs update when ovs packages absent\"","commit_id":"f907d061ba1d8cf6fbd15fc242b162c618a70154"},{"author":{"_account_id":27069,"name":"Sai Ram Peesapati","email":"peesapatisairam@gmail.com","username":"sairamp"},"change_message_id":"c63fc0993cc77f7761ee9bf42671f0bbcf2b4f7d","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            rpm -qa | awk -F- \u0027/^(openvswitch[0-9]+\\.[0-9]+-|openvswitch-2)/{print $1}\u0027"},{"line_number":225,"context_line":"        - name: Don\u0027t update if not present"},{"line_number":226,"context_line":"          set_fact:"},{"line_number":227,"context_line":"            run_ovs_update: \"{{ (ovs_pkg_out.stdout | length) \u003e 0 }}\""},{"line_number":228,"context_line":"        - name: Block for gathering information for upgrading OpenvSwitch layered product packaging"},{"line_number":229,"context_line":"          when:"},{"line_number":230,"context_line":"            - step|int \u003d\u003d 2"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_f643813e","line":227,"updated":"2020-01-09 21:31:23.000000000","message":"I took this same logic and added to update_tasks (in OSPD13) on my setup and yes, below tasks are skipping if openvswitch is not present on overcloud nodes. \nWhile testing I observed, these 2 tasks are being ran for all steps (0 to 5). It occurred to me that it will be nice if we can make it run only when step is 2.","commit_id":"f907d061ba1d8cf6fbd15fc242b162c618a70154"}]}