)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"13d7a2edbf4c569f7b86bb1a5379ac0f0c97ea80","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This change will always set ServerDeletionPolicy to \u0027retain\u0027 during"},{"line_number":10,"context_line":"upgrade prepare, and back to the default \u0027delete\u0027 during the converge."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"For a normal upgrade this will have no effect since scale-down is not"},{"line_number":13,"context_line":"recommended during an upgrade."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"For a transition from nova based undercloud to nova-less, this allows"},{"line_number":16,"context_line":"the following steps to work:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7fd8b277_184cd51e","line":13,"range":{"start_line":12,"start_character":21,"end_line":13,"end_character":11},"updated":"2020-12-01 08:58:55.000000000","message":"well just cos it is not recommended it doesn\u0027t necessarily follow that it won\u0027t happen 😊 \n\nit offers protection even if that happens by accident right?","commit_id":"e42558dc09242fbb80de2baacb9eaad5c5e4598b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"13d7a2edbf4c569f7b86bb1a5379ac0f0c97ea80","unresolved":true,"context_lines":[{"line_number":23,"context_line":"   resources which are managed directly with the provision/unprovision"},{"line_number":24,"context_line":"   commands"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This approach is an alternative to preventing the heat nova resource"},{"line_number":27,"context_line":"from ever deleting a nova server after the undercloud upgrade[2]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This is a medium risk backport as it affects major upgrades, but it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"31174661_615b757a","line":26,"range":{"start_line":26,"start_character":20,"end_line":26,"end_character":31},"updated":"2020-12-01 08:58:55.000000000","message":"nice to see this interface I am only familiar with the \u0027alternative\u0027 you\u0027re pointing to we used that in the past for the network resources.\n\nsince i had to go looking adding pointer if useful for anyone else https://docs.openstack.org/heat/latest/template_guide/hot_spec.html#resources-section \u0027deletion_policy\u0027","commit_id":"e42558dc09242fbb80de2baacb9eaad5c5e4598b"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"9aeb63a5f23cfe6e1e5d7925a82b2e63f0b8a5d8","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This is a medium risk backport as it affects major upgrades, but it"},{"line_number":30,"context_line":"actually reduces the risk of accidentally deleting servers during"},{"line_number":31,"context_line":"upgrade."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[1] https://review.opendev.org/#/c/674141/"},{"line_number":34,"context_line":"[2] https://review.opendev.org/#/c/675498/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_e2b518d1","line":31,"updated":"2020-01-08 17:26:35.000000000","message":"Does that affect FFWD upgrade?","commit_id":"e42558dc09242fbb80de2baacb9eaad5c5e4598b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"13d7a2edbf4c569f7b86bb1a5379ac0f0c97ea80","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This is a medium risk backport as it affects major upgrades, but it"},{"line_number":30,"context_line":"actually reduces the risk of accidentally deleting servers during"},{"line_number":31,"context_line":"upgrade."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[1] https://review.opendev.org/#/c/674141/"},{"line_number":34,"context_line":"[2] https://review.opendev.org/#/c/675498/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"493cae8f_c92ae622","line":31,"in_reply_to":"3fa7e38b_e2b518d1","updated":"2020-12-01 08:58:55.000000000","message":"well it *could* do if you added the ServerDeletionPolicy to the ffwd upgrade environment files prepare/converge?","commit_id":"e42558dc09242fbb80de2baacb9eaad5c5e4598b"}]}