)]}'
{"deployment/neutron/neutron-metadata-container-puppet.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"7cbc2da9dfc77d3ba2e4e0f08f55ccbf1e2dc7c9","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":229,"context_line":"            - release \u003d\u003d \u0027rocky\u0027"},{"line_number":230,"context_line":"            - neutron_metadata_agent_enabled|bool"},{"line_number":231,"context_line":"        - when:"},{"line_number":232,"context_line":"            - step|int \u003d\u003d 2"},{"line_number":233,"context_line":"            - neutron_user_avail|bool"},{"line_number":234,"context_line":"          block:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_6511a0ae","line":231,"updated":"2020-02-06 08:41:21.000000000","message":"These tasks are added as part of \u0027post_upgrade_tasks\u0027 in dhcp and l3 services, which I beleive will be invoked during FFU\u0027s 3rd step. Any particular reason for not following the same approach?","commit_id":"da2cbcabac6e3de5d37e4c72958dc3a0d03b4ad8"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"b490c2479728c33aba28d926749fae0e83f5003d","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":229,"context_line":"            - release \u003d\u003d \u0027rocky\u0027"},{"line_number":230,"context_line":"            - neutron_metadata_agent_enabled|bool"},{"line_number":231,"context_line":"        - when:"},{"line_number":232,"context_line":"            - step|int \u003d\u003d 2"},{"line_number":233,"context_line":"            - neutron_user_avail|bool"},{"line_number":234,"context_line":"          block:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_37e6a94b","line":231,"in_reply_to":"3fa7e38b_6511a0ae","updated":"2020-02-19 22:07:15.000000000","message":"Changed to be in post_upgrade_tasks","commit_id":"da2cbcabac6e3de5d37e4c72958dc3a0d03b4ad8"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"d4de6ba5092f0b5889f20bc193259957e2f217ab","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":229,"context_line":"            - release \u003d\u003d \u0027rocky\u0027"},{"line_number":230,"context_line":"            - neutron_metadata_agent_enabled|bool"},{"line_number":231,"context_line":"        - when:"},{"line_number":232,"context_line":"            - step|int \u003d\u003d 2"},{"line_number":233,"context_line":"            - neutron_user_avail|bool"},{"line_number":234,"context_line":"          block:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_8f118b53","line":231,"in_reply_to":"3fa7e38b_6511a0ae","updated":"2020-02-19 19:12:20.000000000","message":"That\u0027s a good point. IIRC there was a reason this was done in the post_upgrade_tasks. There was some kind of timing issue that was making the setfacl lines useless unless it was done during the post_upgrade_tasks.","commit_id":"da2cbcabac6e3de5d37e4c72958dc3a0d03b4ad8"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"7cbc2da9dfc77d3ba2e4e0f08f55ccbf1e2dc7c9","unresolved":false,"context_lines":[{"line_number":230,"context_line":"            - neutron_metadata_agent_enabled|bool"},{"line_number":231,"context_line":"        - when:"},{"line_number":232,"context_line":"            - step|int \u003d\u003d 2"},{"line_number":233,"context_line":"            - neutron_user_avail|bool"},{"line_number":234,"context_line":"          block:"},{"line_number":235,"context_line":"            - name: Ensure r/w access for existing files after upgrade"},{"line_number":236,"context_line":"              become: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_250ba87c","line":233,"range":{"start_line":233,"start_character":14,"end_line":233,"end_character":32},"updated":"2020-02-06 08:41:21.000000000","message":"Is it defined elsewhere?","commit_id":"da2cbcabac6e3de5d37e4c72958dc3a0d03b4ad8"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"d4de6ba5092f0b5889f20bc193259957e2f217ab","unresolved":false,"context_lines":[{"line_number":230,"context_line":"            - neutron_metadata_agent_enabled|bool"},{"line_number":231,"context_line":"        - when:"},{"line_number":232,"context_line":"            - step|int \u003d\u003d 2"},{"line_number":233,"context_line":"            - neutron_user_avail|bool"},{"line_number":234,"context_line":"          block:"},{"line_number":235,"context_line":"            - name: Ensure r/w access for existing files after upgrade"},{"line_number":236,"context_line":"              become: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_cf30e3ed","line":233,"range":{"start_line":233,"start_character":14,"end_line":233,"end_character":32},"in_reply_to":"3fa7e38b_250ba87c","updated":"2020-02-19 19:12:20.000000000","message":"good catch, in the neutron agent case this is obtained in a task just above the setfacl lines.","commit_id":"da2cbcabac6e3de5d37e4c72958dc3a0d03b4ad8"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"7cbc2da9dfc77d3ba2e4e0f08f55ccbf1e2dc7c9","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            - step|int \u003d\u003d 2"},{"line_number":233,"context_line":"            - neutron_user_avail|bool"},{"line_number":234,"context_line":"          block:"},{"line_number":235,"context_line":"            - name: Ensure r/w access for existing files after upgrade"},{"line_number":236,"context_line":"              become: true"},{"line_number":237,"context_line":"              shell: |"},{"line_number":238,"context_line":"                umask 0002"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_4573441d","line":235,"updated":"2020-02-06 08:41:21.000000000","message":"This step looks common across multiple services, though it is needed if the service is placed in different roles, it would be duplicate run (if all in the same role). I don\u0027t think we have a mechanism to avoid such duplication now. Just an observation, no actions required.","commit_id":"da2cbcabac6e3de5d37e4c72958dc3a0d03b4ad8"}]}