)]}'
{"ci/environments/scenario001-standalone.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"35db237af1c6839b07262eba6a150c862616dc7c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  CephPoolDefaultSize: 1"},{"line_number":73,"context_line":"  CephEnableDashboard: true"},{"line_number":74,"context_line":"  CephAnsibleRepo: \"tripleo-centos-ceph-nautilus\""},{"line_number":75,"context_line":"  CinderRbdExtraPools: pool1,pool2,pool3"},{"line_number":76,"context_line":"  CephPools:"},{"line_number":77,"context_line":"    - name: altrbd"},{"line_number":78,"context_line":"      pg_num: 8"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1fa4df85_02877bd9","line":75,"updated":"2020-03-02 12:05:46.000000000","message":"try use \"altrbd,pool2\" so we make sure the CephPools value is actually overriding the properties which would otherwise be used for the pools listed by CinderRbdExtraPools","commit_id":"b5a0afe2c72364daaece56e8d59e4dd6ad38fb37"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"ea2d439e6fa6e680c8aa2af934528cfc889f3913","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  CephPoolDefaultSize: 1"},{"line_number":73,"context_line":"  CephEnableDashboard: true"},{"line_number":74,"context_line":"  CephAnsibleRepo: \"tripleo-centos-ceph-nautilus\""},{"line_number":75,"context_line":"  CinderRbdExtraPools: pool1,pool2,pool3"},{"line_number":76,"context_line":"  CephPools:"},{"line_number":77,"context_line":"    - name: altrbd"},{"line_number":78,"context_line":"      pg_num: 8"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1fa4df85_e7702cdf","line":75,"in_reply_to":"1fa4df85_02877bd9","updated":"2020-03-02 12:22:18.000000000","message":"++ will do","commit_id":"b5a0afe2c72364daaece56e8d59e4dd6ad38fb37"}],"deployment/ceph-ansible/ceph-base.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"762346a5551a4d38cf102ae4b87ce4b66aef7cc0","unresolved":false,"context_lines":[{"line_number":382,"context_line":"          glance_pool_name: {get_param: GlanceRbdPoolName}"},{"line_number":383,"context_line":"          cinder_pool_name: {get_param: CinderRbdPoolName}"},{"line_number":384,"context_line":"          cinder_backup_pool_name: {get_param: CinderBackupRbdPoolName}"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"  CephBaseAnsibleVars:"},{"line_number":387,"context_line":"    type: OS::Heat::Value"},{"line_number":388,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_0c563b08","line":385,"updated":"2020-02-23 16:20:26.000000000","message":"Don\u0027t forget CinderRbdExtraPools, a list of extra pools which will be created for Cinder. \n\nI see you\u0027ve moved the logic for determining the PG numbers and application type to tripleo-ansible. That\u0027s probably a good thing, but please pass CephPoolDefaultPgNum to tripleo-ansible.","commit_id":"e84a524f654c44b791d0d3f2a4af890280f2d1b2"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"35db237af1c6839b07262eba6a150c862616dc7c","unresolved":false,"context_lines":[{"line_number":405,"context_line":"            enabled: {get_param: NovaEnableRbdBackend}"},{"line_number":406,"context_line":"          glance_pool:"},{"line_number":407,"context_line":"            name: {get_param: GlanceRbdPoolName}"},{"line_number":408,"context_line":"            enabled: true"},{"line_number":409,"context_line":"          cinder_pool:"},{"line_number":410,"context_line":"            name: {get_param: CinderRbdPoolName}"},{"line_number":411,"context_line":"            enabled: {get_param: CinderEnableRbdBackend}"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1fa4df85_a73a3431","line":408,"updated":"2020-03-02 12:05:46.000000000","message":"I think we can if: GlanceBackend \u003d\u003d \u0027rbd\u0027","commit_id":"b5a0afe2c72364daaece56e8d59e4dd6ad38fb37"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"ea2d439e6fa6e680c8aa2af934528cfc889f3913","unresolved":false,"context_lines":[{"line_number":405,"context_line":"            enabled: {get_param: NovaEnableRbdBackend}"},{"line_number":406,"context_line":"          glance_pool:"},{"line_number":407,"context_line":"            name: {get_param: GlanceRbdPoolName}"},{"line_number":408,"context_line":"            enabled: true"},{"line_number":409,"context_line":"          cinder_pool:"},{"line_number":410,"context_line":"            name: {get_param: CinderRbdPoolName}"},{"line_number":411,"context_line":"            enabled: {get_param: CinderEnableRbdBackend}"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1fa4df85_475a604f","line":408,"in_reply_to":"1fa4df85_a73a3431","updated":"2020-03-02 12:22:18.000000000","message":"Yes, it makes sense, I\u0027ll address this in the next PS","commit_id":"b5a0afe2c72364daaece56e8d59e4dd6ad38fb37"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"35db237af1c6839b07262eba6a150c862616dc7c","unresolved":false,"context_lines":[{"line_number":409,"context_line":"          cinder_pool:"},{"line_number":410,"context_line":"            name: {get_param: CinderRbdPoolName}"},{"line_number":411,"context_line":"            enabled: {get_param: CinderEnableRbdBackend}"},{"line_number":412,"context_line":"            extra_pools: {get_param: CinderRbdExtraPools}"},{"line_number":413,"context_line":"          backup_pool: {get_param: CinderBackupRbdPoolName}"},{"line_number":414,"context_line":"          extra_pools: {get_param: CephPools}"},{"line_number":415,"context_line":"          pg_num: {get_param: CephPoolDefaultPgNum}"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1fa4df85_e19c9c5e","line":412,"updated":"2020-03-02 12:05:46.000000000","message":"maybe_cinder_extra_pools","commit_id":"b5a0afe2c72364daaece56e8d59e4dd6ad38fb37"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"ea2d439e6fa6e680c8aa2af934528cfc889f3913","unresolved":false,"context_lines":[{"line_number":409,"context_line":"          cinder_pool:"},{"line_number":410,"context_line":"            name: {get_param: CinderRbdPoolName}"},{"line_number":411,"context_line":"            enabled: {get_param: CinderEnableRbdBackend}"},{"line_number":412,"context_line":"            extra_pools: {get_param: CinderRbdExtraPools}"},{"line_number":413,"context_line":"          backup_pool: {get_param: CinderBackupRbdPoolName}"},{"line_number":414,"context_line":"          extra_pools: {get_param: CephPools}"},{"line_number":415,"context_line":"          pg_num: {get_param: CephPoolDefaultPgNum}"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1fa4df85_ca09752c","line":412,"in_reply_to":"1fa4df85_e19c9c5e","updated":"2020-03-02 12:22:18.000000000","message":"Actually I removed the \"cinder_\" prefix because in ansible I can access the variable like \"cinder_pool.extra_pools\" instead of \"cinder_pool.cinder_extra_pools\", but I agree with you, adding the prefix can improve readability.","commit_id":"b5a0afe2c72364daaece56e8d59e4dd6ad38fb37"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"35db237af1c6839b07262eba6a150c862616dc7c","unresolved":false,"context_lines":[{"line_number":410,"context_line":"            name: {get_param: CinderRbdPoolName}"},{"line_number":411,"context_line":"            enabled: {get_param: CinderEnableRbdBackend}"},{"line_number":412,"context_line":"            extra_pools: {get_param: CinderRbdExtraPools}"},{"line_number":413,"context_line":"          backup_pool: {get_param: CinderBackupRbdPoolName}"},{"line_number":414,"context_line":"          extra_pools: {get_param: CephPools}"},{"line_number":415,"context_line":"          pg_num: {get_param: CephPoolDefaultPgNum}"},{"line_number":416,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1fa4df85_419fb05e","line":413,"updated":"2020-03-02 12:05:46.000000000","message":"maybe cinder_backup_pool\n\nalso, like Glance, we could do if: CinderBackupBackend \u003d\u003d \u0027ceph\u0027","commit_id":"b5a0afe2c72364daaece56e8d59e4dd6ad38fb37"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"ea2d439e6fa6e680c8aa2af934528cfc889f3913","unresolved":false,"context_lines":[{"line_number":410,"context_line":"            name: {get_param: CinderRbdPoolName}"},{"line_number":411,"context_line":"            enabled: {get_param: CinderEnableRbdBackend}"},{"line_number":412,"context_line":"            extra_pools: {get_param: CinderRbdExtraPools}"},{"line_number":413,"context_line":"          backup_pool: {get_param: CinderBackupRbdPoolName}"},{"line_number":414,"context_line":"          extra_pools: {get_param: CephPools}"},{"line_number":415,"context_line":"          pg_num: {get_param: CephPoolDefaultPgNum}"},{"line_number":416,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1fa4df85_aa0e792f","line":413,"in_reply_to":"1fa4df85_419fb05e","updated":"2020-03-02 12:22:18.000000000","message":"\u003e maybe cinder_backup_pool\nSame here\n\n \u003e \n \u003e also, like Glance, we could do if: CinderBackupBackend \u003d\u003d \u0027ceph\u0027\n++ makes sense, will do","commit_id":"b5a0afe2c72364daaece56e8d59e4dd6ad38fb37"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e6bbabd51cf1d0f4435799d62e574d75e0d2d933","unresolved":false,"context_lines":[{"line_number":287,"context_line":"    type: boolean"},{"line_number":288,"context_line":"    tags:"},{"line_number":289,"context_line":"      - role_specific"},{"line_number":290,"context_line":"  GnocchiRbdEnabled:"},{"line_number":291,"context_line":"    default: true"},{"line_number":292,"context_line":"    description: Whether to enable or not the Rbd backend for Gnocchi"},{"line_number":293,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"1fa4df85_87db78eb","line":290,"updated":"2020-03-02 12:12:16.000000000","message":"I think we don\u0027t have this param anywhere yet though, wouldn\u0027t add it for the sole purpose of controlling the pool creation ... rather do like we do for cinder-backup","commit_id":"0f15f482c73f6af855e170e5b1bf5d5f9e740161"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"8c46f067ebb3926609130e9f9de83e1442618b35","unresolved":false,"context_lines":[{"line_number":287,"context_line":"    type: boolean"},{"line_number":288,"context_line":"    tags:"},{"line_number":289,"context_line":"      - role_specific"},{"line_number":290,"context_line":"  GnocchiRbdEnabled:"},{"line_number":291,"context_line":"    default: true"},{"line_number":292,"context_line":"    description: Whether to enable or not the Rbd backend for Gnocchi"},{"line_number":293,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"1fa4df85_424a3cac","line":290,"in_reply_to":"1fa4df85_87db78eb","updated":"2020-03-03 09:42:26.000000000","message":"ack and agree","commit_id":"0f15f482c73f6af855e170e5b1bf5d5f9e740161"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"89d56767b4cdbf733ea6814b196311b60ecd807a","unresolved":false,"context_lines":[{"line_number":407,"context_line":"      value:"},{"line_number":408,"context_line":"        vars:"},{"line_number":409,"context_line":"          gnocchi_pool:"},{"line_number":410,"context_line":"            name: {get_param: GnocchiRbdPoolName}"},{"line_number":411,"context_line":"          nova_pool:"},{"line_number":412,"context_line":"            name: {get_param: NovaRbdPoolName}"},{"line_number":413,"context_line":"            enabled: {get_param: NovaEnableRbdBackend}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1fa4df85_ac0bb921","line":410,"updated":"2020-03-05 11:21:43.000000000","message":"we have GnocchiBackend set to \u0027rbd\u0027 when Gnocchi is using it, so we could do the \"if\" trick here too","commit_id":"1516b1e590031c9495745be2fd648a9ae23d583f"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"725645263b8d0f6d6e96d07102d06fcad296cbd3","unresolved":false,"context_lines":[{"line_number":407,"context_line":"      value:"},{"line_number":408,"context_line":"        vars:"},{"line_number":409,"context_line":"          gnocchi_pool:"},{"line_number":410,"context_line":"            name: {get_param: GnocchiRbdPoolName}"},{"line_number":411,"context_line":"          nova_pool:"},{"line_number":412,"context_line":"            name: {get_param: NovaRbdPoolName}"},{"line_number":413,"context_line":"            enabled: {get_param: NovaEnableRbdBackend}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1fa4df85_2c5ee911","line":410,"in_reply_to":"1fa4df85_ac0bb921","updated":"2020-03-05 11:24:31.000000000","message":"ack thanks, updating the PS","commit_id":"1516b1e590031c9495745be2fd648a9ae23d583f"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"f51a9d8c2d5cfe808b0d4cc1a2d7c75a096fec9b","unresolved":false,"context_lines":[{"line_number":618,"context_line":"            - name: include common ceph defaults"},{"line_number":619,"context_line":"              include_role:"},{"line_number":620,"context_line":"                name: tripleo_ceph_common"},{"line_number":621,"context_line":"            - name: create ceph-ansible working directory"},{"line_number":622,"context_line":"              include_role:"},{"line_number":623,"context_line":"                name: tripleo_ceph_work_dir"},{"line_number":624,"context_line":"                tasks_from: prepare"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1fa4df85_ab2cf601","line":621,"updated":"2020-03-07 19:39:50.000000000","message":"whops, thanks","commit_id":"a9b8087db1892236e1df9e76d7f4bac4ba6ea844"}]}