)]}'
{"deployment/octavia/octavia-api-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"24f1fb7bcb641510fb2fa32be399319e87fb6324","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            admin: {get_param: [EndpointMap, OctaviaAdmin, uri]}"},{"line_number":145,"context_line":"          project: {get_param: OctaviaProjectName}"},{"line_number":146,"context_line":"          users:"},{"line_number":147,"context_line":"            {get_param: OctaviaUserName}:"},{"line_number":148,"context_line":"              password: {get_param: OctaviaPassword}"},{"line_number":149,"context_line":"          region: {get_param: KeystoneRegion}"},{"line_number":150,"context_line":"          service: \u0027load-balancer\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_a0eda326","line":147,"range":{"start_line":147,"start_character":12,"end_line":147,"end_character":41},"updated":"2020-02-24 13:01:52.000000000","message":"Currently this is causing error in yaml validation. I\u0027m not sure how we can pass a parameter for dict key here...","commit_id":"a149a3e849e4553f51858bdd8aaccd7ef913b232"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9d061a97d3ef821ea52ea1a3e3b7fe7a6c7beb2e","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            admin: {get_param: [EndpointMap, OctaviaAdmin, uri]}"},{"line_number":145,"context_line":"          project: {get_param: OctaviaProjectName}"},{"line_number":146,"context_line":"          users:"},{"line_number":147,"context_line":"            {get_param: OctaviaUserName}:"},{"line_number":148,"context_line":"              password: {get_param: OctaviaPassword}"},{"line_number":149,"context_line":"          region: {get_param: KeystoneRegion}"},{"line_number":150,"context_line":"          service: \u0027load-balancer\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_69d9b881","line":147,"updated":"2020-02-25 21:22:28.000000000","message":"quote it?","commit_id":"a149a3e849e4553f51858bdd8aaccd7ef913b232"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"46d23b9b7816c16900904e074fd13d7fb47d2d58","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            admin: {get_param: [EndpointMap, OctaviaAdmin, uri]}"},{"line_number":145,"context_line":"          project: {get_param: OctaviaProjectName}"},{"line_number":146,"context_line":"          users:"},{"line_number":147,"context_line":"            {get_param: OctaviaUserName}:"},{"line_number":148,"context_line":"              password: {get_param: OctaviaPassword}"},{"line_number":149,"context_line":"          region: {get_param: KeystoneRegion}"},{"line_number":150,"context_line":"          service: \u0027load-balancer\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_f00ffb33","line":147,"in_reply_to":"1fa4df85_31a04290","updated":"2020-03-10 22:15:07.000000000","message":"hmm... I\u0027m afraid that we have a quoted string as user name.\n\nhttps://db66c2f10e6fd10aa6bf-1bf46d7a860737ec8d15db10a4dffe15.ssl.cf5.rackcdn.com/709354/3/check/tripleo-ci-centos-8-scenario010-standalone/d8412c3/logs/undercloud/home/zuul/standalone-ansible-qogs1b6i/global_vars.yaml","commit_id":"a149a3e849e4553f51858bdd8aaccd7ef913b232"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f21c7c6d2b722a5ca6b8e59db7cbeff6c3476639","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            admin: {get_param: [EndpointMap, OctaviaAdmin, uri]}"},{"line_number":145,"context_line":"          project: {get_param: OctaviaProjectName}"},{"line_number":146,"context_line":"          users:"},{"line_number":147,"context_line":"            {get_param: OctaviaUserName}:"},{"line_number":148,"context_line":"              password: {get_param: OctaviaPassword}"},{"line_number":149,"context_line":"          region: {get_param: KeystoneRegion}"},{"line_number":150,"context_line":"          service: \u0027load-balancer\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_31a04290","line":147,"in_reply_to":"1fa4df85_69d9b881","updated":"2020-03-10 12:57:33.000000000","message":"just updated the patch with quiting this, but I\u0027m afraid quoting can cause another issue here, because it can prevent the parameter resolved.\n\nIMO we need to add a parameter in tripleo-ansible to override user name, but I\u0027d tend to just deprecated the parameter at the moment because I don\u0027t think it is really useful to have customized user name as I mentioned in subsequent patch...\n\nAnyway we can see how it works with quoting in gate.","commit_id":"a149a3e849e4553f51858bdd8aaccd7ef913b232"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"58224c0b21ba6743eeac437ce98ad32702a379c7","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            admin: {get_param: [EndpointMap, OctaviaAdmin, uri]}"},{"line_number":145,"context_line":"          project: {get_param: OctaviaProjectName}"},{"line_number":146,"context_line":"          users:"},{"line_number":147,"context_line":"            \"{get_param: OctaviaUserName}\":"},{"line_number":148,"context_line":"              password: {get_param: OctaviaPassword}"},{"line_number":149,"context_line":"          region: {get_param: KeystoneRegion}"},{"line_number":150,"context_line":"          service: \u0027load-balancer\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1fa4df85_33a35d02","line":147,"updated":"2020-03-10 22:19:29.000000000","message":"I wonder if you\u0027ll have to do some awful string templating to do this similar to how we handle $NETWORK everywhere","commit_id":"0aae07e68348bafce52af673f0c3ab90a6ef8e2b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5eb6432db19c964e4c8c036379525b6416740594","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            admin: {get_param: [EndpointMap, OctaviaAdmin, uri]}"},{"line_number":145,"context_line":"          project: {get_param: OctaviaProjectName}"},{"line_number":146,"context_line":"          users:"},{"line_number":147,"context_line":"            \"{get_param: OctaviaUserName}\":"},{"line_number":148,"context_line":"              password: {get_param: OctaviaPassword}"},{"line_number":149,"context_line":"          region: {get_param: KeystoneRegion}"},{"line_number":150,"context_line":"          service: \u0027load-balancer\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1fa4df85_210874d7","line":147,"in_reply_to":"1fa4df85_33a35d02","updated":"2020-03-18 13:59:06.000000000","message":"Now I fixed this parameter problem by adding a new parameter in tripleo to override user name [1].\n\n[1] https://review.opendev.org/#/c/712191/\n\nI don\u0027t think it\u0027s ideal to have this hacky parameter for only octavia user creation, but IMO it\u0027s much better than having tricky templating here...","commit_id":"0aae07e68348bafce52af673f0c3ab90a6ef8e2b"}]}