)]}'
{"deployment/cinder/cinder-backup-pacemaker-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"caf8e99abcb2c78d27661ae87aaf13f1ec929a32","unresolved":false,"context_lines":[{"line_number":117,"context_line":"      monitoring_subscription: {get_attr: [CinderBackupBase, role_data, monitoring_subscription]}"},{"line_number":118,"context_line":"      config_settings:"},{"line_number":119,"context_line":"        map_merge:"},{"line_number":120,"context_line":"          - get_attr: [CinderBackupBase, role_data, config_settings]"},{"line_number":121,"context_line":"          - tripleo::profile::pacemaker::cinder::backup_bundle::cinder_backup_docker_image: \u0026cinder_backup_image_pcmklatest"},{"line_number":122,"context_line":"              yaql:"},{"line_number":123,"context_line":"                data:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1f621f24_0b263fb8","line":120,"updated":"2020-11-05 16:18:52.000000000","message":"Are you missing the CinderCommon config_settings?","commit_id":"01ea9322927681b9983cd31f90ff90a47840298b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c65afe002232e14f10555d350c1202131dd10098","unresolved":false,"context_lines":[{"line_number":117,"context_line":"      monitoring_subscription: {get_attr: [CinderBackupBase, role_data, monitoring_subscription]}"},{"line_number":118,"context_line":"      config_settings:"},{"line_number":119,"context_line":"        map_merge:"},{"line_number":120,"context_line":"          - get_attr: [CinderBackupBase, role_data, config_settings]"},{"line_number":121,"context_line":"          - tripleo::profile::pacemaker::cinder::backup_bundle::cinder_backup_docker_image: \u0026cinder_backup_image_pcmklatest"},{"line_number":122,"context_line":"              yaql:"},{"line_number":123,"context_line":"                data:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1f621f24_13103101","line":120,"in_reply_to":"1f621f24_0b263fb8","updated":"2020-11-05 23:31:42.000000000","message":"CinderBackupBase config_settings already includes CinderCommon config_settings so we don\u0027t need to include that agan here.","commit_id":"01ea9322927681b9983cd31f90ff90a47840298b"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"4e27be95a7f403c39eb771ac6778f43d6dddf1f7","unresolved":false,"context_lines":[{"line_number":117,"context_line":"      monitoring_subscription: {get_attr: [CinderBackupBase, role_data, monitoring_subscription]}"},{"line_number":118,"context_line":"      config_settings:"},{"line_number":119,"context_line":"        map_merge:"},{"line_number":120,"context_line":"          - get_attr: [CinderBackupBase, role_data, config_settings]"},{"line_number":121,"context_line":"          - tripleo::profile::pacemaker::cinder::backup_bundle::cinder_backup_docker_image: \u0026cinder_backup_image_pcmklatest"},{"line_number":122,"context_line":"              yaql:"},{"line_number":123,"context_line":"                data:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1f621f24_e981464c","line":120,"in_reply_to":"1f621f24_13103101","updated":"2020-11-06 04:32:50.000000000","message":"I see that now, thanks!","commit_id":"01ea9322927681b9983cd31f90ff90a47840298b"}],"deployment/cinder/cinder-common-container-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b17bdcd4d3fea037260ee41aa7820bc9f68b6871","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    value:"},{"line_number":219,"context_line":"      list_concat:"},{"line_number":220,"context_line":"        - *cinder_common_volumes"},{"line_number":221,"context_line":"        - {get_attr: [CinderLogging, volumes]}"},{"line_number":222,"context_line":"        - {get_param: CinderVolumeOptVolumes}"},{"line_number":223,"context_line":"        -"},{"line_number":224,"context_line":"          - /var/lib/kolla/config_files/cinder_volume.json:/var/lib/kolla/config_files/config.json:ro"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f621f24_997004df","line":221,"updated":"2020-11-03 22:18:56.000000000","message":"Why not include these in cinder_common_volumes (after L27)?","commit_id":"e01b186e5a990f09e03edfb487d0fc7b944dc9cb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"74b768bf585cd1a5ec0db2edc63e930e838fcd9a","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    value:"},{"line_number":219,"context_line":"      list_concat:"},{"line_number":220,"context_line":"        - *cinder_common_volumes"},{"line_number":221,"context_line":"        - {get_attr: [CinderLogging, volumes]}"},{"line_number":222,"context_line":"        - {get_param: CinderVolumeOptVolumes}"},{"line_number":223,"context_line":"        -"},{"line_number":224,"context_line":"          - /var/lib/kolla/config_files/cinder_volume.json:/var/lib/kolla/config_files/config.json:ro"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f621f24_c2ef20ae","line":221,"in_reply_to":"1f621f24_997004df","updated":"2020-11-04 11:48:22.000000000","message":"The reason why I didn\u0027t include this in cinder_common_volumes is that the cinder_common_volumes is also used in CinderApi resource.\n\nSince we have separated logging resource for api and the other services. IMO we shouldn\u0027t add something from OS::TripleO::Services::Logging::CinderCommon to CinderApi resource.","commit_id":"e01b186e5a990f09e03edfb487d0fc7b944dc9cb"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2dbbddb033bf2019d9dc46f8b057811eaaa103cf","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    value:"},{"line_number":219,"context_line":"      list_concat:"},{"line_number":220,"context_line":"        - *cinder_common_volumes"},{"line_number":221,"context_line":"        - {get_attr: [CinderLogging, volumes]}"},{"line_number":222,"context_line":"        - {get_param: CinderVolumeOptVolumes}"},{"line_number":223,"context_line":"        -"},{"line_number":224,"context_line":"          - /var/lib/kolla/config_files/cinder_volume.json:/var/lib/kolla/config_files/config.json:ro"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f621f24_2e007b01","line":221,"in_reply_to":"1f621f24_c2ef20ae","updated":"2020-11-04 14:56:56.000000000","message":"OK, that makes sense. This whole \"cinder common\" concept was introduced to avoid duplicating content in multiple files (where things often got out of sync, for example between the pacemaker and non-pcmk templates). But I recognize the fact that determining whether something is \"common\" is not always a simple yes/no decision.","commit_id":"e01b186e5a990f09e03edfb487d0fc7b944dc9cb"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b17bdcd4d3fea037260ee41aa7820bc9f68b6871","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    value:"},{"line_number":254,"context_line":"      list_concat:"},{"line_number":255,"context_line":"        - *cinder_common_volumes"},{"line_number":256,"context_line":"        - {get_attr: [CinderLogging, volumes]}"},{"line_number":257,"context_line":"        -"},{"line_number":258,"context_line":"          - /var/lib/kolla/config_files/cinder_backup.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":259,"context_line":"          - /etc/iscsi:/var/lib/kolla/config_files/src-iscsid:ro"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f621f24_7963681b","line":256,"updated":"2020-11-03 22:18:56.000000000","message":"ditto comment at L221","commit_id":"e01b186e5a990f09e03edfb487d0fc7b944dc9cb"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"caf8e99abcb2c78d27661ae87aaf13f1ec929a32","unresolved":false,"context_lines":[{"line_number":97,"context_line":"      CinderServiceName: {get_param: CinderServiceName}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"outputs:"},{"line_number":100,"context_line":"  cinder_daemon_cmd_extra_args:"},{"line_number":101,"context_line":"    description: Common Extra command line arguments for cinder daemon services"},{"line_number":102,"context_line":"    value: {get_attr:[CinderLogging, cmd_extra_args]}"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1f621f24_cb79e793","line":100,"updated":"2020-11-05 16:18:52.000000000","message":"I really don\u0027t understand the reason for changing \"common\" to \"daemon\" in all the template outputs. We chose \"common\" precisely because it conveys the notion that that they\u0027re common. In this context, the word \"daemon\" doesn\u0027t convey anything like that.","commit_id":"01ea9322927681b9983cd31f90ff90a47840298b"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"4e27be95a7f403c39eb771ac6778f43d6dddf1f7","unresolved":false,"context_lines":[{"line_number":97,"context_line":"      CinderServiceName: {get_param: CinderServiceName}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"outputs:"},{"line_number":100,"context_line":"  cinder_daemon_cmd_extra_args:"},{"line_number":101,"context_line":"    description: Common Extra command line arguments for cinder daemon services"},{"line_number":102,"context_line":"    value: {get_attr:[CinderLogging, cmd_extra_args]}"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1f621f24_6e037c10","line":100,"in_reply_to":"1f621f24_9303a1b8","updated":"2020-11-06 04:32:50.000000000","message":"Thank you for understanding. Common simply means \"typical,\" and isn\u0027t meant to mean \"universal with no exceptions.\"","commit_id":"01ea9322927681b9983cd31f90ff90a47840298b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c65afe002232e14f10555d350c1202131dd10098","unresolved":false,"context_lines":[{"line_number":97,"context_line":"      CinderServiceName: {get_param: CinderServiceName}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"outputs:"},{"line_number":100,"context_line":"  cinder_daemon_cmd_extra_args:"},{"line_number":101,"context_line":"    description: Common Extra command line arguments for cinder daemon services"},{"line_number":102,"context_line":"    value: {get_attr:[CinderLogging, cmd_extra_args]}"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1f621f24_9303a1b8","line":100,"in_reply_to":"1f621f24_cb79e793","updated":"2020-11-05 23:31:42.000000000","message":"The reason why we renamed these items is that they are not actually \"common\". We don\u0027t use these items for api but only for the other services, thus I renamed it to \"deamon\" to explicitly shows that this is not used for api.\nBut maybe we can just rename this back to common regarding the fact that we use Cinder\"Common\" for the logging resource which is only used for daemon services...","commit_id":"01ea9322927681b9983cd31f90ff90a47840298b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0b59316c89a36e0c91c463a5fb9e24f4da088d44","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    value: {get_attr: [CinderLogging, docker_config]}"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"  cinder_common_config_settings:"},{"line_number":113,"context_line":"    descrpiton: Common extra hieradata for cinder daemon services"},{"line_number":114,"context_line":"    value: {get_attr: [CinderLogging, config_settings]}"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"  cinder_common_volumes:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"1f621f24_090c6b39","line":113,"range":{"start_line":113,"start_character":4,"end_line":113,"end_character":14},"updated":"2020-11-09 14:04:02.000000000","message":"This typo should be fixed...","commit_id":"dcd8bb4c17e80fbea232a0db67229ba0f2a4a5ec"}],"deployment/cinder/cinder-scheduler-container-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b17bdcd4d3fea037260ee41aa7820bc9f68b6871","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  MySQLClient:"},{"line_number":54,"context_line":"    type: ../database/mysql-client.yaml"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  CinderLogging:"},{"line_number":57,"context_line":"    type: OS::TripleO::Services::Logging::CinderCommon"},{"line_number":58,"context_line":"    properties:"},{"line_number":59,"context_line":"      ContainerCinderImage: \u0026cinder_scheduler_image {get_param: ContainerCinderSchedulerImage}"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f621f24_dceb8fd9","line":56,"updated":"2020-11-03 22:18:56.000000000","message":"I don\u0027t think this resource is necessary when all the necessary pieces are already present via the CinderCommon resource at L72.\n\nUntil now, the CinderCommon resource was used by cinder-volume and cinder-backup, and I like the way you enhanced it to facilitate configuring c-vol and c-bak logging. I think the same technique can be used to configure c-sch\u0027s logging without the need to define another resource (L56).","commit_id":"e01b186e5a990f09e03edfb487d0fc7b944dc9cb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"74b768bf585cd1a5ec0db2edc63e930e838fcd9a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  MySQLClient:"},{"line_number":54,"context_line":"    type: ../database/mysql-client.yaml"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  CinderLogging:"},{"line_number":57,"context_line":"    type: OS::TripleO::Services::Logging::CinderCommon"},{"line_number":58,"context_line":"    properties:"},{"line_number":59,"context_line":"      ContainerCinderImage: \u0026cinder_scheduler_image {get_param: ContainerCinderSchedulerImage}"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f621f24_a5ddce71","line":56,"in_reply_to":"1f621f24_dceb8fd9","updated":"2020-11-04 11:48:22.000000000","message":"Done","commit_id":"e01b186e5a990f09e03edfb487d0fc7b944dc9cb"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b17bdcd4d3fea037260ee41aa7820bc9f68b6871","unresolved":false,"context_lines":[{"line_number":84,"context_line":"      config_settings:"},{"line_number":85,"context_line":"        map_merge:"},{"line_number":86,"context_line":"          - get_attr: [CinderBase, role_data, config_settings]"},{"line_number":87,"context_line":"          - get_attr: [CinderLogging, config_settings]"},{"line_number":88,"context_line":"          - cinder::scheduler::scheduler_driver: cinder.scheduler.filter_scheduler.FilterScheduler"},{"line_number":89,"context_line":"      service_config_settings:"},{"line_number":90,"context_line":"        map_merge:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f621f24_1c17c7a5","line":87,"updated":"2020-11-03 22:18:56.000000000","message":"I don\u0027t think this is necessary because the value is null for both file and stdout.\n\nAnd if some config_settings were required, they should be accessed via the CinderCommon resource so that c-vol, c-bak and c-sch all work the same way (yes, c-api is unique).","commit_id":"e01b186e5a990f09e03edfb487d0fc7b944dc9cb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"74b768bf585cd1a5ec0db2edc63e930e838fcd9a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"      config_settings:"},{"line_number":85,"context_line":"        map_merge:"},{"line_number":86,"context_line":"          - get_attr: [CinderBase, role_data, config_settings]"},{"line_number":87,"context_line":"          - get_attr: [CinderLogging, config_settings]"},{"line_number":88,"context_line":"          - cinder::scheduler::scheduler_driver: cinder.scheduler.filter_scheduler.FilterScheduler"},{"line_number":89,"context_line":"      service_config_settings:"},{"line_number":90,"context_line":"        map_merge:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f621f24_e2497cd0","line":87,"in_reply_to":"1f621f24_1c17c7a5","updated":"2020-11-04 11:48:22.000000000","message":"I\u0027d prefer to keep this because\n\n1. It is consistent with the existing templates like nova-scheduler-container-puppet.yaml\n\n2. It would be helpful to have the interface because we can easily implement parameters which become required in the future.","commit_id":"e01b186e5a990f09e03edfb487d0fc7b944dc9cb"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2dbbddb033bf2019d9dc46f8b057811eaaa103cf","unresolved":false,"context_lines":[{"line_number":84,"context_line":"      config_settings:"},{"line_number":85,"context_line":"        map_merge:"},{"line_number":86,"context_line":"          - get_attr: [CinderBase, role_data, config_settings]"},{"line_number":87,"context_line":"          - get_attr: [CinderLogging, config_settings]"},{"line_number":88,"context_line":"          - cinder::scheduler::scheduler_driver: cinder.scheduler.filter_scheduler.FilterScheduler"},{"line_number":89,"context_line":"      service_config_settings:"},{"line_number":90,"context_line":"        map_merge:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f621f24_0e9f7fb4","line":87,"in_reply_to":"1f621f24_e2497cd0","updated":"2020-11-04 14:56:56.000000000","message":"I guess I\u0027m OK with keeping it for a future need, but I don\u0027t see where it\u0027s pulled in for the c-vol and c-bak services. This is how I realized it may not be necessary.","commit_id":"e01b186e5a990f09e03edfb487d0fc7b944dc9cb"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b17bdcd4d3fea037260ee41aa7820bc9f68b6871","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            list_join:"},{"line_number":110,"context_line":"            - \u0027 \u0027"},{"line_number":111,"context_line":"            - - \u0027/usr/bin/cinder-scheduler --config-file /usr/share/cinder/cinder-dist.conf --config-file /etc/cinder/cinder.conf\u0027"},{"line_number":112,"context_line":"              - get_attr: [CinderLogging, cmd_extra_args]"},{"line_number":113,"context_line":"          config_files:"},{"line_number":114,"context_line":"            - source: \"/var/lib/kolla/config_files/src/*\""},{"line_number":115,"context_line":"              dest: \"/\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f621f24_39f45086","line":112,"updated":"2020-11-03 22:18:56.000000000","message":"The CinderLogging resource at L56 could be eliminated by switching this to \"get_attr: [CinderCommon, cinder_common_cmd_extra_args]\"","commit_id":"e01b186e5a990f09e03edfb487d0fc7b944dc9cb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"74b768bf585cd1a5ec0db2edc63e930e838fcd9a","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            list_join:"},{"line_number":110,"context_line":"            - \u0027 \u0027"},{"line_number":111,"context_line":"            - - \u0027/usr/bin/cinder-scheduler --config-file /usr/share/cinder/cinder-dist.conf --config-file /etc/cinder/cinder.conf\u0027"},{"line_number":112,"context_line":"              - get_attr: [CinderLogging, cmd_extra_args]"},{"line_number":113,"context_line":"          config_files:"},{"line_number":114,"context_line":"            - source: \"/var/lib/kolla/config_files/src/*\""},{"line_number":115,"context_line":"              dest: \"/\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f621f24_85d8927f","line":112,"in_reply_to":"1f621f24_39f45086","updated":"2020-11-04 11:48:22.000000000","message":"Done","commit_id":"e01b186e5a990f09e03edfb487d0fc7b944dc9cb"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b17bdcd4d3fea037260ee41aa7820bc9f68b6871","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            volumes:"},{"line_number":142,"context_line":"              list_concat:"},{"line_number":143,"context_line":"                - {get_attr: [CinderCommon, cinder_common_volumes]}"},{"line_number":144,"context_line":"                - {get_attr: [CinderLogging, volumes]}"},{"line_number":145,"context_line":"                -"},{"line_number":146,"context_line":"                  - /var/lib/kolla/config_files/cinder_scheduler.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":147,"context_line":"            environment:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f621f24_99eac4a9","line":144,"updated":"2020-11-03 22:18:56.000000000","message":"Could [CinderLogging, volumes] be automatically included in [CinderCommon, cinder_common_volumes] ?","commit_id":"e01b186e5a990f09e03edfb487d0fc7b944dc9cb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"74b768bf585cd1a5ec0db2edc63e930e838fcd9a","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            volumes:"},{"line_number":142,"context_line":"              list_concat:"},{"line_number":143,"context_line":"                - {get_attr: [CinderCommon, cinder_common_volumes]}"},{"line_number":144,"context_line":"                - {get_attr: [CinderLogging, volumes]}"},{"line_number":145,"context_line":"                -"},{"line_number":146,"context_line":"                  - /var/lib/kolla/config_files/cinder_scheduler.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":147,"context_line":"            environment:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f621f24_25d37e62","line":144,"in_reply_to":"1f621f24_99eac4a9","updated":"2020-11-04 11:48:22.000000000","message":"We shouldn\u0027t merge that into cinder_common_volumes because it affects CinderApi resource. I added another output key for CinderCommon to replace this.","commit_id":"e01b186e5a990f09e03edfb487d0fc7b944dc9cb"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b17bdcd4d3fea037260ee41aa7820bc9f68b6871","unresolved":false,"context_lines":[{"line_number":148,"context_line":"              KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"},{"line_number":149,"context_line":"      host_prep_tasks:"},{"line_number":150,"context_line":"        list_concat:"},{"line_number":151,"context_line":"        - {get_attr: [CinderLogging, host_prep_tasks]}"},{"line_number":152,"context_line":"        - - name: enable virt_sandbox_use_netlink for healthcheck"},{"line_number":153,"context_line":"            seboolean:"},{"line_number":154,"context_line":"              name: virt_sandbox_use_netlink"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f621f24_39229001","line":151,"updated":"2020-11-03 22:18:56.000000000","message":"I think it would be find to use [CinderCommon, cinder_common_host_prep_tasks], which already includes the CinderLogging\u0027s host_prep_tasks.","commit_id":"e01b186e5a990f09e03edfb487d0fc7b944dc9cb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"74b768bf585cd1a5ec0db2edc63e930e838fcd9a","unresolved":false,"context_lines":[{"line_number":148,"context_line":"              KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"},{"line_number":149,"context_line":"      host_prep_tasks:"},{"line_number":150,"context_line":"        list_concat:"},{"line_number":151,"context_line":"        - {get_attr: [CinderLogging, host_prep_tasks]}"},{"line_number":152,"context_line":"        - - name: enable virt_sandbox_use_netlink for healthcheck"},{"line_number":153,"context_line":"            seboolean:"},{"line_number":154,"context_line":"              name: virt_sandbox_use_netlink"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f621f24_05d64250","line":151,"in_reply_to":"1f621f24_39229001","updated":"2020-11-04 11:48:22.000000000","message":"Done","commit_id":"e01b186e5a990f09e03edfb487d0fc7b944dc9cb"}],"deployment/cinder/cinder-volume-container-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"caf8e99abcb2c78d27661ae87aaf13f1ec929a32","unresolved":false,"context_lines":[{"line_number":221,"context_line":"      config_settings:"},{"line_number":222,"context_line":"        map_merge:"},{"line_number":223,"context_line":"          - get_attr: [CinderBase, role_data, config_settings]"},{"line_number":224,"context_line":"          - get_attr: [CinderCommon, cinder_daemon_config_settings]"},{"line_number":225,"context_line":"          - tripleo::profile::base::lvm::enable_udev: false"},{"line_number":226,"context_line":"          - tripleo::profile::base::cinder::volume::cinder_enable_iscsi_backend: {get_param: CinderEnableIscsiBackend}"},{"line_number":227,"context_line":"            tripleo::profile::base::cinder::volume::cinder_enable_nfs_backend: {get_param: CinderEnableNfsBackend}"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1f621f24_4b0e7732","line":224,"updated":"2020-11-05 16:18:52.000000000","message":"OK fine, except I think they\u0027re missing in the pcmk version of the template.","commit_id":"01ea9322927681b9983cd31f90ff90a47840298b"}],"deployment/cinder/cinder-volume-pacemaker-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"caf8e99abcb2c78d27661ae87aaf13f1ec929a32","unresolved":false,"context_lines":[{"line_number":103,"context_line":"      monitoring_subscription: {get_attr: [CinderBase, role_data, monitoring_subscription]}"},{"line_number":104,"context_line":"      config_settings:"},{"line_number":105,"context_line":"        map_merge:"},{"line_number":106,"context_line":"          - get_attr: [CinderBase, role_data, config_settings]"},{"line_number":107,"context_line":"          - tripleo::profile::base::lvm::enable_udev: false"},{"line_number":108,"context_line":"            tripleo::profile::pacemaker::cinder::volume_bundle::cinder_volume_docker_image: \u0026cinder_volume_image_pcmklatest"},{"line_number":109,"context_line":"              yaql:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1f621f24_eb282387","line":106,"updated":"2020-11-05 16:18:52.000000000","message":"Don\u0027t you also need the settings from CinderCommon?","commit_id":"01ea9322927681b9983cd31f90ff90a47840298b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c65afe002232e14f10555d350c1202131dd10098","unresolved":false,"context_lines":[{"line_number":103,"context_line":"      monitoring_subscription: {get_attr: [CinderBase, role_data, monitoring_subscription]}"},{"line_number":104,"context_line":"      config_settings:"},{"line_number":105,"context_line":"        map_merge:"},{"line_number":106,"context_line":"          - get_attr: [CinderBase, role_data, config_settings]"},{"line_number":107,"context_line":"          - tripleo::profile::base::lvm::enable_udev: false"},{"line_number":108,"context_line":"            tripleo::profile::pacemaker::cinder::volume_bundle::cinder_volume_docker_image: \u0026cinder_volume_image_pcmklatest"},{"line_number":109,"context_line":"              yaql:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1f621f24_f32bf52c","line":106,"in_reply_to":"1f621f24_eb282387","updated":"2020-11-05 23:31:42.000000000","message":"That is included via CinderBase config_settings, so we don\u0027t need to include it explicitly here.","commit_id":"01ea9322927681b9983cd31f90ff90a47840298b"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"4e27be95a7f403c39eb771ac6778f43d6dddf1f7","unresolved":false,"context_lines":[{"line_number":103,"context_line":"      monitoring_subscription: {get_attr: [CinderBase, role_data, monitoring_subscription]}"},{"line_number":104,"context_line":"      config_settings:"},{"line_number":105,"context_line":"        map_merge:"},{"line_number":106,"context_line":"          - get_attr: [CinderBase, role_data, config_settings]"},{"line_number":107,"context_line":"          - tripleo::profile::base::lvm::enable_udev: false"},{"line_number":108,"context_line":"            tripleo::profile::pacemaker::cinder::volume_bundle::cinder_volume_docker_image: \u0026cinder_volume_image_pcmklatest"},{"line_number":109,"context_line":"              yaql:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1f621f24_097f6267","line":106,"in_reply_to":"1f621f24_f32bf52c","updated":"2020-11-06 04:32:50.000000000","message":"Ah yes, I see that now, thanks.","commit_id":"01ea9322927681b9983cd31f90ff90a47840298b"}],"overcloud-resource-registry-puppet.j2.yaml":[{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"c76c827b353bb88e9c6e0df28bac14939f7e05e0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  # TripleO overcloud networks"},{"line_number":69,"context_line":"  OS::TripleO::Network: network/networks.yaml"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  # Special network to allocate unique OVN chassis mac addresses, for distributed vlan traffic."},{"line_number":72,"context_line":"  OS::TripleO::OVNMacAddressNetwork: network/ovn_mac_addr_net.yaml"},{"line_number":73,"context_line":"  OS::TripleO::OVNMacAddressPort: network/ports/ovn_mac_addr_port.yaml"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f621f24_4a1d0365","line":71,"updated":"2020-11-02 16:49:10.000000000","message":"Is this related and needed?","commit_id":"e01b186e5a990f09e03edfb487d0fc7b944dc9cb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ef171dfb266ba1d213f94a93be2f2dca21b0e118","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  # TripleO overcloud networks"},{"line_number":69,"context_line":"  OS::TripleO::Network: network/networks.yaml"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  # Special network to allocate unique OVN chassis mac addresses, for distributed vlan traffic."},{"line_number":72,"context_line":"  OS::TripleO::OVNMacAddressNetwork: network/ovn_mac_addr_net.yaml"},{"line_number":73,"context_line":"  OS::TripleO::OVNMacAddressPort: network/ports/ovn_mac_addr_port.yaml"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f621f24_faa938dd","line":71,"in_reply_to":"1f621f24_4a1d0365","updated":"2020-11-03 01:14:28.000000000","message":"I\u0027m afraid you are confused with diffs between the latest version and old version ?\n\nThis line is not changed by this patch.","commit_id":"e01b186e5a990f09e03edfb487d0fc7b944dc9cb"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"ccd31308e6bd96dc09035a407f45e3dbc472d8d0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  # TripleO overcloud networks"},{"line_number":69,"context_line":"  OS::TripleO::Network: network/networks.yaml"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  # Special network to allocate unique OVN chassis mac addresses, for distributed vlan traffic."},{"line_number":72,"context_line":"  OS::TripleO::OVNMacAddressNetwork: network/ovn_mac_addr_net.yaml"},{"line_number":73,"context_line":"  OS::TripleO::OVNMacAddressPort: network/ports/ovn_mac_addr_port.yaml"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f621f24_d6f9b080","line":71,"in_reply_to":"1f621f24_faa938dd","updated":"2020-11-03 15:48:55.000000000","message":"This is likely the case. Diffing between versions can be misleading unless you realize many of the diffs are a result of a rebase.","commit_id":"e01b186e5a990f09e03edfb487d0fc7b944dc9cb"}]}