)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"761f998b0ee9a3d6a9e096bb34450978a42f0c8a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"defaults to false and will be set to true during the prepare step (via env file"},{"line_number":16,"context_line":") and disabled during converge."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"As an addition, it changes the use of UpgradeLeappEnabled for the pacemaker"},{"line_number":19,"context_line":"service as this parameter defaults to true. This change uses the new added"},{"line_number":20,"context_line":"OperatingSystem Upgrade variable instead."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I7ac0c74726f7bbeb773d54f6909c5f647717f79a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_687d8eb0","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":41},"updated":"2020-04-22 10:41:16.000000000","message":"I don\u0027t see where this happens?","commit_id":"95b39363d25befbfe082cd810673e87d04af5c24"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"064618a049c17f59270c57f879a83ab326d858a2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"defaults to false and will be set to true during the prepare step (via env file"},{"line_number":16,"context_line":") and disabled during converge."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"As an addition, it changes the use of UpgradeLeappEnabled for the pacemaker"},{"line_number":19,"context_line":"service as this parameter defaults to true. This change uses the new added"},{"line_number":20,"context_line":"OperatingSystem Upgrade variable instead."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I7ac0c74726f7bbeb773d54f6909c5f647717f79a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_78fddc6c","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":41},"in_reply_to":"1f493fa4_687d8eb0","updated":"2020-04-28 13:32:20.000000000","message":"This happens here https://review.opendev.org/#/c/713330/5/deployment/pacemaker/pacemaker-baremetal-puppet.yaml","commit_id":"95b39363d25befbfe082cd810673e87d04af5c24"}],"deployment/cinder/cinder-backup-pacemaker-puppet.yaml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"65c7fc873cdd7f9d808f922e2870a303b4aac87f","unresolved":false,"context_lines":[{"line_number":308,"context_line":"              set_fact: is_cinder_backup_bootstrap_node\u003d{{cinder_backup_short_bootstrap_node_name|lower \u003d\u003d ansible_hostname|lower}}"},{"line_number":309,"context_line":"            - name: Set fact operating_system_upgrade"},{"line_number":310,"context_line":"              set_fact:"},{"line_number":311,"context_line":"                operating_system_upgrade: {get_param: OperatingSystemUpgrade}"},{"line_number":312,"context_line":"        - name: Update cinder_backup pcs resource bundle for new container image"},{"line_number":313,"context_line":"          when:"},{"line_number":314,"context_line":"            - step|int \u003d\u003d 1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_74d5bbb6","line":311,"updated":"2020-03-19 09:01:10.000000000","message":"I wonder if there\u0027s a way we could set this just once, e.g. in tripleo-packages.yaml. The only problem is we\u0027d need some extra step for setting these facts so that we can guarantee that they\u0027re set before they\u0027re used. E.g. if we set this in a single service in step 0, only step 1 (of any other service) at the earliest can depend on that fact.\n\nI don\u0027t think we have such a facility presently so +1.","commit_id":"639f5628e604e5ec4c259b786ba97ba6526988b3"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"d730ba61604acf7a74e45332a158e37d140d2266","unresolved":false,"context_lines":[{"line_number":308,"context_line":"              set_fact: is_cinder_backup_bootstrap_node\u003d{{cinder_backup_short_bootstrap_node_name|lower \u003d\u003d ansible_hostname|lower}}"},{"line_number":309,"context_line":"            - name: Set fact operating_system_upgrade"},{"line_number":310,"context_line":"              set_fact:"},{"line_number":311,"context_line":"                operating_system_upgrade: {get_param: OperatingSystemUpgrade}"},{"line_number":312,"context_line":"        - name: Update cinder_backup pcs resource bundle for new container image"},{"line_number":313,"context_line":"          when:"},{"line_number":314,"context_line":"            - step|int \u003d\u003d 1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4c43b2_ac2cc499","line":311,"in_reply_to":"1fa4df85_74d5bbb6","updated":"2020-04-14 16:15:50.000000000","message":"Well, in theory it would be possible, as all the steps which require from this fact to be set are run at step 1. However, I was having a look at https://review.opendev.org/#/c/713330/4/deployment/pacemaker/pacemaker-baremetal-puppet.yaml which makes use of a similar parameter UpgradeLeappEnabled (variable in which I based) and even though the fact upgrade_leapp_enabled was set in tripleo-packages we were re-setting it here too...do you recall why was that? I just want to understand clearly if it would be possible to just leave the fact setting in tripleo-packages service and make use of the fact in the rest of the services.\n\nThanks for your comment @Jirka!","commit_id":"639f5628e604e5ec4c259b786ba97ba6526988b3"}],"deployment/pacemaker/pacemaker-baremetal-puppet.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"761f998b0ee9a3d6a9e096bb34450978a42f0c8a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    type: boolean"},{"line_number":119,"context_line":"    default: false"},{"line_number":120,"context_line":"    description: \u003e"},{"line_number":121,"context_line":"      This flag indicates that the operating system has been upgraded during"},{"line_number":122,"context_line":"      the upgrade workflow."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"conditions:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_288546ae","line":121,"range":{"start_line":121,"start_character":52,"end_line":121,"end_character":60},"updated":"2020-04-22 10:41:16.000000000","message":"\u0027has been\u0027 or \u0027has to be\u0027? Is this a statement of something done, or still to be done?","commit_id":"95b39363d25befbfe082cd810673e87d04af5c24"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"064618a049c17f59270c57f879a83ab326d858a2","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    type: boolean"},{"line_number":119,"context_line":"    default: false"},{"line_number":120,"context_line":"    description: \u003e"},{"line_number":121,"context_line":"      This flag indicates that the operating system has been upgraded during"},{"line_number":122,"context_line":"      the upgrade workflow."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"conditions:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_78803cc0","line":121,"range":{"start_line":121,"start_character":52,"end_line":121,"end_character":60},"in_reply_to":"1f493fa4_288546ae","updated":"2020-04-28 13:32:20.000000000","message":"Done","commit_id":"95b39363d25befbfe082cd810673e87d04af5c24"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"ca658de34463f6f8eb2ab780fae1cb219669f4cd","unresolved":false,"context_lines":[{"line_number":97,"context_line":"      tag: system.pacemaker"},{"line_number":98,"context_line":"      file: /var/log/host/pacemaker.log"},{"line_number":99,"context_line":"      startmsg.regex: \"^[a-zA-Z]{3} [0-9]{2} [:0-9]{8}\""},{"line_number":100,"context_line":"  UpgradeLeappEnabled:"},{"line_number":101,"context_line":"    description: Use Leapp for operating system upgrade"},{"line_number":102,"context_line":"    type: boolean"},{"line_number":103,"context_line":"    default: false"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff570b3c_fce141fe","line":100,"updated":"2020-05-13 04:44:05.000000000","message":"This parameter can be removed as it is not used any more. upgrade_leapp_enabled is created in the upgrade_tasks for another tripleo service, how is the order of execution (has to be set before using) is ensured?","commit_id":"9405639e558c0ca2d2fcba05350dcd99bd80e1d5"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"945c98ce61ea0853d85e113538a4f941f2a1dc14","unresolved":false,"context_lines":[{"line_number":97,"context_line":"      tag: system.pacemaker"},{"line_number":98,"context_line":"      file: /var/log/host/pacemaker.log"},{"line_number":99,"context_line":"      startmsg.regex: \"^[a-zA-Z]{3} [0-9]{2} [:0-9]{8}\""},{"line_number":100,"context_line":"  UpgradeLeappEnabled:"},{"line_number":101,"context_line":"    description: Use Leapp for operating system upgrade"},{"line_number":102,"context_line":"    type: boolean"},{"line_number":103,"context_line":"    default: false"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff570b3c_9d3abc95","line":100,"in_reply_to":"ff570b3c_9d2bdc80","updated":"2020-05-13 10:05:26.000000000","message":"Ok. I missed that. Thanks.","commit_id":"9405639e558c0ca2d2fcba05350dcd99bd80e1d5"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"c980558c99fdece0bc3a4a669a0319e942d79c65","unresolved":false,"context_lines":[{"line_number":97,"context_line":"      tag: system.pacemaker"},{"line_number":98,"context_line":"      file: /var/log/host/pacemaker.log"},{"line_number":99,"context_line":"      startmsg.regex: \"^[a-zA-Z]{3} [0-9]{2} [:0-9]{8}\""},{"line_number":100,"context_line":"  UpgradeLeappEnabled:"},{"line_number":101,"context_line":"    description: Use Leapp for operating system upgrade"},{"line_number":102,"context_line":"    type: boolean"},{"line_number":103,"context_line":"    default: false"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff570b3c_9d2bdc80","line":100,"in_reply_to":"ff570b3c_fce141fe","updated":"2020-05-13 09:57:10.000000000","message":"That\u0027s the reason why it\u0027s here, because this step0 happens before the step0 for the tripleo-packages service. So, if we don\u0027t include it here, it will try to access upgrade_leapp_enabled variable but it will be undefined. However, that is why it was included in both. As well as the fact setting in line 201 of this file.","commit_id":"9405639e558c0ca2d2fcba05350dcd99bd80e1d5"}],"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"761f998b0ee9a3d6a9e096bb34450978a42f0c8a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    type: boolean"},{"line_number":92,"context_line":"    default: false"},{"line_number":93,"context_line":"    description: \u003e"},{"line_number":94,"context_line":"      This flag indicates that the operating system has been upgraded during"},{"line_number":95,"context_line":"      the upgrade workflow."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_88abba1b","line":94,"range":{"start_line":94,"start_character":52,"end_line":94,"end_character":60},"updated":"2020-04-22 10:41:16.000000000","message":"Same question as in https://review.opendev.org/#/c/713330/5/deployment/pacemaker/pacemaker-baremetal-puppet.yaml","commit_id":"95b39363d25befbfe082cd810673e87d04af5c24"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"7551ed4f7f1886d7c2fd85b481b3a8adf71f4c78","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    default: \u0027false\u0027"},{"line_number":88,"context_line":"    description: Set to true to skip the update all packages"},{"line_number":89,"context_line":"    type: boolean"},{"line_number":90,"context_line":"  OperatingSystemUpgrade:"},{"line_number":91,"context_line":"    type: boolean"},{"line_number":92,"context_line":"    default: false"},{"line_number":93,"context_line":"    description: \u003e"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f493fa4_c87b4cf2","line":90,"updated":"2020-04-30 10:01:26.000000000","message":"I\u0027m considering making use of the UpgradeLeappEnabled variable and default it to false (we would need to pass it as enabled via environment file) and like this avoid adding a new Heat parameter which will have the very same effect as UpgradeLeappEnabled.","commit_id":"3cdaad116048a6deccb96828e159a0cd533d17e5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"103d312c05592f70ebc01c5ff3cdcbd15ebe92a8","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    default: \u0027false\u0027"},{"line_number":88,"context_line":"    description: Set to true to skip the update all packages"},{"line_number":89,"context_line":"    type: boolean"},{"line_number":90,"context_line":"  OperatingSystemUpgrade:"},{"line_number":91,"context_line":"    type: boolean"},{"line_number":92,"context_line":"    default: false"},{"line_number":93,"context_line":"    description: \u003e"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f493fa4_c3f20f70","line":90,"in_reply_to":"1f493fa4_c87b4cf2","updated":"2020-04-30 11:00:38.000000000","message":"Yep, that sounds sensible","commit_id":"3cdaad116048a6deccb96828e159a0cd533d17e5"}],"environments/lifecycle/ffwd-upgrade-converge.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fb996bb7ae8cb38ab24a00a0fb2ac009e694b609","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  UpgradeInitCommand: \u0027\u0027"},{"line_number":8,"context_line":"  StackUpdateType: \u0027\u0027"},{"line_number":9,"context_line":"  NetworkDeploymentActions: [\u0027CREATE\u0027]"},{"line_number":10,"context_line":"  OperatingSystemUpgrade: False"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1fa4df85_f770f6dc","line":10,"updated":"2020-03-17 09:26:03.000000000","message":"ugh, shouldn\u0027t that be True for ffwd upgrade?","commit_id":"c3bbab3464f1ce3029d5aca5c10327b69126c496"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"2f07c01361ee92a0b0118f05491ab7827a1c1a6e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  UpgradeInitCommand: \u0027\u0027"},{"line_number":8,"context_line":"  StackUpdateType: \u0027\u0027"},{"line_number":9,"context_line":"  NetworkDeploymentActions: [\u0027CREATE\u0027]"},{"line_number":10,"context_line":"  OperatingSystemUpgrade: False"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1fa4df85_29d71252","line":10,"in_reply_to":"1fa4df85_f770f6dc","updated":"2020-04-08 13:45:48.000000000","message":"The ffwd-upgrade-prepare.yaml is the environment file passed when running the upgrade prepare step, therefore (for Train) we want this to be True as there will be a OS upgade in the workflow. Once the procedure has finished, we run a converge step to get back this parameter to it\u0027s initial value (False) and this is the env file we pass.","commit_id":"c3bbab3464f1ce3029d5aca5c10327b69126c496"}],"environments/lifecycle/ffwd-upgrade-prepare.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fa81536df39f2e4927b341f6ecb79da3951a746f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"parameter_defaults:"},{"line_number":10,"context_line":"  StackUpdateType: FASTFORWARDUPGRADE"},{"line_number":11,"context_line":"  NetworkDeploymentActions: [\u0027CREATE\u0027,\u0027UPDATE\u0027]"},{"line_number":12,"context_line":"  OperatingSystemUpgrade: True"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1fa4df85_57622a18","line":12,"updated":"2020-03-17 09:25:14.000000000","message":"False?","commit_id":"c3bbab3464f1ce3029d5aca5c10327b69126c496"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"2f07c01361ee92a0b0118f05491ab7827a1c1a6e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"parameter_defaults:"},{"line_number":10,"context_line":"  StackUpdateType: FASTFORWARDUPGRADE"},{"line_number":11,"context_line":"  NetworkDeploymentActions: [\u0027CREATE\u0027,\u0027UPDATE\u0027]"},{"line_number":12,"context_line":"  OperatingSystemUpgrade: True"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1fa4df85_6980aa47","line":12,"in_reply_to":"1fa4df85_57622a18","updated":"2020-04-08 13:45:48.000000000","message":"so, here there is my doubt...this should be false for master/Ussuri but True for Train. Should I merge it to False and then change it in the backport to Train?","commit_id":"c3bbab3464f1ce3029d5aca5c10327b69126c496"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"4492812eb0471eb5e0840cc3748224fa63029553","unresolved":false,"context_lines":[{"line_number":9,"context_line":"parameter_defaults:"},{"line_number":10,"context_line":"  StackUpdateType: FASTFORWARDUPGRADE"},{"line_number":11,"context_line":"  NetworkDeploymentActions: [\u0027CREATE\u0027,\u0027UPDATE\u0027]"},{"line_number":12,"context_line":"  OperatingSystemUpgrade: True"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f4c43b2_515f9740","line":12,"updated":"2020-04-14 16:10:22.000000000","message":"I am in favor of having this set to \u0027False\u0027 and then switching it to \u0027True\u0027 for the Train backport.","commit_id":"d4cd22c167c6a214774a18ff9ea1a4c2ff92864d"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"8d692c6076eb585190c78b8a6388c0ac7e9e5b9d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"parameter_defaults:"},{"line_number":10,"context_line":"  StackUpdateType: FASTFORWARDUPGRADE"},{"line_number":11,"context_line":"  NetworkDeploymentActions: [\u0027CREATE\u0027,\u0027UPDATE\u0027]"},{"line_number":12,"context_line":"  OperatingSystemUpgrade: True"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f4c43b2_1174d367","line":12,"in_reply_to":"3f4c43b2_515f9740","updated":"2020-04-15 20:15:29.000000000","message":"ok, make sense. I\u0027ll take care of it","commit_id":"d4cd22c167c6a214774a18ff9ea1a4c2ff92864d"}]}