)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"cfa184a2dda3fc1a13f8c82fda5023bc9b404727","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://review.opendev.org/#/c/577223/"},{"line_number":17,"context_line":"[2] https://review.opendev.org/#/c/581364/"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ic7b6e45b47bdb91758818555d870056730fe3983"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f4c43b2_19927cf7","line":18,"updated":"2020-04-13 06:51:04.000000000","message":"You should add Depends-On: https://review.opendev.org/#/c/718822/ \nto mentioned that it requires puppet-neutron changes for same parameter.","commit_id":"15fb0d49003122ffe263c80fc1262c3d298535ee"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bbcd8a4d1a01bde491526b29657e0ce6f1c724cb","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://review.opendev.org/#/c/577223/"},{"line_number":17,"context_line":"[2] https://review.opendev.org/#/c/581364/"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ic7b6e45b47bdb91758818555d870056730fe3983"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f4c43b2_489357fb","line":18,"in_reply_to":"3f4c43b2_19927cf7","updated":"2020-04-15 15:47:12.000000000","message":"Done","commit_id":"15fb0d49003122ffe263c80fc1262c3d298535ee"}],"deployment/neutron/neutron-ovs-agent-container-puppet.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"02d120a7c36be39403a1e2b8b40886c6b0c39cc5","unresolved":false,"context_lines":[{"line_number":175,"context_line":"          - values:"},{"line_number":176,"context_line":"              NeutronBridgeMappings: {get_param: NeutronBridgeMappings}"},{"line_number":177,"context_line":"              OvsHwOffload: {get_param: OvsHwOffload}"},{"line_number":178,"context_line":"              OvsDisableEMC: {get_param: OvsDisableEMC}"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"  NeutronBase:"},{"line_number":181,"context_line":"    type: ./neutron-base.yaml"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_3c9b5a66","line":178,"updated":"2020-04-09 21:23:16.000000000","message":"You need ot add your vars in here so they get consumed somewhere?","commit_id":"45440f056b96cea06e7041a32151e32f300afe07"}],"deployment/neutron/neutron-sriov-agent-container-puppet.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"02d120a7c36be39403a1e2b8b40886c6b0c39cc5","unresolved":false,"context_lines":[{"line_number":142,"context_line":"          - values:"},{"line_number":143,"context_line":"              NeutronPhysicalDevMappings: {get_param: NeutronPhysicalDevMappings}"},{"line_number":144,"context_line":"              NeutronExcludeDevices: {get_param: NeutronExcludeDevices}"},{"line_number":145,"context_line":"              NeutronSriovAgentExtensions: {get_param: NeutronSriovAgentExtensions}"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"  ContainersCommon:"},{"line_number":148,"context_line":"    type: ../containers-common.yaml"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_9ca3869e","line":145,"updated":"2020-04-09 21:23:16.000000000","message":"You ned to add your vars in here too","commit_id":"45440f056b96cea06e7041a32151e32f300afe07"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"19f997a7217692e2c0e1582fd05799b899b7d718","unresolved":false,"context_lines":[{"line_number":134,"context_line":"          - values:"},{"line_number":135,"context_line":"              NeutronPhysicalDevMappings: {get_param: NeutronPhysicalDevMappings}"},{"line_number":136,"context_line":"              NeutronExcludeDevices: {get_param: NeutronExcludeDevices}"},{"line_number":137,"context_line":"              NeutronSriovAgentExtensions: {get_param: NeutronSriovAgentExtensions}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"  ContainersCommon:"},{"line_number":140,"context_line":"    type: ../containers-common.yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df33271e_9c2546c5","line":137,"updated":"2020-04-09 21:48:55.000000000","message":"They go up here when they are role_specific","commit_id":"deb5f85acf44eeaeefdd93dbe2dcf5b2e1d7603b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c62c1ac2022a12c0e2675f0aa9a519fc0afaa99f","unresolved":false,"context_lines":[{"line_number":134,"context_line":"          - values:"},{"line_number":135,"context_line":"              NeutronPhysicalDevMappings: {get_param: NeutronPhysicalDevMappings}"},{"line_number":136,"context_line":"              NeutronExcludeDevices: {get_param: NeutronExcludeDevices}"},{"line_number":137,"context_line":"              NeutronSriovAgentExtensions: {get_param: NeutronSriovAgentExtensions}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"  ContainersCommon:"},{"line_number":140,"context_line":"    type: ../containers-common.yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df33271e_b72f8586","line":137,"in_reply_to":"df33271e_9c2546c5","updated":"2020-04-09 21:52:44.000000000","message":"Done","commit_id":"deb5f85acf44eeaeefdd93dbe2dcf5b2e1d7603b"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"0f84ba1a993b592327f71259abfe8cdcdaecfa16","unresolved":false,"context_lines":[{"line_number":93,"context_line":"      measured in kilobits per second (kbps). The device must appear in"},{"line_number":94,"context_line":"      physical_device_mappings as the value."},{"line_number":95,"context_line":"    type: comma_delimited_list"},{"line_number":96,"context_line":"    default: \"\""},{"line_number":97,"context_line":"    tags:"},{"line_number":98,"context_line":"     - role_specific"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_457242e5","line":96,"updated":"2020-05-05 00:26:04.000000000","message":"I\u0027d double check that this works the way you expect with role specific parameters. IIRC, role specific params sort of bypass heat\u0027s type handling which could end up with an actual string showing up in the hiera instead of a list. FWICT, it should be fine because of the any2array usage in the puppet, but better safe than sorry.","commit_id":"6ca476842f9a0e89a9d38c606c5b7112909162a6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e3482e45892751e4895339f38e409fa8da02258b","unresolved":false,"context_lines":[{"line_number":93,"context_line":"      measured in kilobits per second (kbps). The device must appear in"},{"line_number":94,"context_line":"      physical_device_mappings as the value."},{"line_number":95,"context_line":"    type: comma_delimited_list"},{"line_number":96,"context_line":"    default: \"\""},{"line_number":97,"context_line":"    tags:"},{"line_number":98,"context_line":"     - role_specific"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_6db47836","line":96,"range":{"start_line":96,"start_character":13,"end_line":96,"end_character":15},"updated":"2020-05-05 13:18:12.000000000","message":"Yea we\u0027re not consistent with this default for comma_delimited_lists. I think technically heat turns this into a proper python list at some point but we\u0027re using \u0027\u0027 elsewhere as well.","commit_id":"6ca476842f9a0e89a9d38c606c5b7112909162a6"}]}