)]}'
{"deployment/nova/nova-api-container-puppet.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"bfd1788c4cec6b760110f73a5957bfdc2e2c3a8f","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  ApacheServiceBase:"},{"line_number":130,"context_line":"    type: ../../deployment/apache/apache-baremetal-puppet.yaml"},{"line_number":131,"context_line":"    properties:"},{"line_number":132,"context_line":"      ServiceData: {get_param: ServiceData}"},{"line_number":133,"context_line":"      ServiceNetMap: {get_param: ServiceNetMap}"},{"line_number":134,"context_line":"      DefaultPasswords: {get_param: DefaultPasswords}"},{"line_number":135,"context_line":"      EndpointMap: {get_param: EndpointMap}"},{"line_number":136,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":137,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":138,"context_line":"      EnableInternalTLS: {get_param: EnableInternalTLS}"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  NovaBase:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df33271e_a2fc6eb5","side":"PARENT","line":137,"range":{"start_line":132,"start_character":0,"end_line":137,"end_character":49},"updated":"2020-04-09 12:50:10.000000000","message":"forgot we need to pass through as not set via parameter_defaults","commit_id":"ece88fdbacbedad40ae75781e7672df38e9137c3"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"bfd1788c4cec6b760110f73a5957bfdc2e2c3a8f","unresolved":false,"context_lines":[{"line_number":135,"context_line":"      EndpointMap: {get_param: EndpointMap}"},{"line_number":136,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":137,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":138,"context_line":"      EnableInternalTLS: {get_param: EnableInternalTLS}"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  NovaBase:"},{"line_number":141,"context_line":"    type: ./nova-base-puppet.yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df33271e_82220a51","side":"PARENT","line":138,"range":{"start_line":138,"start_character":6,"end_line":138,"end_character":55},"updated":"2020-04-09 12:50:10.000000000","message":"don\u0027t think this is necessary but I\u0027ll leave it in place","commit_id":"ece88fdbacbedad40ae75781e7672df38e9137c3"}],"deployment/nova/nova-apidb-client-puppet.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"1c70289483da655bc8f6bb27d133582bdb351796","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    description: \u003e"},{"line_number":40,"context_line":"        Set to true to enable the SQLAlchemy-collectd server plugin"},{"line_number":41,"context_line":"    default: false"},{"line_number":42,"context_line":"  DatabaseSyncTimeout:"},{"line_number":43,"context_line":"    default: 300"},{"line_number":44,"context_line":"    description: DB Sync Timeout default"},{"line_number":45,"context_line":"    type: number"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"conditions:"},{"line_number":48,"context_line":"  enable_sqlalchemy_collectd: {equals : [{get_param: EnableSQLAlchemyCollectd}, true]}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f621f24_9c38a5ee","line":45,"range":{"start_line":42,"start_character":2,"end_line":45,"end_character":16},"updated":"2020-11-10 16:03:45.000000000","message":"nit: remove this","commit_id":"7b79bdcc744a1f21bf02592eebceceee82de69c0"}],"deployment/nova/nova-base-puppet.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"9f4aa4e69863532b32f8755821b1f508274d51b0","unresolved":false,"context_lines":[{"line_number":424,"context_line":"          - {}"},{"line_number":425,"context_line":"          - nova::upgrade_level_compute: {get_param: UpgradeLevelNovaCompute}"},{"line_number":426,"context_line":"      service_config_settings:"},{"line_number":427,"context_line":"        mysql:"},{"line_number":428,"context_line":"          # NOTE(aschultz): this should be configurable if/when we support more"},{"line_number":429,"context_line":"          # complex cell v2 configurations. For now, this is the default cell"},{"line_number":430,"context_line":"          # created for the cell v2 configuration"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_710b1329","side":"PARENT","line":427,"updated":"2020-08-06 17:00:44.000000000","message":"probably should be set to empty hash instead of removing","commit_id":"d35ea3c3bbd8e799f5aa89260e9461cde284b395"}],"deployment/nova/nova-compute-common-container-puppet.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"39bb562ad8600d506d086cdf05ca840936c6b519","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            block:"},{"line_number":64,"context_line":"              - name: discover via nova_manager?"},{"line_number":65,"context_line":"                set_fact:"},{"line_number":66,"context_line":"                  nova_cellv2_discovery_delegate_host: \"{{ groups[\u0027nova_manager\u0027][0] }}\""},{"line_number":67,"context_line":"                  nova_cellv2_discovery_container: nova_manager"},{"line_number":68,"context_line":"                when:"},{"line_number":69,"context_line":"                  - groups[\u0027nova_manager\u0027] is defined and (groups[\u0027nova_manager\u0027]|length\u003e0)"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_c02c8549","line":66,"range":{"start_line":66,"start_character":67,"end_line":66,"end_character":79},"updated":"2020-04-21 20:28:06.000000000","message":"todo: create a nova_manager service + container + role","commit_id":"1c572f6024886fde787c05e1563e5e002046e41e"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"8e94b7cc6ac9b3e31260ade19486d45ec9a281e2","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                  nova_cellv2_discovery_container: nova_manager"},{"line_number":68,"context_line":"                when:"},{"line_number":69,"context_line":"                  - groups[\u0027nova_manager\u0027] is defined and (groups[\u0027nova_manager\u0027]|length\u003e0)"},{"line_number":70,"context_line":"              - name: discover via nova_api?"},{"line_number":71,"context_line":"                set_fact:"},{"line_number":72,"context_line":"                  nova_cellv2_discovery_delegate_host: \"{{ groups[\u0027nova_api\u0027][0] }}\""},{"line_number":73,"context_line":"                  nova_cellv2_discovery_container: nova_api"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_3e05fa14","line":70,"range":{"start_line":70,"start_character":35,"end_line":70,"end_character":43},"updated":"2020-08-05 18:32:41.000000000","message":"todo: can we handle multi-cell deployments? Maybe if we run on the cell conductor and specify the local cell uuid","commit_id":"1c572f6024886fde787c05e1563e5e002046e41e"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"9f4aa4e69863532b32f8755821b1f508274d51b0","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                  nova_cellv2_discovery_container: nova_manager"},{"line_number":68,"context_line":"                when:"},{"line_number":69,"context_line":"                  - groups[\u0027nova_manager\u0027] is defined and (groups[\u0027nova_manager\u0027]|length\u003e0)"},{"line_number":70,"context_line":"              - name: discover via nova_api?"},{"line_number":71,"context_line":"                set_fact:"},{"line_number":72,"context_line":"                  nova_cellv2_discovery_delegate_host: \"{{ groups[\u0027nova_api\u0027][0] }}\""},{"line_number":73,"context_line":"                  nova_cellv2_discovery_container: nova_api"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_c18183fd","line":70,"range":{"start_line":70,"start_character":35,"end_line":70,"end_character":43},"in_reply_to":"9f560f44_3e05fa14","updated":"2020-08-06 17:00:44.000000000","message":"No, that would requires access to the API db","commit_id":"1c572f6024886fde787c05e1563e5e002046e41e"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"0519cff7ce620bba890f2e4095866cf9b5446f4a","unresolved":false,"context_lines":[{"line_number":712,"context_line":"      puppet_config:"},{"line_number":713,"context_line":"        config_volume: nova_libvirt"},{"line_number":714,"context_line":"        puppet_tags: nova_config,nova_paste_api_ini"},{"line_number":715,"context_line":"        step_config: \u003e"},{"line_number":716,"context_line":"          # TODO(emilien): figure how to deal with libvirt profile."},{"line_number":717,"context_line":"          # We\u0027ll probably treat it like we do with Neutron plugins."},{"line_number":718,"context_line":"          # Until then, just include it in the default nova-compute role."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df33271e_2b15d29c","line":715,"range":{"start_line":715,"start_character":21,"end_line":715,"end_character":22},"updated":"2020-04-09 18:52:13.000000000","message":"\u003e makes this one long comment, needs to be |","commit_id":"bc3ca71e8e8e33791d89d743a4ec50b5288aac64"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"7b0d6d9ab7e43ade0f5984589dd19e7a11138d0b","unresolved":false,"context_lines":[{"line_number":837,"context_line":"                      list_concat:"},{"line_number":838,"context_line":"                        - {get_attr: [ContainersCommon, volumes]}"},{"line_number":839,"context_line":"                        -"},{"line_number":840,"context_line":"                          - /var/lib/config-data/nova_libvirt/etc/my.cnf.d/:/etc/my.cnf.d/:ro"},{"line_number":841,"context_line":"                          - /var/lib/config-data/nova_libvirt/etc/nova/:/etc/nova/:ro"},{"line_number":842,"context_line":"                          - /var/log/containers/nova:/var/log/nova"},{"line_number":843,"context_line":"                          - /var/lib/container-config-scripts/:/container-config-scripts/"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df33271e_4b85b6ce","line":840,"range":{"start_line":840,"start_character":26,"end_line":840,"end_character":93},"updated":"2020-04-09 18:55:18.000000000","message":"remove","commit_id":"bc3ca71e8e8e33791d89d743a4ec50b5288aac64"}],"deployment/nova/nova-conductor-container-puppet.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"33bbe28db1ff6e0c2ae08c139bc1c4caf916b45b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":87,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  NovaApiDBClient:"},{"line_number":90,"context_line":"    type: ./nova-apidb-client-puppet.yaml"},{"line_number":91,"context_line":"    properties:"},{"line_number":92,"context_line":"      ServiceData: {get_param: ServiceData}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_41b61340","line":89,"range":{"start_line":89,"start_character":2,"end_line":89,"end_character":18},"updated":"2020-08-05 18:37:22.000000000","message":"todo: only the superconductor should have access in a multicell deployment","commit_id":"1c572f6024886fde787c05e1563e5e002046e41e"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"7e5fb7263d30b28d58c2d8c82970bc701705bec1","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                  - /var/lib/config-data/nova/etc/my.cnf.d/tripleo.cnf:/etc/my.cnf.d/tripleo.cnf:ro"},{"line_number":188,"context_line":"                  - /var/lib/config-data/nova/etc/nova/:/etc/nova/:ro"},{"line_number":189,"context_line":"            user: root"},{"line_number":190,"context_line":"            command: \"/usr/bin/bootstrap_host_exec nova_conductor su nova -s /bin/bash -c \u0027/usr/bin/nova-manage db sync\u0027\""},{"line_number":191,"context_line":"            environment:"},{"line_number":192,"context_line":"              TRIPLEO_DEPLOY_IDENTIFIER: {get_param: DeployIdentifier}"},{"line_number":193,"context_line":"        step_4:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1f621f24_9ca25bad","line":190,"range":{"start_line":190,"start_character":91,"end_line":190,"end_character":119},"updated":"2020-11-11 10:18:04.000000000","message":"This is failing for me downstream for a cell conductor using https://review.opendev.org/#/c/762173/2 but succeeds with https://review.opendev.org/#/c/762173/1:\n\n    ERROR: Could not access cell0.\n    Has the nova_api database been created?\n    Has the nova_cell0 database been created?\n    Has \"nova-manage api_db sync\" been run?\n    Has \"nova-manage cell_v2 map_cell0\" been run?\n    Is [api_database]/connection set in nova.conf?\n    Is the cell0 database connection URL correct?\n    Error: No sql_connection parameter is established","commit_id":"96bf097cb2dda990eb5e8ad86107ae82f9df5d8b"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"b6f6a295520684674c2cea4459b229409810750c","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                  - /var/lib/config-data/nova/etc/my.cnf.d/tripleo.cnf:/etc/my.cnf.d/tripleo.cnf:ro"},{"line_number":188,"context_line":"                  - /var/lib/config-data/nova/etc/nova/:/etc/nova/:ro"},{"line_number":189,"context_line":"            user: root"},{"line_number":190,"context_line":"            command: \"/usr/bin/bootstrap_host_exec nova_conductor su nova -s /bin/bash -c \u0027/usr/bin/nova-manage db sync\u0027\""},{"line_number":191,"context_line":"            environment:"},{"line_number":192,"context_line":"              TRIPLEO_DEPLOY_IDENTIFIER: {get_param: DeployIdentifier}"},{"line_number":193,"context_line":"        step_4:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1f621f24_3c72274a","line":190,"range":{"start_line":190,"start_character":91,"end_line":190,"end_character":119},"in_reply_to":"1f621f24_9ca25bad","updated":"2020-11-11 10:22:13.000000000","message":"Need to add --local_cell","commit_id":"96bf097cb2dda990eb5e8ad86107ae82f9df5d8b"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"8832b6221ee5107c443514a21cb5359cbcbdde18","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        map_merge:"},{"line_number":123,"context_line":"          - get_attr: [NovaBase, role_data, config_settings]"},{"line_number":124,"context_line":"          - if:"},{"line_number":125,"context_line":"            - is_not_additional_cell"},{"line_number":126,"context_line":"            - get_attr: [NovaApiDBClient, role_data, config_settings]"},{"line_number":127,"context_line":"            - {}"},{"line_number":128,"context_line":"          - get_attr: [NovaDBClient, role_data, config_settings]"},{"line_number":129,"context_line":"          - get_attr: [NovaLogging, config_settings]"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1f621f24_1bbac808","line":126,"range":{"start_line":125,"start_character":14,"end_line":126,"end_character":69},"updated":"2020-11-11 22:09:38.000000000","message":"FIXME: apparently cell conductor still requires api db access","commit_id":"c2e265fbcc708f627f5ffb5be33988c762bc1670"}],"deployment/nova/nova-metadata-container-puppet.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"569a1359a86a4a8bbc28b77f769467e75ceacf89","unresolved":false,"context_lines":[{"line_number":149,"context_line":"      config_settings:"},{"line_number":150,"context_line":"        map_merge:"},{"line_number":151,"context_line":"          - get_attr: [NovaBase, role_data, config_settings]"},{"line_number":152,"context_line":"          - get_attr: [NovaApiDBClient, role_data, config_settings]"},{"line_number":153,"context_line":"          - get_attr: [NovaDBClient, role_data, config_settings]"},{"line_number":154,"context_line":"          - get_attr: [ApacheServiceBase, role_data, config_settings]"},{"line_number":155,"context_line":"          - get_attr: [NovaMetadataLogging, config_settings]"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f621f24_840ccbec","line":152,"range":{"start_line":152,"start_character":0,"end_line":152,"end_character":67},"updated":"2020-11-10 22:44:01.000000000","message":"AFAICT should remove api db access when NovaLocalMetadataPerCell","commit_id":"7b79bdcc744a1f21bf02592eebceceee82de69c0"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bdd253697b9812ac5549ca7430f74645decbfb10","unresolved":false,"context_lines":[{"line_number":152,"context_line":"          - get_attr: [NovaBase, role_data, config_settings]"},{"line_number":153,"context_line":"          - if:"},{"line_number":154,"context_line":"            - is_not_cell_local"},{"line_number":155,"context_line":"            - get_attr: [NovaApiDBClient, role_data, config_settings]"},{"line_number":156,"context_line":"            - {}"},{"line_number":157,"context_line":"          - get_attr: [NovaDBClient, role_data, config_settings]"},{"line_number":158,"context_line":"          - get_attr: [ApacheServiceBase, role_data, config_settings]"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1f621f24_237936c7","line":155,"updated":"2020-11-16 10:36:15.000000000","message":"Just to confirm my understanding of the local cell case, is that really expected to have (potentially?) different creds configured in hiera nova::database_connection and nova::api_database_connection?\n\nOr why we need to have the same creds in two places?","commit_id":"f2ae7f396ca2d7f269100ff2a155bed2dc046093"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"a569db3a9cce7df936d7e27e3961f88aa841ddb2","unresolved":false,"context_lines":[{"line_number":152,"context_line":"          - get_attr: [NovaBase, role_data, config_settings]"},{"line_number":153,"context_line":"          - if:"},{"line_number":154,"context_line":"            - is_not_cell_local"},{"line_number":155,"context_line":"            - get_attr: [NovaApiDBClient, role_data, config_settings]"},{"line_number":156,"context_line":"            - {}"},{"line_number":157,"context_line":"          - get_attr: [NovaDBClient, role_data, config_settings]"},{"line_number":158,"context_line":"          - get_attr: [ApacheServiceBase, role_data, config_settings]"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1f621f24_4ef57256","line":155,"in_reply_to":"1f621f24_237936c7","updated":"2020-11-16 17:19:24.000000000","message":"Not sure I understand the question. When local cell nova::api_database_connection is not set","commit_id":"f2ae7f396ca2d7f269100ff2a155bed2dc046093"}],"deployment/nova/nova-vnc-proxy-container-puppet.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"569a1359a86a4a8bbc28b77f769467e75ceacf89","unresolved":false,"context_lines":[{"line_number":138,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":139,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  NovaApiDBClient:"},{"line_number":142,"context_line":"    type: ./nova-apidb-client-puppet.yaml"},{"line_number":143,"context_line":"    properties:"},{"line_number":144,"context_line":"      ServiceData: {get_param: ServiceData}"},{"line_number":145,"context_line":"      ServiceNetMap: {get_param: ServiceNetMap}"},{"line_number":146,"context_line":"      DefaultPasswords: {get_param: DefaultPasswords}"},{"line_number":147,"context_line":"      EndpointMap: {get_param: EndpointMap}"},{"line_number":148,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":149,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"  NovaDBClient:"},{"line_number":152,"context_line":"    type: ./nova-db-client-puppet.yaml"},{"line_number":153,"context_line":"    properties:"},{"line_number":154,"context_line":"      ServiceData: {get_param: ServiceData}"},{"line_number":155,"context_line":"      ServiceNetMap: {get_param: ServiceNetMap}"},{"line_number":156,"context_line":"      DefaultPasswords: {get_param: DefaultPasswords}"},{"line_number":157,"context_line":"      EndpointMap: {get_param: EndpointMap}"},{"line_number":158,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":159,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"outputs:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f621f24_c474036b","line":159,"range":{"start_line":141,"start_character":0,"end_line":159,"end_character":49},"updated":"2020-11-10 22:44:01.000000000","message":"can remove DB access, it\u0027s just a websocket proxy","commit_id":"7b79bdcc744a1f21bf02592eebceceee82de69c0"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"e5425fc93128a27385349455b43a439a6db50b2b","unresolved":false,"context_lines":[{"line_number":138,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":139,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  NovaApiDBClient:"},{"line_number":142,"context_line":"    type: ./nova-apidb-client-puppet.yaml"},{"line_number":143,"context_line":"    properties:"},{"line_number":144,"context_line":"      ServiceData: {get_param: ServiceData}"},{"line_number":145,"context_line":"      ServiceNetMap: {get_param: ServiceNetMap}"},{"line_number":146,"context_line":"      DefaultPasswords: {get_param: DefaultPasswords}"},{"line_number":147,"context_line":"      EndpointMap: {get_param: EndpointMap}"},{"line_number":148,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":149,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"  NovaDBClient:"},{"line_number":152,"context_line":"    type: ./nova-db-client-puppet.yaml"},{"line_number":153,"context_line":"    properties:"},{"line_number":154,"context_line":"      ServiceData: {get_param: ServiceData}"},{"line_number":155,"context_line":"      ServiceNetMap: {get_param: ServiceNetMap}"},{"line_number":156,"context_line":"      DefaultPasswords: {get_param: DefaultPasswords}"},{"line_number":157,"context_line":"      EndpointMap: {get_param: EndpointMap}"},{"line_number":158,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":159,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"outputs:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f621f24_1cfacbbb","line":159,"range":{"start_line":141,"start_character":0,"end_line":159,"end_character":49},"in_reply_to":"1f621f24_7511575d","updated":"2020-11-11 10:07:31.000000000","message":"indeed","commit_id":"7b79bdcc744a1f21bf02592eebceceee82de69c0"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"bfb1e36e9278831f3e84c0cc8214bf89b5d03763","unresolved":false,"context_lines":[{"line_number":138,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":139,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  NovaApiDBClient:"},{"line_number":142,"context_line":"    type: ./nova-apidb-client-puppet.yaml"},{"line_number":143,"context_line":"    properties:"},{"line_number":144,"context_line":"      ServiceData: {get_param: ServiceData}"},{"line_number":145,"context_line":"      ServiceNetMap: {get_param: ServiceNetMap}"},{"line_number":146,"context_line":"      DefaultPasswords: {get_param: DefaultPasswords}"},{"line_number":147,"context_line":"      EndpointMap: {get_param: EndpointMap}"},{"line_number":148,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":149,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"  NovaDBClient:"},{"line_number":152,"context_line":"    type: ./nova-db-client-puppet.yaml"},{"line_number":153,"context_line":"    properties:"},{"line_number":154,"context_line":"      ServiceData: {get_param: ServiceData}"},{"line_number":155,"context_line":"      ServiceNetMap: {get_param: ServiceNetMap}"},{"line_number":156,"context_line":"      DefaultPasswords: {get_param: DefaultPasswords}"},{"line_number":157,"context_line":"      EndpointMap: {get_param: EndpointMap}"},{"line_number":158,"context_line":"      RoleName: {get_param: RoleName}"},{"line_number":159,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"outputs:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f621f24_7511575d","line":159,"range":{"start_line":141,"start_character":0,"end_line":159,"end_character":49},"in_reply_to":"1f621f24_c474036b","updated":"2020-11-11 08:03:34.000000000","message":"I think we still need the NovaDBClient because with nova-consoleauth removed it validates the provided token against the db, no?","commit_id":"7b79bdcc744a1f21bf02592eebceceee82de69c0"}],"roles/NovaManager.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"5573e36dd8b9e2eed4a7be6acb043cc6580078d5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  HostnameFormatDefault: \u0027%stackname%-novamanager-%index%\u0027"},{"line_number":11,"context_line":"  update_serial: 25"},{"line_number":12,"context_line":"  ServicesDefault:"},{"line_number":13,"context_line":"    - OS::TripleO::Services::AuditD"},{"line_number":14,"context_line":"    - OS::TripleO::Services::BootParams"},{"line_number":15,"context_line":"    - OS::TripleO::Services::CACerts"},{"line_number":16,"context_line":"    - OS::TripleO::Services::CertmongerUser"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_a467264d","line":13,"updated":"2020-08-06 22:02:12.000000000","message":"missing Aide, based on Novacontrol.yaml","commit_id":"30d0eab7f3b187e8a6c28f3caaf836c8cfc73f4d"}],"tools/yaml-validate.py":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"35a27be96bf72436a510f9819c34e3a93945e501","unresolved":false,"context_lines":[{"line_number":249,"context_line":"  \u0027./deployment/qdr/qdroutered-container-puppet.yaml\u0027: False,"},{"line_number":250,"context_line":"  # puppet/services/messaging/*.yaml provide oslo_messaging services"},{"line_number":251,"context_line":"  \u0027./deployment/messaging/rpc-qdrouterd-container-puppet.yaml\u0027: False,"},{"line_number":252,"context_line":"  \u0027./puppet/services/messaging/rpc-qdrouterd.yaml\u0027: False,"},{"line_number":253,"context_line":"}"},{"line_number":254,"context_line":"VALIDATE_DOCKER_OVERRIDE \u003d {"},{"line_number":255,"context_line":"  # deployment/rabbitmq/rabbitmq-messaging-notify-shared-puppet.yaml does not"}],"source_content_type":"text/x-python","patch_set":15,"id":"1f621f24_97c332ed","line":252,"range":{"start_line":252,"start_character":2,"end_line":252,"end_character":58},"updated":"2020-11-13 16:38:57.000000000","message":"err, when/why did I do that?","commit_id":"5f548f167273b42eee266d315810d9818b0350ae"}]}