)]}'
{"network/service_net_map.j2.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"783d19fe48d896b1f5b1fabc7489da6000fba80b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"      {{role.name}}HostnameResolveNetwork: {{ _service_nets.get(\u0027storage\u0027, \u0027ctlplane\u0027) }}"},{"line_number":97,"context_line":"{%- endfor %}"},{"line_number":98,"context_line":"{%- for role in roles if not role.name.startswith(\u0027Ceph\u0027) %}"},{"line_number":99,"context_line":"    {%- if \u0027InternalApi\u0027 in role.networks %}"},{"line_number":100,"context_line":"      {{role.name}}HostnameResolveNetwork: {{ _service_nets.get(\u0027internal_api\u0027, \u0027ctlplane\u0027) }}"},{"line_number":101,"context_line":"    {%- else %}"},{"line_number":102,"context_line":"      {{role.name}}HostnameResolveNetwork: ctlplane"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_7d57a559","line":99,"range":{"start_line":99,"start_character":2,"end_line":99,"end_character":44},"updated":"2020-04-27 14:54:18.000000000","message":"*sigh*, these hardcoding of based on network names.\nCan we instead update roles_data to include which network is the hostname resolve network for the role?\n\nFor example for Ceph:\n\n- name: CephStorage\n  networks:\n    Storage:\n      subnet: storage_subnet\n      resolve_network: true\n      metric_qdr_network: true\n    StorageMgmt:\n      subnet: storage_mgmt_subnet\n\nAlternatively:\n\n- name: CephStorage\n  resolve_network: storage\n  metric_qdr_network: storage\n  networks:\n    Storage:\n      subnet: storage_subnet\n    StorageMgmt:\n      subnet: storage_mgmt_subnet\n\nI think doing this would allow us to remove a lot of the special casing in Jinja2, it\u0027s more obvious for the end user as well?","commit_id":"324fcc36ba4945623aa8e6b6f8466e45b6be93af"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"edd547c7f4ac671b08670adeb389bfda188fd8fd","unresolved":false,"context_lines":[{"line_number":96,"context_line":"      {{role.name}}HostnameResolveNetwork: {{ _service_nets.get(\u0027storage\u0027, \u0027ctlplane\u0027) }}"},{"line_number":97,"context_line":"{%- endfor %}"},{"line_number":98,"context_line":"{%- for role in roles if not role.name.startswith(\u0027Ceph\u0027) %}"},{"line_number":99,"context_line":"    {%- if \u0027InternalApi\u0027 in role.networks %}"},{"line_number":100,"context_line":"      {{role.name}}HostnameResolveNetwork: {{ _service_nets.get(\u0027internal_api\u0027, \u0027ctlplane\u0027) }}"},{"line_number":101,"context_line":"    {%- else %}"},{"line_number":102,"context_line":"      {{role.name}}HostnameResolveNetwork: ctlplane"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_806b2ab5","line":99,"range":{"start_line":99,"start_character":2,"end_line":99,"end_character":44},"in_reply_to":"1f493fa4_7d57a559","updated":"2020-04-27 15:01:58.000000000","message":"Hmm.. Are we not doing plenty of hardcoding here? Are we saying hardcoding based on \u0027name_lower\u0027 i.e internal_api is fine but not on network names?","commit_id":"324fcc36ba4945623aa8e6b6f8466e45b6be93af"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"2c6c82ad368f9f14cef27560276bc00398cb6f67","unresolved":false,"context_lines":[{"line_number":96,"context_line":"      {{role.name}}HostnameResolveNetwork: {{ _service_nets.get(\u0027storage\u0027, \u0027ctlplane\u0027) }}"},{"line_number":97,"context_line":"{%- endfor %}"},{"line_number":98,"context_line":"{%- for role in roles if not role.name.startswith(\u0027Ceph\u0027) %}"},{"line_number":99,"context_line":"    {%- if \u0027InternalApi\u0027 in role.networks %}"},{"line_number":100,"context_line":"      {{role.name}}HostnameResolveNetwork: {{ _service_nets.get(\u0027internal_api\u0027, \u0027ctlplane\u0027) }}"},{"line_number":101,"context_line":"    {%- else %}"},{"line_number":102,"context_line":"      {{role.name}}HostnameResolveNetwork: ctlplane"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_009d5abb","line":99,"range":{"start_line":99,"start_character":2,"end_line":99,"end_character":44},"in_reply_to":"1f493fa4_7d57a559","updated":"2020-04-27 15:02:07.000000000","message":"I see the bug is opened against train, changeing the roles_data interface in a backport is\u0027nt ideal.\nLet\u0027s do this, and get it backported, I can follow up with something to be less reliant upon names that are ultimately user configurable.","commit_id":"324fcc36ba4945623aa8e6b6f8466e45b6be93af"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"f4fcb9afd29ff176092f863dfc608d2f9dae442a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"      {{role.name}}HostnameResolveNetwork: {{ _service_nets.get(\u0027storage\u0027, \u0027ctlplane\u0027) }}"},{"line_number":97,"context_line":"{%- endfor %}"},{"line_number":98,"context_line":"{%- for role in roles if not role.name.startswith(\u0027Ceph\u0027) %}"},{"line_number":99,"context_line":"    {%- if \u0027InternalApi\u0027 in role.networks %}"},{"line_number":100,"context_line":"      {{role.name}}HostnameResolveNetwork: {{ _service_nets.get(\u0027internal_api\u0027, \u0027ctlplane\u0027) }}"},{"line_number":101,"context_line":"    {%- else %}"},{"line_number":102,"context_line":"      {{role.name}}HostnameResolveNetwork: ctlplane"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_31338664","line":99,"range":{"start_line":99,"start_character":2,"end_line":99,"end_character":44},"in_reply_to":"1f493fa4_806b2ab5","updated":"2020-04-27 16:34:54.000000000","message":"We are, way too much.\n\nIt\u0027s all the name.startwith(\u0027Ceph\u0027) and similar as well. This breaks when edge operators decide to name their roles \u003csiteid\u003eCeph instead of Ceph\u003csite\u003e etc.","commit_id":"324fcc36ba4945623aa8e6b6f8466e45b6be93af"}]}