)]}'
{"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c6aa62c8230bf3d15ee850225c0c22f3a1bb2983","unresolved":false,"context_lines":[{"line_number":421,"context_line":"            exclude: ansible"},{"line_number":422,"context_line":"        # This is failsafe unless openvswitch package does something to the systemd service state."},{"line_number":423,"context_line":"        - name: Check if openvswitch.service is present"},{"line_number":424,"context_line":"          command: systemctl status openvswitch"},{"line_number":425,"context_line":"          register: svc_ovs_check"},{"line_number":426,"context_line":"          ignore_errors: yes"},{"line_number":427,"context_line":"        - name: Ensure openvswitch is running after update"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_4cb9f076","line":424,"updated":"2020-05-01 20:32:30.000000000","message":"please use the systemd module to figure out if the service is running:\n\nhttps://docs.ansible.com/ansible/latest/modules/systemd_module.html","commit_id":"d9b3176443a469b413f55913feae7d230091d5bb"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"fec8db33e9b0cd21019907dfb87668189516fa40","unresolved":false,"context_lines":[{"line_number":428,"context_line":"          when:"},{"line_number":429,"context_line":"            - step|int \u003d\u003d 3"},{"line_number":430,"context_line":"            - ovs_service_state is defined"},{"line_number":431,"context_line":"            - ovs_service_state.status.ActiveState \u003d\u003d \u0027active\u0027"},{"line_number":432,"context_line":"          service:"},{"line_number":433,"context_line":"            name: openvswitch"},{"line_number":434,"context_line":"            enabled: yes"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_f41cdf14","line":431,"range":{"start_line":431,"start_character":9,"end_line":431,"end_character":62},"updated":"2020-05-24 18:01:49.000000000","message":"what to do when service is in inactive state? with just checking for \u0027active\u0027 state will not start the service when package is installed and unit file is present.\n\ni think you need to rely on package, if openvswitch package is present, ensure openvswitch service is started state else skip the task.","commit_id":"41b06705822c00e33d05db9d73f6ecde2867b7ce"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"c03ebb9c12b4c25f912f6a1a5375e3fc75fe2222","unresolved":false,"context_lines":[{"line_number":428,"context_line":"          when:"},{"line_number":429,"context_line":"            - step|int \u003d\u003d 3"},{"line_number":430,"context_line":"            - ovs_service_state is defined"},{"line_number":431,"context_line":"            - ovs_service_state.status.ActiveState \u003d\u003d \u0027active\u0027"},{"line_number":432,"context_line":"          service:"},{"line_number":433,"context_line":"            name: openvswitch"},{"line_number":434,"context_line":"            enabled: yes"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_7380b78c","line":431,"range":{"start_line":431,"start_character":9,"end_line":431,"end_character":62},"in_reply_to":"ff570b3c_f41cdf14","updated":"2020-05-27 12:49:56.000000000","message":"Good catch! What about using \u0027UnitFileState\u0027 instead? If it\u0027s enabled it should be started otherwise leave it alone?","commit_id":"41b06705822c00e33d05db9d73f6ecde2867b7ce"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"c6f5e5459194c54b71a6ae75f91bc21845b8c3ca","unresolved":false,"context_lines":[{"line_number":428,"context_line":"          when:"},{"line_number":429,"context_line":"            - step|int \u003d\u003d 3"},{"line_number":430,"context_line":"            - ovs_service_state is defined"},{"line_number":431,"context_line":"            - ovs_service_state.status.ActiveState \u003d\u003d \u0027active\u0027"},{"line_number":432,"context_line":"          service:"},{"line_number":433,"context_line":"            name: openvswitch"},{"line_number":434,"context_line":"            enabled: yes"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_147cf31e","line":431,"range":{"start_line":431,"start_character":9,"end_line":431,"end_character":62},"in_reply_to":"ff570b3c_f41cdf14","updated":"2020-05-24 18:03:02.000000000","message":"There are already some tasks which does similar https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml#L277-L287","commit_id":"41b06705822c00e33d05db9d73f6ecde2867b7ce"}]}