)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"25155205aea1fc4423861f697a7752e9c08da709","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If enable-ssh-admin.sh workflow fails, the script was looping forever,"},{"line_number":10,"context_line":"because it only checks if the workflow is SUCCESSFUL."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Now, we have a timeout of 500 seconds and when it reaches it, it\u0027ll stop"},{"line_number":13,"context_line":"and print a debug message."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Note: we\u0027re using ENABLE_SSH_ADMIN_TIMEOUT variable which can be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f493fa4_c197743a","line":12,"range":{"start_line":12,"start_character":26,"end_line":12,"end_character":30},"updated":"2020-05-04 12:40:45.000000000","message":"600 isn\u0027t it?","commit_id":"ed96df18c2d620f47b4412ad1f1193d70b13af05"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"f0358a97b19c20a6899cb11bf782698cf1337261","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If enable-ssh-admin.sh workflow fails, the script was looping forever,"},{"line_number":10,"context_line":"because it only checks if the workflow is SUCCESSFUL."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Now, we have a timeout of 500 seconds and when it reaches it, it\u0027ll stop"},{"line_number":13,"context_line":"and print a debug message."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Note: we\u0027re using ENABLE_SSH_ADMIN_TIMEOUT variable which can be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"1f493fa4_c25904ff","line":12,"updated":"2020-05-06 12:41:30.000000000","message":"just a nit: shouldn\u0027t this be 600 seconds instead of 500?","commit_id":"b3127ac3f17d61e8bf6cfd43b05a4a2f31f7939f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ccd06eb42c1ac917202898322da2388412b06828","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If enable-ssh-admin.sh workflow fails, the script was looping forever,"},{"line_number":10,"context_line":"because it only checks if the workflow is SUCCESSFUL."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Now, we have a timeout of 500 seconds and when it reaches it, it\u0027ll stop"},{"line_number":13,"context_line":"and print a debug message."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Note: we\u0027re using ENABLE_SSH_ADMIN_TIMEOUT variable which can be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"1f493fa4_82041cc8","line":12,"in_reply_to":"1f493fa4_c25904ff","updated":"2020-05-06 12:42:17.000000000","message":"yeah it was 500s and i failed to update all the commit message.","commit_id":"b3127ac3f17d61e8bf6cfd43b05a4a2f31f7939f"}],"deployed-server/scripts/enable-ssh-admin.sh":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9e93de1592dc3ccfcc4018ad1b372a37d5b67011","unresolved":false,"context_lines":[{"line_number":13,"context_line":"SSH_HOSTKEY_OPTIONS\u003d\"-o StrictHostKeyChecking\u003dno -o UserKnownHostsFile\u003d/dev/null\""},{"line_number":14,"context_line":"SHORT_TERM_KEY_COMMENT\u003d\"TripleO split stack short term key\""},{"line_number":15,"context_line":"SLEEP_TIME\u003d5"},{"line_number":16,"context_line":"WORKFLOW_TIMEOUT\u003d500"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# needed to handle where python lives"},{"line_number":19,"context_line":"function get_python() {"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1f493fa4_ce64c6e8","line":16,"range":{"start_line":16,"start_character":17,"end_line":16,"end_character":20},"updated":"2020-05-04 02:44:41.000000000","message":"I\u0027m not sure about the default, I need to do more research for a safe value.","commit_id":"c2c4093acb5d47c66b2b683858160453d94c89e6"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"66dd2b1c8cec7bedc35155e70e5e227b016745e5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"SSH_HOSTKEY_OPTIONS\u003d\"-o StrictHostKeyChecking\u003dno -o UserKnownHostsFile\u003d/dev/null\""},{"line_number":14,"context_line":"SHORT_TERM_KEY_COMMENT\u003d\"TripleO split stack short term key\""},{"line_number":15,"context_line":"SLEEP_TIME\u003d5"},{"line_number":16,"context_line":"WORKFLOW_TIMEOUT\u003d500"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# needed to handle where python lives"},{"line_number":19,"context_line":"function get_python() {"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1f493fa4_8e2bde2e","line":16,"range":{"start_line":16,"start_character":17,"end_line":16,"end_character":20},"in_reply_to":"1f493fa4_ce64c6e8","updated":"2020-05-04 03:56:26.000000000","message":"The default seems to be 600s[1][2]. We should probably make it configurable via an argument?\n\n[1] https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/constants.py#L83\n[2] https://bugs.launchpad.net/tripleo/+bug/1805725\n\nAlso not sure we suggest using it from ussuri onwards and use cli-enable-ssh-admin.yaml playbook instead(?), though the cleanup and doc changes are still TBD.","commit_id":"c2c4093acb5d47c66b2b683858160453d94c89e6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c3eebcc776b6d91bc84fcb6ad0603f378249d550","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"function workflow_finished {"},{"line_number":38,"context_line":"    local execution_id\u003d\"$1\""},{"line_number":39,"context_line":"    if ! timeout $ENABLE_SSH_ADMIN_TIMEOUT sh -c \" while ! openstack workflow execution show -f shell $execution_id | grep \u0027state\u003d\"SUCCESS\"\u0027 \u003e /dev/null; do sleep $SLEEP_TIME; done\"; then"},{"line_number":40,"context_line":"        echo \"Workflow $execution_id did not finish with success after $ENABLE_SSH_ADMIN_TIMEOUT seconds.\""},{"line_number":41,"context_line":"    fi"},{"line_number":42,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1f493fa4_fc3cd331","line":39,"range":{"start_line":39,"start_character":118,"end_line":39,"end_character":140},"updated":"2020-05-04 13:36:01.000000000","message":"We could just look for other status\u0027s too. This will just cause faulures to exit after 10 mins even if it fails after 2.","commit_id":"f6ef7b149817bd0f5b1ecc413a4f96a58fccc320"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5ecd60331bd3641dbe5eaa17588f23410a23aeb8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        else"},{"line_number":51,"context_line":"            sleep $SLEEP_TIME"},{"line_number":52,"context_line":"        fi"},{"line_number":53,"context_line":"        counter\u003d$(( $counter - 5 ))"},{"line_number":54,"context_line":"    done"},{"line_number":55,"context_line":"    echo \"Workflow $execution_id did not finish after $ENABLE_SSH_ADMIN_TIMEOUT seconds.\""},{"line_number":56,"context_line":"    return 1"}],"source_content_type":"text/x-sh","patch_set":8,"id":"1f493fa4_d6a8d3dc","line":53,"range":{"start_line":53,"start_character":31,"end_line":53,"end_character":32},"updated":"2020-05-04 15:16:31.000000000","message":"should be 1 not 5. You\u0027re already taking the 5 into account on L39","commit_id":"c6b7e21dd7415789f9a51632a1a1559844103572"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"bce4a63bb90cf5c992b92d1989a0dc18d13aee86","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    while [ $counter -gt 0 ]"},{"line_number":42,"context_line":"    do"},{"line_number":43,"context_line":"        RESULT\u003d$(openstack workflow execution show -f value -c state $execution_id  \u003e /dev/null)"},{"line_number":44,"context_line":"        if [ \"$RESULT\" \u003d\u003d \"ERROR\" ]; then"},{"line_number":45,"context_line":"            echo \"Workflow $execution_id finished with error. Check mistral logs.\""},{"line_number":46,"context_line":"            return 1"}],"source_content_type":"text/x-sh","patch_set":10,"id":"1f493fa4_4df7fcd5","line":43,"range":{"start_line":43,"start_character":82,"end_line":43,"end_character":95},"updated":"2020-05-05 13:28:28.000000000","message":"Don\u0027t want \u003e/dev/null. This actually means it\u0027ll never complete","commit_id":"bc525cc7301668a5588e88fdd72d72fadd0ac31e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"57ca4330bf494f54232ab4d2c5ecf5d7608ea93f","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    while [ $counter -gt 0 ]"},{"line_number":42,"context_line":"    do"},{"line_number":43,"context_line":"        RESULT\u003d$(openstack workflow execution show -f value -c state $execution_id  \u003e /dev/null)"},{"line_number":44,"context_line":"        if [ \"$RESULT\" \u003d\u003d \"ERROR\" ]; then"},{"line_number":45,"context_line":"            echo \"Workflow $execution_id finished with error. Check mistral logs.\""},{"line_number":46,"context_line":"            return 1"}],"source_content_type":"text/x-sh","patch_set":10,"id":"1f493fa4_11998e1e","line":43,"range":{"start_line":43,"start_character":82,"end_line":43,"end_character":95},"in_reply_to":"1f493fa4_4df7fcd5","updated":"2020-05-05 14:15:00.000000000","message":"right with the new command, this isn\u0027t useful anymore.","commit_id":"bc525cc7301668a5588e88fdd72d72fadd0ac31e"}]}