)]}'
{"environments/services/undercloud-at-scale.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"185f73bf47b3d9071de8aae99744b6107a94266a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    ## RabbitMQ; reduce traffic from all services for messaging"},{"line_number":30,"context_line":"    ## Explicitly we care about: neutron, heat, nova, keystone"},{"line_number":31,"context_line":"    ## TODO: Check re. minion nodes; do they need this?"},{"line_number":32,"context_line":"    NotificationDriver: \u0027noop\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    ## Find how to plug this in, and if it is a global / inheritable setting"},{"line_number":35,"context_line":"    ## /var/lib/config-data/puppet-generated/\u003cSERVICE\u003e/etc/httpd/conf/httpd.conf"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_d91d4867","line":32,"range":{"start_line":32,"start_character":4,"end_line":32,"end_character":30},"updated":"2020-05-14 14:12:36.000000000","message":"If telemetry is disabled, this should be noop across the board. If it\u0027s not that\u0027s a bug","commit_id":"7ada80ad3fe902638a140a77c4fb20467764d136"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0b897473a4ae0fc0233524f954be417f6eaf4270","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    ## RabbitMQ; reduce traffic from all services for messaging"},{"line_number":30,"context_line":"    ## Explicitly we care about: neutron, heat, nova, keystone"},{"line_number":31,"context_line":"    ## TODO: Check re. minion nodes; do they need this?"},{"line_number":32,"context_line":"    NotificationDriver: \u0027noop\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    ## Find how to plug this in, and if it is a global / inheritable setting"},{"line_number":35,"context_line":"    ## /var/lib/config-data/puppet-generated/\u003cSERVICE\u003e/etc/httpd/conf/httpd.conf"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_15badcdc","line":32,"range":{"start_line":32,"start_character":4,"end_line":32,"end_character":30},"in_reply_to":"ff570b3c_553c54be","updated":"2020-05-14 19:27:35.000000000","message":"No but notifications are usually picked up by telemetry. I think there are some actual uses of notifications somewhere but i\u0027m not fully versed in the uses across all projects. I thought we went through and \u0027fixed\u0027 the non-noop previously. It would be good to identify what isn\u0027t noop by default","commit_id":"7ada80ad3fe902638a140a77c4fb20467764d136"},{"author":{"_account_id":27427,"name":"David Peacock","email":"dpeacock@redhat.com","username":"davidjpeacock"},"change_message_id":"219d6d8a5c64a42925ee0aee429da5e8783996ee","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    ## RabbitMQ; reduce traffic from all services for messaging"},{"line_number":30,"context_line":"    ## Explicitly we care about: neutron, heat, nova, keystone"},{"line_number":31,"context_line":"    ## TODO: Check re. minion nodes; do they need this?"},{"line_number":32,"context_line":"    NotificationDriver: \u0027noop\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    ## Find how to plug this in, and if it is a global / inheritable setting"},{"line_number":35,"context_line":"    ## /var/lib/config-data/puppet-generated/\u003cSERVICE\u003e/etc/httpd/conf/httpd.conf"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_553c54be","line":32,"range":{"start_line":32,"start_character":4,"end_line":32,"end_character":30},"in_reply_to":"ff570b3c_d91d4867","updated":"2020-05-14 19:12:52.000000000","message":"Is RabbitMQ exclusive to telemetry?  Do we use it for anything else?","commit_id":"7ada80ad3fe902638a140a77c4fb20467764d136"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"185f73bf47b3d9071de8aae99744b6107a94266a","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    #########################"},{"line_number":59,"context_line":"    # Workers are usually tied to CPU core count, but this will be variable"},{"line_number":60,"context_line":"    # based on environment"},{"line_number":61,"context_line":"    HeatWorkers: 48"},{"line_number":62,"context_line":"    # database executor thread; should match worker count "},{"line_number":63,"context_line":"    puppet-heat::config::heat_config:"},{"line_number":64,"context_line":"      executor_thread_pool_size:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_993c70c9","line":61,"range":{"start_line":61,"start_character":17,"end_line":61,"end_character":19},"updated":"2020-05-14 14:12:36.000000000","message":"I thought 24 was a max value we wanted for heat, did that change somewhere? We can update the os_workers_heat_engine fact instead","commit_id":"7ada80ad3fe902638a140a77c4fb20467764d136"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0b897473a4ae0fc0233524f954be417f6eaf4270","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    #########################"},{"line_number":59,"context_line":"    # Workers are usually tied to CPU core count, but this will be variable"},{"line_number":60,"context_line":"    # based on environment"},{"line_number":61,"context_line":"    HeatWorkers: 48"},{"line_number":62,"context_line":"    # database executor thread; should match worker count "},{"line_number":63,"context_line":"    puppet-heat::config::heat_config:"},{"line_number":64,"context_line":"      executor_thread_pool_size:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_75d07820","line":61,"range":{"start_line":61,"start_character":17,"end_line":61,"end_character":19},"in_reply_to":"ff570b3c_35a60012","updated":"2020-05-14 19:27:35.000000000","message":"By default we use os_workers_heat_engine and have previously capped it because of previous guidance. If it would be beneficial to go up to 48, we should fix the fact over in puppet-openstacklib","commit_id":"7ada80ad3fe902638a140a77c4fb20467764d136"},{"author":{"_account_id":27427,"name":"David Peacock","email":"dpeacock@redhat.com","username":"davidjpeacock"},"change_message_id":"219d6d8a5c64a42925ee0aee429da5e8783996ee","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    #########################"},{"line_number":59,"context_line":"    # Workers are usually tied to CPU core count, but this will be variable"},{"line_number":60,"context_line":"    # based on environment"},{"line_number":61,"context_line":"    HeatWorkers: 48"},{"line_number":62,"context_line":"    # database executor thread; should match worker count "},{"line_number":63,"context_line":"    puppet-heat::config::heat_config:"},{"line_number":64,"context_line":"      executor_thread_pool_size:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_35a60012","line":61,"range":{"start_line":61,"start_character":17,"end_line":61,"end_character":19},"in_reply_to":"ff570b3c_993c70c9","updated":"2020-05-14 19:12:52.000000000","message":"Would that fact be easily exposed?  HeatWorkers is already right there in THT, and is something we tune regularly on large deployments.\n\nIs there a benefit to updating os_workers_heat_engine as you specify?  Are they actually the same thing?","commit_id":"7ada80ad3fe902638a140a77c4fb20467764d136"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"185f73bf47b3d9071de8aae99744b6107a94266a","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    ## Memcached"},{"line_number":108,"context_line":"    #########################"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    # TODO for all services; heat exampled below"},{"line_number":111,"context_line":"    [cache]"},{"line_number":112,"context_line":"    Enabled \u003d true"},{"line_number":113,"context_line":"    Backend \u003d dogpile.cache.memcached"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_f9500c0d","line":110,"updated":"2020-05-14 14:12:36.000000000","message":"I think this enabled now upstream? We should probably just backport that logic","commit_id":"7ada80ad3fe902638a140a77c4fb20467764d136"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0b897473a4ae0fc0233524f954be417f6eaf4270","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    ## Memcached"},{"line_number":108,"context_line":"    #########################"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    # TODO for all services; heat exampled below"},{"line_number":111,"context_line":"    [cache]"},{"line_number":112,"context_line":"    Enabled \u003d true"},{"line_number":113,"context_line":"    Backend \u003d dogpile.cache.memcached"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_75951840","line":110,"in_reply_to":"ff570b3c_f5e9281a","updated":"2020-05-14 19:27:35.000000000","message":"https://review.opendev.org/#/c/724876/","commit_id":"7ada80ad3fe902638a140a77c4fb20467764d136"},{"author":{"_account_id":27427,"name":"David Peacock","email":"dpeacock@redhat.com","username":"davidjpeacock"},"change_message_id":"219d6d8a5c64a42925ee0aee429da5e8783996ee","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    ## Memcached"},{"line_number":108,"context_line":"    #########################"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    # TODO for all services; heat exampled below"},{"line_number":111,"context_line":"    [cache]"},{"line_number":112,"context_line":"    Enabled \u003d true"},{"line_number":113,"context_line":"    Backend \u003d dogpile.cache.memcached"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_f5e9281a","line":110,"in_reply_to":"ff570b3c_f9500c0d","updated":"2020-05-14 19:12:52.000000000","message":"Great to know; I\u0027ll look into this.  Do you know the patch(es) that covered this?","commit_id":"7ada80ad3fe902638a140a77c4fb20467764d136"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"3aac257a5eb50cf2999ba7aae537e8263d736f94","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    Enabled \u003d true"},{"line_number":113,"context_line":"    Backend \u003d dogpile.cache.memcached"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    HeatMemcacheEnabled: true    # TODO expose heat::cache::enabled: true via THT"},{"line_number":116,"context_line":"    HeatMemcacheBackend: dogpile.cache.memcached # TODO expose heat::cache::backend"},{"line_number":117,"context_line":"    HeatMemcacheServers: 127.0.0.1 # TODO expose heat::cache::memcache_servers "}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_cd49c6b7","line":117,"range":{"start_line":115,"start_character":0,"end_line":117,"end_character":79},"updated":"2020-05-18 15:13:01.000000000","message":"This is now enabled by default for both undercloud and overcloud.\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/deployment/heat/heat-base-puppet.yaml#L195-L199\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_746/727959/2/check/tripleo-ci-centos-8-containers-multinode/746acfe/logs/undercloud/var/lib/config-data/puppet-generated/heat/etc/heat/heat.conf\n\nAlso, heat caching would not give much performance benefit in the undercloud. We only cache heat constraints and service extensions (enabling finder cache may give some issues). There can be issues with using a single memcache server and it\u0027s overhead will negate all benefits. AFAIK, it\u0027s gives some benefits with keystone token caching, but not seen anything else with other services.","commit_id":"7ada80ad3fe902638a140a77c4fb20467764d136"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"3ec7165f39ce52ee2dc3813c603ef900dc27bbcd","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    #####################"},{"line_number":42,"context_line":"    ## Heat"},{"line_number":43,"context_line":"    #####################"},{"line_number":44,"context_line":"    #HeatRPCResponseTimeout: 1200 # TODO expose heat::rpc_response_timeout: 600 via THT"},{"line_number":45,"context_line":"                             # in follow-up patch this depends on"},{"line_number":46,"context_line":"    # Set to the number of Overcloud nodes that will be deployed."},{"line_number":47,"context_line":"    NodeCreateBatchSize: 500"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_8b9dcf67","line":44,"updated":"2020-06-25 17:29:42.000000000","message":"10 minutes is the current timeout for both the Heat API (via HAProxy and for the RPC response timeout). Do we really need to increase this to 20 minutes?","commit_id":"56a9b6b19479bdc2666f7dfb8f0c98e3dd9ce18d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f7cee6f3209d567fcba7a5192e020604740e4638","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    #HeatRPCResponseTimeout: 1200 # TODO expose heat::rpc_response_timeout: 600 via THT"},{"line_number":45,"context_line":"                             # in follow-up patch this depends on"},{"line_number":46,"context_line":"    # Set to the number of Overcloud nodes that will be deployed."},{"line_number":47,"context_line":"    NodeCreateBatchSize: 500"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    #####################"},{"line_number":50,"context_line":"    ## Ironic"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_71582855","line":47,"updated":"2020-06-25 19:01:26.000000000","message":"Any heat params don\u0027t go under UndercloudExtraConfig","commit_id":"56a9b6b19479bdc2666f7dfb8f0c98e3dd9ce18d"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"3ec7165f39ce52ee2dc3813c603ef900dc27bbcd","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    #####################"},{"line_number":50,"context_line":"    ## Ironic"},{"line_number":51,"context_line":"    #####################"},{"line_number":52,"context_line":"    NovaSyncPowerStateInterval: 180"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    #####################"},{"line_number":55,"context_line":"    ## Nova"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_2baf632a","line":52,"updated":"2020-06-25 17:29:42.000000000","message":"+1 to enabling this. By default, TripleO sets it to \"-1\" which disables it. https://docs.openstack.org/newton/config-reference/compute/config-options.html","commit_id":"56a9b6b19479bdc2666f7dfb8f0c98e3dd9ce18d"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"3ec7165f39ce52ee2dc3813c603ef900dc27bbcd","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    #####################"},{"line_number":55,"context_line":"    ## Nova"},{"line_number":56,"context_line":"    #####################"},{"line_number":57,"context_line":"    nova::compute::ironic::max_concurrent_builds: 10"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    #####################"},{"line_number":60,"context_line":"    ## Mistral"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_cb086793","line":57,"updated":"2020-06-25 17:29:42.000000000","message":"50 has been tested as a good number to set: https://bugs.launchpad.net/fuel/+bug/1541910 . 10 is actually the default already.","commit_id":"56a9b6b19479bdc2666f7dfb8f0c98e3dd9ce18d"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"3ec7165f39ce52ee2dc3813c603ef900dc27bbcd","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    #####################"},{"line_number":60,"context_line":"    ## Mistral"},{"line_number":61,"context_line":"    #####################"},{"line_number":62,"context_line":"    MistralRPCResponseTimeout: 600 # TODO: expose via mistral::rpc_response_timeout:"},{"line_number":63,"context_line":"    MistralExecutionFieldSizeLimit: 32768"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    #####################"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_2b3c832d","line":62,"updated":"2020-06-25 17:29:42.000000000","message":"+1 to this. It is currently set to 2 minutes. Raising it to 10 minutes would match what we have set for Heat.","commit_id":"56a9b6b19479bdc2666f7dfb8f0c98e3dd9ce18d"}],"environments/undercloud/undercloud-tuning.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8f4af0e425f0eba8fa8a33f41b822de63e0ba3fa","unresolved":true,"context_lines":[{"line_number":35,"context_line":"  # Type: string"},{"line_number":36,"context_line":"  MysqlInnodbBufferPoolSize: 5G"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  # Interval to sync power states between the database and the hypervisor. Set to -1 to disable. Setting this to 0 will run at the default rate."},{"line_number":39,"context_line":"  # Type: number"},{"line_number":40,"context_line":"  NovaSyncPowerStateInterval: 180"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  # Set a token expiration time in seconds."},{"line_number":43,"context_line":"  # Type: number"},{"line_number":44,"context_line":"  TokenExpiration: 86400"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"2bd6c1cb_a8e3d867","line":41,"range":{"start_line":38,"start_character":0,"end_line":41,"end_character":0},"updated":"2021-06-01 15:55:40.000000000","message":"don\u0027t think this is relevant anymore?","commit_id":"32730030cb977ad38411ecc885726b24eecd4c90"}],"sample-env-generator/undercloud-tuning.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"719a748cdb84a4b5ad2d59d5fbfe5d22009d0fa7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    description: |"},{"line_number":50,"context_line":"      The RPC response timeout between Mistral and RabbitMQ."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  NodeCreateBatchSize:"},{"line_number":53,"context_line":"    description: Number of nodes for Heat to process at one time."},{"line_number":54,"context_line":"    type: number"},{"line_number":55,"context_line":"    default: 500"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  NovaMaxConcurrentBuilds:"},{"line_number":58,"context_line":"    type: number"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_8e53b86c","line":55,"range":{"start_line":52,"start_character":0,"end_line":55,"end_character":16},"updated":"2020-09-01 12:32:25.000000000","message":"Have we tested this value? This is only valid for first time deployment. 500 nodes at one go is too much for nova to handle. Anyway we\u0027re moving to nova-less (i.e Deployed Server), so we should not set this at all. Remove the 30 default we have.","commit_id":"364929caea100dd42b254dd131ab1fe85c6308dd"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"608fe9697c49f6209a124975028b83ef85a43044","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    description: |"},{"line_number":50,"context_line":"      The RPC response timeout between Mistral and RabbitMQ."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  NodeCreateBatchSize:"},{"line_number":53,"context_line":"    description: Number of nodes for Heat to process at one time."},{"line_number":54,"context_line":"    type: number"},{"line_number":55,"context_line":"    default: 500"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  NovaMaxConcurrentBuilds:"},{"line_number":58,"context_line":"    type: number"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_b302060b","line":55,"range":{"start_line":52,"start_character":0,"end_line":55,"end_character":16},"in_reply_to":"9f560f44_8e53b86c","updated":"2020-09-22 13:34:31.000000000","message":"Done","commit_id":"364929caea100dd42b254dd131ab1fe85c6308dd"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3f7d557b0adc0cf747da67ac5c78d8d7d36316df","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      Use this environment file to manage parameters related to"},{"line_number":9,"context_line":"      tuning the Undercloud to handle a larger Overcloud deployment."},{"line_number":10,"context_line":"    files:"},{"line_number":11,"context_line":"      sample-env-generator/undercloud-tuning.yaml:"},{"line_number":12,"context_line":"        parameters:"},{"line_number":13,"context_line":"          - TokenExpiration"},{"line_number":14,"context_line":"          - ZaqarWsTimeout"},{"line_number":15,"context_line":"          - MistralExecutionFieldSizeLimit"},{"line_number":16,"context_line":"          - MistralRPCResponseTimeout"},{"line_number":17,"context_line":"          - MysqlInnodbBufferPoolSize"},{"line_number":18,"context_line":"          - NovaMaxConcurrentBuilds"},{"line_number":19,"context_line":"          - NovaSyncPowerStateInterval"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"parameters:"},{"line_number":22,"context_line":"  TokenExpiration:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_8e2d1991","line":19,"range":{"start_line":11,"start_character":0,"end_line":19,"end_character":38},"updated":"2020-09-22 13:37:32.000000000","message":"These should be a reference to the service files where they are defined rather than here. We only do this if we\u0027re setting something that like lives in the core framework and not a service specific param.  To specify specific values, you\u0027d create a sample_values section under here.  Check the undercloud-minion.yaml for better examples of what i\u0027m talking about","commit_id":"6b16f91613e2ec2bef9387b39cdaeaa3c369379f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"047a5bfb23b0018168a6326ecdb6a6789e59ac59","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      Use this environment file to manage parameters related to"},{"line_number":9,"context_line":"      tuning the Undercloud to handle a larger Overcloud deployment."},{"line_number":10,"context_line":"    files:"},{"line_number":11,"context_line":"      sample-env-generator/undercloud-tuning.yaml:"},{"line_number":12,"context_line":"        parameters:"},{"line_number":13,"context_line":"          - TokenExpiration"},{"line_number":14,"context_line":"          - ZaqarWsTimeout"},{"line_number":15,"context_line":"          - MistralExecutionFieldSizeLimit"},{"line_number":16,"context_line":"          - MistralRPCResponseTimeout"},{"line_number":17,"context_line":"          - MysqlInnodbBufferPoolSize"},{"line_number":18,"context_line":"          - NovaMaxConcurrentBuilds"},{"line_number":19,"context_line":"          - NovaSyncPowerStateInterval"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"parameters:"},{"line_number":22,"context_line":"  TokenExpiration:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_db54ec24","line":19,"range":{"start_line":11,"start_character":0,"end_line":19,"end_character":38},"in_reply_to":"9f560f44_5b7e1ce3","updated":"2020-09-22 17:03:12.000000000","message":"Ehhhh you could probably explain this in the description for the environment file rather than do it this way","commit_id":"6b16f91613e2ec2bef9387b39cdaeaa3c369379f"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"4853529d71c52b1175495606acc5303bfd3a5ceb","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      Use this environment file to manage parameters related to"},{"line_number":9,"context_line":"      tuning the Undercloud to handle a larger Overcloud deployment."},{"line_number":10,"context_line":"    files:"},{"line_number":11,"context_line":"      sample-env-generator/undercloud-tuning.yaml:"},{"line_number":12,"context_line":"        parameters:"},{"line_number":13,"context_line":"          - TokenExpiration"},{"line_number":14,"context_line":"          - ZaqarWsTimeout"},{"line_number":15,"context_line":"          - MistralExecutionFieldSizeLimit"},{"line_number":16,"context_line":"          - MistralRPCResponseTimeout"},{"line_number":17,"context_line":"          - MysqlInnodbBufferPoolSize"},{"line_number":18,"context_line":"          - NovaMaxConcurrentBuilds"},{"line_number":19,"context_line":"          - NovaSyncPowerStateInterval"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"parameters:"},{"line_number":22,"context_line":"  TokenExpiration:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_5b7e1ce3","line":19,"range":{"start_line":11,"start_character":0,"end_line":19,"end_character":38},"in_reply_to":"9f560f44_8e2d1991","updated":"2020-09-22 16:51:17.000000000","message":"I avoided that method because this way the variables would be printed into the generated THT template with a detailed description of why and how the parameters should be used for tuning. I can switch the descriptions to comments instead.","commit_id":"6b16f91613e2ec2bef9387b39cdaeaa3c369379f"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"195c1f358f6f49477349218b0091e8c7c7cda3a8","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      Use this environment file to manage parameters related to"},{"line_number":9,"context_line":"      tuning the Undercloud to handle a larger Overcloud deployment."},{"line_number":10,"context_line":"    files:"},{"line_number":11,"context_line":"      sample-env-generator/undercloud-tuning.yaml:"},{"line_number":12,"context_line":"        parameters:"},{"line_number":13,"context_line":"          - TokenExpiration"},{"line_number":14,"context_line":"          - ZaqarWsTimeout"},{"line_number":15,"context_line":"          - MistralExecutionFieldSizeLimit"},{"line_number":16,"context_line":"          - MistralRPCResponseTimeout"},{"line_number":17,"context_line":"          - MysqlInnodbBufferPoolSize"},{"line_number":18,"context_line":"          - NovaMaxConcurrentBuilds"},{"line_number":19,"context_line":"          - NovaSyncPowerStateInterval"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"parameters:"},{"line_number":22,"context_line":"  TokenExpiration:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_7690574f","line":19,"range":{"start_line":11,"start_character":0,"end_line":19,"end_character":38},"in_reply_to":"9f560f44_db54ec24","updated":"2020-09-22 17:33:45.000000000","message":"Done","commit_id":"6b16f91613e2ec2bef9387b39cdaeaa3c369379f"}]}