)]}'
{"environments/ceph-ansible/ceph-ansible.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"43b608f39b313bb6388aae0b0e6ade3128dc9130","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  CinderBackupBackend: ceph"},{"line_number":15,"context_line":"  NovaEnableRbdBackend: true"},{"line_number":16,"context_line":"  GlanceBackend: rbd"},{"line_number":17,"context_line":"  GlanceShowMultipleLocations: true"},{"line_number":18,"context_line":"  ## Uncomment below if enabling legacy telemetry"},{"line_number":19,"context_line":"  # GnocchiBackend: rbd"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_bf85bb5c","line":17,"updated":"2020-05-15 16:57:23.000000000","message":"ceph-ansible is used in much more than just edge. This should be in an edge related deployment file. Please don\u0027t make this change here.\n\ne.g. https://github.com/openstack/tripleo-heat-templates/blob/master/environments/dcn-hci.yaml#L50","commit_id":"b59934434dcc38c4af138a6cf208bf59f9069a17"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"3dbeb0996e3923bc5db831b6509dec707933b866","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  CinderBackupBackend: ceph"},{"line_number":15,"context_line":"  NovaEnableRbdBackend: true"},{"line_number":16,"context_line":"  GlanceBackend: rbd"},{"line_number":17,"context_line":"  GlanceShowMultipleLocations: true"},{"line_number":18,"context_line":"  ## Uncomment below if enabling legacy telemetry"},{"line_number":19,"context_line":"  # GnocchiBackend: rbd"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_6f807547","line":17,"in_reply_to":"ff570b3c_117c9b70","updated":"2020-05-18 12:07:23.000000000","message":"\u003e It\u0027s about nova RBD working better when NovaEnableRbdBackend is set per role instead of globally.\n\nYes, \"per role\". Why not use ceph-ansible-per-role for those types of deployments?\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/environments/ceph-ansible/ceph-ansible-per-role.yaml\n\n \u003e The param tells glance to expose the direct backend uris to nova.\n\nYes, we want COW boots so we want Nova to get the RBD URI, (e.g. rbd://d25504ce-459f-432d-b6fa-79854d786f2b/images/8083c7e7-32d8-4f7a-b1da-0ed7884f1076/snap) so it\u0027s not pulled from the glance API.\n\n \u003e It is another magic setting for glance that gets enabled when\n \u003e NovaEnableRbdBackend: true and GlanceBackend: rbd are set.\n\nRight that\u0027s why we still get the COW boots as per:\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/stable/train/deployment/glance/glance-api-container-puppet.yaml#L313-L322\n\n \u003e i.e:\n \u003e \n \u003e parameter_defaults:\n \u003e NovaEnableRbdBackend: true\n \u003e \n \u003e is currently equivalent to this:\n \u003e \n \u003e parameter_defaults:\n \u003e # default to local ephemeral\n \u003e NovaEnableRbdBackend: false\n \u003e GlanceShowMultipleLocations: true\n \u003e ComputeParameters:\n \u003e # Just this role uses RBD for ephemeral\n \u003e NovaEnableRbdBackend: true\n \u003e \n \u003e \n \u003e Explicitly setting the param here means we no longer rely on\n \u003e implicit magic and usage is more obvious i.e this just works:\n \u003e \n \u003e parameter_defaults:\n \u003e NovaEnableRbdBackend: false\n \u003e ComputeParameters:\n \u003e NovaEnableRbdBackend: true\n\nSo if you want to do that, you can use per-role or override it separately in another env file.","commit_id":"b59934434dcc38c4af138a6cf208bf59f9069a17"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"3a161e887bdbaa9fcd00dcd5879db77531cc8231","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  CinderBackupBackend: ceph"},{"line_number":15,"context_line":"  NovaEnableRbdBackend: true"},{"line_number":16,"context_line":"  GlanceBackend: rbd"},{"line_number":17,"context_line":"  GlanceShowMultipleLocations: true"},{"line_number":18,"context_line":"  ## Uncomment below if enabling legacy telemetry"},{"line_number":19,"context_line":"  # GnocchiBackend: rbd"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_117c9b70","line":17,"in_reply_to":"ff570b3c_bf85bb5c","updated":"2020-05-15 17:52:59.000000000","message":"This has nothing to do with edge.\n\nIt\u0027s about nova RBD working better when NovaEnableRbdBackend is set per role instead of globally.\n\nThe param tells glance to expose the direct backend uris to nova. It is another magic setting for glance that gets enabled when NovaEnableRbdBackend: true and GlanceBackend: rbd are set. \n\ni.e:\n\n    parameter_defaults:\n      NovaEnableRbdBackend: true\n\nis currently equivalent to this:\n\n    parameter_defaults:\n      # default to local ephemeral\n      NovaEnableRbdBackend: false\n      GlanceShowMultipleLocations: true\n      ComputeParameters:\n        # Just this role uses RBD for ephemeral\n        NovaEnableRbdBackend: true\n\n\nExplicitly setting the param here means we no longer rely on implicit magic and usage is more obvious i.e this just works:\n\n    parameter_defaults:\n      NovaEnableRbdBackend: false\n      ComputeParameters:\n        NovaEnableRbdBackend: true","commit_id":"b59934434dcc38c4af138a6cf208bf59f9069a17"}],"roles/ComputeHCI.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"09ffc0bf9d616fe4241f305ef0b553a5836772bf","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      subnet: storage_mgmt_subnet"},{"line_number":16,"context_line":"  RoleParametersDefault:"},{"line_number":17,"context_line":"    TunedProfileName: \"throughput-performance\""},{"line_number":18,"context_line":"    NovaEnableRbdBackend: true"},{"line_number":19,"context_line":"  # CephOSD present so serial has to be 1"},{"line_number":20,"context_line":"  update_serial: 1"},{"line_number":21,"context_line":"  ServicesDefault:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_11a93b8f","line":18,"range":{"start_line":18,"start_character":4,"end_line":18,"end_character":30},"updated":"2020-05-15 17:55:36.000000000","message":"This is to ensure that when the global NovaEnableRbdBackend: false we still default to RBD ephemeral for the HCI computes","commit_id":"b59934434dcc38c4af138a6cf208bf59f9069a17"}],"tools/yaml-validate.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b53084e1bb5154d3d8a599bf496de7e077ffcfbd","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                print(\u0027ERROR: ServicesDefault in %s is different from \u0027"},{"line_number":388,"context_line":"                      \u0027ServicesDefault in roles/Compute.yaml\u0027 % hci_role_filename)"},{"line_number":389,"context_line":"                return 1"},{"line_number":390,"context_line":"        if role.get(\u0027RoleParametersDefault\u0027, {}).get(\u0027NovaEnableRbdBackend\u0027, None) !\u003d True:"},{"line_number":391,"context_line":"            print(\u0027ERROR: HCI role {} does not set NovaEnableRbdBackend: true\u0027.format(role[\u0027name\u0027]))"},{"line_number":392,"context_line":"            return 1"},{"line_number":393,"context_line":"    return 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_0ae580dc","line":390,"updated":"2020-05-15 21:31:01.000000000","message":"pep8: E712 comparison to True should be \u0027if cond is not True:\u0027 or \u0027if not cond:\u0027","commit_id":"b59934434dcc38c4af138a6cf208bf59f9069a17"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b53084e1bb5154d3d8a599bf496de7e077ffcfbd","unresolved":false,"context_lines":[{"line_number":463,"context_line":"                print(\u0027ERROR: ServicesDefault in %s is different from \u0027"},{"line_number":464,"context_line":"                      \u0027ServicesDefault in roles/Compute.yaml\u0027 % hci_role_filename)"},{"line_number":465,"context_line":"                return 1"},{"line_number":466,"context_line":"            if role.get(\u0027RoleParametersDefault\u0027, {}).get(\u0027NovaEnableRbdBackend\u0027, None) !\u003d True:"},{"line_number":467,"context_line":"                print(\u0027ERROR: HCI role {} does not set NovaEnableRbdBackend: true\u0027.format(role[\u0027name\u0027]))"},{"line_number":468,"context_line":"                return 1"},{"line_number":469,"context_line":"    return 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_eae92cb7","line":466,"updated":"2020-05-15 21:31:01.000000000","message":"pep8: E712 comparison to True should be \u0027if cond is not True:\u0027 or \u0027if not cond:\u0027","commit_id":"b59934434dcc38c4af138a6cf208bf59f9069a17"}]}