)]}'
{"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"26ab0637e8875f2ae6cbcba29e55fcf51674c570","unresolved":false,"context_lines":[{"line_number":1057,"context_line":"            - name: Check if we need to update the paunch config"},{"line_number":1058,"context_line":"              shell: |"},{"line_number":1059,"context_line":"                set -o pipefail"},{"line_number":1060,"context_line":"                jq .\"nova_compute\".\"image\" /var/lib/tripleo-config/docker-container-startup-config-step_4.json"},{"line_number":1061,"context_line":"              register: nova_compute_paunch_image"},{"line_number":1062,"context_line":"            - when: nova_compute_paunch_image.stdout !\u003d nova_compute_image"},{"line_number":1063,"context_line":"              block:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff570b3c_fc689ef5","line":1060,"updated":"2020-05-19 19:53:26.000000000","message":"I was going to suggest the use of podman_container_info...but I had forgotten that at this point there is no podman in the Compute node.","commit_id":"4f59fb2e7da97561eef28a96742498398492b4b1"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"26ab0637e8875f2ae6cbcba29e55fcf51674c570","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"                - name: Remove api_database section from nova_compute config"},{"line_number":1074,"context_line":"                  shell: crudini --del api_database /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf"},{"line_number":1075,"context_line":"                # This code is partial copy of logic in podman installation"},{"line_number":1076,"context_line":"                - name: Make sure the Undercloud hostname is included in /etc/hosts"},{"line_number":1077,"context_line":"                  when:"},{"line_number":1078,"context_line":"                    - undercloud_hosts_entries is defined"},{"line_number":1079,"context_line":"                  lineinfile:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff570b3c_ef045e17","line":1076,"updated":"2020-05-19 19:53:26.000000000","message":"And this logic is needed because the podman service upgrade tasks won\u0027t run in the Compute at this point, right?","commit_id":"4f59fb2e7da97561eef28a96742498398492b4b1"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"cac196c4ffb7584ca0d081e1a1497692f273ebb8","unresolved":false,"context_lines":[{"line_number":1068,"context_line":"                set -o pipefail"},{"line_number":1069,"context_line":"                jq .\"nova_compute\".\"image\" /var/lib/tripleo-config/docker-container-startup-config-step_4.json"},{"line_number":1070,"context_line":"              register: nova_compute_paunch_image"},{"line_number":1071,"context_line":"            - when: nova_compute_paunch_image.stdout !\u003d nova_compute_image"},{"line_number":1072,"context_line":"              block:"},{"line_number":1073,"context_line":"                - name: Update the nova_compute paunch image in config"},{"line_number":1074,"context_line":"                  shell: |"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff570b3c_ed6ded98","line":1071,"range":{"start_line":1071,"start_character":0,"end_line":1071,"end_character":74},"updated":"2020-05-28 11:32:51.000000000","message":"Note: This condition makes the process idempotent, hopefully.","commit_id":"debe99ae68e41db859f91cc2b471c670a5ca4222"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"474066cbfc953018c502dba2fc2f3a0f7ad538c4","unresolved":false,"context_lines":[{"line_number":1068,"context_line":"                set -o pipefail"},{"line_number":1069,"context_line":"                jq .\"nova_compute\".\"image\" /var/lib/tripleo-config/docker-container-startup-config-step_4.json"},{"line_number":1070,"context_line":"              register: nova_compute_paunch_image"},{"line_number":1071,"context_line":"            - when: nova_compute_paunch_image.stdout !\u003d nova_compute_image"},{"line_number":1072,"context_line":"              block:"},{"line_number":1073,"context_line":"                - name: Update the nova_compute paunch image in config"},{"line_number":1074,"context_line":"                  shell: |"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff570b3c_0adeeed8","line":1071,"range":{"start_line":1071,"start_character":0,"end_line":1071,"end_character":74},"in_reply_to":"ff570b3c_ed6ded98","updated":"2020-06-03 09:55:49.000000000","message":"This should fail anywhere else than Queens EL7 based deployments.","commit_id":"debe99ae68e41db859f91cc2b471c670a5ca4222"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d1df8aa6fdf8ff9824fa2e229589cf15de4563d4","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"                    cat \u003c\u003c\u003c $(jq \u0027.nova_compute.image \u003d \"{{ nova_compute_image }}\"\u0027 \\"},{"line_number":1077,"context_line":"                    /var/lib/tripleo-config/docker-container-startup-config-step_4.json) \u003e\\"},{"line_number":1078,"context_line":"                    /var/lib/tripleo-config/docker-container-startup-config-step_4.json"},{"line_number":1079,"context_line":"                # Nova compute will not work unless we ensure it will not connect against db and use messaging"},{"line_number":1080,"context_line":"                - name: Remove database section from nova_compute config"},{"line_number":1081,"context_line":"                  shell: crudini --del database /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf"},{"line_number":1082,"context_line":"                - name: Remove api_database section from nova_compute config"},{"line_number":1083,"context_line":"                  shell: crudini --del api_database /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf"},{"line_number":1084,"context_line":"                # This code is partial copy of logic in podman installation"},{"line_number":1085,"context_line":"                - name: Make sure the Undercloud hostname is included in /etc/hosts"},{"line_number":1086,"context_line":"                  when:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff570b3c_0dcae118","line":1083,"range":{"start_line":1079,"start_character":0,"end_line":1083,"end_character":121},"updated":"2020-05-28 11:59:02.000000000","message":"Isn\u0027t the issue here that we are using the Queens nova.conf with a Train nova-compute service? Shouldn\u0027t we rebuild this somehow here?","commit_id":"debe99ae68e41db859f91cc2b471c670a5ca4222"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"474066cbfc953018c502dba2fc2f3a0f7ad538c4","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"                    cat \u003c\u003c\u003c $(jq \u0027.nova_compute.image \u003d \"{{ nova_compute_image }}\"\u0027 \\"},{"line_number":1077,"context_line":"                    /var/lib/tripleo-config/docker-container-startup-config-step_4.json) \u003e\\"},{"line_number":1078,"context_line":"                    /var/lib/tripleo-config/docker-container-startup-config-step_4.json"},{"line_number":1079,"context_line":"                # Nova compute will not work unless we ensure it will not connect against db and use messaging"},{"line_number":1080,"context_line":"                - name: Remove database section from nova_compute config"},{"line_number":1081,"context_line":"                  shell: crudini --del database /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf"},{"line_number":1082,"context_line":"                - name: Remove api_database section from nova_compute config"},{"line_number":1083,"context_line":"                  shell: crudini --del api_database /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf"},{"line_number":1084,"context_line":"                # This code is partial copy of logic in podman installation"},{"line_number":1085,"context_line":"                - name: Make sure the Undercloud hostname is included in /etc/hosts"},{"line_number":1086,"context_line":"                  when:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff570b3c_4a9aa613","line":1083,"range":{"start_line":1079,"start_character":0,"end_line":1083,"end_character":121},"in_reply_to":"ff570b3c_0dcae118","updated":"2020-06-03 09:55:49.000000000","message":"We don\u0027t have any reasonable tooling to rebuild these configs sadly. If there will be config change we need to copy it to this snippet. Expectation is there is only very small number of changes that could land here. If it gets bigger we will have to rework this part.","commit_id":"debe99ae68e41db859f91cc2b471c670a5ca4222"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"cba44c4628f34a40caa52ba708dfb41a2d67ff1a","unresolved":false,"context_lines":[{"line_number":1099,"context_line":"                - name: Set container_registry_insecure registries"},{"line_number":1100,"context_line":"                  when: container_registry_insecure_registries !\u003d []"},{"line_number":1101,"context_line":"                  shell: crudini --set /etc/containers/registries.conf registries.insecure registries \"[{{ container_registry_insecure_registries | map(\u0027regex_replace\u0027, \u0027(.*)\u0027, \"\u0027\\1\u0027\") | join(\u0027,\u0027) }}]\""},{"line_number":1102,"context_line":"                - name: Restart docker"},{"line_number":1103,"context_line":"                  service:"},{"line_number":1104,"context_line":"                    name: docker"},{"line_number":1105,"context_line":"                    state: restarted"},{"line_number":1106,"context_line":"                # Finally apply the paunch config to start the new nova_compute"},{"line_number":1107,"context_line":"                - name: Apply paunch config"},{"line_number":1108,"context_line":"                  shell: paunch apply --file /var/lib/tripleo-config/docker-container-startup-config-step_4.json --config-id tripleo_step4"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff570b3c_442b162f","line":1105,"range":{"start_line":1102,"start_character":0,"end_line":1105,"end_character":36},"updated":"2020-05-28 08:49:42.000000000","message":"What should it do if docker is not there, but podman is? This is likely to be the case for stein-\u003etrain, so we should cater to it.","commit_id":"debe99ae68e41db859f91cc2b471c670a5ca4222"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"1105a838a10138c160e4c469e3043b759fca1ffb","unresolved":false,"context_lines":[{"line_number":1099,"context_line":"                - name: Set container_registry_insecure registries"},{"line_number":1100,"context_line":"                  when: container_registry_insecure_registries !\u003d []"},{"line_number":1101,"context_line":"                  shell: crudini --set /etc/containers/registries.conf registries.insecure registries \"[{{ container_registry_insecure_registries | map(\u0027regex_replace\u0027, \u0027(.*)\u0027, \"\u0027\\1\u0027\") | join(\u0027,\u0027) }}]\""},{"line_number":1102,"context_line":"                - name: Restart docker"},{"line_number":1103,"context_line":"                  service:"},{"line_number":1104,"context_line":"                    name: docker"},{"line_number":1105,"context_line":"                    state: restarted"},{"line_number":1106,"context_line":"                # Finally apply the paunch config to start the new nova_compute"},{"line_number":1107,"context_line":"                - name: Apply paunch config"},{"line_number":1108,"context_line":"                  shell: paunch apply --file /var/lib/tripleo-config/docker-container-startup-config-step_4.json --config-id tripleo_step4"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff570b3c_ad6935bf","line":1105,"range":{"start_line":1102,"start_character":0,"end_line":1105,"end_character":36},"in_reply_to":"ff570b3c_442b162f","updated":"2020-05-28 11:23:34.000000000","message":"If the code gets into this block and there is no docker than it should fail. In any way the \"Check if we need to update the paunch config\" works only on Queens and else it should fail.","commit_id":"debe99ae68e41db859f91cc2b471c670a5ca4222"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"764ecd324ec9029c61748e5e7150ded4d4afcc73","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"                    cat \u003c\u003c\u003c $(jq \u0027.nova_compute.image \u003d \"{{ nova_compute_image }}\"\u0027 \\"},{"line_number":1108,"context_line":"                    /var/lib/tripleo-config/docker-container-startup-config-step_4.json) \u003e\\"},{"line_number":1109,"context_line":"                    /var/lib/tripleo-config/docker-container-startup-config-step_4.json"},{"line_number":1110,"context_line":"                # Nova compute will not work unless we ensure it will not connect against db and use messaging"},{"line_number":1111,"context_line":"                - name: Remove database section from nova_compute config"},{"line_number":1112,"context_line":"                  shell: crudini --del database /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf"},{"line_number":1113,"context_line":"                - name: Remove api_database section from nova_compute config"},{"line_number":1114,"context_line":"                  shell: crudini --del api_database /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf"},{"line_number":1115,"context_line":"                # This code is partial copy of logic in podman installation"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_4c46b451","line":1112,"range":{"start_line":1110,"start_character":15,"end_line":1112,"end_character":117},"updated":"2020-06-18 07:04:00.000000000","message":"so since the local conductor mode was removed 6+ releases ago the database url will not be used to directly connect to the db. having it present in the config is more of a security concen if a guest breaks out of the vm ratehr then a pratical upgrade issue. it should still be removed but you should also remove it form the config generation for all branches.","commit_id":"a97a738d8436440889412fac9e140eca0f162598"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"c4221f0f5eba7bf584163da071eb83f02ecf1f51","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"                    cat \u003c\u003c\u003c $(jq \u0027.nova_compute.image \u003d \"{{ nova_compute_image }}\"\u0027 \\"},{"line_number":1108,"context_line":"                    /var/lib/tripleo-config/docker-container-startup-config-step_4.json) \u003e\\"},{"line_number":1109,"context_line":"                    /var/lib/tripleo-config/docker-container-startup-config-step_4.json"},{"line_number":1110,"context_line":"                # Nova compute will not work unless we ensure it will not connect against db and use messaging"},{"line_number":1111,"context_line":"                - name: Remove database section from nova_compute config"},{"line_number":1112,"context_line":"                  shell: crudini --del database /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf"},{"line_number":1113,"context_line":"                - name: Remove api_database section from nova_compute config"},{"line_number":1114,"context_line":"                  shell: crudini --del api_database /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf"},{"line_number":1115,"context_line":"                # This code is partial copy of logic in podman installation"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_f7be4c63","line":1112,"range":{"start_line":1110,"start_character":15,"end_line":1112,"end_character":117},"in_reply_to":"bf51134e_4c46b451","updated":"2020-06-19 14:48:01.000000000","message":"It\u0027s a WIP https://review.opendev.org/718552.\n\nFor now I think these tasks can be dropped. Just ensure UpgradeLevelNovaCompute is not set to \u0027auto\u0027 as this triggers the check that raises DBNotAllowed exceptions","commit_id":"a97a738d8436440889412fac9e140eca0f162598"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7d7bd62eecdd3484e15ce26873f542675b21af64","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"                    cat \u003c\u003c\u003c $(jq \u0027.nova_compute.image \u003d \"{{ nova_compute_image }}\"\u0027 \\"},{"line_number":1108,"context_line":"                    /var/lib/tripleo-config/docker-container-startup-config-step_4.json) \u003e\\"},{"line_number":1109,"context_line":"                    /var/lib/tripleo-config/docker-container-startup-config-step_4.json"},{"line_number":1110,"context_line":"                # Nova compute will not work unless we ensure it will not connect against db and use messaging"},{"line_number":1111,"context_line":"                - name: Remove database section from nova_compute config"},{"line_number":1112,"context_line":"                  shell: crudini --del database /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf"},{"line_number":1113,"context_line":"                - name: Remove api_database section from nova_compute config"},{"line_number":1114,"context_line":"                  shell: crudini --del api_database /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf"},{"line_number":1115,"context_line":"                # This code is partial copy of logic in podman installation"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_3dcc2560","line":1112,"range":{"start_line":1110,"start_character":15,"end_line":1112,"end_character":117},"in_reply_to":"bf51134e_f7be4c63","updated":"2020-06-19 15:52:19.000000000","message":"Could we rather leave these tasks here (they produce a functional result) and implement improvements in a follow up review instead?","commit_id":"a97a738d8436440889412fac9e140eca0f162598"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"9cffcf7bdb1a8e0159e52f3bb74fa9491551017e","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"                    cat \u003c\u003c\u003c $(jq \u0027.nova_compute.image \u003d \"{{ nova_compute_image }}\"\u0027 \\"},{"line_number":1108,"context_line":"                    /var/lib/tripleo-config/docker-container-startup-config-step_4.json) \u003e\\"},{"line_number":1109,"context_line":"                    /var/lib/tripleo-config/docker-container-startup-config-step_4.json"},{"line_number":1110,"context_line":"                # Nova compute will not work unless we ensure it will not connect against db and use messaging"},{"line_number":1111,"context_line":"                - name: Remove database section from nova_compute config"},{"line_number":1112,"context_line":"                  shell: crudini --del database /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf"},{"line_number":1113,"context_line":"                - name: Remove api_database section from nova_compute config"},{"line_number":1114,"context_line":"                  shell: crudini --del api_database /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf"},{"line_number":1115,"context_line":"                # This code is partial copy of logic in podman installation"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_b4c4b5f6","line":1112,"range":{"start_line":1110,"start_character":15,"end_line":1112,"end_character":117},"in_reply_to":"bf51134e_f7be4c63","updated":"2020-06-22 14:15:14.000000000","message":"In theory that should be ensured by this https://github.com/openstack/tripleo-heat-templates/blob/master/environments/lifecycle/upgrade-prepare.yaml#L13, it\u0027s always prepended in every upgrade.","commit_id":"a97a738d8436440889412fac9e140eca0f162598"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"764ecd324ec9029c61748e5e7150ded4d4afcc73","unresolved":false,"context_lines":[{"line_number":1110,"context_line":"                # Nova compute will not work unless we ensure it will not connect against db and use messaging"},{"line_number":1111,"context_line":"                - name: Remove database section from nova_compute config"},{"line_number":1112,"context_line":"                  shell: crudini --del database /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf"},{"line_number":1113,"context_line":"                - name: Remove api_database section from nova_compute config"},{"line_number":1114,"context_line":"                  shell: crudini --del api_database /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf"},{"line_number":1115,"context_line":"                # This code is partial copy of logic in podman installation"},{"line_number":1116,"context_line":"                - name: Make sure the Undercloud hostname is included in /etc/hosts"},{"line_number":1117,"context_line":"                  when:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_2c6a60b2","line":1114,"range":{"start_line":1113,"start_character":15,"end_line":1114,"end_character":121},"updated":"2020-06-18 07:04:00.000000000","message":"the api db on the other had has never been valid to include on the compute node so if the puppet module is generating this on the compute node its a bug. it can break the compute node by breaking how we do compute service version detection so this does need to be removed.","commit_id":"a97a738d8436440889412fac9e140eca0f162598"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ee209e6ed8506351be397dec0c5a4021e402eae6","unresolved":false,"context_lines":[{"line_number":1133,"context_line":"                - name: Restart docker"},{"line_number":1134,"context_line":"                  service:"},{"line_number":1135,"context_line":"                    name: docker"},{"line_number":1136,"context_line":"                    state: restarted"},{"line_number":1137,"context_line":"                # Finally apply the paunch config to start the new nova_compute"},{"line_number":1138,"context_line":"                - name: Apply paunch config"},{"line_number":1139,"context_line":"                  shell: paunch apply --file /var/lib/tripleo-config/docker-container-startup-config-step_4.json --config-id tripleo_step4"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_1d8665dc","line":1136,"range":{"start_line":1136,"start_character":27,"end_line":1136,"end_character":36},"updated":"2020-06-22 15:25:30.000000000","message":"this restarts all docker containers, I hope that\u0027s expected?","commit_id":"a97a738d8436440889412fac9e140eca0f162598"}]}