)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"9acf0c6d51f705e35a560730bc71436e48f9acee","unresolved":false,"context_lines":[{"line_number":10,"context_line":"on a \"stable\" overcloud using a command like:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"$ openstack overcloud external-upgrade run --tags ceph_fstobs \\"},{"line_number":13,"context_line":"        -e ceph_ansible_playbooks_param\u003d/path/to/playbook.yml"},{"line_number":14,"context_line":"        | tee oc-fstobs.log"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"1. https://github.com/ceph/ceph-ansible/blob/master/infrastructure-playbooks/filestore-to-bluestore.yml"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_ff7eac16","line":13,"updated":"2020-06-05 11:58:58.000000000","message":"alternatively I could add a task to set filestore-to-bluestore playbook in tht directly so the user doesn\u0027t have to pass it manually","commit_id":"c262ef352a1b82949a25dfea7d85cb25ab923e11"}],"deployment/ceph-ansible/ceph-base.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c0a98578dd025a6ecfc6bfefff898a3abfff8058","unresolved":false,"context_lines":[{"line_number":691,"context_line":"            - never"},{"line_number":692,"context_line":"            - ceph_fstobs"},{"line_number":693,"context_line":"          block:"},{"line_number":694,"context_line":"            - name: set ceph_ansible_playbooks_default"},{"line_number":695,"context_line":"              set_fact:"},{"line_number":696,"context_line":"                ceph_ansible_playbooks_default: [\"/usr/share/ceph-ansible/infrastructure-playbooks/filestore-to-bluestore.yml\"]"},{"line_number":697,"context_line":"        - when: step|int \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff570b3c_7f9f3901","line":694,"updated":"2020-06-05 14:51:46.000000000","message":"we probably need to check for use of --limit here too judging from [1]\n\n1. https://github.com/ceph/ceph-ansible/blob/master/infrastructure-playbooks/filestore-to-bluestore.yml#L4","commit_id":"1928302907452ad6f614af070fa1a8c5169f9adf"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"32df117182e6af21b1119e8417d6f85b349c0c40","unresolved":false,"context_lines":[{"line_number":691,"context_line":"            - never"},{"line_number":692,"context_line":"            - ceph_fstobs"},{"line_number":693,"context_line":"          block:"},{"line_number":694,"context_line":"            - name: set ceph_ansible_playbooks_default"},{"line_number":695,"context_line":"              set_fact:"},{"line_number":696,"context_line":"                ceph_ansible_playbooks_default: [\"/usr/share/ceph-ansible/infrastructure-playbooks/filestore-to-bluestore.yml\"]"},{"line_number":697,"context_line":"        - when: step|int \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff570b3c_91595c8f","line":694,"in_reply_to":"ff570b3c_7f9f3901","updated":"2020-06-05 20:35:37.000000000","message":"have to do this","commit_id":"1928302907452ad6f614af070fa1a8c5169f9adf"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"357628839a4d9e458dcbec8b5496f555e79d33a4","unresolved":false,"context_lines":[{"line_number":688,"context_line":"                ceph_ansible_playbooks_default: [\"/usr/share/ceph-ansible/infrastructure-playbooks/docker-to-podman.yml\"]"},{"line_number":689,"context_line":"        - when: step|int \u003d\u003d 0"},{"line_number":690,"context_line":"          tags:"},{"line_number":691,"context_line":"            - never"},{"line_number":692,"context_line":"            - ceph_fstobs"},{"line_number":693,"context_line":"          block:"},{"line_number":694,"context_line":"            - name: stop if _limit is unset"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_bedfcfd4","line":691,"range":{"start_line":691,"start_character":14,"end_line":691,"end_character":19},"updated":"2020-06-10 13:11:32.000000000","message":"k, i had to go looking for that one https://docs.ansible.com/ansible/latest/user_guide/playbooks_tags.html\n\nso why is that one special? I mean, if you specify ceph_fstobs OR \u0027never\u0027 it will be executed.\n\nso i guess there is a case where you won\u0027t be using \u0027fstobs\u0027 but you will be using \u0027never\u0027?","commit_id":"1fdfe54ccf2a17fa74fa45c8c93830772c1fcd2c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ac3a2d51fe0730593574225e2358dd18a14e005b","unresolved":false,"context_lines":[{"line_number":688,"context_line":"                ceph_ansible_playbooks_default: [\"/usr/share/ceph-ansible/infrastructure-playbooks/docker-to-podman.yml\"]"},{"line_number":689,"context_line":"        - when: step|int \u003d\u003d 0"},{"line_number":690,"context_line":"          tags:"},{"line_number":691,"context_line":"            - never"},{"line_number":692,"context_line":"            - ceph_fstobs"},{"line_number":693,"context_line":"          block:"},{"line_number":694,"context_line":"            - name: stop if _limit is unset"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_2e5f0a73","line":691,"range":{"start_line":691,"start_character":14,"end_line":691,"end_character":19},"in_reply_to":"ff570b3c_ae45da45","updated":"2020-06-10 14:55:46.000000000","message":"17:51 \u003cgfidente\u003e unless one of the other tags is explicitly requested\n17:51 \u003cgfidente\u003e so if you run\n17:51 \u003cgfidente\u003e ansible-playbook myplay.yml they don\u0027t run, even if the condition in the block is true\n17:51 \u003cgfidente\u003e they only run if you do\n17:51 \u003cgfidente\u003e ansible-playbook --tags ceph_fstobs\n17:52 \u003cmarios\u003e ah ok now i get it thanks... so even if you don\u0027t specify fstobs, it would run\n17:52 \u003cmarios\u003e but never stops that\n17:53 \u003cgfidente\u003e esxactly\n17:53 \u003cmarios\u003e k thanks","commit_id":"1fdfe54ccf2a17fa74fa45c8c93830772c1fcd2c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"253900113b320fab7a83b752b5d1f6a95f9e4deb","unresolved":false,"context_lines":[{"line_number":688,"context_line":"                ceph_ansible_playbooks_default: [\"/usr/share/ceph-ansible/infrastructure-playbooks/docker-to-podman.yml\"]"},{"line_number":689,"context_line":"        - when: step|int \u003d\u003d 0"},{"line_number":690,"context_line":"          tags:"},{"line_number":691,"context_line":"            - never"},{"line_number":692,"context_line":"            - ceph_fstobs"},{"line_number":693,"context_line":"          block:"},{"line_number":694,"context_line":"            - name: stop if _limit is unset"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_f92a017c","line":691,"range":{"start_line":691,"start_character":14,"end_line":691,"end_character":19},"in_reply_to":"ff570b3c_bedfcfd4","updated":"2020-06-10 13:41:51.000000000","message":"never has a special meaning, it basically will cause regular ansible-playbook runs to skip these tasks, unless ceph_fstobs is explicitly requested ... goal in this case is to run these tasks only when ceph_fstobs is wanted","commit_id":"1fdfe54ccf2a17fa74fa45c8c93830772c1fcd2c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"19a0937ee5ee16e1d73cb908141c6e5b419640a0","unresolved":false,"context_lines":[{"line_number":688,"context_line":"                ceph_ansible_playbooks_default: [\"/usr/share/ceph-ansible/infrastructure-playbooks/docker-to-podman.yml\"]"},{"line_number":689,"context_line":"        - when: step|int \u003d\u003d 0"},{"line_number":690,"context_line":"          tags:"},{"line_number":691,"context_line":"            - never"},{"line_number":692,"context_line":"            - ceph_fstobs"},{"line_number":693,"context_line":"          block:"},{"line_number":694,"context_line":"            - name: stop if _limit is unset"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_ae45da45","line":691,"range":{"start_line":691,"start_character":14,"end_line":691,"end_character":19},"in_reply_to":"ff570b3c_f92a017c","updated":"2020-06-10 14:28:58.000000000","message":"right... but that was my question. why is fstobs only not enough? why do you need never as well?\n\nthe only case i can think of is what i wrote above... is there a case that you won\u0027t specify fstobs, but you still want this bit to run, and will specify never? otherwise remove it?","commit_id":"1fdfe54ccf2a17fa74fa45c8c93830772c1fcd2c"}]}