)]}'
{"docker/services/nova-api.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"118646c0d9c96907f918a5e9777b47a01260b449","unresolved":false,"context_lines":[{"line_number":430,"context_line":"            - name: Setup cell_v2 (create default cell)"},{"line_number":431,"context_line":"              # (owalsh) puppet-nova expects the cell name \u0027default\u0027"},{"line_number":432,"context_line":"              # (owalsh) pass the db uri explicitly to avoid https://bugs.launchpad.net/tripleo/+bug/1662344"},{"line_number":433,"context_line":"              shell: nova-manage cell_v2 create_cell --name\u003d\u0027default\u0027 --database_connection\u003d$(hiera nova::database_connection)"},{"line_number":434,"context_line":"              register: nova_api_create_cell"},{"line_number":435,"context_line":"              failed_when: nova_api_create_cell.rc not in [0,2]"},{"line_number":436,"context_line":"              changed_when: nova_api_create_cell.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_c82ae22a","side":"PARENT","line":433,"range":{"start_line":433,"start_character":94,"end_line":433,"end_character":99},"updated":"2020-06-09 09:26:57.000000000","message":"AFAIK if we wanted to do this we would need to tell hiera to use the puppet hiera config (/etc/puppet/heira.yaml)... but how did this ever work? Perhaps we previously configured hiera to lookup the puppet hieradata by default.\n\nIn any case the hieradata doesn\u0027t appear to be updated when this runs, so best to take it directly from nova-base, as we do for CELL0.","commit_id":"c0267e0c35ffd05ea166886608db66e430a2f725"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"bf78fb47361b55aa06b331d7485cb4ddecdf5db8","unresolved":false,"context_lines":[{"line_number":430,"context_line":"            - name: Setup cell_v2 (create default cell)"},{"line_number":431,"context_line":"              # (owalsh) puppet-nova expects the cell name \u0027default\u0027"},{"line_number":432,"context_line":"              # (owalsh) pass the db uri explicitly to avoid https://bugs.launchpad.net/tripleo/+bug/1662344"},{"line_number":433,"context_line":"              shell: nova-manage cell_v2 create_cell --name\u003d\u0027default\u0027 --database_connection\u003d$(hiera nova::database_connection)"},{"line_number":434,"context_line":"              register: nova_api_create_cell"},{"line_number":435,"context_line":"              failed_when: nova_api_create_cell.rc not in [0,2]"},{"line_number":436,"context_line":"              changed_when: nova_api_create_cell.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_08ca1a6d","side":"PARENT","line":433,"range":{"start_line":433,"start_character":94,"end_line":433,"end_character":99},"in_reply_to":"ff570b3c_c82ae22a","updated":"2020-06-09 09:29:04.000000000","message":"FWIW it\u0027s been this way for a long time https://review.opendev.org/405241","commit_id":"c0267e0c35ffd05ea166886608db66e430a2f725"}],"puppet/services/nova-api.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"118646c0d9c96907f918a5e9777b47a01260b449","unresolved":false,"context_lines":[{"line_number":284,"context_line":"              when:"},{"line_number":285,"context_line":"                - step|int \u003d\u003d 5"},{"line_number":286,"context_line":"                - is_bootstrap_node|bool"},{"line_number":287,"context_line":"              shell: nova-manage cell_v2 map_cell0 --database_connection\u003d$(hiera nova::cell0_database_connection)"},{"line_number":288,"context_line":"            - name: Setup cell_v2 (create default cell)"},{"line_number":289,"context_line":"              when:"},{"line_number":290,"context_line":"                - step|int \u003d\u003d 5"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_68b63641","line":287,"range":{"start_line":287,"start_character":75,"end_line":287,"end_character":112},"updated":"2020-06-09 09:26:57.000000000","message":"should fix it here too","commit_id":"1fa381c80e400177ce18206584722bc2553f7d6f"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"0ef2cba264c666ee5c60d474cc3f40d4d82b13f5","unresolved":true,"context_lines":[{"line_number":288,"context_line":"                str_replace:"},{"line_number":289,"context_line":"                  template: nova-manage cell_v2 map_cell0 --database_connection\u003d\u0027CELL\u0027"},{"line_number":290,"context_line":"                  params:"},{"line_number":291,"context_line":"                    CELL: {get_attr: [NovaApiBase, role_data, config_settings, \"nova::cell0_database_connection\"]}"},{"line_number":292,"context_line":"            - name: Setup cell_v2 (create default cell)"},{"line_number":293,"context_line":"              when:"},{"line_number":294,"context_line":"                - step|int \u003d\u003d 5"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"efc87206_cf2b3537","line":291,"range":{"start_line":291,"start_character":38,"end_line":291,"end_character":49},"updated":"2021-01-05 11:28:31.000000000","message":"doesn\u0027t exist, should that be NovaBase?","commit_id":"093a1cca273bf3e369dc502c22a7be7e6b33d752"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"6e8c725febdf2ebf44c4084200d083e4af1e6ecb","unresolved":true,"context_lines":[{"line_number":288,"context_line":"                str_replace:"},{"line_number":289,"context_line":"                  template: nova-manage cell_v2 map_cell0 --database_connection\u003d\u0027CELL\u0027"},{"line_number":290,"context_line":"                  params:"},{"line_number":291,"context_line":"                    CELL: {get_attr: [NovaApiBase, role_data, config_settings, \"nova::cell0_database_connection\"]}"},{"line_number":292,"context_line":"            - name: Setup cell_v2 (create default cell)"},{"line_number":293,"context_line":"              when:"},{"line_number":294,"context_line":"                - step|int \u003d\u003d 5"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1ea06b6b_8f0f3425","line":291,"range":{"start_line":291,"start_character":38,"end_line":291,"end_character":49},"in_reply_to":"efc87206_cf2b3537","updated":"2021-01-05 11:44:06.000000000","message":"yes indeed","commit_id":"093a1cca273bf3e369dc502c22a7be7e6b33d752"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"0ef2cba264c666ee5c60d474cc3f40d4d82b13f5","unresolved":true,"context_lines":[{"line_number":299,"context_line":"                str_replace:"},{"line_number":300,"context_line":"                  template: nova-manage cell_v2 create_cell --name\u003d\u0027default\u0027 --database_connection\u003d\u0027CELL\u0027"},{"line_number":301,"context_line":"                  params:"},{"line_number":302,"context_line":"                    CELL: {get_attr: [NovaApiBase, role_data, config_settings, \"nova::database_connection\"]}"},{"line_number":303,"context_line":"              register: nova_api_create_cell"},{"line_number":304,"context_line":"              failed_when: nova_api_create_cell.rc not in [0,2]"},{"line_number":305,"context_line":"              changed_when: nova_api_create_cell.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c64a2ffb_277e1c4a","line":302,"range":{"start_line":302,"start_character":38,"end_line":302,"end_character":49},"updated":"2021-01-05 11:28:31.000000000","message":"doesn\u0027t exist, should that be NovaBase?","commit_id":"093a1cca273bf3e369dc502c22a7be7e6b33d752"}]}