)]}'
{"common/deploy-steps.j2":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2494672af8271f8f85f50d22d046a44b0d5fbbca","unresolved":false,"context_lines":[{"line_number":671,"context_line":"              tasks:"},{"line_number":672,"context_line":"{%- for role in roles %}"},{"line_number":673,"context_line":"                - name: {{role.name}} Host prep block"},{"line_number":674,"context_line":"                  when:"},{"line_number":675,"context_line":"                    - tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"},{"line_number":676,"context_line":"                  block:"},{"line_number":677,"context_line":"                    - name: {{role.name}} Host prep steps"},{"line_number":678,"context_line":"                      delegate_to: localhost"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff570b3c_4d3ecbda","line":675,"range":{"start_line":674,"start_character":1,"end_line":675,"end_character":58},"updated":"2020-06-10 10:18:44.000000000","message":"doesn\u0027t that result in even more tasks skipped?","commit_id":"b9524377f5068dcfebba6f18827f4d33731f49cf"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"26e7b6ac7bbd4e5c0daabbf592a4946aa62434e1","unresolved":false,"context_lines":[{"line_number":671,"context_line":"              tasks:"},{"line_number":672,"context_line":"{%- for role in roles %}"},{"line_number":673,"context_line":"                - name: {{role.name}} Host prep block"},{"line_number":674,"context_line":"                  when:"},{"line_number":675,"context_line":"                    - tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"},{"line_number":676,"context_line":"                  block:"},{"line_number":677,"context_line":"                    - name: {{role.name}} Host prep steps"},{"line_number":678,"context_line":"                      delegate_to: localhost"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff570b3c_b999a97a","line":675,"range":{"start_line":674,"start_character":1,"end_line":675,"end_character":58},"in_reply_to":"ff570b3c_4d3ecbda","updated":"2020-06-10 13:35:08.000000000","message":"No because of include tasks","commit_id":"b9524377f5068dcfebba6f18827f4d33731f49cf"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2cbde366aed0e7ef946df639d4c567f99a776118","unresolved":false,"context_lines":[{"line_number":679,"context_line":"                      run_once: true"},{"line_number":680,"context_line":"                      debug:"},{"line_number":681,"context_line":"                        msg: Use --start-at-task \u0027{{role.name}} Host prep steps\u0027 to resume from this task"},{"line_number":682,"context_line":"                    - include_tasks: {{role.name}}/host_prep_tasks.yaml"},{"line_number":683,"context_line":"{%- endfor %}"},{"line_number":684,"context_line":"              tags:"},{"line_number":685,"context_line":"                - overcloud"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff570b3c_4d17eb52","line":682,"range":{"start_line":682,"start_character":22,"end_line":682,"end_character":35},"updated":"2020-06-10 10:21:05.000000000","message":"changing this from static to dynamic impact may have an unexpected behavioral results, like tags or start-at-task stopping working? or changing the way included tasks evaluated to get skipped?\n\nthis looks a quite intrusive change and should be carefully tested and measured for the deplyment time changes. Please open a bug for tracking this and provide the measurements results.","commit_id":"b9524377f5068dcfebba6f18827f4d33731f49cf"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6e2fcb9f33db3afb8832b530d895b670915a5f97","unresolved":false,"context_lines":[{"line_number":679,"context_line":"                      run_once: true"},{"line_number":680,"context_line":"                      debug:"},{"line_number":681,"context_line":"                        msg: Use --start-at-task \u0027{{role.name}} Host prep steps\u0027 to resume from this task"},{"line_number":682,"context_line":"                    - include_tasks: {{role.name}}/host_prep_tasks.yaml"},{"line_number":683,"context_line":"{%- endfor %}"},{"line_number":684,"context_line":"              tags:"},{"line_number":685,"context_line":"                - overcloud"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff570b3c_7f67eeeb","line":682,"range":{"start_line":682,"start_character":22,"end_line":682,"end_character":35},"in_reply_to":"ff570b3c_04182582","updated":"2020-06-10 16:41:56.000000000","message":"we can switch it back if we find this useful, however i think we need to re-evaluate the use of tags and --start-at-task because none of it is tested (and is clearly broken)","commit_id":"b9524377f5068dcfebba6f18827f4d33731f49cf"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"08949eb1ce928640872daa37fbedcc1422562dc4","unresolved":false,"context_lines":[{"line_number":679,"context_line":"                      run_once: true"},{"line_number":680,"context_line":"                      debug:"},{"line_number":681,"context_line":"                        msg: Use --start-at-task \u0027{{role.name}} Host prep steps\u0027 to resume from this task"},{"line_number":682,"context_line":"                    - include_tasks: {{role.name}}/host_prep_tasks.yaml"},{"line_number":683,"context_line":"{%- endfor %}"},{"line_number":684,"context_line":"              tags:"},{"line_number":685,"context_line":"                - overcloud"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff570b3c_04182582","line":682,"range":{"start_line":682,"start_character":22,"end_line":682,"end_character":35},"in_reply_to":"ff570b3c_0bc5d80a","updated":"2020-06-10 16:35:43.000000000","message":"If we want tags inside these tasks to be executable, then we need to add the \u0027always\u0027 tag to this include_tasks task. See https://odyssey4.me/2019/11/26/ansible-include-tags.html for a bit more of an explanation.","commit_id":"b9524377f5068dcfebba6f18827f4d33731f49cf"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9d54ca80a4f016be8ee0543d49cfe4725bb9492f","unresolved":false,"context_lines":[{"line_number":679,"context_line":"                      run_once: true"},{"line_number":680,"context_line":"                      debug:"},{"line_number":681,"context_line":"                        msg: Use --start-at-task \u0027{{role.name}} Host prep steps\u0027 to resume from this task"},{"line_number":682,"context_line":"                    - include_tasks: {{role.name}}/host_prep_tasks.yaml"},{"line_number":683,"context_line":"{%- endfor %}"},{"line_number":684,"context_line":"              tags:"},{"line_number":685,"context_line":"                - overcloud"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff570b3c_0bc5d80a","line":682,"range":{"start_line":682,"start_character":22,"end_line":682,"end_character":35},"in_reply_to":"ff570b3c_198d352a","updated":"2020-06-10 14:21:32.000000000","message":"for the record, this actually doesn\u0027t work today (this one) because tripleo_firewall fails hard if facts weren\u0027t gathered which wouldn\u0027t occur using --start-at-task.  I tested it after fixing tripleo_firewall and it works fine (tm)","commit_id":"b9524377f5068dcfebba6f18827f4d33731f49cf"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"26e7b6ac7bbd4e5c0daabbf592a4946aa62434e1","unresolved":false,"context_lines":[{"line_number":679,"context_line":"                      run_once: true"},{"line_number":680,"context_line":"                      debug:"},{"line_number":681,"context_line":"                        msg: Use --start-at-task \u0027{{role.name}} Host prep steps\u0027 to resume from this task"},{"line_number":682,"context_line":"                    - include_tasks: {{role.name}}/host_prep_tasks.yaml"},{"line_number":683,"context_line":"{%- endfor %}"},{"line_number":684,"context_line":"              tags:"},{"line_number":685,"context_line":"                - overcloud"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff570b3c_198d352a","line":682,"range":{"start_line":682,"start_character":22,"end_line":682,"end_character":35},"in_reply_to":"ff570b3c_4d17eb52","updated":"2020-06-10 13:35:08.000000000","message":"It shouldn\u0027t because start at tasks is defined before this and not in this task file.  Additionally switching to include tasks causes none of the tasks in here to be processed vs always importing the task list.","commit_id":"b9524377f5068dcfebba6f18827f4d33731f49cf"}]}