)]}'
{"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"08841cbc43b206ae607e1ed785633114a871da16","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                  - puppet-tripleo"},{"line_number":234,"context_line":"                  - python3-heat-agent*"},{"line_number":235,"context_line":"                  - rsync"},{"line_number":236,"context_line":"                  - ceph-common"},{"line_number":237,"context_line":"                state: present"},{"line_number":238,"context_line":"              when: ansible_distribution_major_version \u003d\u003d \u00278\u0027"},{"line_number":239,"context_line":"        # With the layered product packaging, the key package is rhosp-openvswitch. It depends on"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_61a913dc","line":236,"range":{"start_line":236,"start_character":20,"end_line":236,"end_character":31},"updated":"2020-06-10 15:11:07.000000000","message":"also ceph-common shouldn\u0027t be a hard requirement?","commit_id":"ca6fa6a2cd1d5dea296fb718e953fe0c57bbb079"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"59779ec58c4ed5fcb911f0f508c5d3c85ba3bb8e","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            - name: Ensure TripleO prerequisite packages are installed"},{"line_number":224,"context_line":"              package:"},{"line_number":225,"context_line":"                name:"},{"line_number":226,"context_line":"                  - jq"},{"line_number":227,"context_line":"                  - lvm2"},{"line_number":228,"context_line":"                  - net-snmp"},{"line_number":229,"context_line":"                  - openstack-selinux"},{"line_number":230,"context_line":"                  - os-net-config"},{"line_number":231,"context_line":"                  - pacemaker"},{"line_number":232,"context_line":"                  - pcs"},{"line_number":233,"context_line":"                  - puppet-tripleo"},{"line_number":234,"context_line":"                  - python3-heat-agent*"},{"line_number":235,"context_line":"                  - rsync"},{"line_number":236,"context_line":"                  - ceph-common"},{"line_number":237,"context_line":"                state: present"},{"line_number":238,"context_line":"              when: ansible_distribution_major_version \u003d\u003d \u00278\u0027"},{"line_number":239,"context_line":"        # With the layered product packaging, the key package is rhosp-openvswitch. It depends on"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_014bf75e","line":236,"range":{"start_line":226,"start_character":0,"end_line":236,"end_character":31},"updated":"2020-06-10 15:07:07.000000000","message":"this list isn\u0027t in sync with https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_bootstrap/vars/redhat-8.yml which is supposed to be handling the required packages during a deployment.\nAlso, I think it\u0027s a wrong assumption to install ceph by default since it is not enabled by default.","commit_id":"ca6fa6a2cd1d5dea296fb718e953fe0c57bbb079"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"9d9dd466e4d7a407d22f29c8e8ea690a49733c79","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            - name: Ensure TripleO prerequisite packages are installed"},{"line_number":224,"context_line":"              package:"},{"line_number":225,"context_line":"                name:"},{"line_number":226,"context_line":"                  - jq"},{"line_number":227,"context_line":"                  - lvm2"},{"line_number":228,"context_line":"                  - net-snmp"},{"line_number":229,"context_line":"                  - openstack-selinux"},{"line_number":230,"context_line":"                  - os-net-config"},{"line_number":231,"context_line":"                  - pacemaker"},{"line_number":232,"context_line":"                  - pcs"},{"line_number":233,"context_line":"                  - puppet-tripleo"},{"line_number":234,"context_line":"                  - python3-heat-agent*"},{"line_number":235,"context_line":"                  - rsync"},{"line_number":236,"context_line":"                  - ceph-common"},{"line_number":237,"context_line":"                state: present"},{"line_number":238,"context_line":"              when: ansible_distribution_major_version \u003d\u003d \u00278\u0027"},{"line_number":239,"context_line":"        # With the layered product packaging, the key package is rhosp-openvswitch. It depends on"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_fa766c0c","line":236,"range":{"start_line":226,"start_character":0,"end_line":236,"end_character":31},"in_reply_to":"ff570b3c_014bf75e","updated":"2020-06-10 17:43:25.000000000","message":"Well we can add packages here but we kinda have some things present and rest we do based on what we had issues/requirements post leapp. These two don\u0027t necessarily have to be in sync.","commit_id":"ca6fa6a2cd1d5dea296fb718e953fe0c57bbb079"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"8e546d6f6118216dd02fbdea8b7e7a42de5e96ce","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                  - puppet-tripleo"},{"line_number":234,"context_line":"                  - python3-heat-agent*"},{"line_number":235,"context_line":"                  - rsync"},{"line_number":236,"context_line":"                  - ceph-common"},{"line_number":237,"context_line":"                state: present"},{"line_number":238,"context_line":"              when: ansible_distribution_major_version \u003d\u003d \u00278\u0027"},{"line_number":239,"context_line":"        # With the layered product packaging, the key package is rhosp-openvswitch. It depends on"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_8296d7ee","line":236,"range":{"start_line":236,"start_character":20,"end_line":236,"end_character":31},"in_reply_to":"ff570b3c_5aacb834","updated":"2020-06-11 12:08:01.000000000","message":"What about to add the ceph requirements in the ceph-base upgrade_tasks for step\u003d0? that wuold make sure it gets installed only on ceph-enabled environments: https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/ceph-ansible/ceph-base.yaml#L555","commit_id":"ca6fa6a2cd1d5dea296fb718e953fe0c57bbb079"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"9d9dd466e4d7a407d22f29c8e8ea690a49733c79","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                  - puppet-tripleo"},{"line_number":234,"context_line":"                  - python3-heat-agent*"},{"line_number":235,"context_line":"                  - rsync"},{"line_number":236,"context_line":"                  - ceph-common"},{"line_number":237,"context_line":"                state: present"},{"line_number":238,"context_line":"              when: ansible_distribution_major_version \u003d\u003d \u00278\u0027"},{"line_number":239,"context_line":"        # With the layered product packaging, the key package is rhosp-openvswitch. It depends on"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_9a43f0af","line":236,"range":{"start_line":236,"start_character":20,"end_line":236,"end_character":31},"in_reply_to":"ff570b3c_61a913dc","updated":"2020-06-10 17:43:25.000000000","message":"\u003e also ceph-common shouldn\u0027t be a hard requirement?\n\nPlease check commit message - we removed ceph-common in very hackish way to get things moving and without readding it it stays broken.","commit_id":"ca6fa6a2cd1d5dea296fb718e953fe0c57bbb079"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b4a9be60e120d7edfe7c89b5d38ceed07921585b","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                  - puppet-tripleo"},{"line_number":234,"context_line":"                  - python3-heat-agent*"},{"line_number":235,"context_line":"                  - rsync"},{"line_number":236,"context_line":"                  - ceph-common"},{"line_number":237,"context_line":"                state: present"},{"line_number":238,"context_line":"              when: ansible_distribution_major_version \u003d\u003d \u00278\u0027"},{"line_number":239,"context_line":"        # With the layered product packaging, the key package is rhosp-openvswitch. It depends on"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_d89a8260","line":236,"range":{"start_line":236,"start_character":20,"end_line":236,"end_character":31},"in_reply_to":"ff570b3c_8296d7ee","updated":"2020-06-11 13:23:12.000000000","message":"yes that would be a better solution","commit_id":"ca6fa6a2cd1d5dea296fb718e953fe0c57bbb079"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ff86935e721160b9c6bd3482dc86cdb503502bc5","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                  - puppet-tripleo"},{"line_number":234,"context_line":"                  - python3-heat-agent*"},{"line_number":235,"context_line":"                  - rsync"},{"line_number":236,"context_line":"                  - ceph-common"},{"line_number":237,"context_line":"                state: present"},{"line_number":238,"context_line":"              when: ansible_distribution_major_version \u003d\u003d \u00278\u0027"},{"line_number":239,"context_line":"        # With the layered product packaging, the key package is rhosp-openvswitch. It depends on"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_5aacb834","line":236,"range":{"start_line":236,"start_character":20,"end_line":236,"end_character":31},"in_reply_to":"ff570b3c_9a43f0af","updated":"2020-06-10 17:51:40.000000000","message":"I don\u0027t think it is correct to add it back here. It\u0027s not something that should be there 100% of the time.","commit_id":"ca6fa6a2cd1d5dea296fb718e953fe0c57bbb079"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"837752d206495274ed5e6e2a5efd6a7f2b0f78af","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                  - puppet-tripleo"},{"line_number":234,"context_line":"                  - python3-heat-agent*"},{"line_number":235,"context_line":"                  - rsync"},{"line_number":236,"context_line":"                  - ceph-common"},{"line_number":237,"context_line":"                state: present"},{"line_number":238,"context_line":"              when: ansible_distribution_major_version \u003d\u003d \u00278\u0027"},{"line_number":239,"context_line":"        # With the layered product packaging, the key package is rhosp-openvswitch. It depends on"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_f812e661","line":236,"range":{"start_line":236,"start_character":20,"end_line":236,"end_character":31},"in_reply_to":"ff570b3c_d89a8260","updated":"2020-06-11 13:38:41.000000000","message":"I thought the package is by default in the image which means we should remove it\u0026\u0026add it back on same place in the common packaging hacks area.","commit_id":"ca6fa6a2cd1d5dea296fb718e953fe0c57bbb079"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a20ec3f76e7adc6eff3f668ac58c2abf3388acf6","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                  - puppet-tripleo"},{"line_number":234,"context_line":"                  - python3-heat-agent*"},{"line_number":235,"context_line":"                  - rsync"},{"line_number":236,"context_line":"                  - ceph-common"},{"line_number":237,"context_line":"                state: present"},{"line_number":238,"context_line":"              when: ansible_distribution_major_version \u003d\u003d \u00278\u0027"},{"line_number":239,"context_line":"        # With the layered product packaging, the key package is rhosp-openvswitch. It depends on"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_b3e7ef46","line":236,"range":{"start_line":236,"start_character":20,"end_line":236,"end_character":31},"in_reply_to":"ff570b3c_f812e661","updated":"2020-06-11 13:45:10.000000000","message":"which would be fine, except this is shared with the undercloud. so it\u0027s not the correct place to manage that","commit_id":"ca6fa6a2cd1d5dea296fb718e953fe0c57bbb079"}]}