)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"fac24475d93f8014b2385a63e140347e198361bc","unresolved":false,"context_lines":[{"line_number":19,"context_line":"LeappRepoInitCommand: |"},{"line_number":20,"context_line":"  subscription-manager repos --enable rhel-7-server-rpms"},{"line_number":21,"context_line":"  subscription-manager repos --enable rhel-7-server-extras-rpms"},{"line_number":22,"context_line":"LeappInitCommand: |"},{"line_number":23,"context_line":"  sudo curl -4ksSL -o /etc/leapp/files/pes-events.json https://example.com/pes-events.json"},{"line_number":24,"context_line":"  sudo curl -4ksSL -o /etc/leapp/files/repomap.csv https://example.com/repomap.csv"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"[1] - https://access.redhat.com/articles/3664871"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf51134e_4c1aa316","line":24,"range":{"start_line":22,"start_character":0,"end_line":24,"end_character":82},"updated":"2020-06-26 11:46:05.000000000","message":"Is this still necessary with the file copy process?","commit_id":"f1099957f3f59f582e3d61f583a63f4824595be2"}],"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c82996a5151d131d462a902e232d38f0575377ad","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                list_join:"},{"line_number":260,"context_line":"                  - \u0027\u0027"},{"line_number":261,"context_line":"                  - - \"#!/bin/bash\\n\\n\""},{"line_number":262,"context_line":"                    - \"if [[ -f /etc/resolv.conf.save ]] ; then rm /etc/resolv.conf.save; fi\\n\\n\""},{"line_number":263,"context_line":"                    - {get_param: UpgradeInitCommand}"},{"line_number":264,"context_line":"            - name: Run UpgradeInitCommonCommand"},{"line_number":265,"context_line":"              shell:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_5ba5e103","side":"PARENT","line":262,"updated":"2020-06-17 10:09:16.000000000","message":"Why remove this? It appears unrelated to me.","commit_id":"abf6c28cfacf0287a0aeaad5ba58c19bdd3d15cc"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c82996a5151d131d462a902e232d38f0575377ad","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                -python2-requests"},{"line_number":209,"context_line":"                -python2-six"},{"line_number":210,"context_line":"                -python2-urllib3"},{"line_number":211,"context_line":"            - name: Run LeappRepoInitCommand"},{"line_number":212,"context_line":"              shell:"},{"line_number":213,"context_line":"                list_join:"},{"line_number":214,"context_line":"                  - \u0027\u0027"},{"line_number":215,"context_line":"                  - - \"#!/bin/bash\\n\\n\""},{"line_number":216,"context_line":"                    - {get_param: LeappRepoInitCommand}"},{"line_number":217,"context_line":"            - name: install leapp"},{"line_number":218,"context_line":"              package:"},{"line_number":219,"context_line":"                name: leapp"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_fb3b1599","line":216,"range":{"start_line":211,"start_character":0,"end_line":216,"end_character":55},"updated":"2020-06-17 10:09:16.000000000","message":"This is fine, but we could do this differently - we need to decide what the interface is we prefer? A shell script is infinitely flexible, but very clumsy.\n\nWe could, instead, have a parameter something like \u0027LeappRepoType\u0027 with the values [\u0027subscription\u0027, \u0027satellite\u0027, \u0027custom\u0027] or something like that.\n\n\u0027subscription\u0027 would use ansible tasks to make use of subscription manager (not shell tasks) to setup and enable the repo.\n\n\u0027satellite\u0027 would do the appropriate things for satellite.\n\n\u0027custom\u0027 could be a bash script for alternative (CI?) methods.\n\nAny thoughts on that idea?","commit_id":"be17c5a168ea56c93915079b84b77e4fc2147fd7"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c82996a5151d131d462a902e232d38f0575377ad","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                list_join:"},{"line_number":224,"context_line":"                  - \u0027\u0027"},{"line_number":225,"context_line":"                  - - \"#!/bin/bash\\n\\n\""},{"line_number":226,"context_line":"                    - {get_param: LeappInitCommand}"},{"line_number":227,"context_line":"            - name: \"add packages into Leapp\u0027s to_remove file\""},{"line_number":228,"context_line":"              vars:"},{"line_number":229,"context_line":"                pkg_to_remove: { get_param: UpgradeLeappToRemove }"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_db91f19b","line":226,"updated":"2020-06-17 10:09:16.000000000","message":"This is fine, but we could do this differently - we need to decide what the interface is we prefer? A shell script is infinitely flexible, but very clumsy.\n\nWe could, instead, have a path here to the location on the undercloud where the leapp files will be - eg: /etc/leapp/files\n\nWe could then use an ansible task to create the folder on the target and copy the files there.\n\nThis would be more restrictive in the implementation, but reduces the barrier to entry because no-one needs to setup a web server.\n\nAny thoughts on that idea?","commit_id":"be17c5a168ea56c93915079b84b77e4fc2147fd7"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"fac24475d93f8014b2385a63e140347e198361bc","unresolved":false,"context_lines":[{"line_number":90,"context_line":"      Command or script snippet to run on all overcloud nodes to"},{"line_number":91,"context_line":"      initialize the Leapp process. E.g. a repository switch."},{"line_number":92,"context_line":"    default: \u0027\u0027"},{"line_number":93,"context_line":"  LeappInitCommand:"},{"line_number":94,"context_line":"    type: string"},{"line_number":95,"context_line":"    description: |"},{"line_number":96,"context_line":"      Command or script snippet to run on all overcloud nodes to"},{"line_number":97,"context_line":"      deliver data files required by Leapp utility and perform"},{"line_number":98,"context_line":"      any extra Leapp configuration required by the utility."},{"line_number":99,"context_line":"      See https://access.redhat.com/articles/3664871"},{"line_number":100,"context_line":"      Example:"},{"line_number":101,"context_line":"        LeappInitCommand: |"},{"line_number":102,"context_line":"          sudo curl -4ksSL -o /etc/leapp/files/pes-events.json https://example.com/pes-events.json"},{"line_number":103,"context_line":"          sudo curl -4ksSL -o /etc/leapp/files/repomap.csv https://example.com/repomap.csv"},{"line_number":104,"context_line":"    default: \u0027\u0027"},{"line_number":105,"context_line":"  UpgradeInitCommand:"},{"line_number":106,"context_line":"    type: string"},{"line_number":107,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_ccdb534c","line":104,"range":{"start_line":93,"start_character":0,"end_line":104,"end_character":15},"updated":"2020-06-26 11:46:05.000000000","message":"Is there still a need for this with the file copy process?\n\nIf this remains useful in some way - should the file copy and this be mutually exclusive, or should they both be used.","commit_id":"f1099957f3f59f582e3d61f583a63f4824595be2"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"eecc4f598730453b8729be9ffa14e5d0c5216f5b","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                name: leapp"},{"line_number":220,"context_line":"                state: latest"},{"line_number":221,"context_line":"            - name: Synchronize leapp files from Undercloud"},{"line_number":222,"context_line":"              synchronize:"},{"line_number":223,"context_line":"                src: \"/etc/leapp/files\""},{"line_number":224,"context_line":"                dest: \"/etc/leapp/files\""},{"line_number":225,"context_line":"            - name: Run LeappInitCommand"},{"line_number":226,"context_line":"              shell:"},{"line_number":227,"context_line":"                list_join:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_4bce1eb4","line":224,"range":{"start_line":222,"start_character":0,"end_line":224,"end_character":40},"updated":"2020-06-25 11:09:31.000000000","message":"I suggest that we add \u0027checksum: yes\u0027 to the parameters here so that the files are checksum verified in the copy process.\n\nHas this task been verified to do the right thing. Rsync is a bit funny and there might need to be a trailing slash in the src or the dest might need to be \u0027/etc/leapp\u0027 to ensure that the copy is done right (with the ownership, selinux flags, etc).","commit_id":"f1099957f3f59f582e3d61f583a63f4824595be2"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b19fb7a75122ea80252cff4a1da0a429312f01ed","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    description: |"},{"line_number":90,"context_line":"      Command or script snippet to run on all overcloud nodes to"},{"line_number":91,"context_line":"      initialize the Leapp process. E.g. a repository switch."},{"line_number":92,"context_line":"    default: \u0027\u0027"},{"line_number":93,"context_line":"  LeappInitCommand:"},{"line_number":94,"context_line":"    type: string"},{"line_number":95,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf51134e_6d85cf06","line":92,"range":{"start_line":92,"start_character":0,"end_line":92,"end_character":15},"updated":"2020-06-29 10:41:32.000000000","message":"Should we provide a default here using subscription-manager? The documentation can then suggest overriding the default if some other method is being used.","commit_id":"b687d7d360a0b9253a32b83aeeb609ac47bb2614"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"7b2b7128c2669607739a036245556e5fa236c6e1","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    description: |"},{"line_number":90,"context_line":"      Command or script snippet to run on all overcloud nodes to"},{"line_number":91,"context_line":"      initialize the Leapp process. E.g. a repository switch."},{"line_number":92,"context_line":"    default: \u0027\u0027"},{"line_number":93,"context_line":"  LeappInitCommand:"},{"line_number":94,"context_line":"    type: string"},{"line_number":95,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf51134e_1f91c4f2","line":92,"range":{"start_line":92,"start_character":0,"end_line":92,"end_character":15},"in_reply_to":"bf51134e_6d85cf06","updated":"2020-07-01 10:01:31.000000000","message":"Well, I don\u0027t dislike this approach. In theory, the upgrade-prepare.yaml environment file is also a way to provide with defaults (and it will allow you overriding what you have there too).","commit_id":"b687d7d360a0b9253a32b83aeeb609ac47bb2614"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b19fb7a75122ea80252cff4a1da0a429312f01ed","unresolved":false,"context_lines":[{"line_number":90,"context_line":"      Command or script snippet to run on all overcloud nodes to"},{"line_number":91,"context_line":"      initialize the Leapp process. E.g. a repository switch."},{"line_number":92,"context_line":"    default: \u0027\u0027"},{"line_number":93,"context_line":"  LeappInitCommand:"},{"line_number":94,"context_line":"    type: string"},{"line_number":95,"context_line":"    description: |"},{"line_number":96,"context_line":"      Command or script snippet to run on all overcloud nodes to"},{"line_number":97,"context_line":"      deliver data files required by Leapp utility and perform"},{"line_number":98,"context_line":"      any extra Leapp configuration required by the utility."},{"line_number":99,"context_line":"      See https://access.redhat.com/articles/3664871"},{"line_number":100,"context_line":"      Example:"},{"line_number":101,"context_line":"        LeappInitCommand: |"},{"line_number":102,"context_line":"          sudo curl -4ksSL -o /etc/leapp/files/pes-events.json https://example.com/pes-events.json"},{"line_number":103,"context_line":"          sudo curl -4ksSL -o /etc/leapp/files/repomap.csv https://example.com/repomap.csv"},{"line_number":104,"context_line":"    default: \u0027\u0027"},{"line_number":105,"context_line":"  UpgradeInitCommand:"},{"line_number":106,"context_line":"    type: string"},{"line_number":107,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf51134e_4d8c4b35","line":104,"range":{"start_line":93,"start_character":0,"end_line":104,"end_character":15},"updated":"2020-06-29 10:41:32.000000000","message":"Do we still need this? It seems like we already have another way to do the data copy now which is simpler.","commit_id":"b687d7d360a0b9253a32b83aeeb609ac47bb2614"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"7b2b7128c2669607739a036245556e5fa236c6e1","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                state: latest"},{"line_number":215,"context_line":"            - name: Synchronize leapp files from Undercloud"},{"line_number":216,"context_line":"              # https://access.redhat.com/articles/3664871"},{"line_number":217,"context_line":"              synchronize:"},{"line_number":218,"context_line":"                src: \"/etc/leapp/files\""},{"line_number":219,"context_line":"                dest: \"/etc/leapp/files\""},{"line_number":220,"context_line":"            - name: Run LeappInitCommand"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_917c99ec","line":217,"updated":"2020-07-01 10:01:31.000000000","message":"I\u0027m thinking...that if I am not mistaken, this command will run from the mistral_executor container. Which doesn\u0027t have the /etc/leapp/files directory:\n\n [root@undercloud-0 stack]# podman exec -it mistral_executor bash\n()[mistral@undercloud-0 /]$ ls /etc/leapp/files\nls: cannot access \u0027/etc/leapp/files\u0027: No such file or directory","commit_id":"03d1ec79a72e9a7d6b7cc59efc6abfa8b996082c"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"2210dd7e03cc4d86afc91129bdad8c9e73d513ed","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                state: latest"},{"line_number":215,"context_line":"            - name: Synchronize leapp files from Undercloud"},{"line_number":216,"context_line":"              # https://access.redhat.com/articles/3664871"},{"line_number":217,"context_line":"              synchronize:"},{"line_number":218,"context_line":"                src: \"/etc/leapp/files\""},{"line_number":219,"context_line":"                dest: \"/etc/leapp/files\""},{"line_number":220,"context_line":"            - name: Run LeappInitCommand"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_9165b948","line":217,"in_reply_to":"bf51134e_917c99ec","updated":"2020-07-01 10:03:59.000000000","message":"So, we either map the /etc/leapp/files in the mistral_executor container or find another way to tell to Ansible to run from the undercloud node. I can do some testing for this and provide with feedback on the review.","commit_id":"03d1ec79a72e9a7d6b7cc59efc6abfa8b996082c"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d785ca82a976bda04fdcda1060941aace46814cf","unresolved":false,"context_lines":[{"line_number":212,"context_line":"              package:"},{"line_number":213,"context_line":"                name: leapp"},{"line_number":214,"context_line":"                state: latest"},{"line_number":215,"context_line":"            - name: Fetch the Leapp data from undercloud"},{"line_number":216,"context_line":"              fetch:"},{"line_number":217,"context_line":"                dest: \u0027{{ playbook_dir }}\u0027"},{"line_number":218,"context_line":"                src: \u0027{{ item }}\u0027"},{"line_number":219,"context_line":"              delegate_to: undercloud"},{"line_number":220,"context_line":"              with_items:"},{"line_number":221,"context_line":"              - /etc/leapp/files/pes-events.json"},{"line_number":222,"context_line":"              - /etc/leapp/files/repomap.csv"},{"line_number":223,"context_line":"            - name: Copy the Leapp data from undercloud"},{"line_number":224,"context_line":"              copy:"},{"line_number":225,"context_line":"                dest: \u0027{{ item }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_d460b838","line":222,"range":{"start_line":215,"start_character":0,"end_line":222,"end_character":44},"updated":"2020-07-01 17:13:58.000000000","message":"Rather than pull this into the playbook folder, why not just bind-mount /etc/leapp/files,ro so that it\u0027s already in the container?\n\nBTW, if you use the \u0027flat\u0027 argument here, it won\u0027t put it into the {{ inventory_hostname }} folder.","commit_id":"6ecca98ad55b7204053c8810189c6166c1b19c08"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2a4cbd91a971471cb2aadab1e12722e7cf921f1b","unresolved":false,"context_lines":[{"line_number":212,"context_line":"              package:"},{"line_number":213,"context_line":"                name: leapp"},{"line_number":214,"context_line":"                state: latest"},{"line_number":215,"context_line":"            - name: Fetch the Leapp data from undercloud"},{"line_number":216,"context_line":"              fetch:"},{"line_number":217,"context_line":"                dest: \u0027{{ playbook_dir }}\u0027"},{"line_number":218,"context_line":"                src: \u0027{{ item }}\u0027"},{"line_number":219,"context_line":"              delegate_to: undercloud"},{"line_number":220,"context_line":"              with_items:"},{"line_number":221,"context_line":"              - /etc/leapp/files/pes-events.json"},{"line_number":222,"context_line":"              - /etc/leapp/files/repomap.csv"},{"line_number":223,"context_line":"            - name: Copy the Leapp data from undercloud"},{"line_number":224,"context_line":"              copy:"},{"line_number":225,"context_line":"                dest: \u0027{{ item }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_3ed90af4","line":222,"range":{"start_line":215,"start_character":0,"end_line":222,"end_character":44},"in_reply_to":"bf51134e_3a3abd33","updated":"2020-07-02 09:24:06.000000000","message":"OK, that makes sense. I had hoped for something more elegant, but so be it.","commit_id":"6ecca98ad55b7204053c8810189c6166c1b19c08"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"0322e9b4398aefc4b593fd9efebe28b1bdb4a99a","unresolved":false,"context_lines":[{"line_number":212,"context_line":"              package:"},{"line_number":213,"context_line":"                name: leapp"},{"line_number":214,"context_line":"                state: latest"},{"line_number":215,"context_line":"            - name: Fetch the Leapp data from undercloud"},{"line_number":216,"context_line":"              fetch:"},{"line_number":217,"context_line":"                dest: \u0027{{ playbook_dir }}\u0027"},{"line_number":218,"context_line":"                src: \u0027{{ item }}\u0027"},{"line_number":219,"context_line":"              delegate_to: undercloud"},{"line_number":220,"context_line":"              with_items:"},{"line_number":221,"context_line":"              - /etc/leapp/files/pes-events.json"},{"line_number":222,"context_line":"              - /etc/leapp/files/repomap.csv"},{"line_number":223,"context_line":"            - name: Copy the Leapp data from undercloud"},{"line_number":224,"context_line":"              copy:"},{"line_number":225,"context_line":"                dest: \u0027{{ item }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_7153b3e3","line":222,"range":{"start_line":215,"start_character":0,"end_line":222,"end_character":44},"in_reply_to":"bf51134e_3ed90af4","updated":"2020-07-02 10:24:46.000000000","message":"It seems to be working:\nTASK [Fetch the Leapp data from undercloud] *********************************************************************************************************************************\nThursday 02 July 2020  05:54:04 -0400 (0:00:20.403)       0:01:42.279 ********* \nchanged: [controller-1 -\u003e localhost] \u003d\u003e (item\u003d/etc/leapp/files/pes-events.json) \u003d\u003e {\"ansible_loop_var\": \"item\", \"changed\": true, \"checksum\": \"e25ad7b2cdc5fbb38d3e19a8085753b\ne1d57d238\", \"dest\": \"/var/lib/mistral/3daf8090-f07a-4864-989a-4e47ce8e858c/controller-1/etc/leapp/files/pes-events.json\", \"item\": \"/etc/leapp/files/pes-events.json\", \"md5sum\n\": \"6d033bc52da7366f1d6cfc046ac4c3d8\", \"remote_checksum\": \"e25ad7b2cdc5fbb38d3e19a8085753be1d57d238\", \"remote_md5sum\": null}\nchanged: [controller-1 -\u003e localhost] \u003d\u003e (item\u003d/etc/leapp/files/repomap.csv) \u003d\u003e {\"ansible_loop_var\": \"item\", \"changed\": true, \"checksum\": \"e9e70e7770ee1b4630ce8cf7f5b9f1e2859\nc10ed\", \"dest\": \"/var/lib/mistral/3daf8090-f07a-4864-989a-4e47ce8e858c/controller-1/etc/leapp/files/repomap.csv\", \"item\": \"/etc/leapp/files/repomap.csv\", \"md5sum\": \"70be8951\n0fdfa00d785b4222576c017e\", \"remote_checksum\": \"e9e70e7770ee1b4630ce8cf7f5b9f1e2859c10ed\", \"remote_md5sum\": null}\n\n\nBut in line with what we are discussing here, if the user for some reason cleaned up all his leapp files or uninstall leapp, the /etc/leapp/files directory would be missing and this sync would fail. I believe we need some file existence check for the Undercloud first and if /etc/leapp/files directory does not exist on the Undercloud either fail with an indication: Hey! you need to provide your repomap.csv and ps-events.json files in the controller node. Or just skip the fetch task if this directory does not exist.","commit_id":"6ecca98ad55b7204053c8810189c6166c1b19c08"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"98058b69025fd20cc75be5093762aec3194be7c7","unresolved":false,"context_lines":[{"line_number":212,"context_line":"              package:"},{"line_number":213,"context_line":"                name: leapp"},{"line_number":214,"context_line":"                state: latest"},{"line_number":215,"context_line":"            - name: Fetch the Leapp data from undercloud"},{"line_number":216,"context_line":"              fetch:"},{"line_number":217,"context_line":"                dest: \u0027{{ playbook_dir }}\u0027"},{"line_number":218,"context_line":"                src: \u0027{{ item }}\u0027"},{"line_number":219,"context_line":"              delegate_to: undercloud"},{"line_number":220,"context_line":"              with_items:"},{"line_number":221,"context_line":"              - /etc/leapp/files/pes-events.json"},{"line_number":222,"context_line":"              - /etc/leapp/files/repomap.csv"},{"line_number":223,"context_line":"            - name: Copy the Leapp data from undercloud"},{"line_number":224,"context_line":"              copy:"},{"line_number":225,"context_line":"                dest: \u0027{{ item }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_3a3abd33","line":222,"range":{"start_line":215,"start_character":0,"end_line":222,"end_character":44},"in_reply_to":"bf51134e_d460b838","updated":"2020-07-02 05:53:58.000000000","message":"I\u0027m thinking that we might break mistral_executor container if we do that. As /etc/leapp/files isn\u0027t always there. It will exist only if leapp is installed. So in the cases where we don\u0027t deploy Podman will try to map a directory which doesn\u0027t exist for the mistral_executor container and that will cause trouble, iiuc.","commit_id":"6ecca98ad55b7204053c8810189c6166c1b19c08"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"0322e9b4398aefc4b593fd9efebe28b1bdb4a99a","unresolved":false,"context_lines":[{"line_number":220,"context_line":"              with_items:"},{"line_number":221,"context_line":"              - /etc/leapp/files/pes-events.json"},{"line_number":222,"context_line":"              - /etc/leapp/files/repomap.csv"},{"line_number":223,"context_line":"            - name: Copy the Leapp data from undercloud"},{"line_number":224,"context_line":"              copy:"},{"line_number":225,"context_line":"                dest: \u0027{{ item }}\u0027"},{"line_number":226,"context_line":"                src: \u0027{{ playbook_dir }}/{{ inventory_hostname }}/{{ item }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_91f3e773","line":223,"updated":"2020-07-02 10:24:46.000000000","message":"I did some \"more intensive\" testing and if the /etc/leapp/files doesn\u0027t exist (which can happen if it got removed by hand for some reason but leapp was already installed in the node), then the task will fail:\nTASK [Copy the Leapp data from undercloud] **********************************************************************************************************************************\nThursday 02 July 2020  06:16:15 -0400 (0:00:01.018)       0:02:07.255 ********* \nfailed: [controller-1] (item\u003d/etc/leapp/files/pes-events.json) \u003d\u003e {\"ansible_loop_var\": \"item\", \"changed\": false, \"checksum\": \"e25ad7b2cdc5fbb38d3e19a8085753be1d57d238\", \"item\": \"/etc/leapp/files/pes-events.json\", \"msg\": \"Destination directory /etc/leapp/files does not exist\"}\nfailed: [controller-1] (item\u003d/etc/leapp/files/repomap.csv) \u003d\u003e {\"ansible_loop_var\": \"item\", \"changed\": false, \"checksum\": \"e9e70e7770ee1b4630ce8cf7f5b9f1e2859c10ed\", \"item\": \"/etc/leapp/files/repomap.csv\", \"msg\": \"Destination directory /etc/leapp/files does not exist\"}\n\nBut I guess that\u0027s a corner case...in theory ,the \"install leapp\" task from above should ensure the /etc/leapp/files directory exists.","commit_id":"6ecca98ad55b7204053c8810189c6166c1b19c08"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d785ca82a976bda04fdcda1060941aace46814cf","unresolved":false,"context_lines":[{"line_number":227,"context_line":"              with_items:"},{"line_number":228,"context_line":"              - /etc/leapp/files/pes-events.json"},{"line_number":229,"context_line":"              - /etc/leapp/files/repomap.csv"},{"line_number":230,"context_line":"            - name: Synchronize leapp files from Undercloud"},{"line_number":231,"context_line":"              # https://access.redhat.com/articles/3664871"},{"line_number":232,"context_line":"              synchronize:"},{"line_number":233,"context_line":"                src: \"/etc/leapp/files\""},{"line_number":234,"context_line":"                dest: \"/etc/leapp/files\""},{"line_number":235,"context_line":"            - name: Run LeappInitCommand"},{"line_number":236,"context_line":"              shell:"},{"line_number":237,"context_line":"                list_join:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_14d070c9","line":234,"range":{"start_line":230,"start_character":0,"end_line":234,"end_character":40},"updated":"2020-07-01 17:13:58.000000000","message":"We already did the copy to the target above. What is this doing?","commit_id":"6ecca98ad55b7204053c8810189c6166c1b19c08"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"0322e9b4398aefc4b593fd9efebe28b1bdb4a99a","unresolved":false,"context_lines":[{"line_number":227,"context_line":"              with_items:"},{"line_number":228,"context_line":"              - /etc/leapp/files/pes-events.json"},{"line_number":229,"context_line":"              - /etc/leapp/files/repomap.csv"},{"line_number":230,"context_line":"            - name: Synchronize leapp files from Undercloud"},{"line_number":231,"context_line":"              # https://access.redhat.com/articles/3664871"},{"line_number":232,"context_line":"              synchronize:"},{"line_number":233,"context_line":"                src: \"/etc/leapp/files\""},{"line_number":234,"context_line":"                dest: \"/etc/leapp/files\""},{"line_number":235,"context_line":"            - name: Run LeappInitCommand"},{"line_number":236,"context_line":"              shell:"},{"line_number":237,"context_line":"                list_join:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_d15d5fea","line":234,"range":{"start_line":230,"start_character":0,"end_line":234,"end_character":40},"in_reply_to":"bf51134e_14d070c9","updated":"2020-07-02 10:24:46.000000000","message":"Yes, this needs to be removed.","commit_id":"6ecca98ad55b7204053c8810189c6166c1b19c08"}],"environments/lifecycle/upgrade-prepare.yaml":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"96b7fd5f849fccbeae8eeebb45f5c1b7a817f92d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  OS::TripleO::Services::MongoDb: OS::Heat::None"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"parameter_defaults:"},{"line_number":11,"context_line":"  UpgradeLeappCommandOptions: \" --enablerepo rhel-8-for-x86_64-baseos-eus-rpms --enablerepo rhel-8-for-x86_64-appstream-eus-rpms --enablerepo rhel-8-for-x86_64-highavailability-eus-rpms --enablerepo advanced-virt-for-rhel-8-x86_64-rpms --enablerepo ansible-2.9-for-rhel-8-x86_64-rpms --enablerepo fast-datapath-for-rhel-8-x86_64-rpms \""},{"line_number":12,"context_line":"  EnablePackageInstall: true"},{"line_number":13,"context_line":"  UpgradeLevelNovaCompute: \u0027\u0027"},{"line_number":14,"context_line":"  UpgradeInitCommonCommand: |"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bf51134e_767ecc6b","line":11,"updated":"2020-07-07 13:32:02.000000000","message":"I do believe, and Dan McPherson confirmed it, that we are required to pass only the following repos in --enablerepo:\n--enablerepo rhel-8-for-x86_64-baseos-eus-rpms --enablerepo rhel-8-for-x86_64-appstream-eus-rpms --enablerepo fast-datapath-for-rhel-8-x86_64-rpms\n\nSo we make sure the eus repos get enabled and then the fast-datapath for openvswitch upgradring. The rest of the repos should get enabled with the new activation key for OSP16.1 repos.","commit_id":"0dc690ff1e002d303d5daeadabf448c11cbaf91b"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"7a548ed8e251442736d8ecac277f6b0c84502cb7","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  OS::TripleO::Services::MongoDb: OS::Heat::None"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"parameter_defaults:"},{"line_number":11,"context_line":"  UpgradeLeappCommandOptions: \" --enablerepo rhel-8-for-x86_64-baseos-eus-rpms --enablerepo rhel-8-for-x86_64-appstream-eus-rpms --enablerepo rhel-8-for-x86_64-highavailability-eus-rpms --enablerepo advanced-virt-for-rhel-8-x86_64-rpms --enablerepo ansible-2.9-for-rhel-8-x86_64-rpms --enablerepo fast-datapath-for-rhel-8-x86_64-rpms \""},{"line_number":12,"context_line":"  EnablePackageInstall: true"},{"line_number":13,"context_line":"  UpgradeLevelNovaCompute: \u0027\u0027"},{"line_number":14,"context_line":"  UpgradeInitCommonCommand: |"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bf51134e_35d71952","line":11,"in_reply_to":"bf51134e_767ecc6b","updated":"2020-07-08 10:46:34.000000000","message":"Autocorrection, I did test the patch myself and reducing the list will cause other issues, packages not being found and so on. We have seen this working in the hackfest, so let\u0027s stick to this list.","commit_id":"0dc690ff1e002d303d5daeadabf448c11cbaf91b"}]}