)]}'
{"deployment/glance/glance-api-edge-container-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"0d3cebb153d0de8c90c3db09f34a9b5e45ff41a5","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    description: Role data for the Glance API role for DCN/Edge."},{"line_number":71,"context_line":"    value:"},{"line_number":72,"context_line":"      firewall_rules:"},{"line_number":73,"context_line":"        \u0027112 glance_api_edge\u0027:"},{"line_number":74,"context_line":"          dport:"},{"line_number":75,"context_line":"            - 9292"},{"line_number":76,"context_line":"      map_merge:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_8c3d89bd","line":73,"updated":"2020-06-17 03:33:42.000000000","message":"Hmmm, intriguing. For the initial design, I believed the glance_api_edge service would inherit the glance_api service\u0027s firewall_rules per L77 (basically, glance_api_edge\u0027s role_data consists of glance_api\u0027s role_data, with some overrides (service_name at L78 and service_config_settings at L79).\n\nBut, apparently the firewall rules must contain the service\u0027s own name, so a \u0027112 glance_api\u0027 firewall rule won\u0027t be added because the actual service name is glance_api_edge. So I agree, we need to add a firewall rule using *this* service name.\n\nFor a moment I though there might be conflicts with the firewall rule inherited from the glance_api service. Hopefully the hashes are merged, and one won\u0027t override the other.","commit_id":"2d488e82cc9669fa87fe03c2e9856434d42a87bc"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ae203a451e03972f9d93c723a0ca8f0a6863aa9a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"          dport:"},{"line_number":75,"context_line":"            - 9292"},{"line_number":76,"context_line":"      map_merge:"},{"line_number":77,"context_line":"        - get_attr: [GlanceApiBase, role_data]"},{"line_number":78,"context_line":"        - service_name: glance_api_edge"},{"line_number":79,"context_line":"          service_config_settings:"},{"line_number":80,"context_line":"            map_merge:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_8d03c042","line":77,"updated":"2020-06-17 11:23:37.000000000","message":"validate.py can\u0027t validate this I think; instead you have to do GlanceApiBase, role_data, $section for every section we want to import ... like ceph-rgw.yaml","commit_id":"2d488e82cc9669fa87fe03c2e9856434d42a87bc"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"80418165db067d1ff1e7d45f8646d15b17e797bb","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      map_merge:"},{"line_number":73,"context_line":"        - get_attr: [GlanceApiBase, role_data]"},{"line_number":74,"context_line":"        - service_name: glance_api_edge"},{"line_number":75,"context_line":"        - firewall_rules:"},{"line_number":76,"context_line":"            \u0027112 glance_api_edge\u0027:"},{"line_number":77,"context_line":"              dport:"},{"line_number":78,"context_line":"                - 9292"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_43ab3788","line":75,"updated":"2020-06-17 12:46:05.000000000","message":"wonder why this isn\u0027t included from the parent resource which is also opening 9292 and 13292 (for tls)","commit_id":"bc22021e474de76b3203f7852af8c1265d90fa42"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"dcaaab0d6b8d94f6e7813d2eba9549385f259809","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      map_merge:"},{"line_number":73,"context_line":"        - get_attr: [GlanceApiBase, role_data]"},{"line_number":74,"context_line":"        - service_name: glance_api_edge"},{"line_number":75,"context_line":"        - firewall_rules:"},{"line_number":76,"context_line":"            \u0027112 glance_api_edge\u0027:"},{"line_number":77,"context_line":"              dport:"},{"line_number":78,"context_line":"                - 9292"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_86943d46","line":75,"in_reply_to":"bf51134e_43ab3788","updated":"2020-06-17 13:13:05.000000000","message":"See my comment on the first patch set. I believe it\u0027s because the service name in the dict key doesn\u0027t match. The parent resource adds a \u0027112 glance_api\u0027 rule, but the glance_api portion needs to match *this* service name, which is glance_api_edge.","commit_id":"bc22021e474de76b3203f7852af8c1265d90fa42"}]}