)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"d905f325d1fe5d85a87cdb3496a7ff0d12a5f602","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6205fbf1_2e8c2ec8","updated":"2022-03-30 15:47:01.000000000","message":"I don\u0027t see why not this but given the emphasis on OVN, I\u0027m not sure that this would have much in the way of priority with respect to backports, etc.","commit_id":"845303365eea61ca9cd6f845b42bedc26ff0ac29"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"9c8c4c456b8c69dc43535f8b477c0f8deb2068de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6eb23835_ba6c94bd","updated":"2022-02-08 05:58:09.000000000","message":"Needs rebase too.","commit_id":"845303365eea61ca9cd6f845b42bedc26ff0ac29"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"96d73b016937b8d893406a0369ee5fe6fdcd369a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"73bce66c_3c9e13f2","updated":"2022-06-28 17:45:05.000000000","message":"Where the DHCP param seems to have been added for nuage https://review.opendev.org/q/I45cc0032ebaaab7022e8a692ecd63045fe08eea2 , maybe it makes more sense to look at deprecated the dhcp param and consoldating to 1.","commit_id":"0c732ea36212a5ec6a0dff4d18c806910fd1cf0d"}],"deployment/neutron/neutron-l3-container-puppet.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"33104b11191c86b4b487120e4c29a51a6fa664ac","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    type: string"},{"line_number":107,"context_line":"    constraints:"},{"line_number":108,"context_line":"      - allowed_values: [ \u0027\u0027, \u0027true\u0027, \u0027True\u0027, \u0027TRUE\u0027, \u0027false\u0027, \u0027False\u0027, \u0027FALSE\u0027]"},{"line_number":109,"context_line":"  NeutronL3OvsIntegrationBridge:"},{"line_number":110,"context_line":"    default: \u0027\u0027"},{"line_number":111,"context_line":"    type: string"},{"line_number":112,"context_line":"    description: Name of Open vSwitch bridge to use"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_8b575dcb","line":109,"updated":"2020-08-28 05:41:19.000000000","message":"There are already 2 parameters for integration bridge input. NeutronDhcpOvsIntegrationBridge and NeutronOvsIntegrationBridge\n\nWe are adding one more for L3 module. Is all 3 parameters should have the same value or each module can have its own integration brdige?","commit_id":"845303365eea61ca9cd6f845b42bedc26ff0ac29"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4dd2fb1f3ba4196f9c29585a8c3567aca97076e3","unresolved":true,"context_lines":[{"line_number":106,"context_line":"    type: string"},{"line_number":107,"context_line":"    constraints:"},{"line_number":108,"context_line":"      - allowed_values: [ \u0027\u0027, \u0027true\u0027, \u0027True\u0027, \u0027TRUE\u0027, \u0027false\u0027, \u0027False\u0027, \u0027FALSE\u0027]"},{"line_number":109,"context_line":"  NeutronL3OvsIntegrationBridge:"},{"line_number":110,"context_line":"    default: \u0027\u0027"},{"line_number":111,"context_line":"    type: string"},{"line_number":112,"context_line":"    description: Name of Open vSwitch bridge to use"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"402a4ea3_4d271ba2","line":109,"in_reply_to":"9f560f44_8b575dcb","updated":"2021-02-19 13:45:00.000000000","message":"IIUC we should use the same value to make it working because these three services are supposed to look at the same bridge.\n\nIn this patch I added an independent parameter to follow what we already have, but it might be better to merge these three values into a single parameter, or deprecate the existing two assuming that no users would try to change this value in real deployments.","commit_id":"845303365eea61ca9cd6f845b42bedc26ff0ac29"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"9c8c4c456b8c69dc43535f8b477c0f8deb2068de","unresolved":true,"context_lines":[{"line_number":139,"context_line":"  radvd_wrapper_enabled: {equals: [{get_param: NeutronEnableRadvdDockerWrapper}, true]}"},{"line_number":140,"context_line":"  docker_enabled: {equals: [{get_param: ContainerCli}, \u0027docker\u0027]}"},{"line_number":141,"context_line":"  service_debug_unset: {equals : [{get_param: NeutronWrapperDebug}, false]}"},{"line_number":142,"context_line":"  l3_ovs_intergation_bridge_unset: {equals: [{get_param: NeutronL3OvsIntegrationBridge}, \u0027\u0027]}"},{"line_number":143,"context_line":"  az_unset: {equals: [{get_param: NeutronL3AgentAvailabilityZone}, \u0027\u0027]}"},{"line_number":144,"context_line":"  l3_agent_extensions_empty: {equals : [{get_param: NeutronL3AgentExtensions}, \"\u0027\u0027\"]}"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"738568f6_e1da452d","line":142,"range":{"start_line":142,"start_character":2,"end_line":142,"end_character":33},"updated":"2022-02-08 05:58:09.000000000","message":"can negate this condition and drop the {} in L221. Also, we should avoid too many default parameters if possible.","commit_id":"845303365eea61ca9cd6f845b42bedc26ff0ac29"}]}