)]}'
{"deployment/database/redis-container-puppet.yaml":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e4c359bc11c8f74d1a145f8fc0489cba11ea7a25","unresolved":false,"context_lines":[{"line_number":234,"context_line":"          package:"},{"line_number":235,"context_line":"            name: redis"},{"line_number":236,"context_line":"            state: absent"},{"line_number":237,"context_line":"        - name: remove old tmpfiles.d config"},{"line_number":238,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":239,"context_line":"          file:"},{"line_number":240,"context_line":"            path: /etc/tmpfiles.d/var-run-redis.conf"},{"line_number":241,"context_line":"            state: absent"},{"line_number":242,"context_line":"      upgrade_tasks:"},{"line_number":243,"context_line":"        - name: Ensure redis is uninstalled on container host"},{"line_number":244,"context_line":"          when: step|int \u003d\u003d 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_4d7172a9","line":241,"range":{"start_line":237,"start_character":8,"end_line":241,"end_character":25},"updated":"2020-06-19 10:01:41.000000000","message":"what about adding it in host_prep_tasks in addition to file create to avoid adding in both update/upgrade_tasks? Such that we ensure new file exist and legacy is not(get\u0027s cleaned up)","commit_id":"4f6d8bf90d4c03ed1ad78b4242c17dc25f61fabb"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"8348408798845d2346caa0464f2a74f5688b9c39","unresolved":false,"context_lines":[{"line_number":234,"context_line":"          package:"},{"line_number":235,"context_line":"            name: redis"},{"line_number":236,"context_line":"            state: absent"},{"line_number":237,"context_line":"        - name: remove old tmpfiles.d config"},{"line_number":238,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":239,"context_line":"          file:"},{"line_number":240,"context_line":"            path: /etc/tmpfiles.d/var-run-redis.conf"},{"line_number":241,"context_line":"            state: absent"},{"line_number":242,"context_line":"      upgrade_tasks:"},{"line_number":243,"context_line":"        - name: Ensure redis is uninstalled on container host"},{"line_number":244,"context_line":"          when: step|int \u003d\u003d 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_689ee454","line":241,"range":{"start_line":237,"start_character":8,"end_line":241,"end_character":25},"in_reply_to":"bf51134e_4d7172a9","updated":"2020-06-19 11:46:41.000000000","message":"it\u0027s more an update/upgrade task imho. IIRC there are already such things (removal during update|upgrades, then addition in host_prep_tasks [or elsewhere])\n\nThere is no need to ensure the absence of the file during a deploy - this is one useless task, and we\u0027re trying to reduce the amount of useless things.","commit_id":"4f6d8bf90d4c03ed1ad78b4242c17dc25f61fabb"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"2c258219f8865e5e51a751781c0bd718abbc5c76","unresolved":false,"context_lines":[{"line_number":239,"context_line":"          file:"},{"line_number":240,"context_line":"            path: /etc/tmpfiles.d/var-run-redis.conf"},{"line_number":241,"context_line":"            state: absent"},{"line_number":242,"context_line":"      upgrade_tasks:"},{"line_number":243,"context_line":"        - name: Ensure redis is uninstalled on container host"},{"line_number":244,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":245,"context_line":"          package:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_c8773002","line":242,"updated":"2020-06-19 11:58:08.000000000","message":"Should we perform the same steps for Fast Forward?","commit_id":"4f6d8bf90d4c03ed1ad78b4242c17dc25f61fabb"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"9de7fc9df6748c5c52e7197fbc329d782a552864","unresolved":false,"context_lines":[{"line_number":225,"context_line":"            content: |"},{"line_number":226,"context_line":"              d /run/redis 0755 root root - -"},{"line_number":227,"context_line":"      update_tasks: \u0026redis_cleaning_tasks"},{"line_number":228,"context_line":"        - name: Ensure redis is uninstalled on container host"},{"line_number":229,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":230,"context_line":"          package:"},{"line_number":231,"context_line":"            name: redis"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9f560f44_c4450446","line":228,"updated":"2020-10-12 10:22:03.000000000","message":"these tasks not moved to block: and use anchors on block intentionally or just missed?","commit_id":"4ab16d3560a0fb3c2255b5fb200bf54608263148"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"de45cffdf6d45280d4fa7c720455296c064563a0","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                path: /etc/tmpfiles.d/var-run-redis.conf"},{"line_number":238,"context_line":"                state: absent"},{"line_number":239,"context_line":"      upgrade_tasks:"},{"line_number":240,"context_line":"        name: redis_container_puppet_tmpfile_cleanup"},{"line_number":241,"context_line":"        when: step|int \u003d\u003d 1"},{"line_number":242,"context_line":"        block: *redis_container_puppet_tmpfile_cleanup"},{"line_number":243,"context_line":"      external_upgrade_tasks:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9f560f44_7b8c857f","line":240,"updated":"2020-10-13 05:42:32.000000000","message":"missed -","commit_id":"4446262cb804bd8630e63af3f65d166319502ca0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8b1a38498032276cf57ae93356e4673267184d78","unresolved":false,"context_lines":[{"line_number":242,"context_line":"      upgrade_tasks:"},{"line_number":243,"context_line":"        - name: redis_container_puppet_redis_pkg_clean"},{"line_number":244,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":245,"context_line":"          block: \u0026redis_container_puppet_redis_pkg_clean"},{"line_number":246,"context_line":"        - name: redis_container_puppet_tmpfile_cleanup"},{"line_number":247,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":248,"context_line":"          block: *redis_container_puppet_tmpfile_cleanup"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9f560f44_00a35500","line":245,"range":{"start_line":245,"start_character":17,"end_line":245,"end_character":18},"updated":"2020-10-13 09:31:11.000000000","message":"* ?","commit_id":"ece11962d6eb4b6a77b08a703f0eebb024283aa2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"90a81dc9710d3db8d34b8c8492355720a15ffaf8","unresolved":false,"context_lines":[{"line_number":242,"context_line":"      upgrade_tasks:"},{"line_number":243,"context_line":"        - name: redis_container_puppet_redis_pkg_clean"},{"line_number":244,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":245,"context_line":"          block: \u0026redis_container_puppet_redis_pkg_clean"},{"line_number":246,"context_line":"        - name: redis_container_puppet_tmpfile_cleanup"},{"line_number":247,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":248,"context_line":"          block: *redis_container_puppet_tmpfile_cleanup"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9f560f44_60969196","line":245,"range":{"start_line":245,"start_character":17,"end_line":245,"end_character":18},"in_reply_to":"9f560f44_00a35500","updated":"2020-10-13 09:31:48.000000000","message":"well i typed \"*\" but it gave me that thing ^ whatever it is :)","commit_id":"ece11962d6eb4b6a77b08a703f0eebb024283aa2"}],"deployment/database/redis-pacemaker-puppet.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"df920ecd28a0025296d421e8a05d15c484242fb8","unresolved":false,"context_lines":[{"line_number":320,"context_line":"            container_image: {get_param: ContainerRedisImage}"},{"line_number":321,"context_line":"            container_image_latest: *redis_image_pcmklatest"},{"line_number":322,"context_line":"      update_tasks:"},{"line_number":323,"context_line":"        - name: remove old tmpfiles.d config"},{"line_number":324,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":325,"context_line":"          file:"},{"line_number":326,"context_line":"            path: /etc/tmpfiles.d/var-run-redis.conf"},{"line_number":327,"context_line":"            state: absent"},{"line_number":328,"context_line":"        - name: Tear-down non-HA redis container"},{"line_number":329,"context_line":"          when:"},{"line_number":330,"context_line":"            - step|int \u003d\u003d 1"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_440dbd3c","line":327,"range":{"start_line":323,"start_character":0,"end_line":327,"end_character":25},"updated":"2020-07-08 14:47:26.000000000","message":"why wasn\u0027t it templated?","commit_id":"85dde9b8b715126e2886de5d3ed84268db9bc4b0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2698466cff294d84e9067e705bc6909218c7a8e7","unresolved":false,"context_lines":[{"line_number":332,"context_line":"      upgrade_tasks:"},{"line_number":333,"context_line":"        - name: redis_pacemaker_puppet_tmpfile_cleanup"},{"line_number":334,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":335,"context_line":"          block: *redis_pacemaker_puppet_tmpfile_cleanup"},{"line_number":336,"context_line":"        - name: Tear-down non-HA redis container"},{"line_number":337,"context_line":"          when:"},{"line_number":338,"context_line":"            - step|int \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9f560f44_cdea360c","line":335,"range":{"start_line":335,"start_character":18,"end_line":335,"end_character":56},"updated":"2020-10-13 08:55:53.000000000","message":"can\u0027t help it i have to comment :) why is this block named differently (e.g. \"nova_migration_target_up_tasks\" or \"nova_libvirt_container_up_tasks\" ).\n\nmaybe this one is more descriptive and you should consider changing the \u0027up_tasks\u0027 :)","commit_id":"82885f6b25304c7675376edc181ee29c2d68bd68"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"503b27fc3ccf565e432258ae022b05a036202f98","unresolved":false,"context_lines":[{"line_number":332,"context_line":"      upgrade_tasks:"},{"line_number":333,"context_line":"        - name: redis_pacemaker_puppet_tmpfile_cleanup"},{"line_number":334,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":335,"context_line":"          block: *redis_pacemaker_puppet_tmpfile_cleanup"},{"line_number":336,"context_line":"        - name: Tear-down non-HA redis container"},{"line_number":337,"context_line":"          when:"},{"line_number":338,"context_line":"            - step|int \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9f560f44_2d6812f2","line":335,"range":{"start_line":335,"start_character":18,"end_line":335,"end_character":56},"in_reply_to":"9f560f44_cdea360c","updated":"2020-10-13 09:20:35.000000000","message":"because I love getting questions ;).\n\nI\u0027ve also split the things in the other redis file since the name talked about tmpfile while doing also the package removal. Cleaner imho.","commit_id":"82885f6b25304c7675376edc181ee29c2d68bd68"}],"deployment/nova/nova-libvirt-container-puppet.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5b0b235eeb270084f803cc67063bd91263882769","unresolved":false,"context_lines":[{"line_number":922,"context_line":"          file:"},{"line_number":923,"context_line":"            path: /etc/tmpfiles.d/var-run-libvirt.conf"},{"line_number":924,"context_line":"            state: absent"},{"line_number":925,"context_line":"      update_tasks: *nova_libvirt_container_up_tasks"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9f560f44_54b2d4e7","line":925,"updated":"2020-07-28 19:22:29.000000000","message":"same as deployment/nova/nova-migration-target-container-puppet.yaml","commit_id":"31836f43eee1cc2be1a21cc4947a1be74793b6be"}],"deployment/nova/nova-migration-target-container-puppet.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5b0b235eeb270084f803cc67063bd91263882769","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            - container_cli \u003d\u003d \u0027podman\u0027"},{"line_number":198,"context_line":"            - not container_healthcheck_disabled"},{"line_number":199,"context_line":"            - step|int \u003d\u003d 5"},{"line_number":200,"context_line":"      update_tasks: \u0026nova_migration_target_up_tasks"},{"line_number":201,"context_line":"        - name: remove old tmpfiles.d config"},{"line_number":202,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":203,"context_line":"          file:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9f560f44_f4bcc8bc","line":200,"updated":"2020-07-28 19:22:29.000000000","message":"even though it\u0027s a nice shortcut, I wouldn\u0027t do that.\none can easily add tasks here (only useful for updates) and they would be run in upgrades by accident.\n\nI would move the \u0026 to a block.","commit_id":"31836f43eee1cc2be1a21cc4947a1be74793b6be"}],"deployment/octavia/octavia-api-container-puppet.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"df920ecd28a0025296d421e8a05d15c484242fb8","unresolved":false,"context_lines":[{"line_number":396,"context_line":"            content: |"},{"line_number":397,"context_line":"              d /run/octavia 0755 root root - -"},{"line_number":398,"context_line":"      update_tasks:"},{"line_number":399,"context_line":"        - name: remove old tmpfiles.d config"},{"line_number":400,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":401,"context_line":"          file:"},{"line_number":402,"context_line":"            path: /etc/tmpfiles.d/var-run-octavia.conf"},{"line_number":403,"context_line":"            state: absent"},{"line_number":404,"context_line":"        - name: Set internal tls variable"},{"line_number":405,"context_line":"          set_fact:"},{"line_number":406,"context_line":"            internal_tls_enabled: {get_param: EnableInternalTLS}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_e4169155","line":403,"range":{"start_line":399,"start_character":0,"end_line":403,"end_character":25},"updated":"2020-07-08 14:47:26.000000000","message":"why wasn\u0027t it templated?","commit_id":"85dde9b8b715126e2886de5d3ed84268db9bc4b0"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5b0b235eeb270084f803cc67063bd91263882769","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                  systemd:"},{"line_number":439,"context_line":"                    daemon-reload: yes"},{"line_number":440,"context_line":"      upgrade_tasks:"},{"line_number":441,"context_line":"        - name: remove old tmpfiles.d config"},{"line_number":442,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":443,"context_line":"          block: *octavia_api_tmpfile_cleanup"},{"line_number":444,"context_line":"        - name: Set internal tls variable"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9f560f44_749f1850","line":441,"range":{"start_line":441,"start_character":16,"end_line":441,"end_character":44},"updated":"2020-07-28 19:22:29.000000000","message":"why do you name it differently from update tasks, it\u0027s doing the same thing.","commit_id":"31836f43eee1cc2be1a21cc4947a1be74793b6be"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"9de7fc9df6748c5c52e7197fbc329d782a552864","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            - { \u0027path\u0027: /run/octavia, \u0027setype\u0027: container_file_t, \u0027mode\u0027: \u00270755\u0027  }"},{"line_number":398,"context_line":"        - name: ensure /run/octavia is present upon reboot"},{"line_number":399,"context_line":"          copy:"},{"line_number":400,"context_line":"            dest: /etc/tmpfiles.d/var-run-octavia.conf"},{"line_number":401,"context_line":"            content: |"},{"line_number":402,"context_line":"              d /run/octavia 0755 root root - -"},{"line_number":403,"context_line":"      update_tasks:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9f560f44_64a878d8","line":400,"range":{"start_line":400,"start_character":34,"end_line":400,"end_character":38},"updated":"2020-10-12 10:22:03.000000000","message":"need rename here too.","commit_id":"4ab16d3560a0fb3c2255b5fb200bf54608263148"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"503b27fc3ccf565e432258ae022b05a036202f98","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            - { \u0027path\u0027: /run/octavia, \u0027setype\u0027: container_file_t, \u0027mode\u0027: \u00270755\u0027  }"},{"line_number":398,"context_line":"        - name: ensure /run/octavia is present upon reboot"},{"line_number":399,"context_line":"          copy:"},{"line_number":400,"context_line":"            dest: /etc/tmpfiles.d/var-run-octavia.conf"},{"line_number":401,"context_line":"            content: |"},{"line_number":402,"context_line":"              d /run/octavia 0755 root root - -"},{"line_number":403,"context_line":"      update_tasks:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9f560f44_7b3005ea","line":400,"range":{"start_line":400,"start_character":34,"end_line":400,"end_character":38},"in_reply_to":"9f560f44_64a878d8","updated":"2020-10-13 09:20:35.000000000","message":"uho - good catch!","commit_id":"4ab16d3560a0fb3c2255b5fb200bf54608263148"}]}