)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c0b3ae4d8340cb82258bffac1f2d32c7018293f2","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TODO: Add in the part where configuration is done."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] https://github.com/infrawatch/tripleo-collectd-ansible-role"},{"line_number":18,"context_line":"[2] https://github.com/infrawatch/collectd-config-ansible-role"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I9939a524795bb3fbc63e44f203f851dadeb7c30a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1f621f24_72e111ff","line":17,"range":{"start_line":17,"start_character":3,"end_line":17,"end_character":63},"updated":"2020-10-28 16:42:04.000000000","message":"This should likely just live in tripleo-ansible in a single role. I wouldn\u0027t put it separate repo","commit_id":"8f21e3f280cbb9c7ca267a0271ade75553ce4f90"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"2e1c912aeacf96baf5702ee4fffb3cc00a1b7f48","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TODO: Add in the part where configuration is done."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] https://github.com/infrawatch/tripleo-collectd-ansible-role"},{"line_number":18,"context_line":"[2] https://github.com/infrawatch/collectd-config-ansible-role"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I9939a524795bb3fbc63e44f203f851dadeb7c30a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"2db462f0_0ba101c7","line":17,"range":{"start_line":17,"start_character":3,"end_line":17,"end_character":63},"in_reply_to":"1f621f24_72e111ff","updated":"2021-02-04 14:02:28.000000000","message":"That\u0027s the plan now. The integration is WIP in github, and will be proposed to tripleo_ansible once it\u0027s working.","commit_id":"8f21e3f280cbb9c7ca267a0271ade75553ce4f90"}],"deployment/metrics/collectd-container-ansible.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ac6b5c197aedb84d0d24d5402682350bafc17eb7","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    description: Set to true to enable mcelog"},{"line_number":397,"context_line":"    default: false"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"  # The existing collectd Parameters should be combined with CollectdVars and all marked for deprecation."},{"line_number":400,"context_line":"  # They will be accepted for backwards compatibility, but new deployments should add the vars"},{"line_number":401,"context_line":"  # directly into the RoleVars parameter, which will not require anymore change here to add new params."},{"line_number":402,"context_line":"  CollectdVars:"},{"line_number":403,"context_line":"    default: {}"},{"line_number":404,"context_line":"    description: Hash of ansible-role-test variables used to configure the test role."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_53899772","line":401,"range":{"start_line":399,"start_character":1,"end_line":401,"end_character":103},"updated":"2020-06-26 19:31:16.000000000","message":"ok that answers my question bellow about backward compatibility.","commit_id":"c8816b4656229ad28644505dd36db8edc9e69baa"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ac6b5c197aedb84d0d24d5402682350bafc17eb7","unresolved":false,"context_lines":[{"line_number":416,"context_line":"      type: json"},{"line_number":417,"context_line":"      value:"},{"line_number":418,"context_line":"        map_merge:"},{"line_number":419,"context_line":"          # The first items in this list should be any old collectd-related parameters, using a new key."},{"line_number":420,"context_line":"          - gnocchi_password: {get_param: GnocchiPassword}"},{"line_number":421,"context_line":"          - keystone_region: {get_param: KeystoneRegion}"},{"line_number":422,"context_line":"          - container_collectd_image: {get_param: ContainerCollectdImage}"},{"line_number":423,"context_line":"          - container_collectd_config_image: {get_param: ContainerCollectdConfigImage}"},{"line_number":424,"context_line":"          - metrics_qdr_port: {get_param: MetricsQdrPort}"},{"line_number":425,"context_line":"          - metrics_qdr_username: {get_param: MetricsQdrUsername}"},{"line_number":426,"context_line":"          - metrics_qdr_password: {get_param: MetricsQdrPassword}"},{"line_number":427,"context_line":"          - monitoring_subscription_collectd: {get_param: MonitoringSubscriptionCollectd}"},{"line_number":428,"context_line":"          - collectd_connection_type: {get_param: CollectdConnectionType}"},{"line_number":429,"context_line":"          - collectd_interval: {get_param: CollectdDefaultPollingInterval}"},{"line_number":430,"context_line":"          - collectd_default_plugins: {get_param: CollectdDefaultPlugins}"},{"line_number":431,"context_line":"          - collectd_extra_plugins: {get_param: CollectdExtraPlugins}"},{"line_number":432,"context_line":"          - collectd_server: {get_param: CollectdServer}"},{"line_number":433,"context_line":"          - collectd_server_port: {get_param: CollectdServerPort}"},{"line_number":434,"context_line":"          - collectd_username: {get_param: CollectdUsername}"},{"line_number":435,"context_line":"          - collectd_password: {get_param: CollectdPassword}"},{"line_number":436,"context_line":"          - collectd_security_level: {get_param: CollectdSecurityLevel}"},{"line_number":437,"context_line":"          - collectd_gnocchi_auth_mode: {get_param: CollectdGnocchiAuthMode}"},{"line_number":438,"context_line":"          - collectd_gnocchi_protocol: {get_param: CollectdGnocchiProtocol}"},{"line_number":439,"context_line":"          - collectd_gnocchi_server: {get_param: CollectdGnocchiServer}"},{"line_number":440,"context_line":"          - collectd_gnocchi_port: {get_param: CollectdGnocchiPort}"},{"line_number":441,"context_line":"          - collectd_gnocchi_user: {get_param: CollectdGnocchiUser}"},{"line_number":442,"context_line":"          - collectd_gnocchi_keyston_auth_url: {get_param: CollectdGnocchiKeystoneAuthUrl}"},{"line_number":443,"context_line":"          - collectd_gnocchi_keystone_username: {get_param: CollectdGnocchiKeystoneUserName}"},{"line_number":444,"context_line":"          - collectd_gnocchi_keystone_userid: {get_param: CollectdGnocchiKeystoneUserId}"},{"line_number":445,"context_line":"          - collectd_gnocchi_keystone_password: {get_param: CollectdGnocchiKeystonePassword}"},{"line_number":446,"context_line":"          - collectd_gnocchi_keystone_project_id: {get_param: CollectdGnocchiKeystoneProjectId}"},{"line_number":447,"context_line":"          - collectd_gnocchi_keystone_project_name: {get_param: CollectdGnocchiKeystoneProjectName}"},{"line_number":448,"context_line":"          - collectd_gnocchi_keystone_user_domain_id: {get_param: CollectdGnocchiKeystoneUserDomainId}"},{"line_number":449,"context_line":"          - collectd_gnocchi_keystone_user_domain_name: {get_param: CollectdGnocchiKeystoneUserDomainName}"},{"line_number":450,"context_line":"          - collectd_gnocchi_keystone_project_domain_id: {get_param: CollectdGnocchiKeystoneProjectDomainId}"},{"line_number":451,"context_line":"          - collectd_gnocchi_keystone_project_domain_name: {get_param: CollectdGnocchiKeystoneProjectDomainName}"},{"line_number":452,"context_line":"          - collectd_gnocchi_keystone_region_name: {get_param: CollectdGnocchiKeystoneRegionName}"},{"line_number":453,"context_line":"          - collectd_gnocchi_keystone_interface: {get_param: CollectdGnocchiKeystoneInterface}"},{"line_number":454,"context_line":"          - collectd_gnocchi_keystone_endpoint: {get_param: CollectdGnocchiKeystoneEndpoint}"},{"line_number":455,"context_line":"          - collectd_gnocchi_resource_type: {get_param: CollectdGnocchiResourceType}"},{"line_number":456,"context_line":"          - collectd_gnocchi_batch_size: {get_param: CollectdGnocchiBatchSize}"},{"line_number":457,"context_line":"          - collectd_sql_alchemy_enable: {get_param: EnableSQLAlchemyCollectd}"},{"line_number":458,"context_line":"          - collectd_sql_alchemy_log_messages: {get_param: CollectdSQLAlchemyLogMessages}"},{"line_number":459,"context_line":"          - collectd_sql_alchemy_bind_host: {get_param: CollectdSQLAlchemyBindHost}"},{"line_number":460,"context_line":"          - collectd_amqp_host: {get_param: CollectdAmqpHost}"},{"line_number":461,"context_line":"          - collectd_amqp_port: {get_param: CollectdAmqpPort}"},{"line_number":462,"context_line":"          - collectd_amqp_user: {get_param: CollectdAmqpUser}"},{"line_number":463,"context_line":"          - collectd_amqp_password: {get_param: CollectdAmqpPassword}"},{"line_number":464,"context_line":"          - collectd_amqp_transport_name: {get_param: CollectdAmqpTransportName}"},{"line_number":465,"context_line":"          - collectd_amqp_address: {get_param: CollectdAmqpAddress}"},{"line_number":466,"context_line":"          - collectd_amqp_instances: {get_param: CollectdAmqpInstances}"},{"line_number":467,"context_line":"          - collectd_amqp_retry_delay: {get_param: CollectdAmqpRetryDelay}"},{"line_number":468,"context_line":"          - collectd_amqp_interval: {get_param: CollectdAmqpInterval}"},{"line_number":469,"context_line":"          - collectd_sensubility_enable: {get_param: CollectdEnableSensubility}"},{"line_number":470,"context_line":"          - collectd_sensubility_exec_sudo_rule: {get_param: CollectdSensubilityExecSudoRule}"},{"line_number":471,"context_line":"          - collectd_sensubility_log_level: {get_param: CollectdSensubilityLogLevel}"},{"line_number":472,"context_line":"          - collectd_sensubility_connection: {get_param: CollectdSensubilityConnection}"},{"line_number":473,"context_line":"          - collectd_sensubility_keepalive_interval: {get_param: CollectdSensubilityKeepaliveInterval}"},{"line_number":474,"context_line":"          - collectd_sensubility_tmp_dir: {get_param: CollectdSensubilityTmpDir}"},{"line_number":475,"context_line":"          - collectd_sensubility_shell_path: {get_param: CollectdSensubilityShellPath}"},{"line_number":476,"context_line":"          - collectd_sensubility_worker_count: {get_param: CollectdSensubilityWorkerCount}"},{"line_number":477,"context_line":"          - collectd_sensubility_checks: {get_param: CollectdSensubilityChecks}"},{"line_number":478,"context_line":"          - collectd_container_healthcheck_enable: {get_param: CollectdEnableContainerHealthCheck}"},{"line_number":479,"context_line":"          - collectd_container_healthcheck_command: {get_param: CollectdContainerHealthCheckCommand}"},{"line_number":480,"context_line":"          - collectd_container_healthcheck_interval: {get_param: CollectdContainerHealthCheckInterval}"},{"line_number":481,"context_line":"          - collectd_container_healthcheck_handlers: {get_param: CollectdContainerHealthCheckHandlers}"},{"line_number":482,"context_line":"          - collectd_container_healthcheck_occurances: {get_param: CollectdContainerHealthCheckOccurrences}"},{"line_number":483,"context_line":"          - collectd_container_healthcheck_refresh: {get_param: CollectdContainerHealthCheckRefresh}"},{"line_number":484,"context_line":"          - enable_stf_enable: {get_param: EnableSTF}"},{"line_number":485,"context_line":"          - collectd_enable_mcelog: {get_param: CollectdEnableMcelog}"},{"line_number":486,"context_line":"          # The last element should be the CollectdVars, which overides any previous deprecated metric."},{"line_number":487,"context_line":"          - { get_param: CollectdVars }"},{"line_number":488,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_135d5f14","line":485,"range":{"start_line":419,"start_character":0,"end_line":485,"end_character":69},"updated":"2020-06-26 19:31:16.000000000","message":"that\u0027s a lot of parameters, I guess you want that for backward compatibility?","commit_id":"c8816b4656229ad28644505dd36db8edc9e69baa"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ac6b5c197aedb84d0d24d5402682350bafc17eb7","unresolved":false,"context_lines":[{"line_number":519,"context_line":"                -"},{"line_number":520,"context_line":"                  - /var/lib/kolla/config_files/collectd.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":521,"context_line":"                  # NOTE: this is the dir I need to write the configs to"},{"line_number":522,"context_line":"                  - /var/lib/config-data/ansible-generated/collectd:/var/lib/kolla/config_files/src:ro"},{"line_number":523,"context_line":"                  - /var/log/containers/collectd:/var/log/collectd:rw,z"},{"line_number":524,"context_line":"                  - /var/run/:/var/run:rw"},{"line_number":525,"context_line":"                  - /sys/fs/cgroup:/sys/fs/cgroup:ro"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_f3b0ab45","line":522,"range":{"start_line":522,"start_character":41,"end_line":522,"end_character":58},"updated":"2020-06-26 19:31:16.000000000","message":"I don\u0027t think we do it elsewhere, it would be a new pattern. Not saying this is wrong, but we don\u0027t manage that directory today.","commit_id":"c8816b4656229ad28644505dd36db8edc9e69baa"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"98333cd228d414b3258122fa0ab6a14bb9e6fbf9","unresolved":false,"context_lines":[{"line_number":519,"context_line":"                -"},{"line_number":520,"context_line":"                  - /var/lib/kolla/config_files/collectd.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":521,"context_line":"                  # NOTE: this is the dir I need to write the configs to"},{"line_number":522,"context_line":"                  - /var/lib/config-data/ansible-generated/collectd:/var/lib/kolla/config_files/src:ro"},{"line_number":523,"context_line":"                  - /var/log/containers/collectd:/var/log/collectd:rw,z"},{"line_number":524,"context_line":"                  - /var/run/:/var/run:rw"},{"line_number":525,"context_line":"                  - /sys/fs/cgroup:/sys/fs/cgroup:ro"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_ca5ada28","line":522,"range":{"start_line":522,"start_character":41,"end_line":522,"end_character":58},"in_reply_to":"bf51134e_f3b0ab45","updated":"2020-07-02 13:58:19.000000000","message":"I\u0027ve been digging into this more, and I believe I need to re-add the kolla_config section, which takes care of mapping the config files.","commit_id":"c8816b4656229ad28644505dd36db8edc9e69baa"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ac6b5c197aedb84d0d24d5402682350bafc17eb7","unresolved":false,"context_lines":[{"line_number":527,"context_line":"              KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"},{"line_number":528,"context_line":"      deploy_steps_tasks:"},{"line_number":529,"context_line":"        import_role:"},{"line_number":530,"context_line":"          name: tripleo_collectd"},{"line_number":531,"context_line":"        vars:"},{"line_number":532,"context_line":"          - deploy_stage: \"deploy_steps_tasks\""},{"line_number":533,"context_line":"          # TODO(efoley): Is this step var available in this context? Previous embedded ansible did this"},{"line_number":534,"context_line":"          - step: \"{{ step }}\""},{"line_number":535,"context_line":"          - {get_attr: [RoleParametersValue, value]}"},{"line_number":536,"context_line":"      host_prep_tasks:"},{"line_number":537,"context_line":"        import_role:"},{"line_number":538,"context_line":"          name: tripleo_collectd"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_73781b8f","line":535,"range":{"start_line":530,"start_character":0,"end_line":535,"end_character":52},"updated":"2020-06-26 19:31:16.000000000","message":"the syntax is wrong, look at RHSM service for example. It should be one task with the import_role.","commit_id":"c8816b4656229ad28644505dd36db8edc9e69baa"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ac6b5c197aedb84d0d24d5402682350bafc17eb7","unresolved":false,"context_lines":[{"line_number":534,"context_line":"          - step: \"{{ step }}\""},{"line_number":535,"context_line":"          - {get_attr: [RoleParametersValue, value]}"},{"line_number":536,"context_line":"      host_prep_tasks:"},{"line_number":537,"context_line":"        import_role:"},{"line_number":538,"context_line":"          name: tripleo_collectd"},{"line_number":539,"context_line":"        vars:"},{"line_number":540,"context_line":"          - deploy_stage: \"host_prep_tasks\""},{"line_number":541,"context_line":"          - {get_attr: [RoleParametersValue, value]}"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"      fast_forward_upgrade_tasks:"},{"line_number":544,"context_line":"        import_role:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_b36e33c6","line":541,"range":{"start_line":537,"start_character":0,"end_line":541,"end_character":52},"updated":"2020-06-26 19:31:16.000000000","message":"ditto","commit_id":"c8816b4656229ad28644505dd36db8edc9e69baa"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ac6b5c197aedb84d0d24d5402682350bafc17eb7","unresolved":false,"context_lines":[{"line_number":541,"context_line":"          - {get_attr: [RoleParametersValue, value]}"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"      fast_forward_upgrade_tasks:"},{"line_number":544,"context_line":"        import_role:"},{"line_number":545,"context_line":"          name: tripleo_collectd"},{"line_number":546,"context_line":"        vars:"},{"line_number":547,"context_line":"           - deploy_stage: \"fast_forward_upgrade_tasks\""},{"line_number":548,"context_line":"           # TODO(efoley): Is this the correct way to add this step var to the ansible?"},{"line_number":549,"context_line":"           # Is it already available somehow, like it was for the embedded ansible?"},{"line_number":550,"context_line":"           - step: \"{{ step }}\""},{"line_number":551,"context_line":"           - release: \"{{ release }}\""},{"line_number":552,"context_line":"           - {get_attr: [RoleParametersValue, value]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_93716fab","line":552,"range":{"start_line":544,"start_character":0,"end_line":552,"end_character":53},"updated":"2020-06-26 19:31:16.000000000","message":"ditto","commit_id":"c8816b4656229ad28644505dd36db8edc9e69baa"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"edf080212c550ef41e4b3ce6df91ad4b16823a05","unresolved":false,"context_lines":[{"line_number":461,"context_line":"          - enable_sqlalchemy_collectd: {get_param: EnableSQLAlchemyCollectd}"},{"line_number":462,"context_line":"          - collectd_sql_alchemy_log_messages: {get_param: CollectdSQLAlchemyLogMessages}"},{"line_number":463,"context_line":"          - collectd_sql_alchemy_bind_host: {get_param: CollectdSQLAlchemyBindHost}"},{"line_number":464,"context_line":"          # TODO: pass these straight through to collectd; They get overwritten"},{"line_number":465,"context_line":"          # by some tripleo variables if the default amqp connection is"},{"line_number":466,"context_line":"          # \"detected\""},{"line_number":467,"context_line":"          - collectd_plugin_amqp1_host: {get_param: CollectdAmqpHost}"},{"line_number":468,"context_line":"          - collectd_plugin_amqp1_port: {get_param: CollectdAmqpPort}"},{"line_number":469,"context_line":"          - collectd_plugin_amqp1_user: {get_param: CollectdAmqpUser}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_9171a379","line":466,"range":{"start_line":464,"start_character":10,"end_line":466,"end_character":22},"updated":"2020-08-05 10:40:42.000000000","message":"These commends will be removed too","commit_id":"9ee34879c828e59bd6ad04cbcd21e45834dd4a30"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"edf080212c550ef41e4b3ce6df91ad4b16823a05","unresolved":false,"context_lines":[{"line_number":510,"context_line":"      # TODO:(efoley): Can this be replaced by an ansible_config step?"},{"line_number":511,"context_line":"      # The config_settings are used here somehow"},{"line_number":512,"context_line":"      # puppet_config: {}  # no-op anymore"},{"line_number":513,"context_line":"      kolla_config:"},{"line_number":514,"context_line":"        /var/lib/kolla/config_files/collectd.json:"},{"line_number":515,"context_line":"          command: /usr/sbin/collectd -f"},{"line_number":516,"context_line":"          config_files:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_d14e7b36","line":513,"range":{"start_line":513,"start_character":6,"end_line":513,"end_character":19},"updated":"2020-08-05 10:40:42.000000000","message":"AFAICT, the deployment is now getting to the point where kolla is trying to deploy, however, there seems to be a few issues with the package compatibility, and tripleo_container_manage, so I have to rebuild/refresh my environment to get the latest set of compatible versions of everything.","commit_id":"9ee34879c828e59bd6ad04cbcd21e45834dd4a30"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"edf080212c550ef41e4b3ce6df91ad4b16823a05","unresolved":false,"context_lines":[{"line_number":563,"context_line":"            name: tripleo_collectd"},{"line_number":564,"context_line":"          vars:"},{"line_number":565,"context_line":"            - deploy_stage: \"deploy_steps_tasks\""},{"line_number":566,"context_line":"            # TODO(efoley): Is this step var available in this context? Previous embedded ansible did this"},{"line_number":567,"context_line":"            # I *think* this should be available automatically, and doesn\u0027t need to be passed explicitly here."},{"line_number":568,"context_line":"            #- step: \"{{ step }}\""},{"line_number":569,"context_line":"            - {get_attr: [RoleParametersValue, value]}"},{"line_number":570,"context_line":"      host_prep_tasks:"},{"line_number":571,"context_line":"        - name: \"Collectd host prep tasks\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_3161b7aa","line":568,"range":{"start_line":566,"start_character":12,"end_line":568,"end_character":33},"updated":"2020-08-05 10:40:42.000000000","message":"This will be removed","commit_id":"9ee34879c828e59bd6ad04cbcd21e45834dd4a30"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"edf080212c550ef41e4b3ce6df91ad4b16823a05","unresolved":false,"context_lines":[{"line_number":581,"context_line":"            name: tripleo_collectd"},{"line_number":582,"context_line":"          vars:"},{"line_number":583,"context_line":"             - deploy_stage: \"fast_forward_upgrade_tasks\""},{"line_number":584,"context_line":"             # TODO(efoley): Is this the correct way to add this step var to the ansible?"},{"line_number":585,"context_line":"             # Is it already available somehow, like it was for the embedded ansible?"},{"line_number":586,"context_line":"             # - step: \"{{ step }}\""},{"line_number":587,"context_line":"             # Assuming that release is also already present as well as step"},{"line_number":588,"context_line":"             # - release: \"{{ release }}\""},{"line_number":589,"context_line":"             - {get_attr: [RoleParametersValue, value]}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_b174a769","line":588,"range":{"start_line":584,"start_character":1,"end_line":588,"end_character":41},"updated":"2020-08-05 10:40:42.000000000","message":"This is to be removed","commit_id":"9ee34879c828e59bd6ad04cbcd21e45834dd4a30"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"7aaa9c34a3f6a3b34e34d626c7fcc52b16e903eb","unresolved":false,"context_lines":[{"line_number":3,"context_line":"description: Configure a test role to use ansible"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"parameters:"},{"line_number":6,"context_line":"  # These following parameters are needed by TripleO AFAICT"},{"line_number":7,"context_line":"  EndpointMap:"},{"line_number":8,"context_line":"    default: {}"},{"line_number":9,"context_line":"    description: Mapping of service endpoint -\u003e protocol. Typically set"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_f4db75e9","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":59},"updated":"2020-09-01 20:15:27.000000000","message":"These params are needed by Tripleo. But this comment is not","commit_id":"7ddb3982a3558fc7ddecbc889d5a177d62422ba0"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"7aaa9c34a3f6a3b34e34d626c7fcc52b16e903eb","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    description: Parameters specific to the role"},{"line_number":32,"context_line":"    type: json"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  # These ones are questionably needed, based on the names."},{"line_number":35,"context_line":"  # Probably required for interacting with OpenStack services, and maybe"},{"line_number":36,"context_line":"  # shouldn\u0027t be handled by an external collectd role."},{"line_number":37,"context_line":"  GnocchiPassword:"},{"line_number":38,"context_line":"    type: string"},{"line_number":39,"context_line":"    description: The password for the gnocchi service and db account."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_94d159cf","line":36,"range":{"start_line":34,"start_character":0,"end_line":36,"end_character":54},"updated":"2020-09-01 20:15:27.000000000","message":"This needs to be deleted","commit_id":"7ddb3982a3558fc7ddecbc889d5a177d62422ba0"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"7aaa9c34a3f6a3b34e34d626c7fcc52b16e903eb","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    description: The container image to use for the collectd config_volume"},{"line_number":51,"context_line":"    type: string"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  # These are used as configuration options for AMQP if the default connection is not used."},{"line_number":54,"context_line":"  MetricsQdrPort:"},{"line_number":55,"context_line":"    default: 5666"},{"line_number":56,"context_line":"    description: Service name or port number on which the qdrouterd will accept"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_74c80521","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":91},"updated":"2020-09-01 20:15:27.000000000","message":"This comment needs to be deleted","commit_id":"7ddb3982a3558fc7ddecbc889d5a177d62422ba0"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"56713d7cbb9f730ec9e38bc5e7f89d86a1442d5f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    type: string"},{"line_number":73,"context_line":"  CollectdConnectionType:"},{"line_number":74,"context_line":"    default: \u0027amqp1\u0027"},{"line_number":75,"context_line":"    description: Define which write plugin should collectd use. Currently"},{"line_number":76,"context_line":"                 supported are \u0027amqp1\u0027, \u0027network\u0027 and \u0027gnocchi\u0027."},{"line_number":77,"context_line":"    type: string"},{"line_number":78,"context_line":"  CollectdDefaultPollingInterval:"},{"line_number":79,"context_line":"    default: 120"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_858d4e2c","line":76,"range":{"start_line":75,"start_character":3,"end_line":76,"end_character":64},"updated":"2020-10-21 10:21:11.000000000","message":"A constraint should be added here","commit_id":"7ddb3982a3558fc7ddecbc889d5a177d62422ba0"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"7aaa9c34a3f6a3b34e34d626c7fcc52b16e903eb","unresolved":false,"context_lines":[{"line_number":83,"context_line":"      the resolution of the collected data. This value can be overridden per"},{"line_number":84,"context_line":"      plugin(per role) by setting \"::collectd::plugin::\u003cplugin_name\u003e::interval\""},{"line_number":85,"context_line":"      key in ExtraConfig(\u003crole_name\u003eExtraConfig)."},{"line_number":86,"context_line":"  # TODO: How is a comma delimited list manifested in the outputs?"},{"line_number":87,"context_line":"  # deal with?"},{"line_number":88,"context_line":"  CollectdDefaultPlugins:"},{"line_number":89,"context_line":"    default:"},{"line_number":90,"context_line":"      - cpu"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_344dedc3","line":87,"range":{"start_line":86,"start_character":0,"end_line":87,"end_character":14},"updated":"2020-09-01 20:15:27.000000000","message":"This needs to be deleted","commit_id":"7ddb3982a3558fc7ddecbc889d5a177d62422ba0"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"56713d7cbb9f730ec9e38bc5e7f89d86a1442d5f","unresolved":false,"context_lines":[{"line_number":152,"context_line":"          - Sign"},{"line_number":153,"context_line":"          - Encrypt"},{"line_number":154,"context_line":"  #TODO(efoley): Add in constraints here, and whereever there\u0027s a list of constraints."},{"line_number":155,"context_line":"  CollectdGnocchiAuthMode:"},{"line_number":156,"context_line":"    type: string"},{"line_number":157,"context_line":"    description: \u003e"},{"line_number":158,"context_line":"      Type of authentication Gnocchi server is using. Supported values are"},{"line_number":159,"context_line":"      \u0027basic\u0027 and \u0027keystone\u0027."},{"line_number":160,"context_line":"    default: \u0027keystone\u0027"},{"line_number":161,"context_line":"  CollectdGnocchiProtocol:"},{"line_number":162,"context_line":"    type: string"},{"line_number":163,"context_line":"    description: API protocol Gnocchi server is using."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_fccad89e","line":160,"range":{"start_line":155,"start_character":0,"end_line":160,"end_character":23},"updated":"2020-10-21 10:21:11.000000000","message":"TODO: Add in constraints","commit_id":"7ddb3982a3558fc7ddecbc889d5a177d62422ba0"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"7aaa9c34a3f6a3b34e34d626c7fcc52b16e903eb","unresolved":false,"context_lines":[{"line_number":391,"context_line":"    type: boolean"},{"line_number":392,"context_line":"    description: Set to true to enable mcelog"},{"line_number":393,"context_line":"    default: false"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"  # The existing collectd Parameters should be combined with CollectdVars and all marked for deprecation."},{"line_number":396,"context_line":"  # They will be accepted for backwards compatibility, but new deployments should add the vars"},{"line_number":397,"context_line":"  # directly into the CollectdVars parameter, which will not require anymore change here to add new params."},{"line_number":398,"context_line":"  CollectdVars:"},{"line_number":399,"context_line":"    default: {}"},{"line_number":400,"context_line":"    description: Hash of collectd variables used to configure the collectd role."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_b4e73dac","line":397,"range":{"start_line":394,"start_character":0,"end_line":397,"end_character":107},"updated":"2020-09-01 20:15:27.000000000","message":"This comment will be removed","commit_id":"7ddb3982a3558fc7ddecbc889d5a177d62422ba0"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"7aaa9c34a3f6a3b34e34d626c7fcc52b16e903eb","unresolved":false,"context_lines":[{"line_number":413,"context_line":"      value:"},{"line_number":414,"context_line":"        map_merge:"},{"line_number":415,"context_line":"          - tripleo_role_name: {get_param: RoleName}"},{"line_number":416,"context_line":"          # The first items in this list should be any old collectd-related"},{"line_number":417,"context_line":"          # parameters, using a new key."},{"line_number":418,"context_line":"          # Some of these can be passed straight through to collectd_config"},{"line_number":419,"context_line":"          # role, but other need some action in the tripleo_collectd role."},{"line_number":420,"context_line":"          # anything that is \"passed straight through\" should use the"},{"line_number":421,"context_line":"          # collectd_ prefix, anything for tripleo should use the tripleo_"},{"line_number":422,"context_line":"          # prefix, as a convention, and so it\u0027s easy to track where the var"},{"line_number":423,"context_line":"          # goes"},{"line_number":424,"context_line":"          - gnocchi_password: {get_param: GnocchiPassword}"},{"line_number":425,"context_line":"          - keystone_region: {get_param: KeystoneRegion}"},{"line_number":426,"context_line":"          - container_collectd_image: {get_param: ContainerCollectdImage}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_d4ff5131","line":423,"range":{"start_line":416,"start_character":8,"end_line":423,"end_character":16},"updated":"2020-09-01 20:15:27.000000000","message":"This comment will be removed.","commit_id":"7ddb3982a3558fc7ddecbc889d5a177d62422ba0"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"7aaa9c34a3f6a3b34e34d626c7fcc52b16e903eb","unresolved":false,"context_lines":[{"line_number":461,"context_line":"          - enable_sqlalchemy_collectd: {get_param: EnableSQLAlchemyCollectd}"},{"line_number":462,"context_line":"          - collectd_sql_alchemy_log_messages: {get_param: CollectdSQLAlchemyLogMessages}"},{"line_number":463,"context_line":"          - collectd_sql_alchemy_bind_host: {get_param: CollectdSQLAlchemyBindHost}"},{"line_number":464,"context_line":"          # TODO: pass these straight through to collectd; They get overwritten"},{"line_number":465,"context_line":"          # by some tripleo variables if the default amqp connection is"},{"line_number":466,"context_line":"          # \"detected\""},{"line_number":467,"context_line":"          - collectd_plugin_amqp1_host: {get_param: CollectdAmqpHost}"},{"line_number":468,"context_line":"          - collectd_plugin_amqp1_port: {get_param: CollectdAmqpPort}"},{"line_number":469,"context_line":"          - collectd_plugin_amqp1_user: {get_param: CollectdAmqpUser}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_14f6e95d","line":466,"range":{"start_line":464,"start_character":0,"end_line":466,"end_character":22},"updated":"2020-09-01 20:15:27.000000000","message":"This comment will be removed","commit_id":"7ddb3982a3558fc7ddecbc889d5a177d62422ba0"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"7aaa9c34a3f6a3b34e34d626c7fcc52b16e903eb","unresolved":false,"context_lines":[{"line_number":503,"context_line":"    description: Role data for the Collectd service"},{"line_number":504,"context_line":"    value:"},{"line_number":505,"context_line":"      service_name: collectd"},{"line_number":506,"context_line":"      # This section contains key value pairs that are written to the node as hieradata"},{"line_number":507,"context_line":"      # config_settings: {}  # no-op for now"},{"line_number":508,"context_line":"      # service_config_settings: {}"},{"line_number":509,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":510,"context_line":"      # TODO:(efoley): Can this be replaced by an ansible_config step?"},{"line_number":511,"context_line":"      # The config_settings are used here somehow"},{"line_number":512,"context_line":"      # puppet_config: {}  # no-op anymore"},{"line_number":513,"context_line":"      kolla_config:"},{"line_number":514,"context_line":"        /var/lib/kolla/config_files/collectd.json:"},{"line_number":515,"context_line":"          command: /usr/sbin/collectd -f"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_d4511164","line":512,"range":{"start_line":506,"start_character":0,"end_line":512,"end_character":42},"updated":"2020-09-01 20:15:27.000000000","message":"I will remove these comments.","commit_id":"7ddb3982a3558fc7ddecbc889d5a177d62422ba0"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"7aaa9c34a3f6a3b34e34d626c7fcc52b16e903eb","unresolved":false,"context_lines":[{"line_number":510,"context_line":"      # TODO:(efoley): Can this be replaced by an ansible_config step?"},{"line_number":511,"context_line":"      # The config_settings are used here somehow"},{"line_number":512,"context_line":"      # puppet_config: {}  # no-op anymore"},{"line_number":513,"context_line":"      kolla_config:"},{"line_number":514,"context_line":"        /var/lib/kolla/config_files/collectd.json:"},{"line_number":515,"context_line":"          command: /usr/sbin/collectd -f"},{"line_number":516,"context_line":"          config_files:"},{"line_number":517,"context_line":"            # Where is this directory populated?"},{"line_number":518,"context_line":"            - source: \"/var/lib/kolla/config_files/src/*\""},{"line_number":519,"context_line":"              dest: \"/\""},{"line_number":520,"context_line":"              merge: true"},{"line_number":521,"context_line":"              preserve_properties: true"},{"line_number":522,"context_line":"            - source: \"/var/lib/kolla/config_files/src/etc/collectd.d\""},{"line_number":523,"context_line":"              dest: \"/etc/\""},{"line_number":524,"context_line":"              merge: false"},{"line_number":525,"context_line":"              preserve_properties: true"},{"line_number":526,"context_line":"          permissions:"},{"line_number":527,"context_line":"            - path: /var/log/collectd"},{"line_number":528,"context_line":"              owner: collectd:collectd"},{"line_number":529,"context_line":"              recurse: true"},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"      # TODO(efoley): Does this need to be pushed to ansible?"},{"line_number":532,"context_line":"      # Leaving it here should be okay, and it should work as long as the"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_141a69c4","line":529,"range":{"start_line":513,"start_character":7,"end_line":529,"end_character":27},"updated":"2020-09-01 20:15:27.000000000","message":"This section is copied over from the -puppet.yaml, I assume no other changes are needed here.","commit_id":"7ddb3982a3558fc7ddecbc889d5a177d62422ba0"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"7aaa9c34a3f6a3b34e34d626c7fcc52b16e903eb","unresolved":false,"context_lines":[{"line_number":531,"context_line":"      # TODO(efoley): Does this need to be pushed to ansible?"},{"line_number":532,"context_line":"      # Leaving it here should be okay, and it should work as long as the"},{"line_number":533,"context_line":"      # files are in the right place on the host"},{"line_number":534,"context_line":"      docker_config:"},{"line_number":535,"context_line":"        step_5:"},{"line_number":536,"context_line":"          collectd:"},{"line_number":537,"context_line":"            image: {get_param: ContainerCollectdImage}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_d423d103","line":534,"range":{"start_line":534,"start_character":6,"end_line":534,"end_character":20},"updated":"2020-09-01 20:15:27.000000000","message":"This step is copied over from the -puppet.yaml, and is the same as before, except for one volume being updated.\n\nThis is correct, right?\n\nThe new dir (../anisble-generated/.. vs ../puppet-generated/..) is where the generated config files (new ansible role[1] to replace puppet) are outputted.\n\n[1] https://github.com/infrawatch/collectd-config-ansible-role\n[2] https://github.com/infrawatch/tripleo-collectd-ansible-role","commit_id":"7ddb3982a3558fc7ddecbc889d5a177d62422ba0"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"7aaa9c34a3f6a3b34e34d626c7fcc52b16e903eb","unresolved":false,"context_lines":[{"line_number":555,"context_line":"            environment:"},{"line_number":556,"context_line":"              KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"      # Do I run conf here or in external_deploy_tasks?"},{"line_number":559,"context_line":"      # External deploy tasks are tun on the host executing the tripleo overcloud deploy command"},{"line_number":560,"context_line":"      deploy_steps_tasks:"},{"line_number":561,"context_line":"        - name: \"Collectd configuration during deployment\""},{"line_number":562,"context_line":"          import_role:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_749645f2","line":559,"range":{"start_line":558,"start_character":3,"end_line":559,"end_character":96},"updated":"2020-09-01 20:15:27.000000000","message":"This comment will be removed","commit_id":"7ddb3982a3558fc7ddecbc889d5a177d62422ba0"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"7aaa9c34a3f6a3b34e34d626c7fcc52b16e903eb","unresolved":false,"context_lines":[{"line_number":557,"context_line":""},{"line_number":558,"context_line":"      # Do I run conf here or in external_deploy_tasks?"},{"line_number":559,"context_line":"      # External deploy tasks are tun on the host executing the tripleo overcloud deploy command"},{"line_number":560,"context_line":"      deploy_steps_tasks:"},{"line_number":561,"context_line":"        - name: \"Collectd configuration during deployment\""},{"line_number":562,"context_line":"          import_role:"},{"line_number":563,"context_line":"            name: tripleo_collectd"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_b49c5d0e","line":560,"range":{"start_line":560,"start_character":0,"end_line":560,"end_character":25},"updated":"2020-09-01 20:15:27.000000000","message":"Question for reviewers: as a general rule, is this where the tasks that replace puppet should be called?","commit_id":"7ddb3982a3558fc7ddecbc889d5a177d62422ba0"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"7aaa9c34a3f6a3b34e34d626c7fcc52b16e903eb","unresolved":false,"context_lines":[{"line_number":563,"context_line":"            name: tripleo_collectd"},{"line_number":564,"context_line":"          vars:"},{"line_number":565,"context_line":"            - deploy_stage: \"deploy_steps_tasks\""},{"line_number":566,"context_line":"            # TODO(efoley): Is this step var available in this context? Previous embedded ansible did this"},{"line_number":567,"context_line":"            # I *think* this should be available automatically, and doesn\u0027t need to be passed explicitly here."},{"line_number":568,"context_line":"            #- step: \"{{ step }}\""},{"line_number":569,"context_line":"            - {get_attr: [RoleParametersValue, value]}"},{"line_number":570,"context_line":"      host_prep_tasks:"},{"line_number":571,"context_line":"        - name: \"Collectd host prep tasks\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_d48471b3","line":568,"range":{"start_line":566,"start_character":11,"end_line":568,"end_character":33},"updated":"2020-09-01 20:15:27.000000000","message":"step is available in the ansible and doesn\u0027t need to be passed through explicitly.\n\nThis comment will be removed","commit_id":"7ddb3982a3558fc7ddecbc889d5a177d62422ba0"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"7aaa9c34a3f6a3b34e34d626c7fcc52b16e903eb","unresolved":false,"context_lines":[{"line_number":581,"context_line":"            name: tripleo_collectd"},{"line_number":582,"context_line":"          vars:"},{"line_number":583,"context_line":"             - deploy_stage: \"fast_forward_upgrade_tasks\""},{"line_number":584,"context_line":"             # TODO(efoley): Is this the correct way to add this step var to the ansible?"},{"line_number":585,"context_line":"             # Is it already available somehow, like it was for the embedded ansible?"},{"line_number":586,"context_line":"             # - step: \"{{ step }}\""},{"line_number":587,"context_line":"             # Assuming that release is also already present as well as step"},{"line_number":588,"context_line":"             # - release: \"{{ release }}\""},{"line_number":589,"context_line":"             - {get_attr: [RoleParametersValue, value]}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_34904ded","line":588,"range":{"start_line":584,"start_character":13,"end_line":588,"end_character":41},"updated":"2020-09-01 20:15:27.000000000","message":"This comment will be removed","commit_id":"7ddb3982a3558fc7ddecbc889d5a177d62422ba0"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c0b3ae4d8340cb82258bffac1f2d32c7018293f2","unresolved":false,"context_lines":[{"line_number":402,"context_line":"      type: json"},{"line_number":403,"context_line":"      value:"},{"line_number":404,"context_line":"        map_merge:"},{"line_number":405,"context_line":"          - tripleo_role_name: {get_param: RoleName}"},{"line_number":406,"context_line":"          - gnocchi_password: {get_param: GnocchiPassword}"},{"line_number":407,"context_line":"          - keystone_region: {get_param: KeystoneRegion}"},{"line_number":408,"context_line":"          - container_collectd_image: {get_param: ContainerCollectdImage}"},{"line_number":409,"context_line":"          - container_collectd_config_image: {get_param: ContainerCollectdConfigImage}"},{"line_number":410,"context_line":"          - metrics_qdr_port: {get_param: MetricsQdrPort}"},{"line_number":411,"context_line":"          - metrics_qdr_username: {get_param: MetricsQdrUsername}"},{"line_number":412,"context_line":"          - metrics_qdr_password: {get_param: MetricsQdrPassword}"},{"line_number":413,"context_line":"          - monitoring_subscription_collectd: {get_param: MonitoringSubscriptionCollectd}"},{"line_number":414,"context_line":"          - collectd_connection_type: {get_param: CollectdConnectionType}"},{"line_number":415,"context_line":"          - collectd_interval: {get_param: CollectdDefaultPollingInterval}"},{"line_number":416,"context_line":"          - collectd_default_plugins: {get_param: CollectdDefaultPlugins}"},{"line_number":417,"context_line":"          - collectd_extra_plugins: {get_param: CollectdExtraPlugins}"},{"line_number":418,"context_line":"          - collectd_server: {get_param: CollectdServer}"},{"line_number":419,"context_line":"          - collectd_server_port: {get_param: CollectdServerPort}"},{"line_number":420,"context_line":"          - collectd_username: {get_param: CollectdUsername}"},{"line_number":421,"context_line":"          - collectd_password: {get_param: CollectdPassword}"},{"line_number":422,"context_line":"          - collectd_security_level: {get_param: CollectdSecurityLevel}"},{"line_number":423,"context_line":"          - collectd_gnocchi_auth_mode: {get_param: CollectdGnocchiAuthMode}"},{"line_number":424,"context_line":"          - collectd_gnocchi_protocol: {get_param: CollectdGnocchiProtocol}"},{"line_number":425,"context_line":"          - collectd_gnocchi_server: {get_param: CollectdGnocchiServer}"},{"line_number":426,"context_line":"          - collectd_gnocchi_port: {get_param: CollectdGnocchiPort}"},{"line_number":427,"context_line":"          - collectd_gnocchi_user: {get_param: CollectdGnocchiUser}"},{"line_number":428,"context_line":"          - collectd_gnocchi_keystone_auth_url: {get_param: CollectdGnocchiKeystoneAuthUrl}"},{"line_number":429,"context_line":"          - collectd_gnocchi_keystone_username: {get_param: CollectdGnocchiKeystoneUserName}"},{"line_number":430,"context_line":"          - collectd_gnocchi_keystone_userid: {get_param: CollectdGnocchiKeystoneUserId}"},{"line_number":431,"context_line":"          - collectd_gnocchi_keystone_password: {get_param: CollectdGnocchiKeystonePassword}"},{"line_number":432,"context_line":"          - collectd_gnocchi_keystone_project_id: {get_param: CollectdGnocchiKeystoneProjectId}"},{"line_number":433,"context_line":"          - collectd_gnocchi_keystone_project_name: {get_param: CollectdGnocchiKeystoneProjectName}"},{"line_number":434,"context_line":"          - collectd_gnocchi_keystone_user_domain_id: {get_param: CollectdGnocchiKeystoneUserDomainId}"},{"line_number":435,"context_line":"          - collectd_gnocchi_keystone_user_domain_name: {get_param: CollectdGnocchiKeystoneUserDomainName}"},{"line_number":436,"context_line":"          - collectd_gnocchi_keystone_project_domain_id: {get_param: CollectdGnocchiKeystoneProjectDomainId}"},{"line_number":437,"context_line":"          - collectd_gnocchi_keystone_project_domain_name: {get_param: CollectdGnocchiKeystoneProjectDomainName}"},{"line_number":438,"context_line":"          - collectd_gnocchi_keystone_region_name: {get_param: CollectdGnocchiKeystoneRegionName}"},{"line_number":439,"context_line":"          - collectd_gnocchi_keystone_interface: {get_param: CollectdGnocchiKeystoneInterface}"},{"line_number":440,"context_line":"          - collectd_gnocchi_keystone_endpoint: {get_param: CollectdGnocchiKeystoneEndpoint}"},{"line_number":441,"context_line":"          - collectd_gnocchi_resource_type: {get_param: CollectdGnocchiResourceType}"},{"line_number":442,"context_line":"          - collectd_gnocchi_batch_size: {get_param: CollectdGnocchiBatchSize}"},{"line_number":443,"context_line":"          - enable_sqlalchemy_collectd: {get_param: EnableSQLAlchemyCollectd}"},{"line_number":444,"context_line":"          - collectd_sqlalchemy_log_messages: {get_param: CollectdSQLAlchemyLogMessages}"},{"line_number":445,"context_line":"          - collectd_sqlalchemy_bind_host: {get_param: CollectdSQLAlchemyBindHost}"},{"line_number":446,"context_line":"          - collectd_amqp_host: {get_param: CollectdAmqpHost}"},{"line_number":447,"context_line":"          - collectd_plugin_amqp1_port: {get_param: CollectdAmqpPort}"},{"line_number":448,"context_line":"          - collectd_plugin_amqp1_user: {get_param: CollectdAmqpUser}"},{"line_number":449,"context_line":"          - collectd_plugin_amqp1_password: {get_param: CollectdAmqpPassword}"},{"line_number":450,"context_line":"          - collectd_amqp_transport_name: {get_param: CollectdAmqpTransportName}"},{"line_number":451,"context_line":"          - collectd_amqp_address: {get_param: CollectdAmqpAddress}"},{"line_number":452,"context_line":"          - collectd_amqp_instances: {get_param: CollectdAmqpInstances}"},{"line_number":453,"context_line":"          - collectd_amqp_retry_delay: {get_param: CollectdAmqpRetryDelay}"},{"line_number":454,"context_line":"          - collectd_amqp_interval: {get_param: CollectdAmqpInterval}"},{"line_number":455,"context_line":"          - collectd_enable_sensubility: {get_param: CollectdEnableSensubility}"},{"line_number":456,"context_line":"          - collectd_sensubility_exec_sudo_rule: {get_param: CollectdSensubilityExecSudoRule}"},{"line_number":457,"context_line":"          - collectd_sensubility_log_level: {get_param: CollectdSensubilityLogLevel}"},{"line_number":458,"context_line":"          - collectd_sensubility_connection: {get_param: CollectdSensubilityConnection}"},{"line_number":459,"context_line":"          - collectd_sensubility_keepalive_interval: {get_param: CollectdSensubilityKeepaliveInterval}"},{"line_number":460,"context_line":"          - collectd_sensubility_tmp_dir: {get_param: CollectdSensubilityTmpDir}"},{"line_number":461,"context_line":"          - collectd_sensubility_shell_path: {get_param: CollectdSensubilityShellPath}"},{"line_number":462,"context_line":"          - collectd_sensubility_worker_count: {get_param: CollectdSensubilityWorkerCount}"},{"line_number":463,"context_line":"          - collectd_sensubility_checks: {get_param: CollectdSensubilityChecks}"},{"line_number":464,"context_line":"          - collectd_enable_container_health_check: {get_param: CollectdEnableContainerHealthCheck}"},{"line_number":465,"context_line":"          - collectd_container_health_check_command: {get_param: CollectdContainerHealthCheckCommand}"},{"line_number":466,"context_line":"          - collectd_container_health_check_interval: {get_param: CollectdContainerHealthCheckInterval}"},{"line_number":467,"context_line":"          - collectd_container_health_check_handlers: {get_param: CollectdContainerHealthCheckHandlers}"},{"line_number":468,"context_line":"          - collectd_container_health_check_occurances: {get_param: CollectdContainerHealthCheckOccurrences}"},{"line_number":469,"context_line":"          - collectd_container_health_check_refresh: {get_param: CollectdContainerHealthCheckRefresh}"},{"line_number":470,"context_line":"          - enable_stf: {get_param: EnableSTF}"},{"line_number":471,"context_line":"          - collectd_enable_mcelog: {get_param: CollectdEnableMcelog}"},{"line_number":472,"context_line":"          # The last element should be the CollectdVars, which overides any previous deprecated metric."},{"line_number":473,"context_line":"          - { get_param: CollectdVars }"},{"line_number":474,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f621f24_b21d6911","line":471,"range":{"start_line":405,"start_character":10,"end_line":471,"end_character":69},"updated":"2020-10-28 16:42:04.000000000","message":"This could be a single map instead of a large list of single dict items\n\n - collect_d: {get_param: foo}\n   collect_a: {get_param: bar}\n - {get_param: CollectdVars}","commit_id":"8f21e3f280cbb9c7ca267a0271ade75553ce4f90"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e8da11f395f104cf45b40dbc59d41b3ead5a798f","unresolved":true,"context_lines":[{"line_number":414,"context_line":"        - name: Configure container healthchecks"},{"line_number":415,"context_line":"          when:"},{"line_number":416,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":417,"context_line":"          import_role:"},{"line_number":418,"context_line":"            name: tripleo_collectd"},{"line_number":419,"context_line":"            tasks_from: configure_healthcheck"},{"line_number":420,"context_line":"          vars:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"2625ed18_54f4daeb","line":417,"range":{"start_line":417,"start_character":10,"end_line":417,"end_character":21},"updated":"2021-03-22 15:28:24.000000000","message":"Please use include_role rather than import role since this has a when condition.","commit_id":"d336c6c2f698d8261bf72cda59e045ef0af2389d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e8da11f395f104cf45b40dbc59d41b3ead5a798f","unresolved":true,"context_lines":[{"line_number":423,"context_line":"        - name: \"Configure collectd\""},{"line_number":424,"context_line":"          when:"},{"line_number":425,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":426,"context_line":"          import_role:"},{"line_number":427,"context_line":"            name: tripleo_collectd"},{"line_number":428,"context_line":"            tasks_from: configure_collectd"},{"line_number":429,"context_line":"          vars:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"72c88e75_9d3b1ca8","line":426,"range":{"start_line":426,"start_character":10,"end_line":426,"end_character":21},"updated":"2021-03-22 15:28:24.000000000","message":"same","commit_id":"d336c6c2f698d8261bf72cda59e045ef0af2389d"}],"environments/metrics/test-collectd-ansible.yaml":[{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"7aaa9c34a3f6a3b34e34d626c7fcc52b16e903eb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# A Heat environment file that enable a test for ansible deployment"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"resource_registry:"},{"line_number":4,"context_line":"  OS::TripleO::Services::Collectd: ../../deployment/metrics/collectd-container-ansible.yaml"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"parameter_defaults:"},{"line_number":7,"context_line":"  CollectdVars:"},{"line_number":8,"context_line":"    param1: \"hello world\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_34a96d23","line":8,"range":{"start_line":4,"start_character":0,"end_line":8,"end_character":25},"updated":"2020-09-01 20:15:27.000000000","message":"This needs to be updated to match the environment files for collectd-container-puppet.yaml","commit_id":"7ddb3982a3558fc7ddecbc889d5a177d62422ba0"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"85553bb122a451d9239327ccbf802ef97e5e446b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"c79d4f19_fdf6b8fd","line":12,"updated":"2021-03-03 19:45:22.000000000","message":"If this is for testing ci/environments/ might be more appropriate","commit_id":"5fbe4ed9db87cf827f93db648ed1a9673105219e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6b8687dd8e0ab9eacef5ce17798a2fdf154fc21c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"1f9deeae_0e7f11bf","line":12,"in_reply_to":"990a5e7c_7b5a55c1","updated":"2021-03-03 20:45:44.000000000","message":"OK. I\u0027d remove it if it\u0027s just for local testing","commit_id":"5fbe4ed9db87cf827f93db648ed1a9673105219e"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"84c23b4f2a3bb46fba5b8a536a3f6d442de47c34","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"990a5e7c_7b5a55c1","line":12,"in_reply_to":"c79d4f19_fdf6b8fd","updated":"2021-03-03 20:35:15.000000000","message":"I was thinking I should remove this, as it was for testing initially. However, at the moment, this is not tested in the CI, as we have one scenario that deploys collectd, and that currently uses puppet.","commit_id":"5fbe4ed9db87cf827f93db648ed1a9673105219e"}]}