)]}'
{"container_config_scripts/manila_ffu_db_sync.sh":[{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"dc97f058a5d7c12794905432e072604b15696601","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# downgraded (which shouldn\u0027t ever happen in tripleo environments)"},{"line_number":20,"context_line":"set -e"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"PRE_DB_SYNC_VERSION\u003d$( sudo -u manila manila-manage db version )"},{"line_number":23,"context_line":"sudo -u manila manila-manage db sync"},{"line_number":24,"context_line":"POST_DB_SYNC_VERSION\u003d$( sudo -u manila manila-manage db version )"},{"line_number":25,"context_line":"echo PRE_UPGRADE_DB_VERSION: $PRE_DB_SYNC_VERSION POST_UPGRADE_DB_VERSION: $POST_DB_SYNC_VERSION"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bf51134e_11df45d6","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":96},"updated":"2020-06-24 14:36:32.000000000","message":"Please check this code in these conditions:\nPre ffwd when db is queens.\nIn ffwd when db is stein.\nIdempotency when db is train.\n\nI worry it will fail at least in the third one.","commit_id":"6b12f0b89e1eeebda613568fea99a4fac53f34cb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8fa13658f4537dd351b25773bfe7d4f60b1d1c76","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# downgraded (which shouldn\u0027t ever happen in tripleo environments)"},{"line_number":20,"context_line":"set -e"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"PRE_DB_SYNC_VERSION\u003d$( sudo -u manila manila-manage db version )"},{"line_number":23,"context_line":"sudo -u manila manila-manage db sync"},{"line_number":24,"context_line":"POST_DB_SYNC_VERSION\u003d$( sudo -u manila manila-manage db version )"},{"line_number":25,"context_line":"echo PRE_UPGRADE_DB_VERSION: $PRE_DB_SYNC_VERSION POST_UPGRADE_DB_VERSION: $POST_DB_SYNC_VERSION"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bf51134e_4c31265a","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":96},"in_reply_to":"bf51134e_11df45d6","updated":"2020-06-24 15:05:06.000000000","message":"How do you see this failing?\n\nAt any point, are we going to be executing a sync from a older version of the code to a newer version of the DB?","commit_id":"6b12f0b89e1eeebda613568fea99a4fac53f34cb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c69135148bd7f6c467176865f546b2d4a30b1e31","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# downgraded (which shouldn\u0027t ever happen in tripleo environments)"},{"line_number":20,"context_line":"set -e"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"PRE_DB_SYNC_VERSION\u003d$( sudo -u manila manila-manage db version )"},{"line_number":23,"context_line":"sudo -u manila manila-manage db sync"},{"line_number":24,"context_line":"POST_DB_SYNC_VERSION\u003d$( sudo -u manila manila-manage db version )"},{"line_number":25,"context_line":"echo PRE_UPGRADE_DB_VERSION: $PRE_DB_SYNC_VERSION POST_UPGRADE_DB_VERSION: $POST_DB_SYNC_VERSION"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bf51134e_172bab82","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":96},"in_reply_to":"bf51134e_2ce2f2a0","updated":"2020-06-25 03:57:20.000000000","message":"This script was corrected after Lukas and Jesse explained the upgrade dance that might occur during FFU, and for the need for a different kind of idempotence, one where there may indeed be a db_sync with older code, after the database has been upgraded. \n\nThe script in the latest patch set:\n\na) identifies the database version, and compares it against the max version from the code\nb) if the versions don\u0027t match, checks if the database version is in the versions from code, if yes - it will invoke \"db sync\" to catch up, since the code brings in a newer version\nc) if the db version isn\u0027t in the code, it can only mean that the code is older than the database, and a sync isn\u0027t necessary.","commit_id":"6b12f0b89e1eeebda613568fea99a4fac53f34cb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"403e63b73e6dda38925e3c482adc8297d1ccc4be","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# downgraded (which shouldn\u0027t ever happen in tripleo environments)"},{"line_number":20,"context_line":"set -e"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"PRE_DB_SYNC_VERSION\u003d$( sudo -u manila manila-manage db version )"},{"line_number":23,"context_line":"sudo -u manila manila-manage db sync"},{"line_number":24,"context_line":"POST_DB_SYNC_VERSION\u003d$( sudo -u manila manila-manage db version )"},{"line_number":25,"context_line":"echo PRE_UPGRADE_DB_VERSION: $PRE_DB_SYNC_VERSION POST_UPGRADE_DB_VERSION: $POST_DB_SYNC_VERSION"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bf51134e_2ce2f2a0","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":96},"in_reply_to":"bf51134e_4c31265a","updated":"2020-06-24 15:14:18.000000000","message":"Just to show you the idempotency, I ran these on different environments:\n\n stable/queens:\n\n\n  ()[root@controller-1 /]# PRE_DB_SYNC_VERSION\u003d$( sudo -u manila manila-manage db version )\n  ()[root@controller-1 /]# sudo -u manila manila-manage db sync\n  ()[root@controller-1 /]# POST_DB_SYNC_VERSION\u003d$( sudo -u manila manila-manage db version )\n  ()[root@controller-1 /]# echo PRE_UPGRADE_DB_VERSION: $PRE_DB_SYNC_VERSION POST_UPGRADE_DB_VERSION: $POST_DB_SYNC_VERSION\n  PRE_UPGRADE_DB_VERSION: 4a482571410f POST_UPGRADE_DB_VERSION: 4a482571410f\n  ()[root@controller-1 /]#  sudo -u manila manila-manage db sync\n  ()[root@controller-1 /]# echo $?\n  0\n\n\n\nOn stable/train:\n\n  ()[root@controller-2 /]# PRE_DB_SYNC_VERSION\u003d$( sudo -u manila manila-manage db version )\n  ()[root@controller-2 /]# sudo -u manila manila-manage db sync\n  ()[root@controller-2 /]# POST_DB_SYNC_VERSION\u003d$( sudo -u manila manila-manage db version )\n  ()[root@controller-2 /]# echo PRE_UPGRADE_DB_VERSION: $PRE_DB_SYNC_VERSION POST_UPGRADE_DB_VERSION: $POST_DB_SYNC_VERSION\n  PRE_UPGRADE_DB_VERSION: 805685098bd2 POST_UPGRADE_DB_VERSION: 805685098bd2\n  ()[root@controller-2 /]# sudo -u manila manila-manage db sync\n  ()[root@controller-2 /]# echo $?\n  0","commit_id":"6b12f0b89e1eeebda613568fea99a4fac53f34cb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1d738084cbc7b7afe5b9b4fdfbe23b8970e49cee","unresolved":false,"context_lines":[{"line_number":28,"context_line":"elif [[ $REPO_VERSIONS \u003d\u003d *\"$DB_VERSION\"* ]]; then"},{"line_number":29,"context_line":"    # Package provides a newer version, we must upgrade"},{"line_number":30,"context_line":"    sudo -u manila manila-manage db sync"},{"line_number":31,"context_line":"    echo \"Manila DB is upgraded to: $DB_VERSION\""},{"line_number":32,"context_line":"else"},{"line_number":33,"context_line":"    echo \"Manila DB version: $DB_VERSION is higher than the maximum provided by the package $REPO_MAX. Nothing to do\""},{"line_number":34,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"bf51134e_dfbdcfb7","line":31,"range":{"start_line":31,"start_character":37,"end_line":31,"end_character":47},"updated":"2020-06-24 22:45:19.000000000","message":"REPO_MAX","commit_id":"84a7a9e4af944eede7bbd617dee632d73ce808bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1d738084cbc7b7afe5b9b4fdfbe23b8970e49cee","unresolved":false,"context_lines":[{"line_number":28,"context_line":"elif [[ $REPO_VERSIONS \u003d\u003d *\"$DB_VERSION\"* ]]; then"},{"line_number":29,"context_line":"    # Package provides a newer version, we must upgrade"},{"line_number":30,"context_line":"    sudo -u manila manila-manage db sync"},{"line_number":31,"context_line":"    echo \"Manila DB is upgraded to: $DB_VERSION\""},{"line_number":32,"context_line":"else"},{"line_number":33,"context_line":"    echo \"Manila DB version: $DB_VERSION is higher than the maximum provided by the package $REPO_MAX. Nothing to do\""},{"line_number":34,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"bf51134e_3fb16be2","line":31,"range":{"start_line":31,"start_character":37,"end_line":31,"end_character":47},"updated":"2020-06-24 22:45:19.000000000","message":"REPO_MAX\n\n\nsigh.","commit_id":"9ac69e5ab57f28b8d1fa8a5c381032b4c261411d"}],"deployment/manila/manila-share-container-puppet.yaml":[{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"dc97f058a5d7c12794905432e072604b15696601","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            path: /etc/ceph"},{"line_number":173,"context_line":"            state: directory"},{"line_number":174,"context_line":"      upgrade_tasks: []"},{"line_number":175,"context_line":"      fast_forward_upgrade_tasks:"},{"line_number":176,"context_line":"        - when:"},{"line_number":177,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":178,"context_line":"            - release \u003d\u003d \u0027rocky\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_91ecf58f","line":175,"range":{"start_line":175,"start_character":5,"end_line":175,"end_character":33},"updated":"2020-06-24 14:36:32.000000000","message":"sorry these tasks are dead code, you didn\u0027t have to update this.","commit_id":"6b12f0b89e1eeebda613568fea99a4fac53f34cb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"49316b2066d8da70e5b15b0c1cf90c6a8858bb40","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            path: /etc/ceph"},{"line_number":173,"context_line":"            state: directory"},{"line_number":174,"context_line":"      upgrade_tasks: []"},{"line_number":175,"context_line":"      fast_forward_upgrade_tasks:"},{"line_number":176,"context_line":"        - when:"},{"line_number":177,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":178,"context_line":"            - release \u003d\u003d \u0027rocky\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_973e9bbe","line":175,"range":{"start_line":175,"start_character":5,"end_line":175,"end_character":33},"in_reply_to":"bf51134e_8c9b3e64","updated":"2020-06-25 03:57:41.000000000","message":"I\u0027ve reverted changes to \"fast_forward_upgrade_tasks\" in all the files","commit_id":"6b12f0b89e1eeebda613568fea99a4fac53f34cb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8fa13658f4537dd351b25773bfe7d4f60b1d1c76","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            path: /etc/ceph"},{"line_number":173,"context_line":"            state: directory"},{"line_number":174,"context_line":"      upgrade_tasks: []"},{"line_number":175,"context_line":"      fast_forward_upgrade_tasks:"},{"line_number":176,"context_line":"        - when:"},{"line_number":177,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":178,"context_line":"            - release \u003d\u003d \u0027rocky\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_8c9b3e64","line":175,"range":{"start_line":175,"start_character":5,"end_line":175,"end_character":33},"in_reply_to":"bf51134e_91ecf58f","updated":"2020-06-24 15:05:06.000000000","message":"Hmm, I see - I can revert this, and the one on https://review.opendev.org/#/c/737602/3/deployment/manila/manila-share-pacemaker-puppet.yaml","commit_id":"6b12f0b89e1eeebda613568fea99a4fac53f34cb"}]}