)]}'
{"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"0e41a1fd7f00c7332a975348dd94ce089904339d","unresolved":false,"context_lines":[{"line_number":219,"context_line":"          block:"},{"line_number":220,"context_line":"            - name: unmount and remove nfs glance entry"},{"line_number":221,"context_line":"              mount: path\u003d/var/lib/glance/images state\u003dabsent"},{"line_number":222,"context_line":"              ignore_errors: yes"},{"line_number":223,"context_line":"            - name: unmount and remove nfs nova entry"},{"line_number":224,"context_line":"              mount: path\u003d/var/lib/nova/instances state\u003dabsent"},{"line_number":225,"context_line":"              ignore_errors: yes"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_dc3444fe","line":222,"range":{"start_line":222,"start_character":14,"end_line":222,"end_character":32},"updated":"2020-07-03 12:51:52.000000000","message":"if the command fails, who cares?","commit_id":"3acaa97928b7dce61fbed14eeb00a043175a7b6f"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"fedc48f7ef8550ec7dc423922b2f20948c0bab98","unresolved":false,"context_lines":[{"line_number":219,"context_line":"          block:"},{"line_number":220,"context_line":"            - name: unmount and remove nfs glance entry"},{"line_number":221,"context_line":"              mount: path\u003d/var/lib/glance/images state\u003dabsent"},{"line_number":222,"context_line":"              ignore_errors: yes"},{"line_number":223,"context_line":"            - name: unmount and remove nfs nova entry"},{"line_number":224,"context_line":"              mount: path\u003d/var/lib/nova/instances state\u003dabsent"},{"line_number":225,"context_line":"              ignore_errors: yes"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_d787fd60","line":222,"range":{"start_line":222,"start_character":14,"end_line":222,"end_character":32},"in_reply_to":"bf51134e_dc3444fe","updated":"2020-07-03 13:08:39.000000000","message":"so the reason for ignoring is that we don\u0027t even know if the give environment is using nfs or not, but if we\u0027re unable to unmount it\u0027s fine for leapp to stop and require further manual steps\n\nalso this will run on any node, including those which don\u0027t mount the remote share so it\u0027s likely to file on some","commit_id":"3acaa97928b7dce61fbed14eeb00a043175a7b6f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b129840e62dc1bd66da5eae01d0b946361793782","unresolved":false,"context_lines":[{"line_number":224,"context_line":"          block:"},{"line_number":225,"context_line":"            - name: unmount and remove nfs glance entry"},{"line_number":226,"context_line":"              mount: path\u003d/var/lib/glance/images state\u003dabsent"},{"line_number":227,"context_line":"              ignore_errors: yes"},{"line_number":228,"context_line":"            - name: unmount and remove nfs glance staging entry"},{"line_number":229,"context_line":"              vars:"},{"line_number":230,"context_line":"                glance_node_staging_uri: {get_param: GlanceNodeStagingUri}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_9608c02d","line":227,"updated":"2020-07-07 13:58:33.000000000","message":"s/yes/true/","commit_id":"7488c2934b94ddacdf8f1ff3134434311bbe1dfa"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b129840e62dc1bd66da5eae01d0b946361793782","unresolved":false,"context_lines":[{"line_number":229,"context_line":"              vars:"},{"line_number":230,"context_line":"                glance_node_staging_uri: {get_param: GlanceNodeStagingUri}"},{"line_number":231,"context_line":"              mount: path\u003d\"{{glance_node_staging_uri[7:]}}\" state\u003dabsent"},{"line_number":232,"context_line":"              ignore_errors: yes"},{"line_number":233,"context_line":"            - name: unmount and remove nfs nova entry"},{"line_number":234,"context_line":"              mount: path\u003d/var/lib/nova/instances state\u003dabsent"},{"line_number":235,"context_line":"              ignore_errors: yes"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_f6077c1b","line":232,"updated":"2020-07-07 13:58:33.000000000","message":"ditto","commit_id":"7488c2934b94ddacdf8f1ff3134434311bbe1dfa"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b129840e62dc1bd66da5eae01d0b946361793782","unresolved":false,"context_lines":[{"line_number":232,"context_line":"              ignore_errors: yes"},{"line_number":233,"context_line":"            - name: unmount and remove nfs nova entry"},{"line_number":234,"context_line":"              mount: path\u003d/var/lib/nova/instances state\u003dabsent"},{"line_number":235,"context_line":"              ignore_errors: yes"},{"line_number":236,"context_line":"            - name: set leapp options"},{"line_number":237,"context_line":"              shell: \u003e"},{"line_number":238,"context_line":"                leapp answer --section remove_pam_pkcs11_module_check.confirm\u003dTrue --add"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_d602380b","line":235,"updated":"2020-07-07 13:58:33.000000000","message":"ditto","commit_id":"7488c2934b94ddacdf8f1ff3134434311bbe1dfa"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"edba89a70c066b8ac051508f9ad2644826bfd5f5","unresolved":false,"context_lines":[{"line_number":232,"context_line":"              ignore_errors: yes"},{"line_number":233,"context_line":"            - name: unmount and remove nfs nova entry"},{"line_number":234,"context_line":"              mount: path\u003d/var/lib/nova/instances state\u003dabsent"},{"line_number":235,"context_line":"              ignore_errors: yes"},{"line_number":236,"context_line":"            - name: set leapp options"},{"line_number":237,"context_line":"              shell: \u003e"},{"line_number":238,"context_line":"                leapp answer --section remove_pam_pkcs11_module_check.confirm\u003dTrue --add"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_c529e49b","line":235,"updated":"2020-07-07 11:34:07.000000000","message":"following up on an IRC chat with Michele (thanks for the review), we\u0027re using ignore_erros for two reasons:\n\n1) the task will run on nodes where there won\u0027t be any nfs mounted, for example compute nodes if it is only glance configured to use nfs\n\n2) leapp will block the upgrade if any entry is left in fstab or any filesystem is mounted https://github.com/oamg/leapp-repository/blob/v0.10.0/repos/system_upgrade/el7toel8/actors/checknfs/actor.py\n\nadditional notes:\n\na) leapp will reboot the node, hence we\u0027re guaranteed to cause service disruption already on this node\n\nb) the fstab entry will be recreated and the share mounted later in the upgrade process when the glance or nova templates will recreate it, like it happens at deployment time","commit_id":"7488c2934b94ddacdf8f1ff3134434311bbe1dfa"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"2c05b8136536e557ca073ebd6da375591f70324f","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                leapp upgrade"},{"line_number":244,"context_line":"                {% if upgrade_leapp_debug|default(true) %}--debug{% endif %}"},{"line_number":245,"context_line":"                {% if upgrade_leapp_command_options|default(false) %}{{ upgrade_leapp_command_options }}{% endif %}"},{"line_number":246,"context_line":"              when: upgrade_leapp_enabled"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        - name: system_upgrade_run step 4"},{"line_number":249,"context_line":"          tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_435ada4f","line":246,"updated":"2020-07-08 10:26:41.000000000","message":"Jose, Lukas I guess this condition should be applied to the whole block: ?\n\nI also wonder, as pointed by Erno in [1], do we have guarantee of glance-api being ... or nova guests being migrated, before we try to unmount?\n\nand if not, shall we try that? force stopping glance-api seems safe given the nodes will be rebooted by leapp anyway\n\nmaybe it\u0027d be best to move these lines in the respective glance-api and nova-libvirt templates?\n\n1. https://bugzilla.redhat.com/show_bug.cgi?id\u003d1853433#c6","commit_id":"7488c2934b94ddacdf8f1ff3134434311bbe1dfa"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"258d4962f2384fb2e65e6c01e0421e3add96fff4","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                leapp upgrade"},{"line_number":244,"context_line":"                {% if upgrade_leapp_debug|default(true) %}--debug{% endif %}"},{"line_number":245,"context_line":"                {% if upgrade_leapp_command_options|default(false) %}{{ upgrade_leapp_command_options }}{% endif %}"},{"line_number":246,"context_line":"              when: upgrade_leapp_enabled"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        - name: system_upgrade_run step 4"},{"line_number":249,"context_line":"          tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_cb05607c","line":246,"in_reply_to":"bf51134e_435ada4f","updated":"2020-07-08 12:48:41.000000000","message":"At the point this task is run, there is no service enabled for that node. I mean, we uninstall everything as you can see in https://review.opendev.org/#/c/739219/2/deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml@164 and the cluster is removed for this node, so force stopping glance-api won\u0027t even work as the service won\u0027t be installed in this controller. Or do you mean stopping it for the whole cluster? I guess I miss the overall view on the concern..maybe we could discuss it on irc.","commit_id":"7488c2934b94ddacdf8f1ff3134434311bbe1dfa"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"064a55385b2d0fe53e50f7b636bfdf8f1b09fc32","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                leapp upgrade"},{"line_number":244,"context_line":"                {% if upgrade_leapp_debug|default(true) %}--debug{% endif %}"},{"line_number":245,"context_line":"                {% if upgrade_leapp_command_options|default(false) %}{{ upgrade_leapp_command_options }}{% endif %}"},{"line_number":246,"context_line":"              when: upgrade_leapp_enabled"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        - name: system_upgrade_run step 4"},{"line_number":249,"context_line":"          tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_0b5c787c","line":246,"in_reply_to":"bf51134e_cb05607c","updated":"2020-07-08 12:53:04.000000000","message":"this node only, thanks for confirming that, sounds like we don\u0027t need to force-stop then","commit_id":"7488c2934b94ddacdf8f1ff3134434311bbe1dfa"}]}