)]}'
{"puppet/role.role.j2.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b5a92fdd5a3631c14865055dd968b1498990702d","unresolved":false,"context_lines":[{"line_number":633,"context_line":"            HOSTNAME: {get_attr:[{{server_resource_name}}, name]}"},{"line_number":634,"context_line":"  hosts_entry:"},{"line_number":635,"context_line":"    value:"},{"line_number":636,"context_line":"      list_join:"},{"line_number":637,"context_line":"        - \u0027,\u0027"},{"line_number":638,"context_line":"        - - str_replace:"},{"line_number":639,"context_line":"              template: PRIMARYIP PRIMARYHOST.DOMAIN PRIMARYHOST"},{"line_number":640,"context_line":"              params:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_3c443d1b","line":637,"range":{"start_line":636,"start_character":6,"end_line":637,"end_character":13},"updated":"2020-07-07 07:33:14.000000000","message":"? Do we really want to return a string here?","commit_id":"5dd756b595d65775aa720968f46b994a3f342c1c"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"5c2c99de7406f35141981108b99fd472a79d7c45","unresolved":false,"context_lines":[{"line_number":633,"context_line":"            HOSTNAME: {get_attr:[{{server_resource_name}}, name]}"},{"line_number":634,"context_line":"  hosts_entry:"},{"line_number":635,"context_line":"    value:"},{"line_number":636,"context_line":"      list_join:"},{"line_number":637,"context_line":"        - \u0027,\u0027"},{"line_number":638,"context_line":"        - - str_replace:"},{"line_number":639,"context_line":"              template: PRIMARYIP PRIMARYHOST.DOMAIN PRIMARYHOST"},{"line_number":640,"context_line":"              params:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_3cb9dde8","line":637,"range":{"start_line":636,"start_character":6,"end_line":637,"end_character":13},"in_reply_to":"bf51134e_1c05f9c2","updated":"2020-07-07 07:42:59.000000000","message":"My worry is when do we split it again before writing it to /etc/hosts?\n\nWe don\u0027t want a comma separated entry like this ending up in the hosts file.\n\n  PRIMARYIP PRIMARYHOST.DOMAIN PRIMARYHOST,CTLPLANEIP CTLPLANEHOST.DOMAIN CTLPLANEHOST","commit_id":"5dd756b595d65775aa720968f46b994a3f342c1c"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"199f6de201bd7c58b07d0c95764f5b500ce73191","unresolved":false,"context_lines":[{"line_number":633,"context_line":"            HOSTNAME: {get_attr:[{{server_resource_name}}, name]}"},{"line_number":634,"context_line":"  hosts_entry:"},{"line_number":635,"context_line":"    value:"},{"line_number":636,"context_line":"      list_join:"},{"line_number":637,"context_line":"        - \u0027,\u0027"},{"line_number":638,"context_line":"        - - str_replace:"},{"line_number":639,"context_line":"              template: PRIMARYIP PRIMARYHOST.DOMAIN PRIMARYHOST"},{"line_number":640,"context_line":"              params:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_1c05f9c2","line":637,"range":{"start_line":636,"start_character":6,"end_line":637,"end_character":13},"in_reply_to":"bf51134e_3c443d1b","updated":"2020-07-07 07:36:20.000000000","message":"What\u0027s the issue? It\u0027s just for one node and not a large string. list_concat_unique does not work on deeply nested lists i.e lists containing more lists.","commit_id":"5dd756b595d65775aa720968f46b994a3f342c1c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"311695e1378e719062dba3100a93ecbbc5d85f76","unresolved":false,"context_lines":[{"line_number":633,"context_line":"            HOSTNAME: {get_attr:[{{server_resource_name}}, name]}"},{"line_number":634,"context_line":"  hosts_entry:"},{"line_number":635,"context_line":"    value:"},{"line_number":636,"context_line":"      list_join:"},{"line_number":637,"context_line":"        - \u0027,\u0027"},{"line_number":638,"context_line":"        - - str_replace:"},{"line_number":639,"context_line":"              template: PRIMARYIP PRIMARYHOST.DOMAIN PRIMARYHOST"},{"line_number":640,"context_line":"              params:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_5c14914e","line":637,"range":{"start_line":636,"start_character":6,"end_line":637,"end_character":13},"in_reply_to":"bf51134e_3cb9dde8","updated":"2020-07-07 08:28:53.000000000","message":"please keep this as a list.\nFor large scale, we can be hit be unexpected string size limitations.","commit_id":"5dd756b595d65775aa720968f46b994a3f342c1c"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"c70c20b0cafeec6862e037cef032b6069f9075c0","unresolved":false,"context_lines":[{"line_number":633,"context_line":"            HOSTNAME: {get_attr:[{{server_resource_name}}, name]}"},{"line_number":634,"context_line":"  hosts_entry:"},{"line_number":635,"context_line":"    value:"},{"line_number":636,"context_line":"      list_join:"},{"line_number":637,"context_line":"        - \u0027,\u0027"},{"line_number":638,"context_line":"        - - str_replace:"},{"line_number":639,"context_line":"              template: PRIMARYIP PRIMARYHOST.DOMAIN PRIMARYHOST"},{"line_number":640,"context_line":"              params:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_3f0c2f3a","line":637,"range":{"start_line":636,"start_character":6,"end_line":637,"end_character":13},"in_reply_to":"bf51134e_5c14914e","updated":"2020-07-07 08:31:57.000000000","message":"As mentioned earlier, AFAIK it\u0027s for one node not dependent on size of deployment.","commit_id":"5dd756b595d65775aa720968f46b994a3f342c1c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"12c09af9fb0dccf9eb6978cd2388bc7c3f27a5b8","unresolved":false,"context_lines":[{"line_number":633,"context_line":"            HOSTNAME: {get_attr:[{{server_resource_name}}, name]}"},{"line_number":634,"context_line":"  hosts_entry:"},{"line_number":635,"context_line":"    value:"},{"line_number":636,"context_line":"      list_join:"},{"line_number":637,"context_line":"        - \u0027,\u0027"},{"line_number":638,"context_line":"        - - str_replace:"},{"line_number":639,"context_line":"              template: PRIMARYIP PRIMARYHOST.DOMAIN PRIMARYHOST"},{"line_number":640,"context_line":"              params:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_ff011706","line":637,"range":{"start_line":636,"start_character":6,"end_line":637,"end_character":13},"in_reply_to":"bf51134e_5c14914e","updated":"2020-07-07 08:30:35.000000000","message":"um, wait, what did you mean it\u0027s just for one node? is it?","commit_id":"5dd756b595d65775aa720968f46b994a3f342c1c"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"c70c20b0cafeec6862e037cef032b6069f9075c0","unresolved":false,"context_lines":[{"line_number":633,"context_line":"            HOSTNAME: {get_attr:[{{server_resource_name}}, name]}"},{"line_number":634,"context_line":"  hosts_entry:"},{"line_number":635,"context_line":"    value:"},{"line_number":636,"context_line":"      list_join:"},{"line_number":637,"context_line":"        - \u0027,\u0027"},{"line_number":638,"context_line":"        - - str_replace:"},{"line_number":639,"context_line":"              template: PRIMARYIP PRIMARYHOST.DOMAIN PRIMARYHOST"},{"line_number":640,"context_line":"              params:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_ff2ab77b","line":637,"range":{"start_line":636,"start_character":6,"end_line":637,"end_character":13},"in_reply_to":"bf51134e_ff011706","updated":"2020-07-07 08:31:57.000000000","message":"yes","commit_id":"5dd756b595d65775aa720968f46b994a3f342c1c"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"c85796a4d43c0b36b1089be6cae209ab3682989f","unresolved":false,"context_lines":[{"line_number":633,"context_line":"            HOSTNAME: {get_attr:[{{server_resource_name}}, name]}"},{"line_number":634,"context_line":"  hosts_entry:"},{"line_number":635,"context_line":"    value:"},{"line_number":636,"context_line":"      list_join:"},{"line_number":637,"context_line":"        - \u0027,\u0027"},{"line_number":638,"context_line":"        - - str_replace:"},{"line_number":639,"context_line":"              template: PRIMARYIP PRIMARYHOST.DOMAIN PRIMARYHOST"},{"line_number":640,"context_line":"              params:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_e5693625","line":637,"range":{"start_line":636,"start_character":6,"end_line":637,"end_character":13},"in_reply_to":"bf51134e_ff2ab77b","updated":"2020-07-13 07:19:36.000000000","message":"Removed the list_join part now as there are some hacks here and there which won\u0027t work.\n\n https://github.com/redhat-openstack/infrared/blob/master/infrared/common/roles/tls-everywhere/tasks/post_overcloud.yml#L6-L38","commit_id":"5dd756b595d65775aa720968f46b994a3f342c1c"}]}