)]}'
{"ci/common/vbmc_setup.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1cf8d90c64f4dfcbf0f6887946ed3fca72b5dcb5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      config: |"},{"line_number":19,"context_line":"        #!/bin/bash"},{"line_number":20,"context_line":"        set -e"},{"line_number":21,"context_line":"        dnf install -y python3-virtualbmc libvirt-client libvirt-daemon libvirt qemu-kvm"},{"line_number":22,"context_line":"        systemctl start libvirtd virtualbmc"},{"line_number":23,"context_line":"        git clone https://opendev.org/openstack/ironic /tmp/ironic"},{"line_number":24,"context_line":"        mkdir -p /var/log/bmlogs"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_15fb6347","line":21,"range":{"start_line":21,"start_character":8,"end_line":21,"end_character":11},"updated":"2020-07-17 13:28:26.000000000","message":"train still support centos7 so needs to be more flexible","commit_id":"41dab2b7630e7124dcdfcae9b820ca1dafd33524"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"f25507f99b6e83f5507ec89627fddebb37f67153","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      config: |"},{"line_number":19,"context_line":"        #!/bin/bash"},{"line_number":20,"context_line":"        set -e"},{"line_number":21,"context_line":"        $(command -v dnf || command -v yum) install -y python3-virtualbmc libvirt-client libvirt-daemon libvirt qemu-kvm"},{"line_number":22,"context_line":"        systemctl start libvirtd virtualbmc"},{"line_number":23,"context_line":"        git clone https://opendev.org/openstack/ironic /tmp/ironic"},{"line_number":24,"context_line":"        mkdir -p /var/log/bmlogs"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_3b7be6be","line":21,"range":{"start_line":21,"start_character":55,"end_line":21,"end_character":74},"updated":"2020-07-20 08:38:27.000000000","message":"If we do python*-virtualbmc, yum/dnf will take care of install python2 and python3 version of packages","commit_id":"7b48b87f3da992c6c6f90598c38e23e1cd4a3767"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"70556370e8ea9bbf8549a370b92cac686c1acae3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      config: |"},{"line_number":19,"context_line":"        #!/bin/bash"},{"line_number":20,"context_line":"        set -e"},{"line_number":21,"context_line":"        $(command -v dnf || command -v yum) install -y python3-virtualbmc libvirt-client libvirt-daemon libvirt qemu-kvm"},{"line_number":22,"context_line":"        systemctl start libvirtd virtualbmc"},{"line_number":23,"context_line":"        git clone https://opendev.org/openstack/ironic /tmp/ironic"},{"line_number":24,"context_line":"        mkdir -p /var/log/bmlogs"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_3bf80648","line":21,"updated":"2020-07-20 08:35:29.000000000","message":"i think this should be an if else situation? Like if this is centos/rhel8 then do what you have here, otherwise if it is centos7 then do what we had before.\n\nyou\u0027ve covered the case of dnf vs yum but not python3-virtualbmc for example and what about the epel-release stuff\n\n[EDIT]: \nI just noticed this is a cherrypick so we already merged to master. But that breaks anything that uses vbmc_setup as it was before i.e. centos/rhel7 jobs - i guess we must no longer have centos7 job that tests this vbmc_setup but the correct thing would be to deprecate the centos7 support instead of just ripping it out.","commit_id":"7b48b87f3da992c6c6f90598c38e23e1cd4a3767"}]}