)]}'
{"deployment/tripleo-packages/openvswitch_special_treatment.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6f3cb6c911b937113d184e368b9c64ace1b5d103","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# With the layered product packaging, the key package is rhosp-openvswitch. It depends on"},{"line_number":3,"context_line":"# a openvswitch package that includes the version as part of the name (e.g openvswitch2.10)."},{"line_number":4,"context_line":"# This requires some additional special handling:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_7aff3567","line":1,"updated":"2020-07-24 16:51:53.000000000","message":"too much tasks, i would write a module for that \"tripleo_ovs_upgrade\".","commit_id":"eec005d4434c0a3835786c00dd5373bc55b35279"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"5315bbd46e6e08220afcb1cd08aa9f04cba20492","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# With the layered product packaging, the key package is rhosp-openvswitch. It depends on"},{"line_number":3,"context_line":"# a openvswitch package that includes the version as part of the name (e.g openvswitch2.10)."},{"line_number":4,"context_line":"# This requires some additional special handling:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_dda9c4dd","line":1,"in_reply_to":"9f560f44_2b88d16f","updated":"2020-07-30 13:54:28.000000000","message":"I guess rewriting as module can be follow up. Firstly we need to get done in the same way as it was before. Then improve it.","commit_id":"eec005d4434c0a3835786c00dd5373bc55b35279"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"0f9066c45b1f32d579b7c36b415840cd15618532","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# With the layered product packaging, the key package is rhosp-openvswitch. It depends on"},{"line_number":3,"context_line":"# a openvswitch package that includes the version as part of the name (e.g openvswitch2.10)."},{"line_number":4,"context_line":"# This requires some additional special handling:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_2b88d16f","line":1,"in_reply_to":"9f560f44_7aff3567","updated":"2020-07-24 18:47:45.000000000","message":"This should be ok to do a module https://review.opendev.org/742968","commit_id":"eec005d4434c0a3835786c00dd5373bc55b35279"}],"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"101f2d5936a38a25792e9e114bb380c44cf71c89","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                  - rsync"},{"line_number":249,"context_line":"                state: present"},{"line_number":250,"context_line":"              when: ansible_distribution_major_version \u003d\u003d \u00278\u0027"},{"line_number":251,"context_line":"        # With the layered product packaging, the key package is rhosp-openvswitch. It depends on"},{"line_number":252,"context_line":"        # a openvswitch package that includes the version as part of the name (e.g openvswitch2.10)."},{"line_number":253,"context_line":"        # This requires some additional special handling:"},{"line_number":254,"context_line":"        #   - During an upgrade the package name for openvswitch may change so"},{"line_number":255,"context_line":"        #     upgrading the currently installed package won\u0027t do anything."},{"line_number":256,"context_line":"        #   - The rhosp-openvswitch package \"obsoletes\" several packages,"},{"line_number":257,"context_line":"        #     including older openvswitch packages. This results in a pretty"},{"line_number":258,"context_line":"        #     severe uninstall/install sequence of operations that stops and"},{"line_number":259,"context_line":"        #     removes openvswitch which could break network links required to"},{"line_number":260,"context_line":"        #     continue the upgrade."},{"line_number":261,"context_line":"        #   - To prevent rhosp-openvswitch breaking connectivity, the currently"},{"line_number":262,"context_line":"        #     installed core openvswitch packages need to be erased from the rpm"},{"line_number":263,"context_line":"        #     database but leave the binaries intact. This effectively"},{"line_number":264,"context_line":"        #     short-circuits the obsoletes mechanism in rhosp-openvswitch and"},{"line_number":265,"context_line":"        #     leaves the core elements of openvswitch running. In the future we"},{"line_number":266,"context_line":"        #     may replace this mechanism with \"an upgrade on reboot\".  We only"},{"line_number":267,"context_line":"        #     do this for the core openvswitch packages so other packages"},{"line_number":268,"context_line":"        #     obsoleted by rhosp-openvswitch will be removed when"},{"line_number":269,"context_line":"        #     rhosp-openvswitch is installed/upgraded."},{"line_number":270,"context_line":"        #   - Neither the rhosp-openvswitch nor openvswitch{m.n} package enables"},{"line_number":271,"context_line":"        #     or starts the systemd service so there must always be a task"},{"line_number":272,"context_line":"        #     to ensure that it is enabled or OpenvSwitch functionality won\u0027t be"},{"line_number":273,"context_line":"        #     available on reboot."},{"line_number":274,"context_line":"        #   - With LP, we expect that the core openvswitch package name will"},{"line_number":275,"context_line":"        #     change with every major upgrade so this special handling will"},{"line_number":276,"context_line":"        #     eventually replace the special handling of upgrading the"},{"line_number":277,"context_line":"        #     openvswitch package \"in place\""},{"line_number":278,"context_line":"        - import_tasks: openvswitch_special_treatment.yaml"},{"line_number":279,"context_line":"          when:"},{"line_number":280,"context_line":"            - step|int \u003d\u003d 2"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_6b2ff487","line":277,"range":{"start_line":251,"start_character":0,"end_line":277,"end_character":44},"updated":"2020-07-24 07:56:21.000000000","message":"I would move that comment block in the task file","commit_id":"c884c57898510e02fc3b21f07bd77cc01fef83e3"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"0f9066c45b1f32d579b7c36b415840cd15618532","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                  - rsync"},{"line_number":249,"context_line":"                state: present"},{"line_number":250,"context_line":"              when: ansible_distribution_major_version \u003d\u003d \u00278\u0027"},{"line_number":251,"context_line":"        # With the layered product packaging, the key package is rhosp-openvswitch. It depends on"},{"line_number":252,"context_line":"        # a openvswitch package that includes the version as part of the name (e.g openvswitch2.10)."},{"line_number":253,"context_line":"        # This requires some additional special handling:"},{"line_number":254,"context_line":"        #   - During an upgrade the package name for openvswitch may change so"},{"line_number":255,"context_line":"        #     upgrading the currently installed package won\u0027t do anything."},{"line_number":256,"context_line":"        #   - The rhosp-openvswitch package \"obsoletes\" several packages,"},{"line_number":257,"context_line":"        #     including older openvswitch packages. This results in a pretty"},{"line_number":258,"context_line":"        #     severe uninstall/install sequence of operations that stops and"},{"line_number":259,"context_line":"        #     removes openvswitch which could break network links required to"},{"line_number":260,"context_line":"        #     continue the upgrade."},{"line_number":261,"context_line":"        #   - To prevent rhosp-openvswitch breaking connectivity, the currently"},{"line_number":262,"context_line":"        #     installed core openvswitch packages need to be erased from the rpm"},{"line_number":263,"context_line":"        #     database but leave the binaries intact. This effectively"},{"line_number":264,"context_line":"        #     short-circuits the obsoletes mechanism in rhosp-openvswitch and"},{"line_number":265,"context_line":"        #     leaves the core elements of openvswitch running. In the future we"},{"line_number":266,"context_line":"        #     may replace this mechanism with \"an upgrade on reboot\".  We only"},{"line_number":267,"context_line":"        #     do this for the core openvswitch packages so other packages"},{"line_number":268,"context_line":"        #     obsoleted by rhosp-openvswitch will be removed when"},{"line_number":269,"context_line":"        #     rhosp-openvswitch is installed/upgraded."},{"line_number":270,"context_line":"        #   - Neither the rhosp-openvswitch nor openvswitch{m.n} package enables"},{"line_number":271,"context_line":"        #     or starts the systemd service so there must always be a task"},{"line_number":272,"context_line":"        #     to ensure that it is enabled or OpenvSwitch functionality won\u0027t be"},{"line_number":273,"context_line":"        #     available on reboot."},{"line_number":274,"context_line":"        #   - With LP, we expect that the core openvswitch package name will"},{"line_number":275,"context_line":"        #     change with every major upgrade so this special handling will"},{"line_number":276,"context_line":"        #     eventually replace the special handling of upgrading the"},{"line_number":277,"context_line":"        #     openvswitch package \"in place\""},{"line_number":278,"context_line":"        - import_tasks: openvswitch_special_treatment.yaml"},{"line_number":279,"context_line":"          when:"},{"line_number":280,"context_line":"            - step|int \u003d\u003d 2"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_8ebed6fc","line":277,"range":{"start_line":251,"start_character":0,"end_line":277,"end_character":44},"in_reply_to":"bf51134e_6b2ff487","updated":"2020-07-24 18:47:45.000000000","message":"Thanks for pointing that out.","commit_id":"c884c57898510e02fc3b21f07bd77cc01fef83e3"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"8a23709d920dbe33b2c6bf9029786125c2ece087","unresolved":false,"context_lines":[{"line_number":338,"context_line":"          vars:"},{"line_number":339,"context_line":"            skip_package_update: {get_param: SkipPackageUpdate}"},{"line_number":340,"context_line":"        # This is failsafe unless openvswitch package does something to the systemd service state."},{"line_number":341,"context_line":"        - name: Ensure openvswitch is running after update"},{"line_number":342,"context_line":"          when: step|int \u003d\u003d 3"},{"line_number":343,"context_line":"          service:"},{"line_number":344,"context_line":"            name: openvswitch"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9f560f44_3e50c8d4","line":341,"updated":"2020-07-29 17:42:45.000000000","message":"Boy ... so this will fail with overcloud-minimal when ovs is not installed.\n\nI propose that we fix that in a following up review.  We should first detect that ovs is installed, then make the check.\n\nOr we can remove it, as everything ovs should be settled in step2.","commit_id":"2142f91aebbc9b5ca3140605f0701e08d0449a29"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"27a52845f067fceca0aa76915941d684a70b0465","unresolved":false,"context_lines":[{"line_number":338,"context_line":"          vars:"},{"line_number":339,"context_line":"            skip_package_update: {get_param: SkipPackageUpdate}"},{"line_number":340,"context_line":"        # This is failsafe unless openvswitch package does something to the systemd service state."},{"line_number":341,"context_line":"        - name: Ensure openvswitch is running after update"},{"line_number":342,"context_line":"          when: step|int \u003d\u003d 3"},{"line_number":343,"context_line":"          service:"},{"line_number":344,"context_line":"            name: openvswitch"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9f560f44_9e2e3441","line":341,"in_reply_to":"9f560f44_3e50c8d4","updated":"2020-07-29 17:45:21.000000000","message":"If we want to keep it nevertheless, a way to check if ovs is installed would be to add a \"check\" parameter to the tripleo_ovs_upgrade module.  It would just return something true when ovs is there... just a though.","commit_id":"2142f91aebbc9b5ca3140605f0701e08d0449a29"}],"deployment/undercloud/undercloud-upgrade.yaml":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"101f2d5936a38a25792e9e114bb380c44cf71c89","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        #     change with every major upgrade so this special handling will"},{"line_number":88,"context_line":"        #     eventually replace the special handling of upgrading the"},{"line_number":89,"context_line":"        #     openvswitch package \"in place\""},{"line_number":90,"context_line":"        - name: Get current OpenvSwitch package name"},{"line_number":91,"context_line":"          register: ovs_pkg_out"},{"line_number":92,"context_line":"          shell:"},{"line_number":93,"context_line":"            rpm -qa | awk -F- \u0027/^(openvswitch[0-9]+\\.[0-9]+-[0-9]+\\.[0-9]+\\.[-0]+-|openvswitch-2)/{print $1}\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_ab290c8a","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":52},"updated":"2020-07-24 07:56:21.000000000","message":"That needs additional testing but we can also use the new common task here for undercloud upgrade","commit_id":"c884c57898510e02fc3b21f07bd77cc01fef83e3"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"0f9066c45b1f32d579b7c36b415840cd15618532","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        #     change with every major upgrade so this special handling will"},{"line_number":88,"context_line":"        #     eventually replace the special handling of upgrading the"},{"line_number":89,"context_line":"        #     openvswitch package \"in place\""},{"line_number":90,"context_line":"        - name: Get current OpenvSwitch package name"},{"line_number":91,"context_line":"          register: ovs_pkg_out"},{"line_number":92,"context_line":"          shell:"},{"line_number":93,"context_line":"            rpm -qa | awk -F- \u0027/^(openvswitch[0-9]+\\.[0-9]+-[0-9]+\\.[0-9]+\\.[-0]+-|openvswitch-2)/{print $1}\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_0e400607","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":52},"in_reply_to":"bf51134e_ab290c8a","updated":"2020-07-24 18:47:45.000000000","message":"Oh, nice catch.  Done.","commit_id":"c884c57898510e02fc3b21f07bd77cc01fef83e3"}]}