)]}'
{"deployment/nova/nova-vnc-proxy-container-puppet.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"32ee8d49b2225a70f32362245f22a03e8a1cead0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                 \u0027default\u0027, \u0027tlsv1_1\u0027, \u0027tlsv1_2\u0027, and \u0027tlsv1_3\u0027.  A value of"},{"line_number":79,"context_line":"                 \u0027default\u0027 will use the underlying system OpenSSL defaults."},{"line_number":80,"context_line":"    constraints:"},{"line_number":81,"context_line":"    - allowed_values: [\u0027default\u0027, \u0027tlsv1_1\u0027, \u0027tlsv1_2\u0027, \u0027tlsv1_3\u0027]"},{"line_number":82,"context_line":"  StackUpdateType:"},{"line_number":83,"context_line":"    type: string"},{"line_number":84,"context_line":"    description: \u003e"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_5c0c5f40","line":81,"range":{"start_line":81,"start_character":23,"end_line":81,"end_character":24},"updated":"2020-08-03 18:53:27.000000000","message":"You can\u0027t unset it because you dropped the \u0027\u0027.  This might break upgrades for folks show didn\u0027t have the previous version defined. I would leave \u0027\u0027 in here","commit_id":"e1d2ece7858bb03a00ee2412b8044e3ab34d7202"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"30ea42e58a7d98eb98aa8dbc4f3e26be63b9799e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                 \u0027default\u0027, \u0027tlsv1_1\u0027, \u0027tlsv1_2\u0027, and \u0027tlsv1_3\u0027.  A value of"},{"line_number":79,"context_line":"                 \u0027default\u0027 will use the underlying system OpenSSL defaults."},{"line_number":80,"context_line":"    constraints:"},{"line_number":81,"context_line":"    - allowed_values: [\u0027default\u0027, \u0027tlsv1_1\u0027, \u0027tlsv1_2\u0027, \u0027tlsv1_3\u0027]"},{"line_number":82,"context_line":"  StackUpdateType:"},{"line_number":83,"context_line":"    type: string"},{"line_number":84,"context_line":"    description: \u003e"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_df8a2168","line":81,"range":{"start_line":81,"start_character":23,"end_line":81,"end_character":24},"in_reply_to":"9f560f44_1f5ad928","updated":"2020-08-03 19:02:59.000000000","message":"My concern was that someone deployed and had thei NovaVNCProxySSLMInimumVersion set to \u0027\u0027. If they update/upgrade, now it would still be \u0027\u0027 in the plan and it\u0027ll cause problems. That being said, it\u0027ll fail heat validation which is before the deploy but that UX can be awful.  Since setting it to \u0027\u0027 fails the container, i guess they wouldn\u0027t be able to use that value no matter what.  You could leave \u0027\u0027 and then do a condition that swaps it to \u0027default\u0027, but that is probably too much overhead.","commit_id":"e1d2ece7858bb03a00ee2412b8044e3ab34d7202"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"441b4084844a8eea03efe115d0f873039e3d47bf","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                 \u0027default\u0027, \u0027tlsv1_1\u0027, \u0027tlsv1_2\u0027, and \u0027tlsv1_3\u0027.  A value of"},{"line_number":79,"context_line":"                 \u0027default\u0027 will use the underlying system OpenSSL defaults."},{"line_number":80,"context_line":"    constraints:"},{"line_number":81,"context_line":"    - allowed_values: [\u0027default\u0027, \u0027tlsv1_1\u0027, \u0027tlsv1_2\u0027, \u0027tlsv1_3\u0027]"},{"line_number":82,"context_line":"  StackUpdateType:"},{"line_number":83,"context_line":"    type: string"},{"line_number":84,"context_line":"    description: \u003e"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_1f5ad928","line":81,"range":{"start_line":81,"start_character":23,"end_line":81,"end_character":24},"in_reply_to":"9f560f44_5c0c5f40","updated":"2020-08-03 18:57:50.000000000","message":"The unset conditional is for NovaVNCProxySSLCiphers, which doesn\u0027t have a default value.\n\nI\u0027m removing \u0027\u0027 here because it\u0027s not actually allowed in nova.\n\nhttps://opendev.org/openstack/nova/src/branch/master/nova/conf/console.py#L63-L73\n\nDid I misinterpret your comment?","commit_id":"e1d2ece7858bb03a00ee2412b8044e3ab34d7202"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d472ae53c13053a02f16857bbe1d607a54968bd8","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                 \u0027default\u0027, \u0027tlsv1_1\u0027, \u0027tlsv1_2\u0027, and \u0027tlsv1_3\u0027.  A value of"},{"line_number":79,"context_line":"                 \u0027default\u0027 will use the underlying system OpenSSL defaults."},{"line_number":80,"context_line":"    constraints:"},{"line_number":81,"context_line":"    - allowed_values: [\u0027default\u0027, \u0027tlsv1_1\u0027, \u0027tlsv1_2\u0027, \u0027tlsv1_3\u0027]"},{"line_number":82,"context_line":"  StackUpdateType:"},{"line_number":83,"context_line":"    type: string"},{"line_number":84,"context_line":"    description: \u003e"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_5fce1182","line":81,"range":{"start_line":81,"start_character":23,"end_line":81,"end_character":24},"in_reply_to":"9f560f44_df8a2168","updated":"2020-08-03 19:30:05.000000000","message":"Well - I think if someone set NovaVNCProxySSLMinimumVersion it would get ignored unless they\u0027re deploying the latest code with https://review.opendev.org/#/c/723920/ , right?","commit_id":"e1d2ece7858bb03a00ee2412b8044e3ab34d7202"}]}