)]}'
{"deployment/metrics/collectd-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8dd06b3bcd8e1c67c4915f097c56d39e106c7907","unresolved":false,"context_lines":[{"line_number":683,"context_line":"                - {get_attr: [ContainersCommon, volumes]}"},{"line_number":684,"context_line":"                -"},{"line_number":685,"context_line":"                  - /var/lib/kolla/config_files/collectd.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":686,"context_line":"                  - /var/lib/containers/storage/overlay-containers/containers.json:ro"},{"line_number":687,"context_line":"                  - /var/lib/config-data/puppet-generated/collectd:/var/lib/kolla/config_files/src:ro"},{"line_number":688,"context_line":"                  - /var/log/containers/collectd:/var/log/collectd:rw,z"},{"line_number":689,"context_line":"                  - /run/:/run:rw"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_e37be288","line":686,"updated":"2020-08-06 10:00:25.000000000","message":"is that file\u0027s contents actually always up to date?","commit_id":"bf70040961fb6b51b8f784af739a69e082937902"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"b935a7a0e2ccb08fbe497c6fecd0ff66a2da5de3","unresolved":false,"context_lines":[{"line_number":683,"context_line":"                - {get_attr: [ContainersCommon, volumes]}"},{"line_number":684,"context_line":"                -"},{"line_number":685,"context_line":"                  - /var/lib/kolla/config_files/collectd.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":686,"context_line":"                  - /var/lib/containers/storage/overlay-containers/containers.json:ro"},{"line_number":687,"context_line":"                  - /var/lib/config-data/puppet-generated/collectd:/var/lib/kolla/config_files/src:ro"},{"line_number":688,"context_line":"                  - /var/log/containers/collectd:/var/log/collectd:rw,z"},{"line_number":689,"context_line":"                  - /run/:/run:rw"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_7e24855e","line":686,"in_reply_to":"9f560f44_e37be288","updated":"2020-08-06 11:18:29.000000000","message":"I think it is, yes.\n\nBut the mount thing is wrong. Please correct the syntax, you\u0027re missing the destination (or the source).\n\nand +1 for the \"ro\" flag.","commit_id":"bf70040961fb6b51b8f784af739a69e082937902"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"7e72fc9d15755414e92b0aac921ce1e82bb52e1b","unresolved":false,"context_lines":[{"line_number":683,"context_line":"                - {get_attr: [ContainersCommon, volumes]}"},{"line_number":684,"context_line":"                -"},{"line_number":685,"context_line":"                  - /var/lib/kolla/config_files/collectd.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":686,"context_line":"                  - /var/lib/containers/storage/overlay-containers/containers.json:/var/lib/containers/storage/overlay-containers/containers.json:ro"},{"line_number":687,"context_line":"                  - /var/lib/config-data/puppet-generated/collectd:/var/lib/kolla/config_files/src:ro"},{"line_number":688,"context_line":"                  - /var/log/containers/collectd:/var/log/collectd:rw,z"},{"line_number":689,"context_line":"                  - /run/:/run:rw"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_5b1b81c8","line":686,"updated":"2020-08-07 05:30:55.000000000","message":"I\u0027m wondering if mounting the plain file like this doesn\u0027t create issues when it gets updated on the host. Did you try it? IIRC there were issues like this for the TLS certificate, leading to mounting the directory instead of the files.\n\nWould be good to test and, maybe, add a note in the commit message. Sorry for not having thought about this potential issue yesterday.","commit_id":"59e9bde60154e4dc89ac6eaa1766d8ddca562086"}]}