)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8b7de7997681ef50b3c2c3105cc0c0358406fda6","unresolved":true,"context_lines":[{"line_number":19,"context_line":"module won\u0027t do anything else. On the contrary, it will disable"},{"line_number":20,"context_line":"the current stream, enable the ones from DnfStreams and synchronize"},{"line_number":21,"context_line":"the content."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"By default the new Heat parameter defaults to empty list and it is"},{"line_number":24,"context_line":"in the environment files where we set the right values depending"},{"line_number":25,"context_line":"on the operation to perform (undercloud upgrade, overcloud update"},{"line_number":26,"context_line":"or overcloud upgrade)."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"[0] - https://docs.ansible.com/ansible/latest/modules/dnf_module.html#examples"},{"line_number":29,"context_line":"Closes-Bug: #1890631"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"db13ebc2_8db97927","line":26,"range":{"start_line":22,"start_character":0,"end_line":26,"end_character":22},"updated":"2020-12-09 16:59:05.000000000","message":"The value is only set in the \u0027prepare\u0027 environment. Does that mean that when anything else is run the updates the stack, these will be removed?","commit_id":"d52994074f50961c6c747775b0a49e5dd3757299"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f80200f9be2a954c94513938c7c8eeb532eec881","unresolved":true,"context_lines":[{"line_number":19,"context_line":"module won\u0027t do anything else. On the contrary, it will disable"},{"line_number":20,"context_line":"the current stream, enable the ones from DnfStreams and synchronize"},{"line_number":21,"context_line":"the content."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"By default the new Heat parameter defaults to empty list and it is"},{"line_number":24,"context_line":"in the environment files where we set the right values depending"},{"line_number":25,"context_line":"on the operation to perform (undercloud upgrade, overcloud update"},{"line_number":26,"context_line":"or overcloud upgrade)."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"[0] - https://docs.ansible.com/ansible/latest/modules/dnf_module.html#examples"},{"line_number":29,"context_line":"Closes-Bug: #1890631"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"ced1025a_fd6b1110","line":26,"range":{"start_line":22,"start_character":0,"end_line":26,"end_character":22},"in_reply_to":"baf4da51_6f761388","updated":"2020-12-16 11:16:56.000000000","message":"If we include the condition for the underlying distro in the parameters provided by DnfStreams then perhaps we can make this more universal?","commit_id":"d52994074f50961c6c747775b0a49e5dd3757299"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"b50e3b7933eef0324072f85649e2f5aeec3a1144","unresolved":true,"context_lines":[{"line_number":19,"context_line":"module won\u0027t do anything else. On the contrary, it will disable"},{"line_number":20,"context_line":"the current stream, enable the ones from DnfStreams and synchronize"},{"line_number":21,"context_line":"the content."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"By default the new Heat parameter defaults to empty list and it is"},{"line_number":24,"context_line":"in the environment files where we set the right values depending"},{"line_number":25,"context_line":"on the operation to perform (undercloud upgrade, overcloud update"},{"line_number":26,"context_line":"or overcloud upgrade)."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"[0] - https://docs.ansible.com/ansible/latest/modules/dnf_module.html#examples"},{"line_number":29,"context_line":"Closes-Bug: #1890631"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"baf4da51_6f761388","line":26,"range":{"start_line":22,"start_character":0,"end_line":26,"end_character":22},"in_reply_to":"db13ebc2_8db97927","updated":"2020-12-14 13:43:50.000000000","message":"Right, these parameters are only being set during the update/upgrade procedures (we automatically import the lifecycle/ environments depending on the action). To get these parameters removed the user needs to override them (at least during a minor update/upgrade) because the inclusion of the lifecycle environment file is invisible to the end user: https://github.com/openstack/python-tripleoclient/blob/10a5c9b66b0196a32df2f692ce7c6a0c6642842c/tripleoclient/v1/undercloud_config.py#L570-L575 and https://github.com/openstack/python-tripleoclient/blob/10a5c9b66b0196a32df2f692ce7c6a0c6642842c/tripleoclient/constants.py#L83-L86","commit_id":"d52994074f50961c6c747775b0a49e5dd3757299"}],"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a86eeeef3aec1f443765d0309cded751cd679c36","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                 Mainly for CI purpose.  It shouldn\u0027t matter on other distributions"},{"line_number":92,"context_line":"                 where it\u0027s disabled in the role. Set to true to skip the enforcement."},{"line_number":93,"context_line":"    type: string"},{"line_number":94,"context_line":"  ContainerToolsStream:"},{"line_number":95,"context_line":"    default: \u00272.0\u0027"},{"line_number":96,"context_line":"    description: Stream to be configured for the container-tools module."},{"line_number":97,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_a18f1828","line":94,"updated":"2020-08-06 20:59:53.000000000","message":"Can we not just add a var for every module and use a json object to do this?","commit_id":"b15c3bc5f458fe797241267c822b7aa6e03093a8"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"c3f28172b664b209ceed664f16bc94530371c915","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                 Mainly for CI purpose.  It shouldn\u0027t matter on other distributions"},{"line_number":92,"context_line":"                 where it\u0027s disabled in the role. Set to true to skip the enforcement."},{"line_number":93,"context_line":"    type: string"},{"line_number":94,"context_line":"  ContainerToolsStream:"},{"line_number":95,"context_line":"    default: \u00272.0\u0027"},{"line_number":96,"context_line":"    description: Stream to be configured for the container-tools module."},{"line_number":97,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_3697c44a","line":94,"in_reply_to":"9f560f44_a18f1828","updated":"2020-08-07 06:39:34.000000000","message":"uhu, funky, that\u0027s more or less what I pointed in the role itself: take a list of dict :).","commit_id":"b15c3bc5f458fe797241267c822b7aa6e03093a8"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a86eeeef3aec1f443765d0309cded751cd679c36","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                    - {get_param: UpgradeInitCommonCommand}"},{"line_number":223,"context_line":"            - name: Ensure container-tools module has the right stream"},{"line_number":224,"context_line":"              include_role:"},{"line_number":225,"context_line":"                name: tripleo-stream-enable"},{"line_number":226,"context_line":"              vars:"},{"line_number":227,"context_line":"                tripleo_stream_enable_module: \"container-tools\""},{"line_number":228,"context_line":"                tripleo_stream_enable_stream: {get_param: ContainerToolsStream}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_01836405","line":225,"updated":"2020-08-06 20:59:53.000000000","message":"tripleo_stream_enable","commit_id":"b15c3bc5f458fe797241267c822b7aa6e03093a8"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"99085634c5a33f2faaf9aa32939e06371fbd1ea5","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                 Mainly for CI purpose.  It shouldn\u0027t matter on other distributions"},{"line_number":92,"context_line":"                 where it\u0027s disabled in the role. Set to true to skip the enforcement."},{"line_number":93,"context_line":"    type: string"},{"line_number":94,"context_line":"  ContainerToolsStream:"},{"line_number":95,"context_line":"    default: [{\u0027module\u0027:\u0027container-tools\u0027, \u0027stream\u0027:\u00272.0\u0027}]"},{"line_number":96,"context_line":"    description: Stream to be configured for the container-tools module."},{"line_number":97,"context_line":"    type: json"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_caf4a68a","line":94,"range":{"start_line":94,"start_character":2,"end_line":94,"end_character":22},"updated":"2020-08-12 09:31:10.000000000","message":"I would rename it to something more generic, especially since the value is now a list of dict.\n\nDnfStreams or something like that would be far better imho.","commit_id":"845528a0316f7129e46f95a805afda2b927d867d"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"99085634c5a33f2faaf9aa32939e06371fbd1ea5","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                  - \u0027\u0027"},{"line_number":221,"context_line":"                  - - \"#!/bin/bash\\n\\n\""},{"line_number":222,"context_line":"                    - {get_param: UpgradeInitCommonCommand}"},{"line_number":223,"context_line":"            - name: Ensure container-tools module has the right stream"},{"line_number":224,"context_line":"              include_role:"},{"line_number":225,"context_line":"                name: tripleo_stream_enable"},{"line_number":226,"context_line":"              vars:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_6a291af1","line":223,"range":{"start_line":223,"start_character":27,"end_line":223,"end_character":42},"updated":"2020-08-12 09:31:10.000000000","message":"here as well - no mention of \"container-tools\", just \"dnf modules\" or something like that.","commit_id":"845528a0316f7129e46f95a805afda2b927d867d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"76f577f196c8b3476cca296dc52410f7e6644eb6","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    type: string"},{"line_number":94,"context_line":"  DnfStreams:"},{"line_number":95,"context_line":"    default: [{\u0027module\u0027:\u0027container-tools\u0027, \u0027stream\u0027:\u00272.0\u0027}]"},{"line_number":96,"context_line":"    description: Streams to be configured befor updating packages. Defaults to"},{"line_number":97,"context_line":"                 container-tools module setting up stream 2.0, as this is"},{"line_number":98,"context_line":"                 currently required for OSP to work."},{"line_number":99,"context_line":"    type: json"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_06a98423","line":96,"updated":"2020-08-28 09:12:59.000000000","message":"before","commit_id":"e3756345428b77f2f0c1e53660d67361ad3a76ad"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"76f577f196c8b3476cca296dc52410f7e6644eb6","unresolved":false,"context_lines":[{"line_number":321,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":322,"context_line":"            - ansible_distribution \u003d\u003d \u0027RedHat\u0027"},{"line_number":323,"context_line":"            - not (skip_rhel_enforcement | bool)"},{"line_number":324,"context_line":"        - name: Ensure DNF modules have the right stream"},{"line_number":325,"context_line":"          include_role:"},{"line_number":326,"context_line":"            name: tripleo-stream-enable"},{"line_number":327,"context_line":"          vars:"},{"line_number":328,"context_line":"            tripleo_stream_enable: {get_param: DnfStreams}"},{"line_number":329,"context_line":"          when:"},{"line_number":330,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":331,"context_line":"            - ansible_distribution \u003d\u003d \u0027RedHat\u0027"},{"line_number":332,"context_line":"            - ansible_distribution_major_version \u003d\u003d \u00278\u0027"},{"line_number":333,"context_line":"        - name: Check for existing yum.pid"},{"line_number":334,"context_line":"          stat:  path\u003d/run/yum.pid"},{"line_number":335,"context_line":"          register: yum_pid_file"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_11f1bc96","line":332,"range":{"start_line":324,"start_character":1,"end_line":332,"end_character":55},"updated":"2020-08-28 09:12:59.000000000","message":"How does this work in downstream CI where I don\u0027t think we have that concept of module when we use rhos-release tool ?","commit_id":"e3756345428b77f2f0c1e53660d67361ad3a76ad"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"ad1777d6195b6920837d033395df019d99956abf","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    type: string"},{"line_number":94,"context_line":"  DnfStreams:"},{"line_number":95,"context_line":"    default: [{\u0027module\u0027:\u0027container-tools\u0027, \u0027stream\u0027:\u00272.0\u0027}]"},{"line_number":96,"context_line":"    description: Streams to be configured befor updating packages. Defaults to"},{"line_number":97,"context_line":"                 container-tools module setting up stream 2.0, as this is"},{"line_number":98,"context_line":"                 currently required for OSP to work."},{"line_number":99,"context_line":"    type: json"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9f560f44_fc55b8fb","line":96,"range":{"start_line":96,"start_character":42,"end_line":96,"end_character":47},"updated":"2020-09-02 10:54:10.000000000","message":"before","commit_id":"699ee541d0d0f131b1163f6db99e025623e2339b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"72d5a919d45571f3ff95f27cbd76855c440c8265","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                 where it\u0027s disabled in the role. Set to true to skip the enforcement."},{"line_number":93,"context_line":"    type: string"},{"line_number":94,"context_line":"  DnfStreams:"},{"line_number":95,"context_line":"    default: [{\u0027module\u0027:\u0027container-tools\u0027, \u0027stream\u0027:\u00272.0\u0027}]"},{"line_number":96,"context_line":"    description: Streams to be configured before updating packages. Defaults to"},{"line_number":97,"context_line":"                 container-tools module setting up stream 2.0, as this is"},{"line_number":98,"context_line":"                 currently required for OSP to work."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_940c5095","line":95,"range":{"start_line":95,"start_character":13,"end_line":95,"end_character":59},"updated":"2020-09-02 15:46:58.000000000","message":"It seems like this should be defined externally rather than being baked into THT. Like something that is provided to the upgrade/update process via the cli since it should know what versions its going from/to. Additionally this likely needs to change for minor releases between things like 8.2 and 8.3 so i\u0027m not certain we should define the defaults here","commit_id":"26d52d5ce9b54517a41a516d4751a1281bd18b41"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"fcb3d834693edacc46f66502587c67c6c5e1014c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                 where it\u0027s disabled in the role. Set to true to skip the enforcement."},{"line_number":93,"context_line":"    type: string"},{"line_number":94,"context_line":"  DnfStreams:"},{"line_number":95,"context_line":"    default: [{\u0027module\u0027:\u0027container-tools\u0027, \u0027stream\u0027:\u00272.0\u0027}]"},{"line_number":96,"context_line":"    description: Streams to be configured before updating packages. Defaults to"},{"line_number":97,"context_line":"                 container-tools module setting up stream 2.0, as this is"},{"line_number":98,"context_line":"                 currently required for OSP to work."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"a2a94578_af63db46","line":95,"range":{"start_line":95,"start_character":13,"end_line":95,"end_character":59},"in_reply_to":"9f560f44_5b68dcf2","updated":"2020-11-24 15:16:41.000000000","message":"It now makes all sense...I had to check the environment files we passed during the undercloud upgrade to realize that we have a /usr/share/openstack-tripleo-heat-templates/environments/lifecycle/undercloud-upgrade-prepare.yaml\nHaving that piece in mind I can prepare a patch that matches your request and in fact, it does make sense...as we will need to enable different modules for the undercloud and the overcloud (undercloud requires container-tools only and for the overcloud container-tools and virt)\n\nThanks for your review.","commit_id":"26d52d5ce9b54517a41a516d4751a1281bd18b41"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7330f11846ed9b01c1953ac0b7a3b674ea8a559e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                 where it\u0027s disabled in the role. Set to true to skip the enforcement."},{"line_number":93,"context_line":"    type: string"},{"line_number":94,"context_line":"  DnfStreams:"},{"line_number":95,"context_line":"    default: [{\u0027module\u0027:\u0027container-tools\u0027, \u0027stream\u0027:\u00272.0\u0027}]"},{"line_number":96,"context_line":"    description: Streams to be configured before updating packages. Defaults to"},{"line_number":97,"context_line":"                 container-tools module setting up stream 2.0, as this is"},{"line_number":98,"context_line":"                 currently required for OSP to work."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_5b68dcf2","line":95,"range":{"start_line":95,"start_character":13,"end_line":95,"end_character":59},"in_reply_to":"9f560f44_8265ede3","updated":"2020-09-22 17:01:25.000000000","message":"Right I think my point is the default should be blank and something like this value should only be applied when necessary (e.g. in upgrade environment).  Additionally we should add a `dnf_module_list | list | length \u003e 0` to the when as well.","commit_id":"26d52d5ce9b54517a41a516d4751a1281bd18b41"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c2b1194454fa2381a5f346bf4c04c0762262226d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                 where it\u0027s disabled in the role. Set to true to skip the enforcement."},{"line_number":93,"context_line":"    type: string"},{"line_number":94,"context_line":"  DnfStreams:"},{"line_number":95,"context_line":"    default: [{\u0027module\u0027:\u0027container-tools\u0027, \u0027stream\u0027:\u00272.0\u0027}]"},{"line_number":96,"context_line":"    description: Streams to be configured before updating packages. Defaults to"},{"line_number":97,"context_line":"                 container-tools module setting up stream 2.0, as this is"},{"line_number":98,"context_line":"                 currently required for OSP to work."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_ca2c384c","line":95,"range":{"start_line":95,"start_character":13,"end_line":95,"end_character":59},"in_reply_to":"9f560f44_9349e6b8","updated":"2020-09-04 15:58:09.000000000","message":"There is an UndercloudUpgrade service, so could use that file to handle the undercloud.\n\n deployment/undercloud/undercloud-upgrade.yaml\n\nThat being said since we control the CLI, you can create any number of environment files to use to do the various OS -\u003e module logic. That being said, I really hate that we have to do this externally and it can\u0027t be included in package specs. That seems weird to me","commit_id":"26d52d5ce9b54517a41a516d4751a1281bd18b41"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"6ae1dbbe9f6121dcdbfdfc9c4b9b050fcc730c6a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                 where it\u0027s disabled in the role. Set to true to skip the enforcement."},{"line_number":93,"context_line":"    type: string"},{"line_number":94,"context_line":"  DnfStreams:"},{"line_number":95,"context_line":"    default: [{\u0027module\u0027:\u0027container-tools\u0027, \u0027stream\u0027:\u00272.0\u0027}]"},{"line_number":96,"context_line":"    description: Streams to be configured before updating packages. Defaults to"},{"line_number":97,"context_line":"                 container-tools module setting up stream 2.0, as this is"},{"line_number":98,"context_line":"                 currently required for OSP to work."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_0a5910fd","line":95,"range":{"start_line":95,"start_character":13,"end_line":95,"end_character":59},"in_reply_to":"9f560f44_9349e6b8","updated":"2020-09-04 15:55:04.000000000","message":"mburns confirmed that we should also enable virt:8.2 module, so I\u0027ll add the module in a second patchset.","commit_id":"26d52d5ce9b54517a41a516d4751a1281bd18b41"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"6347efb24cd7fed38202b303c9308e0176311311","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                 where it\u0027s disabled in the role. Set to true to skip the enforcement."},{"line_number":93,"context_line":"    type: string"},{"line_number":94,"context_line":"  DnfStreams:"},{"line_number":95,"context_line":"    default: [{\u0027module\u0027:\u0027container-tools\u0027, \u0027stream\u0027:\u00272.0\u0027}]"},{"line_number":96,"context_line":"    description: Streams to be configured before updating packages. Defaults to"},{"line_number":97,"context_line":"                 container-tools module setting up stream 2.0, as this is"},{"line_number":98,"context_line":"                 currently required for OSP to work."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_9349e6b8","line":95,"range":{"start_line":95,"start_character":13,"end_line":95,"end_character":59},"in_reply_to":"9f560f44_940c5095","updated":"2020-09-04 15:53:37.000000000","message":"So, I wanted to do it that way by leveraging the upgrade-prepare.yaml/upgrade-converge.yaml parameters. But I am not aware of any way to pass specific parameters before the undercloud upgrade. Is there something like undercloud-upgrade.yaml environment file? Also, this modules won\u0027t really change much per release, will they? I mean...if this value is harcoded here, it will be the same for update or upgrade, won\u0027t it? If for some reason, we decide to move to container-tools:3.0 in 16.4 we will need to set it for both operations, when updating and upgrading, unless I missunderstand it...so both operations will have the very same value, won\u0027t they?\nAlso, I need to confirm with Reldel folks. But I guess the virt module is also a requirement to install OSP, so we should add it here.","commit_id":"26d52d5ce9b54517a41a516d4751a1281bd18b41"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"1c4e0122fd52327f8c95d904af11e477a3418b14","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                 where it\u0027s disabled in the role. Set to true to skip the enforcement."},{"line_number":93,"context_line":"    type: string"},{"line_number":94,"context_line":"  DnfStreams:"},{"line_number":95,"context_line":"    default: [{\u0027module\u0027:\u0027container-tools\u0027, \u0027stream\u0027:\u00272.0\u0027}]"},{"line_number":96,"context_line":"    description: Streams to be configured before updating packages. Defaults to"},{"line_number":97,"context_line":"                 container-tools module setting up stream 2.0, as this is"},{"line_number":98,"context_line":"                 currently required for OSP to work."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_8265ede3","line":95,"range":{"start_line":95,"start_character":13,"end_line":95,"end_character":59},"in_reply_to":"9f560f44_ca2c384c","updated":"2020-09-22 14:16:28.000000000","message":"But, that\u0027s exactly where I put the Undercloud upgrade handling https://review.opendev.org/#/c/745213/10/deployment/undercloud/undercloud-upgrade.yaml , how else could I set the DnfStreams value without using the default value (and in a way that allows overwritting the parameter)?","commit_id":"26d52d5ce9b54517a41a516d4751a1281bd18b41"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"40134e44bc203c7bcfd77214023f7a0b403b9328","unresolved":true,"context_lines":[{"line_number":241,"context_line":"                state: present"},{"line_number":242,"context_line":"              loop: \"{{ dnf_module_list|list }}\""},{"line_number":243,"context_line":"              when:"},{"line_number":244,"context_line":"                - ansible_distribution \u003d\u003d \u0027RedHat\u0027"},{"line_number":245,"context_line":"                - ansible_distribution_major_version \u003d\u003d \u00278\u0027"},{"line_number":246,"context_line":"                - dnf_module_list|length \u003e 0"},{"line_number":247,"context_line":"            - name: Ensure TripleO prerequisite packages are installed"},{"line_number":248,"context_line":"              package:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"4aa93383_268bc002","line":245,"range":{"start_line":244,"start_character":0,"end_line":245,"end_character":59},"updated":"2020-11-25 14:10:17.000000000","message":"I don\u0027t think we need this as streams are a thing in centos","commit_id":"040d37bb9edb693ff735eb6157dd52993d5079b8"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1b6de28cf58caa2f811ae03e8890db3672977235","unresolved":true,"context_lines":[{"line_number":241,"context_line":"                state: present"},{"line_number":242,"context_line":"              loop: \"{{ dnf_module_list|list }}\""},{"line_number":243,"context_line":"              when:"},{"line_number":244,"context_line":"                - ansible_distribution \u003d\u003d \u0027RedHat\u0027"},{"line_number":245,"context_line":"                - ansible_distribution_major_version \u003d\u003d \u00278\u0027"},{"line_number":246,"context_line":"                - dnf_module_list|length \u003e 0"},{"line_number":247,"context_line":"            - name: Ensure TripleO prerequisite packages are installed"},{"line_number":248,"context_line":"              package:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"378312f8_72387bbe","line":245,"range":{"start_line":244,"start_character":0,"end_line":245,"end_character":59},"in_reply_to":"014c6eca_7c0f0ff1","updated":"2020-11-25 16:25:32.000000000","message":"Well, that\u0027s one way of doing it - although hopefully this code never runs on Fedora 8. 😊\n\nI would recommend using \u003e\u003d 8 so that it continues to work on RHEL9.","commit_id":"040d37bb9edb693ff735eb6157dd52993d5079b8"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"c674631f8d698be20075a0c6ed1739a8d3a2a919","unresolved":true,"context_lines":[{"line_number":241,"context_line":"                state: present"},{"line_number":242,"context_line":"              loop: \"{{ dnf_module_list|list }}\""},{"line_number":243,"context_line":"              when:"},{"line_number":244,"context_line":"                - ansible_distribution \u003d\u003d \u0027RedHat\u0027"},{"line_number":245,"context_line":"                - ansible_distribution_major_version \u003d\u003d \u00278\u0027"},{"line_number":246,"context_line":"                - dnf_module_list|length \u003e 0"},{"line_number":247,"context_line":"            - name: Ensure TripleO prerequisite packages are installed"},{"line_number":248,"context_line":"              package:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fb19d780_5a6fd09e","line":245,"range":{"start_line":244,"start_character":0,"end_line":245,"end_character":59},"in_reply_to":"378312f8_72387bbe","updated":"2020-11-26 06:22:34.000000000","message":"I agree with Jesse here.\nAs a side note, we want to support release-based check in the ansible, since rhel-8.2 will require container-tools:2.0, while rhel-8.4 (osp-16.2) will probably request another stream (and I won\u0027t mention rhel-9 (osp-17)) ;).","commit_id":"040d37bb9edb693ff735eb6157dd52993d5079b8"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"d4bebe9b04a52d7500f3dd6c4358a8a5cfe2d74d","unresolved":true,"context_lines":[{"line_number":241,"context_line":"                state: present"},{"line_number":242,"context_line":"              loop: \"{{ dnf_module_list|list }}\""},{"line_number":243,"context_line":"              when:"},{"line_number":244,"context_line":"                - ansible_distribution \u003d\u003d \u0027RedHat\u0027"},{"line_number":245,"context_line":"                - ansible_distribution_major_version \u003d\u003d \u00278\u0027"},{"line_number":246,"context_line":"                - dnf_module_list|length \u003e 0"},{"line_number":247,"context_line":"            - name: Ensure TripleO prerequisite packages are installed"},{"line_number":248,"context_line":"              package:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"aa66559c_a9665ee4","line":245,"range":{"start_line":244,"start_character":0,"end_line":245,"end_character":59},"in_reply_to":"4aa93383_268bc002","updated":"2020-11-25 14:36:16.000000000","message":"right - and iirc we might also need to switch stream for container-tools in order to get the right podman version. Might be good to check with the CI folks, iirc Yatin might know things on that topic.","commit_id":"040d37bb9edb693ff735eb6157dd52993d5079b8"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"7c214a5e7e3d760f031f2686f2373e594a0ab6c4","unresolved":true,"context_lines":[{"line_number":241,"context_line":"                state: present"},{"line_number":242,"context_line":"              loop: \"{{ dnf_module_list|list }}\""},{"line_number":243,"context_line":"              when:"},{"line_number":244,"context_line":"                - ansible_distribution \u003d\u003d \u0027RedHat\u0027"},{"line_number":245,"context_line":"                - ansible_distribution_major_version \u003d\u003d \u00278\u0027"},{"line_number":246,"context_line":"                - dnf_module_list|length \u003e 0"},{"line_number":247,"context_line":"            - name: Ensure TripleO prerequisite packages are installed"},{"line_number":248,"context_line":"              package:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"014c6eca_7c0f0ff1","line":245,"range":{"start_line":244,"start_character":0,"end_line":245,"end_character":59},"in_reply_to":"69b5dd86_ecb8c7a8","updated":"2020-11-25 16:05:12.000000000","message":"One thing, I believe DNF and the streams is a 8 version thing right? I mean...it does make to leave the condition:\n\nansible_distribution_major_version \u003d\u003d \u00278\u0027\n\ndoesn\u0027t it? although in the end this task will never be run by a 7 version (RHEL or CentOS) system... but just in case.","commit_id":"040d37bb9edb693ff735eb6157dd52993d5079b8"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"c199c228214968353ecf1b12fc336c55f6a657de","unresolved":true,"context_lines":[{"line_number":241,"context_line":"                state: present"},{"line_number":242,"context_line":"              loop: \"{{ dnf_module_list|list }}\""},{"line_number":243,"context_line":"              when:"},{"line_number":244,"context_line":"                - ansible_distribution \u003d\u003d \u0027RedHat\u0027"},{"line_number":245,"context_line":"                - ansible_distribution_major_version \u003d\u003d \u00278\u0027"},{"line_number":246,"context_line":"                - dnf_module_list|length \u003e 0"},{"line_number":247,"context_line":"            - name: Ensure TripleO prerequisite packages are installed"},{"line_number":248,"context_line":"              package:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"69b5dd86_ecb8c7a8","line":245,"range":{"start_line":244,"start_character":0,"end_line":245,"end_character":59},"in_reply_to":"aa66559c_a9665ee4","updated":"2020-11-25 15:56:03.000000000","message":"Oh right..I missed that detail. I\u0027ll change the code. Also, this way we can get feedback about this tasks in the upstream CI as they will also get triggered.","commit_id":"040d37bb9edb693ff735eb6157dd52993d5079b8"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0bc2ba4e928e12c9c8caab2b87e9e0c579bdf7b0","unresolved":true,"context_lines":[{"line_number":234,"context_line":"              vars:"},{"line_number":235,"context_line":"                dnf_module_list: {get_param: DnfStreams}"},{"line_number":236,"context_line":"              dnf:"},{"line_number":237,"context_line":"                name: \"@{{ item.module }}:{{ item.stream }}/{{ item.profile|default(\u0027common\u0027) }}\""},{"line_number":238,"context_line":"                state: present"},{"line_number":239,"context_line":"              loop: \"{{ dnf_module_list|list }}\""},{"line_number":240,"context_line":"              when:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"e6226441_4f8a589a","line":237,"range":{"start_line":237,"start_character":59,"end_line":237,"end_character":93},"updated":"2021-01-05 20:53:03.000000000","message":"I just noticed this but I don\u0027t think that\u0027s a thing upstream?","commit_id":"4c2d5927e610731c23cdb0b49ed6ecbf86960692"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"c2eaea129ff9e24b45bf4b23d11481a7be83f505","unresolved":false,"context_lines":[{"line_number":234,"context_line":"              vars:"},{"line_number":235,"context_line":"                dnf_module_list: {get_param: DnfStreams}"},{"line_number":236,"context_line":"              dnf:"},{"line_number":237,"context_line":"                name: \"@{{ item.module }}:{{ item.stream }}/{{ item.profile|default(\u0027common\u0027) }}\""},{"line_number":238,"context_line":"                state: present"},{"line_number":239,"context_line":"              loop: \"{{ dnf_module_list|list }}\""},{"line_number":240,"context_line":"              when:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"46bfa1a6_5bd3e841","line":237,"range":{"start_line":237,"start_character":59,"end_line":237,"end_character":93},"in_reply_to":"e6226441_4f8a589a","updated":"2021-01-12 07:45:39.000000000","message":"As far as I can see, the profile is also a thing in Centos:\n\n[centos@jfrancoa-tester-2 ~]$ sudo dnf module list\nCentOS-8 - AppStream                                                                                                       2.1 MB/s | 6.3 MB     00:02    \nCentOS-8 - Base                                                                                                            1.4 MB/s | 2.3 MB     00:01    \nCentOS-8 - Extras                                                                                                           19 kB/s | 8.6 kB     00:00    \nCentOS-8 - AppStream\nName                 Stream      Profiles Summary                                                                                                          \n389-ds               1.4                  389 Directory Server (base)                                                                                      \nant                  1.10 [d]    common [ Java build tool                                                                                                  \n                                 d]       \ncontainer-tools      rhel8 [d]   common [ Most recent (rolling) versions of podman, buildah, skopeo, runc, conmon, runc, conmon, CRIU, Udica, etc as well a\n                                 d]       s dependencies such as container-selinux built and tested together, and updated as frequently as every 12 weeks.\ncontainer-tools      1.0         common [ Stable versions of podman 1.0, buildah 1.5, skopeo 0.1, runc, conmon, CRIU, Udica, etc as well as dependencies su\n                                 d]       ch as container-selinux built and tested together, and supported for 24 months.\ncontainer-tools      2.0         common [ Stable versions of podman 1.6, buildah 1.11, skopeo 0.1, runc, conmon, etc as well as dependencies such as contai\n                                 d]       ner-selinux built and tested together, and supported as documented on the Application Stream lifecycle page.\nfreeradius           3.0 [d]     server [ High-performance and highly configurable free RADIUS server                                                      \n                                 d]       \ngimp                 2.8 [d]     common [ gimp module                                                                                                      \n                                 d], deve \n                                 l        \ngo-toolset           rhel8 [d]   common [ Go                                                                                                               \n                                 d]       \nhttpd                2.4 [d]     common [ Apache HTTP Server                                                                                               \n                                 d], deve \n                                 l, minim \n                                 al       \nidm                  DL1         common [ The Red Hat Enterprise Linux Identity Management system module                                                   \n                                 d], adtr \n                                 ust, cli \n                                 ent, dns \n                                 , server \nidm                  client [d]  common [ RHEL IdM long term support client module                                                                         \n                                 d]       \ninkscape             0.92.3 [d]  common [ Vector-based drawing program using SVG                                                                           \n                                 d]       \njavapackages-runtime 201801 [d]  common [ Basic runtime utilities to support Java applications                                                             \n                                 d]       \njmc                  rhel8 [d]   common [ Java Mission Control is a profiling and diagnostics tool for the Hotspot JVM                                     \n                                 d], core \nlibselinux-python    2.8         common   Python 2 bindings for libselinux                                                                                 \nllvm-toolset         rhel8 [d]   common [ LLVM                                                                                                             \n                                 d]       \nmailman              2.1 [d]     common [ Electronic mail discussion and e-newsletter lists managing software                                              \n                                 d]       \nmariadb              10.3 [d]    client,  MariaDB Module                                                                                                   \n                                 server [ \n                                 d], gale \n                                 ra       \nmaven                3.5 [d]     common [ Java project management and project comprehension tool                                                           \n                                 d]       \nmaven                3.6         common [ Java project management and project comprehension tool                                                           \n                                 d]       \nmercurial            4.8 [d]     common [ Mercurial -- a distributed SCM                                                                                   \n                                 d]       \nmod_auth_openidc     2.3                  Apache module suporting OpenID Connect authentication                                                            \nmysql                8.0 [d]     client,  MySQL Module                                                                                                     \n                                 server [ \n                                 d]       \nnginx                1.14 [d]    common [ nginx webserver                                                                                                  \n                                 d]       \nnginx                1.16        common [ nginx webserver                                                                                                  \n                                 d]       \nnginx                1.18        common [ nginx webserver                                                                                                  \n                                 d]       \nnodejs               10 [d]      common [ Javascript runtime                                                                                               \n                                 d], deve \n                                 lopment, \n                                  minimal \n                                 , s2i    \nnodejs               12          common [ Javascript runtime                                                                                               \n                                 d], deve \n                                 lopment, \n                                  minimal \n                                 , s2i    \nnodejs               14          common [ Javascript runtime                                                                                               \n                                 d], deve \n                                 lopment, \n                                  minimal \n                                 , s2i    \nparfait              0.5         common   Parfait Module                                                                                                   \nperl                 5.24        common [ Practical Extraction and Report Language                                                                         \n                                 d], mini \n                                 mal      \nperl                 5.26 [d]    common [ Practical Extraction and Report Language                                                                         \n                                 d], mini \n                                 mal      \nperl                 5.30        common [ Practical Extraction and Report Language                                                                         \n                                 d], mini \n                                 mal      \nperl-App-cpanminus   1.7044 [d]  common [ Get, unpack, build and install CPAN modules                                                                      \n                                 d]       \nperl-DBD-MySQL       4.046 [d]   common [ A MySQL interface for Perl                                                                                       \n                                 d]       \nperl-DBD-Pg          3.7 [d]     common [ A PostgreSQL interface for Perl                                                                                  \n                                 d]       \nperl-DBD-SQLite      1.58 [d]    common [ SQLite DBI driver                                                                                                \n                                 d]       \nperl-DBI             1.641 [d]   common [ A database access API for Perl                                                                                   \n                                 d]       \nperl-FCGI            0.78 [d]    common [ FastCGI Perl bindings                                                                                            \n                                 d]       \nperl-IO-Socket-SSL   2.066 [d]   common [ Perl library for transparent TLS                                                                                 \n                                 d]       \nperl-YAML            1.24 [d]    common [ Perl parser for YAML                                                                                             \n                                 d]       \nperl-libwww-perl     6.34 [d]    common [ A Perl interface to the World-Wide Web                                                                           \n                                 d]       \nphp                  7.2 [d]     common [ PHP scripting language                                                                                           \n                                 d], deve \n                                 l, minim \n                                 al       \nphp                  7.3         common [ PHP scripting language                                                                                           \n                                 d], deve \n                                 l, minim \n                                 al       \nphp                  7.4         common [ PHP scripting language                                                                                           \n                                 d], deve \n                                 l, minim \n                                 al       \npki-core             10.6                 PKI Core module for PKI 10.6 or later                                                                            \npki-deps             10.6                 PKI Dependencies module for PKI 10.6 or later                                                                    \npostgresql           9.6         client,  PostgreSQL server and client module                                                                              \n                                 server [ \n                                 d]       \npostgresql           10 [d]      client,  PostgreSQL server and client module                                                                              \n                                 server [ \n                                 d]       \npostgresql           12          client,  PostgreSQL server and client module                                                                              \n                                 server [ \n                                 d]       \npython27             2.7 [d]     common [ Python programming language, version 2.7                                                                         \n                                 d]       \npython36             3.6 [d]     common [ Python programming language, version 3.6                                                                         \n                                 d], buil \n                                 d        \npython38             3.8 [d]     common [ Python programming language, version 3.8                                                                         \n                                 d], buil \n                                 d        \nredis                5 [d]       common [ Redis persistent key-value database                                                                              \n                                 d]       \nrhn-tools            1.0 [d]     common [ Red Hat Satellite 5 tools for RHEL                                                                               \n                                 d]       \nruby                 2.5 [d]     common [ An interpreter of object-oriented scripting language                                                             \n                                 d]       \nruby                 2.6         common [ An interpreter of object-oriented scripting language                                                             \n                                 d]       \nruby                 2.7         common [ An interpreter of object-oriented scripting language                                                             \n                                 d]       \nrust-toolset         rhel8 [d]   common [ Rust                                                                                                             \n                                 d]       \nsatellite-5-client   1.0 [d][e]  common [ Red Hat Satellite 5 client packages                                                                              \n                                 d], gui  \nscala                2.10 [d]    common [ A hybrid functional/object-oriented language for the JVM                                                         \n                                 d]       \nsquid                4 [d]       common [ Squid - Optimising Web Delivery                                                                                  \n                                 d]       \nsubversion           1.10 [d]    common [ Apache Subversion                                                                                                \n                                 d], serv \n                                 er       \nswig                 3.0 [d]     common [ Connects C/C++/Objective C to some high-level programming languages                                              \n                                 d], comp \n                                 lete     \nvarnish              6 [d]       common [ Varnish HTTP cache                                                                                               \n                                 d]       \nvirt                 rhel [d][e] common [ Virtualization module                                                                                            \n                                 d]       \n\nHint: [d]efault, [e]nabled, [x]disabled, [i]nstalled","commit_id":"4c2d5927e610731c23cdb0b49ed6ecbf86960692"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"c956d6660680fe93799968caeaafdf657a4e1c78","unresolved":true,"context_lines":[{"line_number":237,"context_line":"                name: \"@{{ item.module }}:{{ item.stream }}/{{ item.profile|default(\u0027common\u0027) }}\""},{"line_number":238,"context_line":"                state: present"},{"line_number":239,"context_line":"              loop: \"{{ dnf_module_list|list }}\""},{"line_number":240,"context_line":"              when:"},{"line_number":241,"context_line":"                - ansible_distribution_major_version \u003e\u003d \u00278\u0027"},{"line_number":242,"context_line":"                - dnf_module_list|length \u003e 0"},{"line_number":243,"context_line":"            - name: Ensure TripleO prerequisite packages are installed"},{"line_number":244,"context_line":"              package:"},{"line_number":245,"context_line":"                name:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"430dd01a_d908da7c","line":242,"range":{"start_line":240,"start_character":0,"end_line":242,"end_character":44},"updated":"2021-01-05 20:54:40.000000000","message":"shouldn\u0027t this be limited to RHEL?","commit_id":"4c2d5927e610731c23cdb0b49ed6ecbf86960692"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5d791724ca939402802bcd371679acd00cf0da94","unresolved":true,"context_lines":[{"line_number":237,"context_line":"                name: \"@{{ item.module }}:{{ item.stream }}/{{ item.profile|default(\u0027common\u0027) }}\""},{"line_number":238,"context_line":"                state: present"},{"line_number":239,"context_line":"              loop: \"{{ dnf_module_list|list }}\""},{"line_number":240,"context_line":"              when:"},{"line_number":241,"context_line":"                - ansible_distribution_major_version \u003e\u003d \u00278\u0027"},{"line_number":242,"context_line":"                - dnf_module_list|length \u003e 0"},{"line_number":243,"context_line":"            - name: Ensure TripleO prerequisite packages are installed"},{"line_number":244,"context_line":"              package:"},{"line_number":245,"context_line":"                name:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"6e8c3cf1_a55bf58c","line":242,"range":{"start_line":240,"start_character":0,"end_line":242,"end_character":44},"in_reply_to":"430dd01a_d908da7c","updated":"2021-01-05 20:55:52.000000000","message":"it\u0027s valid for centos, though the values may need to change?","commit_id":"4c2d5927e610731c23cdb0b49ed6ecbf86960692"}],"deployment/undercloud/undercloud-upgrade.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"99085634c5a33f2faaf9aa32939e06371fbd1ea5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                 Mainly for CI purpose.  It shouldn\u0027t matter on other distributions"},{"line_number":37,"context_line":"                 where it\u0027s disabled in the role. Set to true to skip the enforcement."},{"line_number":38,"context_line":"    type: string"},{"line_number":39,"context_line":"  ContainerToolsStream:"},{"line_number":40,"context_line":"    default: [{\u0027module\u0027:\u0027container-tools\u0027, \u0027stream\u0027:\u00272.0\u0027}]"},{"line_number":41,"context_line":"    description: Stream to be configured for the container-tools module."},{"line_number":42,"context_line":"    type: json"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_aa333262","line":39,"range":{"start_line":39,"start_character":2,"end_line":39,"end_character":22},"updated":"2020-08-12 09:31:10.000000000","message":"Same as in the other file","commit_id":"845528a0316f7129e46f95a805afda2b927d867d"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"99085634c5a33f2faaf9aa32939e06371fbd1ea5","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            - step|int \u003d\u003d 0"},{"line_number":65,"context_line":"            - ansible_distribution \u003d\u003d \u0027RedHat\u0027"},{"line_number":66,"context_line":"            - not (skip_rhel_enforcement | bool)"},{"line_number":67,"context_line":"        - name: Ensure container-tools module has the right stream"},{"line_number":68,"context_line":"          include_role:"},{"line_number":69,"context_line":"            name: tripleo_stream_enable"},{"line_number":70,"context_line":"          vars:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_8a38ee3d","line":67,"range":{"start_line":67,"start_character":23,"end_line":67,"end_character":38},"updated":"2020-08-12 09:31:10.000000000","message":"and same here","commit_id":"845528a0316f7129e46f95a805afda2b927d867d"}]}