)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a319ec6575707f70bbe1cddb4c8dcde6c722d7f5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-10-12 18:40:13 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding parameters for timemaster service configuration"},{"line_number":8,"context_line":"Since timesync applicable for both chrony and timemaster, renamed the file"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I32e9d17132d188aaddc5f5be578643a5f25ea375"},{"line_number":11,"context_line":"Closes-Bug: #1893025"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9f560f44_6e8212a7","line":8,"updated":"2020-10-12 13:12:18.000000000","message":"https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"1ce8fac0c1b4417b178e65be7818ab25efc21c1c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"18925d2977cae602b510f3146fd4f0a620c96691","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Config parameters for timemaster service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"timemaster service provides provides HA between different"},{"line_number":10,"context_line":"time service i.e chrony, PTP. When timemaster service runs,"},{"line_number":11,"context_line":"it spwans instances/child processes of chronyd, ptp4l and"},{"line_number":12,"context_line":"phy2sys. Look at below output."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9c607cef_3c419b3a","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":36},"updated":"2020-12-30 03:01:08.000000000","message":"(nit) provides","commit_id":"bed10b2072ef96d0b7188621c2f5b0da79af378c"},{"author":{"_account_id":30229,"name":"Haresh","email":"hakhande@redhat.com","username":"hakhande"},"change_message_id":"7d5fddf2a4f0b3597dc26e6c312d55507baa8ba5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Config parameters for timemaster service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"timemaster service provides provides HA between different"},{"line_number":10,"context_line":"time service i.e chrony, PTP. When timemaster service runs,"},{"line_number":11,"context_line":"it spwans instances/child processes of chronyd, ptp4l and"},{"line_number":12,"context_line":"phy2sys. Look at below output."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"addf1b99_5ecde0d4","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":36},"in_reply_to":"9c607cef_3c419b3a","updated":"2021-01-06 17:03:29.000000000","message":"Ack","commit_id":"bed10b2072ef96d0b7188621c2f5b0da79af378c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"18925d2977cae602b510f3146fd4f0a620c96691","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"2 new parameters added by this patch in order to make above work."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"In order to use timemaster service, we need to remove Timesync and"},{"line_number":46,"context_line":"add TimeMaster in roles_data.yaml for the role we desire to have"},{"line_number":47,"context_line":"Timemaster service."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    - OS::TripleO::Services::TimeMaster"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Change-Id: I32e9d17132d188aaddc5f5be578643a5f25ea375"},{"line_number":52,"context_line":"Closes-Bug: #1893025"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"6ad018b8_8128138c","line":49,"range":{"start_line":45,"start_character":0,"end_line":49,"end_character":39},"updated":"2020-12-30 03:01:08.000000000","message":"Can we add TimeMaster to roles_data, make it None by default, and provide an environment file to use TimeMaster service ?\nI think that\u0027s what we usually do when we introduce a new optional service.","commit_id":"bed10b2072ef96d0b7188621c2f5b0da79af378c"},{"author":{"_account_id":30229,"name":"Haresh","email":"hakhande@redhat.com","username":"hakhande"},"change_message_id":"7d5fddf2a4f0b3597dc26e6c312d55507baa8ba5","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"2 new parameters added by this patch in order to make above work."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"In order to use timemaster service, we need to remove Timesync and"},{"line_number":46,"context_line":"add TimeMaster in roles_data.yaml for the role we desire to have"},{"line_number":47,"context_line":"Timemaster service."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    - OS::TripleO::Services::TimeMaster"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Change-Id: I32e9d17132d188aaddc5f5be578643a5f25ea375"},{"line_number":52,"context_line":"Closes-Bug: #1893025"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"b04a8c87_f7569071","line":49,"range":{"start_line":45,"start_character":0,"end_line":49,"end_character":39},"in_reply_to":"6ad018b8_8128138c","updated":"2021-01-06 17:03:29.000000000","message":"Hi, Purpose here is to leave this decision to Admin. Timemaster and Chrony can co-exist in single deployment (controllers can use chrony whereas selected computes use Timemaster) and mutually exclusive per role (Either chronyd or timemaster).","commit_id":"bed10b2072ef96d0b7188621c2f5b0da79af378c"}],"deployment/timemaster/timemaster-baremetal-ansible.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"259c10aed53fae3e8c72bbc5552e9b50f80ed671","unresolved":true,"context_lines":[{"line_number":143,"context_line":"        chrony_role_action: all"},{"line_number":144,"context_line":"        chrony_ntp_servers: {get_param: NtpServer}"},{"line_number":145,"context_line":"        chrony_ntp_pools: {get_param: NtpPool}"},{"line_number":146,"context_line":"        ptp_interfaces: {get_param: [RoleParameters, PTPInterfaces]}"},{"line_number":147,"context_line":"        ptp_transport: {get_param: [RoleParameters, PTPMessageTransport]}"},{"line_number":148,"context_line":"        tripleo_timemaster_role_action: all"},{"line_number":149,"context_line":"        chrony_global_server_settings:"},{"line_number":150,"context_line":"          if:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a0902b5_723828b1","line":147,"range":{"start_line":146,"start_character":8,"end_line":147,"end_character":73},"updated":"2020-12-18 11:57:41.000000000","message":"Wtih this implementation, it will accept only the role-specific parameters and it will not accept global parameters. \n\nValid Example\n-------------\nparameter_defaults:\n  ComputeSriovParameters:\n    PTPMessageTransport: \"...\"\n    PTPInterfaces: \"...\"\n\n\nInvalid Example\n---------------\nparameter_defaults:\n  PTPMessageTransport: \"...\"\n  PTPInterfaces: \"...\"\n\n\nFirst example will apply only to the provided role (Computesriov), but the later will apply the parameters to all the roles which includes the \"OS::TripleO::Timemaster\" service. Is this the intended behavior?\n\nI would recomment to merge the global and role-specific via a resource as like other parameters using this merging code:\n\n  RoleParametersValue:\n    type: OS::Heat::Value\n    properties:\n      type: json\n      value:\n        map_replace:\n          - map_replace:\n            - tripleo_ptp4l_interface: PtpInterface\n              tripleo_ptp4l_conf_network_transport: PtpMessageTransport\n            - values: {get_param: [RoleParameters]}\n          - values:\n              PtpInterface: {get_param: PtpInterface}\n              PtpMessageTransport: {get_param: PtpMessageTransport}\n\nOnce it is merged, it can be used as below in here:\n\n        ptp_interfaces: {get_attr: [RoleParametersValue, value, tripleo_ptp4l_interface]}\n        ptp_transport: {get_attr: [RoleParametersValue, value, tripleo_ptp4l_conf_network_transport]}","commit_id":"08d8136ba8f41ea5507efcf17d80a84972451baa"},{"author":{"_account_id":30229,"name":"Haresh","email":"hakhande@redhat.com","username":"hakhande"},"change_message_id":"408e46c76894f6d0274386e5d439bade64a86972","unresolved":true,"context_lines":[{"line_number":143,"context_line":"        chrony_role_action: all"},{"line_number":144,"context_line":"        chrony_ntp_servers: {get_param: NtpServer}"},{"line_number":145,"context_line":"        chrony_ntp_pools: {get_param: NtpPool}"},{"line_number":146,"context_line":"        ptp_interfaces: {get_param: [RoleParameters, PTPInterfaces]}"},{"line_number":147,"context_line":"        ptp_transport: {get_param: [RoleParameters, PTPMessageTransport]}"},{"line_number":148,"context_line":"        tripleo_timemaster_role_action: all"},{"line_number":149,"context_line":"        chrony_global_server_settings:"},{"line_number":150,"context_line":"          if:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"89e8b095_cc090a26","line":147,"range":{"start_line":146,"start_character":8,"end_line":147,"end_character":73},"in_reply_to":"9a0902b5_723828b1","updated":"2020-12-24 13:09:33.000000000","message":"Yes these are role specific parameters. Since, Controllers dont need them, making them global like chrony (where chrony used by controller node as well) wont be good option. What do you think?","commit_id":"08d8136ba8f41ea5507efcf17d80a84972451baa"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5a93e49975a645c9024da443d1818e28c65b1485","unresolved":true,"context_lines":[{"line_number":113,"context_line":"    description: Configure and starts timemaster service."},{"line_number":114,"context_line":"    value:"},{"line_number":115,"context_line":"      host_prep_tasks:"},{"line_number":116,"context_line":"        - name: Populate service facts (chrony and timemaster)"},{"line_number":117,"context_line":"          service_facts: # needed to make yaml happy"},{"line_number":118,"context_line":"        - name: Disable chronyd"},{"line_number":119,"context_line":"          service:"},{"line_number":120,"context_line":"            name: chronyd"},{"line_number":121,"context_line":"            state: stopped"},{"line_number":122,"context_line":"            enabled: no"},{"line_number":123,"context_line":"          when: \"\u0027chronyd.service\u0027 in ansible_facts.services\""},{"line_number":124,"context_line":"        - name: Disable ptp4l"},{"line_number":125,"context_line":"          service:"},{"line_number":126,"context_line":"            name: ptp4l"},{"line_number":127,"context_line":"            state: stopped"},{"line_number":128,"context_line":"            enabled: no"},{"line_number":129,"context_line":"          when: \"\u0027ptp4l.service\u0027 in ansible_facts.services\""},{"line_number":130,"context_line":"        - name: Disable phc2sys"},{"line_number":131,"context_line":"          service:"},{"line_number":132,"context_line":"            name: phc2sys"},{"line_number":133,"context_line":"            state: stopped"},{"line_number":134,"context_line":"            enabled: no"},{"line_number":135,"context_line":"          when: \"\u0027phc2sys.service\u0027 in ansible_facts.services\""},{"line_number":136,"context_line":"        - name: Configure and Run Timemaster"},{"line_number":137,"context_line":"          include_role:"},{"line_number":138,"context_line":"            name: tripleo_timemaster"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"85fc2308_3eed819f","line":135,"range":{"start_line":116,"start_character":0,"end_line":135,"end_character":61},"updated":"2021-01-07 17:34:35.000000000","message":"Shouldn\u0027t this be in the role itself?","commit_id":"2f1edfdffa49ca6356214a7f5923f724942251ec"},{"author":{"_account_id":30229,"name":"Haresh","email":"hakhande@redhat.com","username":"hakhande"},"change_message_id":"7061a86c56840352e356105db424418eba1bcb3d","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    description: Configure and starts timemaster service."},{"line_number":114,"context_line":"    value:"},{"line_number":115,"context_line":"      host_prep_tasks:"},{"line_number":116,"context_line":"        - name: Populate service facts (chrony and timemaster)"},{"line_number":117,"context_line":"          service_facts: # needed to make yaml happy"},{"line_number":118,"context_line":"        - name: Disable chronyd"},{"line_number":119,"context_line":"          service:"},{"line_number":120,"context_line":"            name: chronyd"},{"line_number":121,"context_line":"            state: stopped"},{"line_number":122,"context_line":"            enabled: no"},{"line_number":123,"context_line":"          when: \"\u0027chronyd.service\u0027 in ansible_facts.services\""},{"line_number":124,"context_line":"        - name: Disable ptp4l"},{"line_number":125,"context_line":"          service:"},{"line_number":126,"context_line":"            name: ptp4l"},{"line_number":127,"context_line":"            state: stopped"},{"line_number":128,"context_line":"            enabled: no"},{"line_number":129,"context_line":"          when: \"\u0027ptp4l.service\u0027 in ansible_facts.services\""},{"line_number":130,"context_line":"        - name: Disable phc2sys"},{"line_number":131,"context_line":"          service:"},{"line_number":132,"context_line":"            name: phc2sys"},{"line_number":133,"context_line":"            state: stopped"},{"line_number":134,"context_line":"            enabled: no"},{"line_number":135,"context_line":"          when: \"\u0027phc2sys.service\u0027 in ansible_facts.services\""},{"line_number":136,"context_line":"        - name: Configure and Run Timemaster"},{"line_number":137,"context_line":"          include_role:"},{"line_number":138,"context_line":"            name: tripleo_timemaster"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"be3b41ce_c29a43c3","line":135,"range":{"start_line":116,"start_character":0,"end_line":135,"end_character":61},"in_reply_to":"0f77b83c_bfcd46fd","updated":"2021-01-26 15:57:40.000000000","message":"Done","commit_id":"2f1edfdffa49ca6356214a7f5923f724942251ec"},{"author":{"_account_id":30229,"name":"Haresh","email":"hakhande@redhat.com","username":"hakhande"},"change_message_id":"4de47055eb98aaba8e09bfa10558bb0ebc9c3915","unresolved":true,"context_lines":[{"line_number":113,"context_line":"    description: Configure and starts timemaster service."},{"line_number":114,"context_line":"    value:"},{"line_number":115,"context_line":"      host_prep_tasks:"},{"line_number":116,"context_line":"        - name: Populate service facts (chrony and timemaster)"},{"line_number":117,"context_line":"          service_facts: # needed to make yaml happy"},{"line_number":118,"context_line":"        - name: Disable chronyd"},{"line_number":119,"context_line":"          service:"},{"line_number":120,"context_line":"            name: chronyd"},{"line_number":121,"context_line":"            state: stopped"},{"line_number":122,"context_line":"            enabled: no"},{"line_number":123,"context_line":"          when: \"\u0027chronyd.service\u0027 in ansible_facts.services\""},{"line_number":124,"context_line":"        - name: Disable ptp4l"},{"line_number":125,"context_line":"          service:"},{"line_number":126,"context_line":"            name: ptp4l"},{"line_number":127,"context_line":"            state: stopped"},{"line_number":128,"context_line":"            enabled: no"},{"line_number":129,"context_line":"          when: \"\u0027ptp4l.service\u0027 in ansible_facts.services\""},{"line_number":130,"context_line":"        - name: Disable phc2sys"},{"line_number":131,"context_line":"          service:"},{"line_number":132,"context_line":"            name: phc2sys"},{"line_number":133,"context_line":"            state: stopped"},{"line_number":134,"context_line":"            enabled: no"},{"line_number":135,"context_line":"          when: \"\u0027phc2sys.service\u0027 in ansible_facts.services\""},{"line_number":136,"context_line":"        - name: Configure and Run Timemaster"},{"line_number":137,"context_line":"          include_role:"},{"line_number":138,"context_line":"            name: tripleo_timemaster"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"0f77b83c_bfcd46fd","line":135,"range":{"start_line":116,"start_character":0,"end_line":135,"end_character":61},"in_reply_to":"85fc2308_3eed819f","updated":"2021-01-12 11:11:00.000000000","message":"Sure, will add them as part of triple-ansible role","commit_id":"2f1edfdffa49ca6356214a7f5923f724942251ec"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5a93e49975a645c9024da443d1818e28c65b1485","unresolved":true,"context_lines":[{"line_number":136,"context_line":"        - name: Configure and Run Timemaster"},{"line_number":137,"context_line":"          include_role:"},{"line_number":138,"context_line":"            name: tripleo_timemaster"},{"line_number":139,"context_line":"        - name: Ensure timemaster has been restarted"},{"line_number":140,"context_line":"          meta: flush_handlers"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"      ansible_group_vars:"},{"line_number":143,"context_line":"        chrony_role_action: all"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"c3f44b9a_5d6b62e6","line":140,"range":{"start_line":139,"start_character":0,"end_line":140,"end_character":30},"updated":"2021-01-07 17:34:35.000000000","message":"do not use handlers","commit_id":"2f1edfdffa49ca6356214a7f5923f724942251ec"},{"author":{"_account_id":30229,"name":"Haresh","email":"hakhande@redhat.com","username":"hakhande"},"change_message_id":"4de47055eb98aaba8e09bfa10558bb0ebc9c3915","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        - name: Configure and Run Timemaster"},{"line_number":137,"context_line":"          include_role:"},{"line_number":138,"context_line":"            name: tripleo_timemaster"},{"line_number":139,"context_line":"        - name: Ensure timemaster has been restarted"},{"line_number":140,"context_line":"          meta: flush_handlers"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"      ansible_group_vars:"},{"line_number":143,"context_line":"        chrony_role_action: all"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9feb0f82_d4b688b8","line":140,"range":{"start_line":139,"start_character":0,"end_line":140,"end_character":30},"in_reply_to":"c3f44b9a_5d6b62e6","updated":"2021-01-12 11:11:00.000000000","message":"Ack","commit_id":"2f1edfdffa49ca6356214a7f5923f724942251ec"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"bc2175603d41e92aa3abf47d414cda13972da09a","unresolved":true,"context_lines":[{"line_number":143,"context_line":"        chrony_role_action: all"},{"line_number":144,"context_line":"        chrony_ntp_servers: {get_param: NtpServer}"},{"line_number":145,"context_line":"        chrony_ntp_pools: {get_param: NtpPool}"},{"line_number":146,"context_line":"        ptp_interfaces: {get_param: [RoleParameters, PTPInterfaces]}"},{"line_number":147,"context_line":"        ptp_transport: {get_param: [RoleParameters, PTPMessageTransport]}"},{"line_number":148,"context_line":"        tripleo_timemaster_role_action: all"},{"line_number":149,"context_line":"        chrony_global_server_settings:"},{"line_number":150,"context_line":"          if:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"c414e050_378fcb27","line":147,"range":{"start_line":146,"start_character":0,"end_line":147,"end_character":73},"updated":"2021-01-07 17:42:52.000000000","message":"You\u0027re also missing the RoleParametersValue structure to enable the role specific nature of these vars. See deployment/iscsid/iscsid-container-puppet.yaml as an example","commit_id":"2f1edfdffa49ca6356214a7f5923f724942251ec"},{"author":{"_account_id":30229,"name":"Haresh","email":"hakhande@redhat.com","username":"hakhande"},"change_message_id":"4879f12684d751563c4173311f7bf42f1789512c","unresolved":true,"context_lines":[{"line_number":143,"context_line":"        chrony_role_action: all"},{"line_number":144,"context_line":"        chrony_ntp_servers: {get_param: NtpServer}"},{"line_number":145,"context_line":"        chrony_ntp_pools: {get_param: NtpPool}"},{"line_number":146,"context_line":"        ptp_interfaces: {get_param: [RoleParameters, PTPInterfaces]}"},{"line_number":147,"context_line":"        ptp_transport: {get_param: [RoleParameters, PTPMessageTransport]}"},{"line_number":148,"context_line":"        tripleo_timemaster_role_action: all"},{"line_number":149,"context_line":"        chrony_global_server_settings:"},{"line_number":150,"context_line":"          if:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9f5d4673_fc9a207d","line":147,"range":{"start_line":146,"start_character":0,"end_line":147,"end_character":73},"in_reply_to":"0f5043bd_d2c18e63","updated":"2021-01-12 16:06:08.000000000","message":"Sure, will check that and follow. Thanks","commit_id":"2f1edfdffa49ca6356214a7f5923f724942251ec"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"25fcd56d2d5175562caafddcf21a6d3c4f3e4f3a","unresolved":true,"context_lines":[{"line_number":143,"context_line":"        chrony_role_action: all"},{"line_number":144,"context_line":"        chrony_ntp_servers: {get_param: NtpServer}"},{"line_number":145,"context_line":"        chrony_ntp_pools: {get_param: NtpPool}"},{"line_number":146,"context_line":"        ptp_interfaces: {get_param: [RoleParameters, PTPInterfaces]}"},{"line_number":147,"context_line":"        ptp_transport: {get_param: [RoleParameters, PTPMessageTransport]}"},{"line_number":148,"context_line":"        tripleo_timemaster_role_action: all"},{"line_number":149,"context_line":"        chrony_global_server_settings:"},{"line_number":150,"context_line":"          if:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"0f5043bd_d2c18e63","line":147,"range":{"start_line":146,"start_character":0,"end_line":147,"end_character":73},"in_reply_to":"294488c5_36e3a3ba","updated":"2021-01-12 14:18:39.000000000","message":"This is not how you use role parameters. You need to have the RoleParametersValue structure as a heat output. See the iscsi file as an example","commit_id":"2f1edfdffa49ca6356214a7f5923f724942251ec"},{"author":{"_account_id":30229,"name":"Haresh","email":"hakhande@redhat.com","username":"hakhande"},"change_message_id":"7061a86c56840352e356105db424418eba1bcb3d","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        chrony_role_action: all"},{"line_number":144,"context_line":"        chrony_ntp_servers: {get_param: NtpServer}"},{"line_number":145,"context_line":"        chrony_ntp_pools: {get_param: NtpPool}"},{"line_number":146,"context_line":"        ptp_interfaces: {get_param: [RoleParameters, PTPInterfaces]}"},{"line_number":147,"context_line":"        ptp_transport: {get_param: [RoleParameters, PTPMessageTransport]}"},{"line_number":148,"context_line":"        tripleo_timemaster_role_action: all"},{"line_number":149,"context_line":"        chrony_global_server_settings:"},{"line_number":150,"context_line":"          if:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"050fa024_2a98af0d","line":147,"range":{"start_line":146,"start_character":0,"end_line":147,"end_character":73},"in_reply_to":"9f5d4673_fc9a207d","updated":"2021-01-26 15:57:40.000000000","message":"Done","commit_id":"2f1edfdffa49ca6356214a7f5923f724942251ec"},{"author":{"_account_id":30229,"name":"Haresh","email":"hakhande@redhat.com","username":"hakhande"},"change_message_id":"4de47055eb98aaba8e09bfa10558bb0ebc9c3915","unresolved":true,"context_lines":[{"line_number":143,"context_line":"        chrony_role_action: all"},{"line_number":144,"context_line":"        chrony_ntp_servers: {get_param: NtpServer}"},{"line_number":145,"context_line":"        chrony_ntp_pools: {get_param: NtpPool}"},{"line_number":146,"context_line":"        ptp_interfaces: {get_param: [RoleParameters, PTPInterfaces]}"},{"line_number":147,"context_line":"        ptp_transport: {get_param: [RoleParameters, PTPMessageTransport]}"},{"line_number":148,"context_line":"        tripleo_timemaster_role_action: all"},{"line_number":149,"context_line":"        chrony_global_server_settings:"},{"line_number":150,"context_line":"          if:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"294488c5_36e3a3ba","line":147,"range":{"start_line":146,"start_character":0,"end_line":147,"end_character":73},"in_reply_to":"c414e050_378fcb27","updated":"2021-01-12 11:11:00.000000000","message":"These 2 parameters are role specific only. I didnt get you here.","commit_id":"2f1edfdffa49ca6356214a7f5923f724942251ec"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"8f1fa18776831f4f56396aacd321cc61c9ad5ffb","unresolved":true,"context_lines":[{"line_number":133,"context_line":"            name: tripleo_timemaster"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"      ansible_group_vars:"},{"line_number":136,"context_line":"        chrony_role_action: all"},{"line_number":137,"context_line":"        chrony_ntp_servers: {get_param: NtpServer}"},{"line_number":138,"context_line":"        chrony_ntp_pools: {get_param: NtpPool}"},{"line_number":139,"context_line":"        tripleo_timemaster_role_action: all"},{"line_number":140,"context_line":"        chrony_global_server_settings:"},{"line_number":141,"context_line":"          if:"},{"line_number":142,"context_line":"          - chrony_global_server_settings_is_empty"},{"line_number":143,"context_line":"          - str_replace:"},{"line_number":144,"context_line":"              template: IBURST minpoll MINPOLL maxpoll MAXPOLL"},{"line_number":145,"context_line":"              params:"},{"line_number":146,"context_line":"                IBURST:"},{"line_number":147,"context_line":"                  if:"},{"line_number":148,"context_line":"                  - ntp_iburst"},{"line_number":149,"context_line":"                  - iburst"},{"line_number":150,"context_line":"                  - \u0027\u0027"},{"line_number":151,"context_line":"                MINPOLL: { get_param: MinPoll }"},{"line_number":152,"context_line":"                MAXPOLL: { get_param: MaxPoll }"},{"line_number":153,"context_line":"          - {get_param: ChronyGlobalServerOptions}"},{"line_number":154,"context_line":"        chrony_global_pool_settings:"},{"line_number":155,"context_line":"          if:"},{"line_number":156,"context_line":"          - chrony_global_pool_settings_is_empty"},{"line_number":157,"context_line":"          - str_replace:"},{"line_number":158,"context_line":"              template: IBURST minpoll MINPOLL maxpoll MAXPOLL"},{"line_number":159,"context_line":"              params:"},{"line_number":160,"context_line":"                IBURST:"},{"line_number":161,"context_line":"                  if:"},{"line_number":162,"context_line":"                  - ntp_iburst"},{"line_number":163,"context_line":"                  - iburst"},{"line_number":164,"context_line":"                  - \u0027\u0027"},{"line_number":165,"context_line":"                MINPOLL: { get_param: MinPoll }"},{"line_number":166,"context_line":"                MAXPOLL: { get_param: MaxPoll }"},{"line_number":167,"context_line":"          - {get_param: ChronyGlobalPoolOptions}"},{"line_number":168,"context_line":"        chrony_manage_package: {get_param: EnablePackageInstall}"},{"line_number":169,"context_line":"        chrony_acl_rules: {get_param: ChronyAclRules}"},{"line_number":170,"context_line":"        ptp_interfaces: {get_attr: [RoleParametersValue, value, tripleo_ptp_interfaces]}"},{"line_number":171,"context_line":"        ptp_transport: {get_attr: [RoleParametersValue, value, tripleo_ptp_transport]}"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"e7deaac7_e2580df6","line":169,"range":{"start_line":136,"start_character":7,"end_line":169,"end_character":53},"updated":"2021-01-27 11:56:49.000000000","message":"Thinking out loud here, these settings are from chrony-baremetal-ansible.yaml [1], any change in this file has to be manually replicated here to which is error prone. Instead it is possible to create a resource for the chrony-baremetal-ansible.yaml service, from which ansible_group_vars canbe reused, with additional mertgin of ptp_interfaces and ptp_transport. some thing like, \n\n\nresources:\n  ...\n  ChronyBase:\n    type: ./../timesync/chrony-baremetal-ansible.yaml\n    properties:\n      ServiceData: {get_param: ServiceData}\n      ServiceNetMap: {get_param: ServiceNetMap}\n      DefaultPasswords: {get_param: DefaultPasswords}\n      EndpointMap: {get_param: EndpointMap}\n      RoleName: {get_param: RoleName}\n      RoleParameters: {get_param: RoleParameters}\n\noutputs:\n  role_data:\n    value:\n      ...\n      ansible_group_vars:\n        map_merge:\n          - get_attr: [ChronyBase, role_data, ansible_group_vars]\n          - ptp_interfaces: {get_attr: [RoleParametersValue, value, tripleo_ptp_interfaces]}\n            ptp_transport: {get_attr: [RoleParametersValue, value, tripleo_ptp_transport]}\n\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/50367fbe3563d34976deb377ed32b6f26aeca44f/deployment/timesync/chrony-baremetal-ansible.yaml#L124","commit_id":"c9db9821d1ec5af19cc0a436d965c9e1c16bc511"}],"deployment/timesync/chrony-baremetal-ansible.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"18925d2977cae602b510f3146fd4f0a620c96691","unresolved":true,"context_lines":[{"line_number":101,"context_line":"    description: Role chrony using composable timesync services."},{"line_number":102,"context_line":"    value:"},{"line_number":103,"context_line":"      service_name: chrony"},{"line_number":104,"context_line":"      config_settings:"},{"line_number":105,"context_line":"        tripleo::chrony::firewall_rules:"},{"line_number":106,"context_line":"          \u0027105 ntp\u0027:"},{"line_number":107,"context_line":"            dport: 123"},{"line_number":108,"context_line":"            proto: udp"},{"line_number":109,"context_line":"      step_config: \u0027\u0027"},{"line_number":110,"context_line":"      host_prep_tasks:"},{"line_number":111,"context_line":"        - name: Populate service facts (chrony)"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"4f9786b9_7a47c025","line":108,"range":{"start_line":104,"start_character":0,"end_line":108,"end_character":22},"updated":"2020-12-30 03:01:08.000000000","message":"Why is this changed ? We no longer use puppet to manage firewall rules thus this change makes this rule ineffective.","commit_id":"bed10b2072ef96d0b7188621c2f5b0da79af378c"},{"author":{"_account_id":30229,"name":"Haresh","email":"hakhande@redhat.com","username":"hakhande"},"change_message_id":"7d5fddf2a4f0b3597dc26e6c312d55507baa8ba5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    description: Role chrony using composable timesync services."},{"line_number":102,"context_line":"    value:"},{"line_number":103,"context_line":"      service_name: chrony"},{"line_number":104,"context_line":"      config_settings:"},{"line_number":105,"context_line":"        tripleo::chrony::firewall_rules:"},{"line_number":106,"context_line":"          \u0027105 ntp\u0027:"},{"line_number":107,"context_line":"            dport: 123"},{"line_number":108,"context_line":"            proto: udp"},{"line_number":109,"context_line":"      step_config: \u0027\u0027"},{"line_number":110,"context_line":"      host_prep_tasks:"},{"line_number":111,"context_line":"        - name: Populate service facts (chrony)"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bfdd1cab_ddee54e4","line":108,"range":{"start_line":104,"start_character":0,"end_line":108,"end_character":22},"in_reply_to":"4f9786b9_7a47c025","updated":"2021-01-06 17:03:29.000000000","message":"Ack","commit_id":"bed10b2072ef96d0b7188621c2f5b0da79af378c"}],"deployment/timesync/timesync-baremetal-ansible.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a319ec6575707f70bbe1cddb4c8dcde6c722d7f5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: rocky"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: \u003e"},{"line_number":4,"context_line":"  Timesync services such as Chrony and timemaster with deployment using ansible, this YAML file"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_8e87a6b6","line":1,"updated":"2020-10-12 13:12:18.000000000","message":"Please don\u0027t merge PTP and chrony. Please add a timemaster specific service file","commit_id":"1ce8fac0c1b4417b178e65be7818ab25efc21c1c"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"65f7a25cc3bd16cbdeb49f159747112a6c3521c9","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    description: Role chrony and timemaster using composable timesync services."},{"line_number":121,"context_line":"    value:"},{"line_number":122,"context_line":"      service_name: chrony"},{"line_number":123,"context_line":"      config_settings:"},{"line_number":124,"context_line":"        tripleo::chrony::firewall_rules:"},{"line_number":125,"context_line":"          \u0027105 ntp\u0027:"},{"line_number":126,"context_line":"            dport: 123"},{"line_number":127,"context_line":"            proto: udp"},{"line_number":128,"context_line":"      step_config: \u0027\u0027"},{"line_number":129,"context_line":"      host_prep_tasks:"},{"line_number":130,"context_line":"        if:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f65232a_9335afdd","line":127,"range":{"start_line":123,"start_character":0,"end_line":127,"end_character":22},"updated":"2020-10-23 13:51:05.000000000","message":"this is no longer applicable. Please use the firewall interface.\n\nExample: https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/keystone/keystone-container-puppet.yaml#L378-L383","commit_id":"99dcd6e9c4d88937d29bfaa5287584774917d3a0"}],"overcloud-resource-registry-puppet.j2.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5a93e49975a645c9024da443d1818e28c65b1485","unresolved":true,"context_lines":[{"line_number":222,"context_line":"  OS::TripleO::Services::Chrony: deployment/timesync/chrony-baremetal-ansible.yaml"},{"line_number":223,"context_line":"  OS::TripleO::Services::Ptp: OS::Heat::None"},{"line_number":224,"context_line":"  OS::TripleO::Services::Timesync: OS::TripleO::Services::Chrony"},{"line_number":225,"context_line":"  OS::TripleO::Services::TimeMaster: deployment/timemaster/timemaster-baremetal-ansible.yaml"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"  # Services that are disabled by default (use relevant environment files):"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"402c9883_6dc9a9e9","line":225,"updated":"2021-01-07 17:34:35.000000000","message":"So where is the environment file to actually enable this? e.g. a file containing:\n\nresource_registry:\n  OS::TripleO::Services::Timesync: OS::TripleO::Services::TimeMaster","commit_id":"2f1edfdffa49ca6356214a7f5923f724942251ec"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"25fcd56d2d5175562caafddcf21a6d3c4f3e4f3a","unresolved":true,"context_lines":[{"line_number":222,"context_line":"  OS::TripleO::Services::Chrony: deployment/timesync/chrony-baremetal-ansible.yaml"},{"line_number":223,"context_line":"  OS::TripleO::Services::Ptp: OS::Heat::None"},{"line_number":224,"context_line":"  OS::TripleO::Services::Timesync: OS::TripleO::Services::Chrony"},{"line_number":225,"context_line":"  OS::TripleO::Services::TimeMaster: deployment/timemaster/timemaster-baremetal-ansible.yaml"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"  # Services that are disabled by default (use relevant environment files):"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"e723e47e_fbdd5ad2","line":225,"in_reply_to":"24eeeae8_b6b5f113","updated":"2021-01-12 14:18:39.000000000","message":"Would timemaster be applied to an entire cloud or only specific roles?  If it\u0027s applied to an entire cloud, switching out what Timesync is configured is the correct solution. If it\u0027s role specific then updating the roles data would be the correct solution","commit_id":"2f1edfdffa49ca6356214a7f5923f724942251ec"},{"author":{"_account_id":30229,"name":"Haresh","email":"hakhande@redhat.com","username":"hakhande"},"change_message_id":"4de47055eb98aaba8e09bfa10558bb0ebc9c3915","unresolved":true,"context_lines":[{"line_number":222,"context_line":"  OS::TripleO::Services::Chrony: deployment/timesync/chrony-baremetal-ansible.yaml"},{"line_number":223,"context_line":"  OS::TripleO::Services::Ptp: OS::Heat::None"},{"line_number":224,"context_line":"  OS::TripleO::Services::Timesync: OS::TripleO::Services::Chrony"},{"line_number":225,"context_line":"  OS::TripleO::Services::TimeMaster: deployment/timemaster/timemaster-baremetal-ansible.yaml"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"  # Services that are disabled by default (use relevant environment files):"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"24eeeae8_b6b5f113","line":225,"in_reply_to":"402c9883_6dc9a9e9","updated":"2021-01-12 11:11:00.000000000","message":"This is new service and should be added to roles_data.yaml. If Admin wants any compute to use timemaster service (Chrony + PTP) and not timesyc (only chrony), Admin should replace timesync with timemaster as below.\n#    - OS::TripleO::Services::Timesync\n    - OS::TripleO::Services::TimeMaster\n\nThis will trigger timemaster service.","commit_id":"2f1edfdffa49ca6356214a7f5923f724942251ec"},{"author":{"_account_id":30229,"name":"Haresh","email":"hakhande@redhat.com","username":"hakhande"},"change_message_id":"7061a86c56840352e356105db424418eba1bcb3d","unresolved":false,"context_lines":[{"line_number":222,"context_line":"  OS::TripleO::Services::Chrony: deployment/timesync/chrony-baremetal-ansible.yaml"},{"line_number":223,"context_line":"  OS::TripleO::Services::Ptp: OS::Heat::None"},{"line_number":224,"context_line":"  OS::TripleO::Services::Timesync: OS::TripleO::Services::Chrony"},{"line_number":225,"context_line":"  OS::TripleO::Services::TimeMaster: deployment/timemaster/timemaster-baremetal-ansible.yaml"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"  # Services that are disabled by default (use relevant environment files):"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"dc840f10_6668a446","line":225,"in_reply_to":"43617e73_ce0f6251","updated":"2021-01-26 15:57:40.000000000","message":"Done","commit_id":"2f1edfdffa49ca6356214a7f5923f724942251ec"},{"author":{"_account_id":30229,"name":"Haresh","email":"hakhande@redhat.com","username":"hakhande"},"change_message_id":"4879f12684d751563c4173311f7bf42f1789512c","unresolved":true,"context_lines":[{"line_number":222,"context_line":"  OS::TripleO::Services::Chrony: deployment/timesync/chrony-baremetal-ansible.yaml"},{"line_number":223,"context_line":"  OS::TripleO::Services::Ptp: OS::Heat::None"},{"line_number":224,"context_line":"  OS::TripleO::Services::Timesync: OS::TripleO::Services::Chrony"},{"line_number":225,"context_line":"  OS::TripleO::Services::TimeMaster: deployment/timemaster/timemaster-baremetal-ansible.yaml"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"  # Services that are disabled by default (use relevant environment files):"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"43617e73_ce0f6251","line":225,"in_reply_to":"e723e47e_fbdd5ad2","updated":"2021-01-12 16:06:08.000000000","message":"It is specific to roles/nodes. It doesnt apply to overall cloud.","commit_id":"2f1edfdffa49ca6356214a7f5923f724942251ec"}],"sample-env-generator/composable-roles.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"40fe0ef20dce0f2b05bd1b911f579bd854e068b5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"bdb73653_cf7b80e8","updated":"2020-12-18 11:58:52.000000000","message":"By reverting this change, you can remove this file from the review list (as there is no valid change than a line removal)","commit_id":"08d8136ba8f41ea5507efcf17d80a84972451baa"},{"author":{"_account_id":30229,"name":"Haresh","email":"hakhande@redhat.com","username":"hakhande"},"change_message_id":"7d5fddf2a4f0b3597dc26e6c312d55507baa8ba5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fae96ea4_4628f08f","in_reply_to":"bdb73653_cf7b80e8","updated":"2021-01-06 17:03:29.000000000","message":"Done","commit_id":"08d8136ba8f41ea5507efcf17d80a84972451baa"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5a93e49975a645c9024da443d1818e28c65b1485","unresolved":true,"context_lines":[{"line_number":189,"context_line":"    default: networker"},{"line_number":190,"context_line":"    description: Name of the flavor for Networker nodes"},{"line_number":191,"context_line":"    type: string"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ee5cf010_b946ebaa","side":"PARENT","line":192,"updated":"2021-01-07 17:34:35.000000000","message":"unrelated change","commit_id":"0d8a2909ae742fdd365a2834c225c91804624119"},{"author":{"_account_id":30229,"name":"Haresh","email":"hakhande@redhat.com","username":"hakhande"},"change_message_id":"4de47055eb98aaba8e09bfa10558bb0ebc9c3915","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    default: networker"},{"line_number":190,"context_line":"    description: Name of the flavor for Networker nodes"},{"line_number":191,"context_line":"    type: string"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"888628ac_9c5e56ab","side":"PARENT","line":192,"in_reply_to":"ee5cf010_b946ebaa","updated":"2021-01-12 11:11:00.000000000","message":"Ack","commit_id":"0d8a2909ae742fdd365a2834c225c91804624119"}]}