)]}'
{"environments/services/ironic.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b594e909cf4531b144de0a5b91bcf11454cc3154","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  OS::TripleO::Services::IronicApi: ../../deployment/ironic/ironic-api-container-puppet.yaml"},{"line_number":6,"context_line":"  OS::TripleO::Services::IronicConductor: ../../deployment/ironic/ironic-conductor-container-puppet.yaml"},{"line_number":7,"context_line":"  OS::TripleO::Services::IronicPxe: ../../deployment/ironic/ironic-pxe-container-puppet.yaml"},{"line_number":8,"context_line":"  OS::TripleO::Services::NovaIronic: ../../deployment/nova/nova-ironic-container-puppet.yaml"},{"line_number":9,"context_line":"  OS::TripleO::Services::IronicNeutronAgent: ../../deployment/ironic/ironic-neutron-agent-container-puppet.yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_d9d09856","side":"PARENT","line":8,"updated":"2020-09-04 13:28:16.000000000","message":"Isn\u0027t this still necessary for ironic in the overcloud?","commit_id":"a71877c843302dd52a2d3f25651a8e8d67cafe78"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"958c2cc4463979a9c343aea7115d6d3e8cca9bec","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  OS::TripleO::Services::IronicApi: ../../deployment/ironic/ironic-api-container-puppet.yaml"},{"line_number":6,"context_line":"  OS::TripleO::Services::IronicConductor: ../../deployment/ironic/ironic-conductor-container-puppet.yaml"},{"line_number":7,"context_line":"  OS::TripleO::Services::IronicPxe: ../../deployment/ironic/ironic-pxe-container-puppet.yaml"},{"line_number":8,"context_line":"  OS::TripleO::Services::NovaIronic: ../../deployment/nova/nova-ironic-container-puppet.yaml"},{"line_number":9,"context_line":"  OS::TripleO::Services::IronicNeutronAgent: ../../deployment/ironic/ironic-neutron-agent-container-puppet.yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_4fa15a95","side":"PARENT","line":8,"in_reply_to":"9f560f44_4c54c854","updated":"2020-09-04 15:24:01.000000000","message":"I would leave this out of this change and we can consider this sperately.","commit_id":"a71877c843302dd52a2d3f25651a8e8d67cafe78"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2c8fedb83e95c7a07d8ffbd4ec2328547628e3ae","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  OS::TripleO::Services::IronicApi: ../../deployment/ironic/ironic-api-container-puppet.yaml"},{"line_number":6,"context_line":"  OS::TripleO::Services::IronicConductor: ../../deployment/ironic/ironic-conductor-container-puppet.yaml"},{"line_number":7,"context_line":"  OS::TripleO::Services::IronicPxe: ../../deployment/ironic/ironic-pxe-container-puppet.yaml"},{"line_number":8,"context_line":"  OS::TripleO::Services::NovaIronic: ../../deployment/nova/nova-ironic-container-puppet.yaml"},{"line_number":9,"context_line":"  OS::TripleO::Services::IronicNeutronAgent: ../../deployment/ironic/ironic-neutron-agent-container-puppet.yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_efd2eed0","side":"PARENT","line":8,"in_reply_to":"9f560f44_4fa15a95","updated":"2020-09-04 15:39:26.000000000","message":"Please check[1]. OVN is default for overcloud and that environment has been explicitly added for overcloud.\n\nSo, unless nova is enabled (it\u0027s by default in overcloud) you don\u0027t need that service with ironic. Therefore it should be clubbed with nova and not ironic \u0027only\u0027.\n\nNote: I removed the service as enabling it without nova does not work.\n\n[1] https://github.com/openstack/tripleo-heat-templates/commit/9b5cb4b3aa300329caa792dbb730edb8d0b94bc2","commit_id":"a71877c843302dd52a2d3f25651a8e8d67cafe78"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"6eab830a6f7f0a954cd52125030e7eaa60c54ab5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  OS::TripleO::Services::IronicApi: ../../deployment/ironic/ironic-api-container-puppet.yaml"},{"line_number":6,"context_line":"  OS::TripleO::Services::IronicConductor: ../../deployment/ironic/ironic-conductor-container-puppet.yaml"},{"line_number":7,"context_line":"  OS::TripleO::Services::IronicPxe: ../../deployment/ironic/ironic-pxe-container-puppet.yaml"},{"line_number":8,"context_line":"  OS::TripleO::Services::NovaIronic: ../../deployment/nova/nova-ironic-container-puppet.yaml"},{"line_number":9,"context_line":"  OS::TripleO::Services::IronicNeutronAgent: ../../deployment/ironic/ironic-neutron-agent-container-puppet.yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_4c54c854","side":"PARENT","line":8,"in_reply_to":"9f560f44_d9d09856","updated":"2020-09-04 14:47:59.000000000","message":"I thought the same, but decided ok since there is a environments/services/ironic-overcloud.yaml which is supposed to be used when enabling ironic in the overcloud. \n\nBut that also assume OVN, so we may want to reconsider.","commit_id":"a71877c843302dd52a2d3f25651a8e8d67cafe78"}]}