)]}'
{"deployment/glance/glance-api-container-puppet.yaml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ba06021c7f4b02a9f13da366b81787b4fd260be7","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        - rbd_backend_enabled"},{"line_number":335,"context_line":"        - equals: [{get_param: GlanceImageImportPlugins}, [\u0027no_op\u0027]]"},{"line_number":336,"context_line":"        - equals: [{get_param: NovaEnableRbdBackend}, true]"},{"line_number":337,"context_line":"      - filesystem_thin_provisioning_enabled"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"  use_tls_proxy: {equals : [{get_param: EnableInternalTLS}, true]}"},{"line_number":340,"context_line":"  glance_workers_unset: {equals : [{get_param: GlanceWorkers}, \u0027\u0027]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_aaccd234","line":337,"updated":"2020-09-29 08:32:24.000000000","message":"is image_conversion plugin only needed to allow sparse in \u0027file\u0027 store type?","commit_id":"4906fa467378c780e64dd31c168d8c2a50eb258b"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"629bfd2b1f921e445ce7939e925ec61e28ed5ee9","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        - rbd_backend_enabled"},{"line_number":335,"context_line":"        - equals: [{get_param: GlanceImageImportPlugins}, [\u0027no_op\u0027]]"},{"line_number":336,"context_line":"        - equals: [{get_param: NovaEnableRbdBackend}, true]"},{"line_number":337,"context_line":"      - filesystem_thin_provisioning_enabled"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"  use_tls_proxy: {equals : [{get_param: EnableInternalTLS}, true]}"},{"line_number":340,"context_line":"  glance_workers_unset: {equals : [{get_param: GlanceWorkers}, \u0027\u0027]}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_999305a5","line":337,"in_reply_to":"9f560f44_aaccd234","updated":"2020-10-01 15:54:07.000000000","message":"image_conversion plugin needs to be enabled for both \u0027file\u0027 \u0026 \u0027rbd\u0027 backend when sparse upload is enabled.","commit_id":"4906fa467378c780e64dd31c168d8c2a50eb258b"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ba06021c7f4b02a9f13da366b81787b4fd260be7","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                - \u0027.conf\u0027"},{"line_number":506,"context_line":"            glance::backend::rbd::rbd_store_pool: {get_param: GlanceRbdPoolName}"},{"line_number":507,"context_line":"            glance::backend::rbd::rbd_store_user: {get_param: CephClientUserName}"},{"line_number":508,"context_line":"            glance::backend::rbd::rbd_thin_provisioning: {if: [rbd_thin_provisioning_enabled, true, false]}"},{"line_number":509,"context_line":"            glance::backend::file::filesystem_thin_provisioning: {if: [filesystem_thin_provisioning_enabled, true, false]}"},{"line_number":510,"context_line":"            glance_backend: {get_param: GlanceBackend}"},{"line_number":511,"context_line":"            tripleo::profile::base::glance::api::glance_backend_id: {get_param: GlanceBackendID}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_2a4ba2b1","line":508,"updated":"2020-09-29 08:32:24.000000000","message":"would it be less problematic if we simply set these to the GlanceSparseUploadEnabled parameter value? I think unless some puppet code imports the rbd:: of file:: class whichever parameter is passed via hiera will be ignored","commit_id":"4906fa467378c780e64dd31c168d8c2a50eb258b"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"629bfd2b1f921e445ce7939e925ec61e28ed5ee9","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                - \u0027.conf\u0027"},{"line_number":506,"context_line":"            glance::backend::rbd::rbd_store_pool: {get_param: GlanceRbdPoolName}"},{"line_number":507,"context_line":"            glance::backend::rbd::rbd_store_user: {get_param: CephClientUserName}"},{"line_number":508,"context_line":"            glance::backend::rbd::rbd_thin_provisioning: {if: [rbd_thin_provisioning_enabled, true, false]}"},{"line_number":509,"context_line":"            glance::backend::file::filesystem_thin_provisioning: {if: [filesystem_thin_provisioning_enabled, true, false]}"},{"line_number":510,"context_line":"            glance_backend: {get_param: GlanceBackend}"},{"line_number":511,"context_line":"            tripleo::profile::base::glance::api::glance_backend_id: {get_param: GlanceBackendID}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_d98d7d7d","line":508,"in_reply_to":"9f560f44_2a4ba2b1","updated":"2020-10-01 15:54:07.000000000","message":"Makes sense :)","commit_id":"4906fa467378c780e64dd31c168d8c2a50eb258b"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"653730b07e07ca96cadcef254ea9f9470e77ecf4","unresolved":false,"context_lines":[{"line_number":194,"context_line":"      NFS mount options for NFS image import staging"},{"line_number":195,"context_line":"    type: string"},{"line_number":196,"context_line":"  GlanceSparseUploadEnabled:"},{"line_number":197,"context_line":"    default: false"},{"line_number":198,"context_line":"    description: \u003e"},{"line_number":199,"context_line":"      When using GlanceBackend \u0027file\u0027 and \u0027rbd\u0027 to enable or not sparse upload."},{"line_number":200,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_d3dd5114","line":197,"updated":"2020-10-01 18:50:43.000000000","message":"Could tripleo take an opinionated view and enable it by default? I don\u0027t believe it would affect existing images.\n\n@Giulio, what do you think?","commit_id":"0d09e70101812a8cd523b774dacc25ef3be15e21"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e4d38bbf2ab9e02334c4814805187a0274aab32f","unresolved":false,"context_lines":[{"line_number":194,"context_line":"      NFS mount options for NFS image import staging"},{"line_number":195,"context_line":"    type: string"},{"line_number":196,"context_line":"  GlanceSparseUploadEnabled:"},{"line_number":197,"context_line":"    default: false"},{"line_number":198,"context_line":"    description: \u003e"},{"line_number":199,"context_line":"      When using GlanceBackend \u0027file\u0027 and \u0027rbd\u0027 to enable or not sparse upload."},{"line_number":200,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_df3273f3","line":197,"in_reply_to":"9f560f44_d3dd5114","updated":"2020-10-01 19:37:06.000000000","message":"I think for edge or multi-compute-roles sites with different nova backends, we had issues enabling image conversion by default because that was causing \"small\" qcow2 images to be transformed in big \"raw\" images\n\nHopefully with sparse upload that is less of an issue so I think enabling it by default doesn\u0027t hurt but I wouldn\u0027t remove the paramter to make sure people can disable it","commit_id":"0d09e70101812a8cd523b774dacc25ef3be15e21"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"97d766063630d89b3a38f245c08995bfa375312d","unresolved":false,"context_lines":[{"line_number":194,"context_line":"      NFS mount options for NFS image import staging"},{"line_number":195,"context_line":"    type: string"},{"line_number":196,"context_line":"  GlanceSparseUploadEnabled:"},{"line_number":197,"context_line":"    default: false"},{"line_number":198,"context_line":"    description: \u003e"},{"line_number":199,"context_line":"      When using GlanceBackend \u0027file\u0027 and \u0027rbd\u0027 to enable or not sparse upload."},{"line_number":200,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_0b2bfb94","line":197,"in_reply_to":"9f560f44_df3273f3","updated":"2020-10-04 04:19:37.000000000","message":"Exactly, this is what my concern was. That\u0027s why I had added extra checks for enabling image_conversion plugin in my previous patch set.\nIt\u0027s safe to have the parameter.","commit_id":"0d09e70101812a8cd523b774dacc25ef3be15e21"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"653730b07e07ca96cadcef254ea9f9470e77ecf4","unresolved":false,"context_lines":[{"line_number":538,"context_line":"            - glance::api::disk_formats: {get_param: GlanceDiskFormats}"},{"line_number":539,"context_line":"          -"},{"line_number":540,"context_line":"            if:"},{"line_number":541,"context_line":"            - glance_sparse_upload_enabled"},{"line_number":542,"context_line":"            - glance::backend::rbd::rbd_thin_provisioning: true"},{"line_number":543,"context_line":"              glance::backend::file::filesystem_thin_provisioning: true"},{"line_number":544,"context_line":"            - {}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_739e0556","line":541,"updated":"2020-10-01 18:50:43.000000000","message":"Is use of this conditional necessary? Asked another way, why can\u0027t you add these:\n\nglance::backend::rbd::rbd_thin_provisioning: {get_param: GlanceSparseUploadEnabled}\nglance::backend::file::filesystem_thin_provisioning: {get_param: GlanceSparseUploadEnabled}\n\nI understand conditionals are sometimes necessary, but I\u0027m not sure that\u0027s the case here.","commit_id":"0d09e70101812a8cd523b774dacc25ef3be15e21"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e4d38bbf2ab9e02334c4814805187a0274aab32f","unresolved":false,"context_lines":[{"line_number":538,"context_line":"            - glance::api::disk_formats: {get_param: GlanceDiskFormats}"},{"line_number":539,"context_line":"          -"},{"line_number":540,"context_line":"            if:"},{"line_number":541,"context_line":"            - glance_sparse_upload_enabled"},{"line_number":542,"context_line":"            - glance::backend::rbd::rbd_thin_provisioning: true"},{"line_number":543,"context_line":"              glance::backend::file::filesystem_thin_provisioning: true"},{"line_number":544,"context_line":"            - {}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_f32cd5b3","line":541,"in_reply_to":"9f560f44_739e0556","updated":"2020-10-01 19:37:06.000000000","message":"+1","commit_id":"0d09e70101812a8cd523b774dacc25ef3be15e21"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"97d766063630d89b3a38f245c08995bfa375312d","unresolved":false,"context_lines":[{"line_number":538,"context_line":"            - glance::api::disk_formats: {get_param: GlanceDiskFormats}"},{"line_number":539,"context_line":"          -"},{"line_number":540,"context_line":"            if:"},{"line_number":541,"context_line":"            - glance_sparse_upload_enabled"},{"line_number":542,"context_line":"            - glance::backend::rbd::rbd_thin_provisioning: true"},{"line_number":543,"context_line":"              glance::backend::file::filesystem_thin_provisioning: true"},{"line_number":544,"context_line":"            - {}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_ab1bef81","line":541,"in_reply_to":"9f560f44_739e0556","updated":"2020-10-04 04:19:37.000000000","message":"Ack","commit_id":"0d09e70101812a8cd523b774dacc25ef3be15e21"}],"releasenotes/notes/enable_glance_sparse_image_upload-fe9e594f91cf57f1.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"653730b07e07ca96cadcef254ea9f9470e77ecf4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add GlanceSparseUploadEnabled to enable sparse image upload"},{"line_number":5,"context_line":"    for rbd and filesystem glance backends."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_93be39ac","line":5,"updated":"2020-10-01 18:50:43.000000000","message":"It might be good to state the \"feature\" is disabled by default. I suspect many users will think it\u0027s a good feature, but they need to enable it because it\u0027s off by default.","commit_id":"0d09e70101812a8cd523b774dacc25ef3be15e21"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"97d766063630d89b3a38f245c08995bfa375312d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add GlanceSparseUploadEnabled to enable sparse image upload"},{"line_number":5,"context_line":"    for rbd and filesystem glance backends."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_cb20e3b4","line":5,"in_reply_to":"9f560f44_93be39ac","updated":"2020-10-04 04:19:37.000000000","message":"Done","commit_id":"0d09e70101812a8cd523b774dacc25ef3be15e21"}]}