)]}'
{"deployment/cinder/cinder-backend-dellemc-powerflex-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f28be85d9dacc24128d736442de094ee1f20e579","unresolved":false,"context_lines":[{"line_number":126,"context_line":"      service_name: cinder_backend_powerflex"},{"line_number":127,"context_line":"      config_settings:"},{"line_number":128,"context_line":"        map_merge:"},{"line_number":129,"context_line":"          - tripleo::profile::base::cinder::volume::cinder_enable_powerflex_backend: {get_param: CinderEnablePowerFlexBackend}"},{"line_number":130,"context_line":"            cinder::backend::dellemc_powerflex::volume_backend_name: {get_param: CinderPowerFlexBackendName}"},{"line_number":131,"context_line":"            cinder::backend::dellemc_powerflex::san_login: {get_param: CinderPowerFlexSanLogin}"},{"line_number":132,"context_line":"            cinder::backend::dellemc_powerflex::san_password: {get_param: CinderPowerFlexSanPassword}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_3bf89f7a","line":129,"updated":"2020-09-21 18:16:17.000000000","message":"This doesn\u0027t match the puppe-tripleo code\nhttps://opendev.org/openstack/puppet-tripleo/src/branch/master/manifests/profile/base/cinder/volume.pp#L143","commit_id":"dd8c294eede773e1264cef84d29e8988da8e1d87"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"bc55e62690b0ed18b27255bc26139b90c1b70e46","unresolved":false,"context_lines":[{"line_number":126,"context_line":"      service_name: cinder_backend_powerflex"},{"line_number":127,"context_line":"      config_settings:"},{"line_number":128,"context_line":"        map_merge:"},{"line_number":129,"context_line":"          - tripleo::profile::base::cinder::volume::cinder_enable_powerflex_backend: {get_param: CinderEnablePowerFlexBackend}"},{"line_number":130,"context_line":"            cinder::backend::dellemc_powerflex::volume_backend_name: {get_param: CinderPowerFlexBackendName}"},{"line_number":131,"context_line":"            cinder::backend::dellemc_powerflex::san_login: {get_param: CinderPowerFlexSanLogin}"},{"line_number":132,"context_line":"            cinder::backend::dellemc_powerflex::san_password: {get_param: CinderPowerFlexSanPassword}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_d6e69ae7","line":129,"in_reply_to":"9f560f44_3bf89f7a","updated":"2020-09-21 19:00:39.000000000","message":"Done","commit_id":"dd8c294eede773e1264cef84d29e8988da8e1d87"}],"environments/cinder-dellemc-vxflexos-config.yaml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"00816686e6a7fb88ae4ffd4cbc2363c6112e65ea","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#  Use Cinder Dell EMC PowerFlex backend template defined in"},{"line_number":20,"context_line":"#  cinder-backend-dellemc-powerflex-puppet.yaml."},{"line_number":21,"context_line":"resource_registry:"},{"line_number":22,"context_line":"  OS::TripleO::Services::CinderBackendVxFlexOS: ../deployment/cinder/cinder-backend-dellemc-vxflexos-puppet.yaml"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"parameter_defaults:"},{"line_number":25,"context_line":"  CinderEnableVxFlexOSBackend: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_e84dffc5","line":22,"updated":"2020-09-17 05:32:51.000000000","message":"This path is not a valid one as this file has been move under deprecated folder in https://review.opendev.org/#/c/745390/, but the path is not aligned properly.","commit_id":"6abfa5ac8057089e3eb18c87bcc5bf633b969565"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"fe3650f99bf70fe53a2905aef297e92356937bbf","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#  Use Cinder Dell EMC PowerFlex backend template defined in"},{"line_number":20,"context_line":"#  cinder-backend-dellemc-powerflex-puppet.yaml."},{"line_number":21,"context_line":"resource_registry:"},{"line_number":22,"context_line":"  OS::TripleO::Services::CinderBackendVxFlexOS: ../deployment/cinder/cinder-backend-dellemc-vxflexos-puppet.yaml"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"parameter_defaults:"},{"line_number":25,"context_line":"  CinderEnableVxFlexOSBackend: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_2a75efcc","line":22,"in_reply_to":"9f560f44_1b4e80c1","updated":"2020-09-21 16:07:00.000000000","message":"Fixed it.","commit_id":"6abfa5ac8057089e3eb18c87bcc5bf633b969565"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"6afa00c3f08c6888842af252c441781f74d164cb","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#  Use Cinder Dell EMC PowerFlex backend template defined in"},{"line_number":20,"context_line":"#  cinder-backend-dellemc-powerflex-puppet.yaml."},{"line_number":21,"context_line":"resource_registry:"},{"line_number":22,"context_line":"  OS::TripleO::Services::CinderBackendVxFlexOS: ../deployment/cinder/cinder-backend-dellemc-vxflexos-puppet.yaml"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"parameter_defaults:"},{"line_number":25,"context_line":"  CinderEnableVxFlexOSBackend: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_07a0f041","line":22,"in_reply_to":"9f560f44_67c9f94f","updated":"2020-09-21 03:10:15.000000000","message":"Are you doing a follow-up to fix this issue? Irrespective of it, it can be fixed as the file name is fixed, it should point to the correct path. The backport should have modification (specific to stable branches) so that it will point to the non-deprecated path.","commit_id":"6abfa5ac8057089e3eb18c87bcc5bf633b969565"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bb8faa3182d3f74c29924cf92763d06952626127","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#  Use Cinder Dell EMC PowerFlex backend template defined in"},{"line_number":20,"context_line":"#  cinder-backend-dellemc-powerflex-puppet.yaml."},{"line_number":21,"context_line":"resource_registry:"},{"line_number":22,"context_line":"  OS::TripleO::Services::CinderBackendVxFlexOS: ../deployment/cinder/cinder-backend-dellemc-vxflexos-puppet.yaml"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"parameter_defaults:"},{"line_number":25,"context_line":"  CinderEnableVxFlexOSBackend: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_1b4e80c1","line":22,"in_reply_to":"9f560f44_67c9f94f","updated":"2020-09-21 14:34:42.000000000","message":"Maybe the way to handle this is to reference the file where it exists in each release. So refer to it in the deprecations section, and update the reference when backporting to release where vxflex has not been deprecated.","commit_id":"6abfa5ac8057089e3eb18c87bcc5bf633b969565"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"5821ffe2655cefb5214bc904ee575c43e8fdc86c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#  Use Cinder Dell EMC PowerFlex backend template defined in"},{"line_number":20,"context_line":"#  cinder-backend-dellemc-powerflex-puppet.yaml."},{"line_number":21,"context_line":"resource_registry:"},{"line_number":22,"context_line":"  OS::TripleO::Services::CinderBackendVxFlexOS: ../deployment/cinder/cinder-backend-dellemc-vxflexos-puppet.yaml"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"parameter_defaults:"},{"line_number":25,"context_line":"  CinderEnableVxFlexOSBackend: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_67c9f94f","line":22,"in_reply_to":"9f560f44_e84dffc5","updated":"2020-09-18 18:15:02.000000000","message":"The deprecation was a different patch. Since this is an environment file, I wonder if we can leave it the way it is, so this review can be backported downstream","commit_id":"6abfa5ac8057089e3eb18c87bcc5bf633b969565"}]}