)]}'
{"puppet/role.role.j2.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"d1bb86c233aa99afd7269b7f77d709695c5cbbc5","unresolved":false,"context_lines":[{"line_number":623,"context_line":"        fqdn_canonical: {get_attr: [NetHostMap, value, canonical, fqdn]}"},{"line_number":624,"context_line":"        hostname_resolve_network: {get_param: [ServiceNetMap, {{role.name}}HostnameResolveNetwork]}"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"  {{server_resource_name}}GroupVars:"},{"line_number":627,"context_line":"    type: OS::Heat::Value"},{"line_number":628,"context_line":"    properties:"},{"line_number":629,"context_line":"      value:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_4ebd1301","line":626,"range":{"start_line":626,"start_character":2,"end_line":626,"end_character":35},"updated":"2020-09-17 07:13:35.000000000","message":"This is an overkill as it creates resources for every node and then finally merged them. We probably should find a better way rather than getting them from individual ports created. Anyway, I\u0027ve moved them to AnsibleHostVars (which would work) until we find a better way to get them at role level.","commit_id":"f2562f95a50fef3d69cbed9387f436515f5c43cf"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"f637a70a79727171748acd650286e49349737c76","unresolved":false,"context_lines":[{"line_number":623,"context_line":"        fqdn_canonical: {get_attr: [NetHostMap, value, canonical, fqdn]}"},{"line_number":624,"context_line":"        hostname_resolve_network: {get_param: [ServiceNetMap, {{role.name}}HostnameResolveNetwork]}"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"  {{server_resource_name}}GroupVars:"},{"line_number":627,"context_line":"    type: OS::Heat::Value"},{"line_number":628,"context_line":"    properties:"},{"line_number":629,"context_line":"      value:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_79841f5e","line":626,"range":{"start_line":626,"start_character":2,"end_line":626,"end_character":35},"in_reply_to":"9f560f44_4ebd1301","updated":"2020-09-17 08:04:58.000000000","message":"We can probably move the \"NetworkConfig\" resource out of role.role.j2.puppet. Instead of getting properties of the ports we can get them of the networks and subnets.\n\n[1] really assumes that all attributes except the ip_address is role specific. So if [1] really means NetworkConfig is rendered only once per role in ansible, we should be able to move the resource to be per-role, instead of per-node.\n\n[1] https://opendev.org/openstack/tripleo-heat-templates/commit/f732a8390adece4d9e9bffbea4654e37b2e54f72","commit_id":"f2562f95a50fef3d69cbed9387f436515f5c43cf"}]}